dhl_express 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1f134e7ecaec8026474a2ab5ead332f2269cf085
-  data.tar.gz: 14bb10ad9e5d50291c4501dccb89bfad68414727
+  metadata.gz: 51cc9df7fdda53be9dbdd840a346cb328a27de2f
+  data.tar.gz: 33f3c84bece5a0cc01d3126fd625d08666486bfe
 SHA512:
-  metadata.gz: 55fdd24757fea39f60c415222f17a8be2b2a8776073acdcb464b4d780529e9f9b7e06ceb8b67a044b0355b01f2ba2f4f9ca43941668bb39f59b984d811d8184e
-  data.tar.gz: efdcb18b5a172e701dda773b62ea794c679cb5cd1dfda2a03bc013e122c737ea4bd000c545eb730d5b035390c5f596962a6d554747dedc7da38135e80751a3c6
+  metadata.gz: 97aa304388d0cc9843b71c6dee0972140beb300c9904f57300a28be58a66cf540e0ec00f6b5e7f0d85b0f6c3a3b98d7c4683e6ad80795c3f7762d483a40a328e
+  data.tar.gz: 3d3c4ca97aba5ef0d9c4b44eee94612cb52e8fa3d00b1ee84f8d95a618d5c5f6bc2796780f7c3901533d0b06884c03bdde7468264a5a693891cc173a4d56be97

data/lib/dhl_express/tracking.rb

@@ -16,14 +16,14 @@ module DhlExpress
       tracking_url = "https://www.mydhl.dhl.com/shipmentTracking?AWB=#{@tracking_number}"
 
       @tracking_json = JSON.parse(Typhoeus.get(tracking_url).body)
-
-      raise RuntimeError, "No Tracking found." if @tracking_json["results"].nil?
     end
 
     # Origin of the package
     #
     # Returns origin as String.
     def origin
+      return nil if tracking_is_empty
+
       origin = @tracking_json["results"][0]["origin"]["value"].strip
       return origin
     end
@@ -32,6 +32,8 @@ module DhlExpress
     #
     # Returns destination as String.
     def destination
+      return nil if tracking_is_empty
+
       destination = @tracking_json["results"][0]["destination"]["value"].strip
       return destination
     end
@@ -40,6 +42,8 @@ module DhlExpress
     #
     # Returns status as String.
     def status
+      return nil if tracking_is_empty
+
       status = @tracking_json["results"][0]["description"].strip
       return status
     end
@@ -48,6 +52,8 @@ module DhlExpress
     #
     # Returns tracking history as Array.
     def history
+      return nil if tracking_is_empty
+
       checkpoints = @tracking_json["results"][0]["checkpoints"]
 
       history = []
@@ -77,5 +83,13 @@ module DhlExpress
       return date
     end
 
+    def tracking_is_empty
+      if @tracking_json["results"].nil?
+        return true
+      else
+        return false
+      end
+    end
+
   end
 end

data/lib/dhl_express/version.rb

@@ -1,3 +1,3 @@
 module DhlExpress
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

data/spec/dhl_express/tracking_spec.rb

@@ -6,12 +6,6 @@ describe DhlExpress::Tracking do
       expect { DhlExpress::Tracking.new() }.to raise_error(ArgumentError)
     end
 
-    it "should not initialize with empty tracking" do
-      VCR.use_cassette 'empty_tracking' do
-        expect { DhlExpress::Tracking.new("1234567") }.to raise_error(RuntimeError)
-      end
-    end
-
     it "should initialize a tracking object" do
       VCR.use_cassette 'working_tracking' do
         package = DhlExpress::Tracking.new("6476119576")
@@ -27,6 +21,13 @@ describe DhlExpress::Tracking do
         expect(package.origin).to be_kind_of(String)
       end
     end
+
+    it "should return nil with empty tracking number" do
+      VCR.use_cassette 'empty_tracking' do
+        package = DhlExpress::Tracking.new("1234567")
+        expect(package.origin).to be_nil
+      end
+    end
   end
 
   describe "#destination" do
@@ -36,6 +37,13 @@ describe DhlExpress::Tracking do
         expect(package.destination).to be_kind_of(String)
       end
     end
+
+    it "should return nil with empty tracking number" do
+      VCR.use_cassette 'empty_tracking' do
+        package = DhlExpress::Tracking.new("1234567")
+        expect(package.destination).to be_nil
+      end
+    end
   end
 
   describe "#status" do
@@ -45,6 +53,13 @@ describe DhlExpress::Tracking do
         expect(package.status).to be_kind_of(String)
       end
     end
+
+    it "should return nil with empty tracking number" do
+      VCR.use_cassette 'empty_tracking' do
+        package = DhlExpress::Tracking.new("1234567")
+        expect(package.status).to be_nil
+      end
+    end
   end
 
   describe "#history" do
@@ -54,6 +69,13 @@ describe DhlExpress::Tracking do
         expect(package.history).to be_kind_of(Array)
       end
     end
+
+    it "should return nil with empty tracking number" do
+      VCR.use_cassette 'empty_tracking' do
+        package = DhlExpress::Tracking.new("1234567")
+        expect(package.history).to be_nil
+      end
+    end
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dhl_express
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Sebastian Szturo