dgp-schedule_attributes 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d2b20ff92edf87c3c1ca146374feba93269d76b4
-  data.tar.gz: 2a7689f49ace828eaf0dffe311e22e5a03dcf134
+  metadata.gz: 031b0bf395bee38af7d2516bb2358b4385128527
+  data.tar.gz: e9881c68f4dd05c30701e75ec7f4dbad5a6eb863
 SHA512:
-  metadata.gz: 8c28fc148b35a7e4a79f4f677a43e931f1794de1daf33b2d19aed2b2b8e159b285901502d9a77c740150e5abd0a67fb1e2f9a60c70a883fc21e0db811367e3c5
-  data.tar.gz: aca106ba76e5fd28f47fadf356020231f0d3e77e297ae87b46299743eb071a2278c38ab9b6958250c71307fea08f3b0a0042506122a15d840f8c9583201b5aaa
+  metadata.gz: e77a84adc8c0cb9825eef971704fb37fe8397d83501e21c72574e437ef3955ede56eb97fcd85daf97f605e2a07c33ef44b90e762a6163f93d10565644ccb4b00
+  data.tar.gz: c4109d2763a4a0a4a77d568538f7590d268aa5e258e1e17f59bef312666c48b67e2a8bf1daf70e35501e104c6f294dbd7106d21cea31ff67900b57200bc5e66f

data/CHANGELOG.md

@@ -0,0 +1,15 @@
+# Changelog
+All notable changes to this project will be documented in this file.
+
+## HEAD
+
+## 0.5.0
+
+- Added Code of Conduct from Contributor Covenant ~ @dgilperez
+- Tests are now rspec-3 like ~ @dgilperez
+- Activate IceCube.compatibility = 12 in specs ~ @dgilperez
+- *POSSIBLE BREAKING CHANGE* Detect :start_date and :end_date attributes and merge them into :start_time and :end_time respective ones before passing them to IceCube::Schedule objects.
+
+## 0.4.0
+
+- Renamed gem to dgp-schedule_attributes to reflect changes in ice_cube dependencies and Rails support ~ @dgilperez

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,22 @@
+# Contributor Code of Conduct
+
+As contributors and maintainers of this project, and in the interest of fostering an open and welcoming community, we pledge to respect all people who contribute through reporting issues, posting feature requests, updating documentation, submitting pull requests or patches, and other activities.
+
+We are committed to making participation in this project a harassment-free experience for everyone, regardless of level of experience, gender, gender identity and expression, sexual orientation, disability, personal appearance, body size, race, ethnicity, age, religion, or nationality.
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery
+* Personal attacks
+* Trolling or insulting/derogatory comments
+* Public or private harassment
+* Publishing other's private information, such as physical or electronic addresses, without explicit permission
+* Other unethical or unprofessional conduct.
+
+Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct. By adopting this Code of Conduct, project maintainers commit themselves to fairly and consistently applying these principles to every aspect of managing this project. Project maintainers who do not follow or enforce the Code of Conduct may be permanently removed from the project team.
+
+This code of conduct applies both within project spaces and in public spaces when an individual is representing the project or its community.
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by opening an issue or contacting one or more of the project maintainers.
+
+This Code of Conduct is adapted from the [Contributor Covenant](http://contributor-covenant.org), version 1.2.0, available at [http://contributor-covenant.org/version/1/2/0/](http://contributor-covenant.org/version/1/2/0/)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    dgp-schedule_attributes (0.4.0)
+    dgp-schedule_attributes (0.5.0)
       activesupport (>= 3.2)
       ice_cube (~> 0.13)
       tzinfo
@@ -9,33 +9,44 @@ PATH
 GEM
   remote: http://rubygems.org/
   specs:
-    activemodel (3.2.13)
-      activesupport (= 3.2.13)
-      builder (~> 3.0.0)
-    activerecord (3.2.13)
-      activemodel (= 3.2.13)
-      activesupport (= 3.2.13)
-      arel (~> 3.0.2)
-      tzinfo (~> 0.3.29)
-    activesupport (3.2.13)
-      i18n (= 0.6.1)
-      multi_json (~> 1.0)
+    activemodel (4.2.4)
+      activesupport (= 4.2.4)
+      builder (~> 3.1)
+    activerecord (4.2.4)
+      activemodel (= 4.2.4)
+      activesupport (= 4.2.4)
+      arel (~> 6.0)
+    activesupport (4.2.4)
+      i18n (~> 0.7)
+      json (~> 1.7, >= 1.7.7)
+      minitest (~> 5.1)
+      thread_safe (~> 0.3, >= 0.3.4)
+      tzinfo (~> 1.1)
     appraisal (2.1.0)
       bundler
       rake
       thor (>= 0.14.0)
-    arel (3.0.2)
-    builder (3.0.4)
+    arel (6.0.3)
+    builder (3.2.2)
+    byebug (2.7.0)
+      columnize (~> 0.3)
+      debugger-linecache (~> 1.2)
     coderay (1.0.9)
+    columnize (0.9.0)
+    debugger-linecache (1.2.0)
     diff-lcs (1.2.5)
-    i18n (0.6.1)
+    i18n (0.7.0)
     ice_cube (0.13.0)
+    json (1.8.3)
     method_source (0.8.1)
-    multi_json (1.7.3)
+    minitest (5.8.0)
     pry (0.9.12.1)
       coderay (~> 1.0.5)
       method_source (~> 0.8)
       slop (~> 3.4)
+    pry-byebug (1.3.2)
+      byebug (~> 2.7)
+      pry (~> 0.9.12)
     rake (10.0.4)
     rspec (2.99.0)
       rspec-core (~> 2.99.0)
@@ -48,7 +59,9 @@ GEM
     slop (3.4.4)
     sqlite3 (1.3.10)
     thor (0.19.1)
-    tzinfo (0.3.37)
+    thread_safe (0.3.5)
+    tzinfo (1.2.2)
+      thread_safe (~> 0.1)
 
 PLATFORMS
   ruby
@@ -58,6 +71,7 @@ DEPENDENCIES
   appraisal
   dgp-schedule_attributes!
   pry
+  pry-byebug
   rake
   rspec (~> 2.99)
   sqlite3

data/gemfiles/rails_3.2.gemfile.lock

@@ -49,7 +49,10 @@ GEM
       thor (>= 0.14.0)
     arel (3.0.3)
     builder (3.0.4)
+    byebug (5.0.0)
+      columnize (= 0.9.0)
     coderay (1.1.0)
+    columnize (0.9.0)
     diff-lcs (1.2.5)
     erubis (2.7.0)
     hike (1.2.3)
@@ -63,6 +66,9 @@ GEM
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
+    pry-byebug (3.2.0)
+      byebug (~> 5.0)
+      pry (~> 0.10)
     rack (1.4.7)
     rack-cache (1.2)
       rack (>= 0.4)
@@ -106,6 +112,7 @@ DEPENDENCIES
   appraisal
   dgp-schedule_attributes!
   pry
+  pry-byebug
   rake
   rspec (~> 2.99)
   sqlite3

data/gemfiles/rails_4.0.gemfile.lock

@@ -36,7 +36,10 @@ GEM
       thor (>= 0.14.0)
     arel (4.0.2)
     builder (3.1.4)
+    byebug (5.0.0)
+      columnize (= 0.9.0)
     coderay (1.1.0)
+    columnize (0.9.0)
     diff-lcs (1.2.5)
     i18n (0.7.0)
     ice_cube (0.13.0)
@@ -47,6 +50,9 @@ GEM
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
+    pry-byebug (3.2.0)
+      byebug (~> 5.0)
+      pry (~> 0.10)
     rake (10.4.2)
     rspec (2.99.0)
       rspec-core (~> 2.99.0)
@@ -71,6 +77,7 @@ DEPENDENCIES
   appraisal
   dgp-schedule_attributes!
   pry
+  pry-byebug
   rake
   rspec (~> 2.99)
   sqlite3

data/gemfiles/rails_4.1.gemfile.lock

@@ -34,7 +34,10 @@ GEM
       thor (>= 0.14.0)
     arel (5.0.1.20140414130214)
     builder (3.2.2)
+    byebug (5.0.0)
+      columnize (= 0.9.0)
     coderay (1.1.0)
+    columnize (0.9.0)
     diff-lcs (1.2.5)
     i18n (0.7.0)
     ice_cube (0.13.0)
@@ -45,6 +48,9 @@ GEM
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
+    pry-byebug (3.2.0)
+      byebug (~> 5.0)
+      pry (~> 0.10)
     rake (10.4.2)
     rspec (2.99.0)
       rspec-core (~> 2.99.0)
@@ -70,6 +76,7 @@ DEPENDENCIES
   appraisal
   dgp-schedule_attributes!
   pry
+  pry-byebug
   rake
   rspec (~> 2.99)
   sqlite3

data/gemfiles/rails_4.2.gemfile.lock

@@ -34,7 +34,10 @@ GEM
       thor (>= 0.14.0)
     arel (6.0.3)
     builder (3.2.2)
+    byebug (5.0.0)
+      columnize (= 0.9.0)
     coderay (1.1.0)
+    columnize (0.9.0)
     diff-lcs (1.2.5)
     i18n (0.7.0)
     ice_cube (0.13.0)
@@ -45,6 +48,9 @@ GEM
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
+    pry-byebug (3.2.0)
+      byebug (~> 5.0)
+      pry (~> 0.10)
     rake (10.4.2)
     rspec (2.99.0)
       rspec-core (~> 2.99.0)
@@ -70,6 +76,7 @@ DEPENDENCIES
   appraisal
   dgp-schedule_attributes!
   pry
+  pry-byebug
   rake
   rspec (~> 2.99)
   sqlite3

data/gemfiles/rails_edge.gemfile.lock

@@ -40,7 +40,10 @@ GEM
       rake
       thor (>= 0.14.0)
     builder (3.2.2)
+    byebug (5.0.0)
+      columnize (= 0.9.0)
     coderay (1.1.0)
+    columnize (0.9.0)
     concurrent-ruby (0.9.1)
     diff-lcs (1.2.5)
     i18n (0.7.0)
@@ -52,6 +55,9 @@ GEM
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
+    pry-byebug (3.2.0)
+      byebug (~> 5.0)
+      pry (~> 0.10)
     rake (10.4.2)
     rspec (2.99.0)
       rspec-core (~> 2.99.0)
@@ -78,6 +84,7 @@ DEPENDENCIES
   arel!
   dgp-schedule_attributes!
   pry
+  pry-byebug
   rake
   rspec (~> 2.99)
   sqlite3

data/lib/schedule_attributes/core.rb

@@ -28,6 +28,8 @@ module ScheduleAttributes
     extend ActiveSupport::Concern
 
     def schedule_attributes=(options)
+      merge_date_and_time_into_time_attribute!(options)
+
       input = ScheduleAttributes::Input.new(options)
       new_schedule = IceCube::Schedule.new(input.start_time || TimeHelpers.today)
 
@@ -142,5 +144,21 @@ module ScheduleAttributes
       OpenStruct.new(atts.delete_if { |_,v| v.blank? })
     end
 
+    private
+
+    # Modifies the passed options hash
+    def merge_date_and_time_into_time_attribute!(options)
+      merged_start_time = "#{options['start_date']} #{options['start_time']}".strip.presence
+      merged_end_time   = "#{options['end_date']} #{options['end_time']}".strip.presence
+      if merged_start_time
+        options.delete('start_date')
+        options['start_time'] = merged_start_time.to_s
+      end
+      if merged_start_time
+        options.delete('end_date')
+        options['end_time'] = merged_end_time.to_s
+      end
+    end
+
   end
 end

data/lib/schedule_attributes/input.rb

@@ -135,11 +135,16 @@ module ScheduleAttributes
     end
 
     def end_date
-      parse_date_time(@params[:end_date], @params[:start_time]) if @params[:end_date]
+      if @params[:end_date]
+        parse_date_time(@params[:end_date], @params[:end_time] || @params[:start_time])
+      elsif @params[:end_time]
+        parse_date_time(@params[:end_time])
+      end
     end
 
     def ends?
-      @params[:end_date].present? && @params[:ends] != "never"
+      return false if @params[:ends] == "never"
+      @params[:end_date].present? || @params[:end_time].present?
     end
 
     def dates

data/lib/schedule_attributes/version.rb

@@ -1,3 +1,3 @@
 module ScheduleAttributes
-  VERSION = "0.4.0"
+  VERSION = "0.5.0"
 end

data/schedule_attributes.gemspec

@@ -29,4 +29,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'activerecord', '>= 3.2'
   s.add_development_dependency 'sqlite3'
   s.add_development_dependency 'appraisal'
+  s.add_development_dependency 'pry-byebug'
 end

data/spec/active_record_integration_spec.rb

@@ -3,13 +3,13 @@ require 'support/scheduled_active_record_model'
 
 describe CustomScheduledActiveRecordModel do
   it "should have a default schedule" do
-    subject.my_schedule.should == hourly
+    expect(subject.my_schedule).to eq(hourly)
   end
 
   def hourly
-    IceCube::Schedule.new(Date.today.to_time).tap { |s|
+    IceCube::Schedule.new(Date.today.to_time).tap do |s|
       s.add_recurrence_rule IceCube::Rule.hourly
-    }
+    end
   end
 end
 
@@ -17,10 +17,9 @@ describe DefaultScheduledActiveRecordModel do
   alias :model :subject
 
   it "should have a default schedule" do
-    subject.schedule.should be_a IceCube::Schedule
+    expect(subject.schedule).to be_a IceCube::Schedule
   end
 
-
   describe "schedule_attributes" do
     it "round-trips a schedule from the database" do
       model.schedule_attributes = {
@@ -32,10 +31,12 @@ describe DefaultScheduledActiveRecordModel do
         "sunday"=>"0",   "monday"=>"0", "tuesday"=>"0", "wednesday"=>"0",
         "thursday"=>"0", "friday"=>"0", "saturday"=>"0"
       }
-      expected = IceCube::Schedule.new(Time.local(2013, 2, 26)) do |s|
-        s.rrule IceCube::Rule.daily(3).until(Time.local(2016, 7, 7))
+      start_time = Time.local(2013, 2, 26)
+      end_time   = Time.local(2016, 7, 7)
+      expected   = IceCube::Schedule.new(start_time, end_time: end_time) do |s|
+        s.rrule IceCube::Rule.daily(3).until(end_time)
       end
-      model.schedule.should == expected
+      expect(model.schedule).to eq(expected)
     end
 
     it "should deal with all_occurrences with no infinite loops" do
@@ -49,8 +50,8 @@ describe DefaultScheduledActiveRecordModel do
       # Calling schedule_attributes should not change Schedule::Rule.
       model.schedule_attributes
 
-      model.schedule.should == schedule
-      model.schedule.all_occurrences.size.should == 5
+      expect(model.schedule).to eq(schedule)
+      expect(model.schedule.all_occurrences.size).to eq(5)
     end
   end
 

data/spec/schedule_attributes/configuration_spec.rb

@@ -5,12 +5,12 @@ describe "ScheduleAttributes" do
   describe ".configure" do
     it "yields a configuration instance" do
       ScheduleAttributes.configure do |config|
-        config.should be_a ScheduleAttributes::Configuration
+        expect(config).to be_a ScheduleAttributes::Configuration
       end
     end
 
     it "returns a configuration instance" do
-      ScheduleAttributes.configure.should be_a ScheduleAttributes::Configuration
+      expect(ScheduleAttributes.configure).to be_a ScheduleAttributes::Configuration
     end
   end
 end
@@ -18,12 +18,12 @@ end
 describe ScheduleAttributes::Configuration do
   describe ".time_format" do
     it "has a default" do
-      subject.time_format.should == '%H:%M'
+      expect(subject.time_format).to eq('%H:%M')
     end
 
     it "is settable" do
       subject.time_format = '%l:%M %P'
-      subject.time_format.should == '%l:%M %P'
+      expect(subject.time_format).to eq('%l:%M %P')
     end
   end
 end

data/spec/schedule_attributes/input_spec.rb

@@ -8,18 +8,18 @@ describe ScheduleAttributes::Input do
     subject(:repeat) { input.repeat? }
 
     context 'no arguments', args: {} do
-      it { should be true }
+      it { is_expected.to be true }
     end
 
     [0, '0', 'false', 'f', 'F', 'no', 'none'].each do |cond|
       context 'false', args: {repeat: cond} do
-        it { should be false }
+        it { is_expected.to be false }
       end
     end
 
     [1, '1', 'true', 't', 'T', 'yes', 'whatever'].each do |cond|
       context 'true', args: {repeat: cond} do
-        it { should be true }
+        it { is_expected.to be true }
       end
     end
   end
@@ -28,35 +28,35 @@ describe ScheduleAttributes::Input do
     subject(:start_time) { input.start_time }
 
     context 'no arguments', args: {} do
-      it { should be nil }
+      it { is_expected.to be nil }
     end
 
     context 'date argument', args: {date: '2000-12-31'} do
-      it { should == Time.new(2000,12,31,0,0,0) }
+      it { is_expected.to eq(Time.new(2000,12,31,0,0,0)) }
     end
 
     context 'start_date argument', args: {start_date: '2000-12-31'} do
-      it { should == Time.new(2000,12,31,0,0,0) }
+      it { is_expected.to eq(Time.new(2000,12,31,0,0,0)) }
     end
 
     context 'date and start_date arguments', args: {date: '2000-06-06', start_date: '2000-12-31'} do
-      it { should == Time.new(2000,12,31,0,0,0) }
+      it { is_expected.to eq(Time.new(2000,12,31,0,0,0)) }
     end
 
     context 'both dates and repeat arguments', args: {repeat: '0', date: '2000-06-06', start_date: '2000-12-31'} do
       it "uses date instead of start_date when not repeating" do
-        should == Time.new(2000,6,6,0,0,0)
+        is_expected.to eq(Time.new(2000,6,6,0,0,0))
       end
     end
 
     context 'start_date and start_time arguments', args: {start_date: '2000-12-31', start_time: '14:30'} do
       it "combines start_date and start_time" do
-        should == Time.new(2000,12,31,14,30,0)
+        is_expected.to eq(Time.new(2000,12,31,14,30,0))
       end
     end
 
     context 'start_time argument', args: {start_time: '14:00'} do
-      it { should == Date.today.to_time + 14.hours }
+      it { is_expected.to eq(Date.today.to_time + 14.hours) }
     end
   end
 
@@ -64,31 +64,31 @@ describe ScheduleAttributes::Input do
     subject(:end_time) { input.end_time }
 
     context 'no arguments', args: {} do
-      it { should be nil }
+      it { is_expected.to be nil }
     end
 
     context 'end_time argument', args: {end_time: '14:00'} do
-      it { should == Date.today.to_time + 14.hours }
+      it { is_expected.to eq(Date.today.to_time + 14.hours) }
     end
 
     context 'start_date and end_time arguments', args: {start_date: '2000-12-31', end_time: '14:00'} do
-      it { should == Time.new(2000,12,31,14,0,0) }
+      it { is_expected.to eq(Time.new(2000,12,31,14,0,0)) }
     end
 
     context 'start_date, end_date and end_time arguments', args: {start_date: '2000-06-06', end_date: '2000-12-31', end_time: '14:00'} do
-      it { should == Time.new(2000,6,6,14,0,0) }
+      it { is_expected.to eq(Time.new(2000,6,6,14,0,0)) }
     end
 
     context 'date and end_time arguments', args: {date: '2000-12-31', end_time: '14:00'} do
-      it { should == Time.new(2000,12,31,14,0,0) }
+      it { is_expected.to eq(Time.new(2000,12,31,14,0,0)) }
     end
 
     context 'start_date and _time and end_date and _time arguments', args: {start_date: '2000-06-06', end_date: '2000-12-31', start_time: '06:00', end_time: '14:00'} do
-      it { should == Time.new(2000,6,6,14,0,0) }
+      it { is_expected.to eq(Time.new(2000,6,6,14,0,0)) }
     end
 
     context 'start_date and _time and end_date and _time arguments, 24h format', args: {start_date: '2000-06-06', end_date: '2000-12-31', start_time: '20:00', end_time: '14:00'} do
-      it { should == Time.new(2000,6,7,14,0,0) }
+      it { is_expected.to eq(Time.new(2000,6,7,14,0,0)) }
     end
   end
 
@@ -96,15 +96,15 @@ describe ScheduleAttributes::Input do
     subject(:duration) { input.duration }
 
     context 'no arguments', args: {} do
-      it { should be nil }
+      it { is_expected.to be nil }
     end
 
     context 'start_time argument', args: {start_time: '8:00'} do
-      it { should be nil }
+      it { is_expected.to be nil }
     end
 
     context 'start_time and end_time arguments', args: {start_time: '8:00', end_time: '14:00'} do
-      it { should == 6.hours }
+      it { is_expected.to eq(6.hours) }
     end
   end
 
@@ -112,27 +112,27 @@ describe ScheduleAttributes::Input do
     subject(:dates) { input.dates }
 
     context 'no arguments', args: {} do
-      it { should == [] }
+      it { is_expected.to eq([]) }
     end
 
     context 'repeat argument', args: {repeat: '0'} do
-      it { should == [] }
+      it { is_expected.to eq([]) }
     end
 
     context 'start_date argument', args: {start_date: '2000-06-06'} do
-      it { should == [] }
+      it { is_expected.to eq([]) }
     end
 
     context 'repeat, date and start_date arguments', args: {repeat: '0', date: '2000-06-06', start_date: '2000-02-03'} do
-      it { should == [Time.new(2000,6,6)] }
+      it { is_expected.to eq([Time.new(2000,6,6)]) }
     end
 
     context 'dates array argument', args: {dates: ['2000-01-02','2000-02-03']} do
-      it { should == [Time.new(2000,1,2), Time.new(2000,2,3)] }
+      it { is_expected.to eq([Time.new(2000,1,2), Time.new(2000,2,3)]) }
     end
 
     context 'repeat, date, start_date and start_time arguments', args: {repeat: '0', date: '2000-06-06', start_date: '2000-06-06', start_time: '12:00'} do
-      it { should == [Time.new(2000,6,6,12,0)] }
+      it { is_expected.to eq([Time.new(2000,6,6,12,0)]) }
     end
   end
 
@@ -140,7 +140,7 @@ describe ScheduleAttributes::Input do
     subject(:ends) { input.ends? }
 
     context 'repeat and end_date arguments', args: {repeat: '1', end_date: ''} do
-      it { should be_falsey }
+      it { is_expected.to be_falsey }
     end
   end
 
@@ -148,15 +148,15 @@ describe ScheduleAttributes::Input do
     subject(:yearly_start_month_day) { input.yearly_start_month_day? }
 
     context 'repeat and yearly_start_month_day arguments', args: {repeat: '1', yearly_start_month_day: '2'} do
-      it { should be_falsey }
+      it { is_expected.to be_falsey }
     end
 
     context 'repeat, yearly_start_month and yearly_start_month_day arguments', args: {repeat: '1', yearly_start_month: '12', yearly_start_month_day: '2'} do
-      it { should be_truthy }
+      it { is_expected.to be_truthy }
     end
 
     context 'repeat, yearly_start_month and yearly_start_month_day arguments', args: {repeat: '1', yearly_start_month: '12', yearly_start_month_day: '1'} do
-      it { should be_falsey }
+      it { is_expected.to be_falsey }
     end
   end
 
@@ -164,19 +164,19 @@ describe ScheduleAttributes::Input do
     subject(:yearly_end_month_day) { input.yearly_end_month_day? }
 
     context 'repeat and yearly_end_month_day arguments', args: {repeat: '1', yearly_end_month_day: '27'} do
-      it { should be_falsey }
+      it { is_expected.to be_falsey }
     end
 
     context 'repeat, yearly_end_month and yearly_end_month_day arguments', args: {repeat: '1', yearly_end_month: '12', yearly_end_month_day: '27'} do
-      it { should be_truthy }
+      it { is_expected.to be_truthy }
     end
 
     context 'repeat, yearly_end_month and yearly_end_month_day arguments', args: {repeat: '1', yearly_end_month: '12', yearly_end_month_day: '31'} do
-      it { should be_falsey }
+      it { is_expected.to be_falsey }
     end
 
     context 'repeat, yearly_end_month and yearly_end_month_day arguments', args: {repeat: '1', yearly_end_month: '11', yearly_end_month_day: '30'} do
-      it { should be_falsey }
+      it { is_expected.to be_falsey }
     end
   end
 end