dfg-paypal 0.8.2

data/spec/paypal/payment/request/item_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper.rb'
+
+describe Paypal::Payment::Request::Item do
+  let :instance do
+    Paypal::Payment::Request::Item.new(
+      :name => 'Name',
+      :description => 'Description',
+      :amount => 10,
+      :quantity => 5,
+      :category => :Digital,
+      :number => '1'
+    )
+  end
+
+  describe '#to_params' do
+    it 'should handle Recurring Profile activation parameters' do
+      instance.to_params(1).should == {
+        :L_PAYMENTREQUEST_1_NAME0 => 'Name',
+        :L_PAYMENTREQUEST_1_DESC0 => 'Description',
+        :L_PAYMENTREQUEST_1_AMT0 => '10.00',
+        :L_PAYMENTREQUEST_1_QTY0 => 5,
+        :L_PAYMENTREQUEST_1_ITEMCATEGORY0 => :Digital,
+        :L_PAYMENTREQUEST_1_NUMBER0 => '1'
+      }
+    end
+  end
+end

data/spec/paypal/payment/request_spec.rb

@@ -0,0 +1,136 @@
+require 'spec_helper.rb'
+
+describe Paypal::Payment::Request do
+  let :instant_request do
+    Paypal::Payment::Request.new(
+      :amount => 25.7,
+      :tax_amount => 0.4,
+      :shipping_amount => 1.5,
+      :currency_code => :JPY,
+      :description => 'Instant Payment Request',
+      :notify_url => 'http://merchant.example.com/notify',
+      :invoice_number => 'ABC123',
+      :custom => 'Custom',
+      :items => [{
+        :quantity => 2,
+        :name => 'Item1',
+        :description => 'Awesome Item 1!',
+        :amount => 10.25
+      }, {
+        :quantity => 3,
+        :name => 'Item2',
+        :description => 'Awesome Item 2!',
+        :amount => 1.1
+      }],
+      :custom_fields => {
+        "l_surveychoice{n}" => 'abcd' # The '{n}' will be replaced with the index
+      }
+    )
+  end
+
+  let :recurring_request do
+    Paypal::Payment::Request.new(
+      :currency_code => :JPY,
+      :billing_type => :RecurringPayments,
+      :billing_agreement_description => 'Recurring Payment Request'
+    )
+  end
+
+  let :reference_transaction_request do
+    Paypal::Payment::Request.new(
+      :currency_code => :JPY,
+      :billing_type => :MerchantInitiatedBillingSingleAgreement,
+      :billing_agreement_description => 'Reference Transaction Request'
+    )
+  end
+
+  describe '.new' do
+    it 'should handle Instant Payment parameters' do
+      instant_request.amount.total.should == 25.7
+      instant_request.amount.tax.should == 0.4
+      instant_request.amount.shipping.should == 1.5
+      instant_request.currency_code.should == :JPY
+      instant_request.description.should == 'Instant Payment Request'
+      instant_request.notify_url.should == 'http://merchant.example.com/notify'
+    end
+
+    it 'should handle Recurring Payment parameters' do
+      recurring_request.currency_code.should == :JPY
+      recurring_request.billing_type.should == :RecurringPayments
+      recurring_request.billing_agreement_description.should == 'Recurring Payment Request'
+    end
+
+    it 'should handle Recurring Payment parameters' do
+      reference_transaction_request.currency_code.should == :JPY
+      reference_transaction_request.billing_type.should == :MerchantInitiatedBillingSingleAgreement
+      reference_transaction_request.billing_agreement_description.should == 'Reference Transaction Request'
+    end
+  end
+
+  describe '#to_params' do
+    it 'should handle Instant Payment parameters' do
+      instant_request.to_params.should == {
+        :PAYMENTREQUEST_0_AMT => "25.70",
+        :PAYMENTREQUEST_0_TAXAMT => "0.40",
+        :PAYMENTREQUEST_0_SHIPPINGAMT => "1.50",
+        :PAYMENTREQUEST_0_CURRENCYCODE => :JPY,
+        :PAYMENTREQUEST_0_DESC => "Instant Payment Request",
+        :PAYMENTREQUEST_0_NOTIFYURL => "http://merchant.example.com/notify",
+        :PAYMENTREQUEST_0_ITEMAMT => "23.80",
+        :PAYMENTREQUEST_0_INVNUM => "ABC123",
+        :PAYMENTREQUEST_0_CUSTOM => "Custom",
+        :L_PAYMENTREQUEST_0_NAME0 => "Item1",
+        :L_PAYMENTREQUEST_0_DESC0 => "Awesome Item 1!",
+        :L_PAYMENTREQUEST_0_AMT0 => "10.25",
+        :L_PAYMENTREQUEST_0_QTY0 => 2,
+        :L_PAYMENTREQUEST_0_NAME1 => "Item2",
+        :L_PAYMENTREQUEST_0_DESC1 => "Awesome Item 2!",
+        :L_PAYMENTREQUEST_0_AMT1 => "1.10",
+        :L_PAYMENTREQUEST_0_QTY1 => 3,
+        :L_SURVEYCHOICE0 => 'abcd' # Note the 'n' was replaced by the index
+      }
+    end
+
+    it 'should handle Recurring Payment parameters' do
+      recurring_request.to_params.should == {
+        :PAYMENTREQUEST_0_AMT => "0.00",
+        :PAYMENTREQUEST_0_TAXAMT => "0.00",
+        :PAYMENTREQUEST_0_SHIPPINGAMT => "0.00",
+        :PAYMENTREQUEST_0_CURRENCYCODE => :JPY,
+        :L_BILLINGTYPE0 => :RecurringPayments,
+        :L_BILLINGAGREEMENTDESCRIPTION0 => "Recurring Payment Request"
+      }
+    end
+
+    it 'should handle Reference Transactions parameters' do
+      reference_transaction_request.to_params.should == {
+        :PAYMENTREQUEST_0_AMT => "0.00",
+        :PAYMENTREQUEST_0_TAXAMT => "0.00",
+        :PAYMENTREQUEST_0_SHIPPINGAMT => "0.00",
+        :PAYMENTREQUEST_0_CURRENCYCODE => :JPY,
+        :L_BILLINGTYPE0 => :MerchantInitiatedBillingSingleAgreement,
+        :L_BILLINGAGREEMENTDESCRIPTION0 => "Reference Transaction Request"
+      }
+    end
+  end
+
+  describe '#items_amount' do
+    context 'when BigDecimal'
+    let(:instance) do
+      Paypal::Payment::Request.new(
+        :items => [{
+          :quantity => 3,
+          :name => 'Item1',
+          :description => 'Awesome Item 1!',
+          :amount => 130.45
+        }]
+      )
+    end
+
+    # NOTE:
+    # 130.45 * 3 => 391.34999999999997 (in ruby 1.9)
+    it 'should calculate total amount correctly' do
+      instance.items_amount.should == 391.35
+    end
+  end
+end

data/spec/paypal/payment/response/address_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper.rb'
+
+describe Paypal::Payment::Response::Address do
+  let :keys do
+    Paypal::Payment::Response::Address.optional_attributes
+  end
+
+  describe '.new' do
+    it 'should allow nil for attributes' do
+      payer = Paypal::Payment::Response::Address.new
+      keys.each do |key|
+        payer.send(key).should be_nil
+      end
+    end
+
+    it 'should treat all attributes as String' do
+      attributes = keys.inject({}) do |attributes, key|
+        attributes.merge!(key => "xyz")
+      end
+      payer = Paypal::Payment::Response::Address.new attributes
+      keys.each do |key|
+        payer.send(key).should == "xyz"
+      end
+    end
+  end
+end

data/spec/paypal/payment/response/info_spec.rb

@@ -0,0 +1,93 @@
+require 'spec_helper.rb'
+
+describe Paypal::Payment::Response::Info do
+  let :attribute_mapping do
+    Paypal::Payment::Response::Info.attribute_mapping
+  end
+
+  let :attributes do
+    {
+      :ACK => 'Success',
+      :CURRENCYCODE => 'JPY',
+      :ERRORCODE => 0,
+      :ORDERTIME => '2011-02-08T03:23:54Z',
+      :PAYMENTSTATUS => 'Completed',
+      :PAYMENTTYPE => 'instant',
+      :PENDINGREASON => 'None',
+      :PROTECTIONELIGIBILITY => 'Ineligible',
+      :PROTECTIONELIGIBILITYTYPE => 'None',
+      :REASONCODE => 'None',
+      :TRANSACTIONID => '8NC65222871997739',
+      :TRANSACTIONTYPE => 'expresscheckout',
+      :AMT => '14.00',
+      :FEEAMT => '0.85',
+      :TAXAMT => '0.00',
+      :RECEIPTID => '12345',
+      :SECUREMERCHANTACCOUNTID => '123456789',
+      :PAYMENTREQUESTID => '12345',
+      :SELLERPAYPALACCOUNTID => 'seller@shop.example.com',
+      :EXCHANGERATE => '0.811965'
+    }
+  end
+
+  describe '.new' do
+    context 'when attribute keys are uppercase Symbol' do
+      it 'should accept all without any warning' do
+        Paypal.logger.should_not_receive(:warn)
+        from_symbol_uppercase = Paypal::Payment::Response::Info.new attributes
+        attribute_mapping.values.each do |key|
+          from_symbol_uppercase.send(key).should_not be_nil
+        end
+        from_symbol_uppercase.amount.should == Paypal::Payment::Common::Amount.new(
+          :total => 14,
+          :fee => 0.85
+        )
+      end
+    end
+
+    context 'when attribute keys are lowercase Symbol' do
+      it 'should ignore them and warn' do
+        _attrs_ = attributes.inject({}) do |_attrs_, (k, v)|
+          _attrs_.merge!(k.to_s.downcase.to_sym => v)
+        end
+        _attrs_.each do |key, value|
+          Paypal.logger.should_receive(:warn).with(
+            "Ignored Parameter (Paypal::Payment::Response::Info): #{key}=#{value}"
+          )
+        end
+        from_symbol_lowercase = Paypal::Payment::Response::Info.new _attrs_
+        attribute_mapping.values.each do |key|
+          from_symbol_lowercase.send(key).should be_nil
+        end
+        from_symbol_lowercase.amount.should == Paypal::Payment::Common::Amount.new
+      end
+    end
+
+    context 'when attribute keys are String' do
+      it 'should ignore them and warn' do
+        attributes.stringify_keys.each do |key, value|
+          Paypal.logger.should_receive(:warn).with(
+            "Ignored Parameter (Paypal::Payment::Response::Info): #{key}=#{value}"
+          )
+        end
+        from_string = Paypal::Payment::Response::Info.new attributes.stringify_keys
+        attribute_mapping.values.each do |key|
+          from_string.send(key).should be_nil
+        end
+        from_string.amount.should == Paypal::Payment::Common::Amount.new
+      end
+    end
+
+    context 'when non-supported attributes are given' do
+      it 'should ignore them and warn' do
+        _attr_ = attributes.merge(
+          :ignored => 'Ignore me!'
+        )
+        Paypal.logger.should_receive(:warn).with(
+          "Ignored Parameter (Paypal::Payment::Response::Info): ignored=Ignore me!"
+        )
+        Paypal::Payment::Response::Info.new _attr_
+      end
+    end
+  end
+end

data/spec/paypal/payment/response/item_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper.rb'
+
+describe Paypal::Payment::Response::Info do
+  let :attributes do
+    {
+      :NAME => 'Item Name',
+      :DESC => 'Item Description',
+      :QTY => '1',
+      :NUMBER => '1',
+      :ITEMCATEGORY => 'Digital',
+      :ITEMWIDTHVALUE => '1.0',
+      :ITEMHEIGHTVALUE => '2.0',
+      :ITEMLENGTHVALUE => '3.0',
+      :ITEMWEIGHTVALUE => '4.0'
+    }
+  end
+
+  describe '.new' do
+    subject { Paypal::Payment::Response::Item.new(attributes) }
+    its(:name) { should == 'Item Name' }
+    its(:description) { should == 'Item Description' }
+    its(:quantity) { should == 1 }
+    its(:category) { should == 'Digital' }
+    its(:width) { should == '1.0' }
+    its(:height) { should == '2.0' }
+    its(:length) { should == '3.0' }
+    its(:weight) { should == '4.0' }
+    its(:number) { should == '1' }
+
+    context 'when non-supported attributes are given' do
+      it 'should ignore them and warn' do
+        _attr_ = attributes.merge(
+          :ignored => 'Ignore me!'
+        )
+        Paypal.logger.should_receive(:warn).with(
+          "Ignored Parameter (Paypal::Payment::Response::Item): ignored=Ignore me!"
+        )
+        Paypal::Payment::Response::Item.new _attr_
+      end
+    end
+  end
+end

data/spec/paypal/payment/response/payer_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper.rb'
+
+describe Paypal::Payment::Response::Payer do
+  let :keys do
+    Paypal::Payment::Response::Payer.optional_attributes
+  end
+
+  describe '.new' do
+    it 'should allow nil for attributes' do
+      payer = Paypal::Payment::Response::Payer.new
+      keys.each do |key|
+        payer.send(key).should be_nil
+      end
+    end
+
+    it 'should treat all attributes as String' do
+      attributes = keys.inject({}) do |attributes, key|
+        attributes.merge!(key => "xyz")
+      end
+      payer = Paypal::Payment::Response::Payer.new attributes
+      keys.each do |key|
+        payer.send(key).should == "xyz"
+      end
+    end
+  end
+end

data/spec/paypal/payment/response_spec.rb

@@ -0,0 +1,16 @@
+require 'spec_helper.rb'
+
+describe Paypal::Payment::Response do
+  describe '.new' do
+    context 'when non-supported attributes are given' do
+      it 'should ignore them and warn' do
+        Paypal.logger.should_receive(:warn).with(
+          "Ignored Parameter (Paypal::Payment::Response): ignored=Ignore me!"
+        )
+        response = Paypal::Payment::Response.new(
+          :ignored => 'Ignore me!'
+        )
+      end
+    end
+  end
+end

data/spec/paypal/util_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper.rb'
+
+describe Paypal::Util do
+  describe '.formatted_amount' do
+    it 'should return String in "xx.yy" format' do
+      Paypal::Util.formatted_amount(nil).should == '0.00'
+      Paypal::Util.formatted_amount(10).should == '10.00'
+      Paypal::Util.formatted_amount(10.02).should == '10.02'
+      Paypal::Util.formatted_amount(10.2).should == '10.20'
+      Paypal::Util.formatted_amount(10.24).should == '10.24'
+      Paypal::Util.formatted_amount(10.255).should == '10.25'
+    end
+  end
+
+  describe '.to_numeric' do
+    it 'should return Numeric' do
+      Paypal::Util.to_numeric('10').should be_kind_of(Integer)
+      Paypal::Util.to_numeric('10.5').should be_kind_of(Float)
+      Paypal::Util.to_numeric('-1.5').should == -1.5
+      Paypal::Util.to_numeric('-1').should == -1
+      Paypal::Util.to_numeric('0').should == 0
+      Paypal::Util.to_numeric('0.00').should == 0
+      Paypal::Util.to_numeric('10').should == 10
+      Paypal::Util.to_numeric('10.00').should == 10
+      Paypal::Util.to_numeric('10.02').should == 10.02
+      Paypal::Util.to_numeric('10.2').should == 10.2
+      Paypal::Util.to_numeric('10.20').should == 10.2
+      Paypal::Util.to_numeric('10.24').should == 10.24
+      Paypal::Util.to_numeric('10.25').should == 10.25
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,25 @@
+require 'simplecov'
+
+SimpleCov.start do
+  add_filter 'spec'
+end
+
+require 'paypal'
+require 'rspec'
+require 'helpers/fake_response_helper'
+
+RSpec.configure do |config|
+  config.before do
+    Paypal.logger = double("logger")
+  end
+  config.after do
+    FakeWeb.clean_registry
+  end
+end
+
+def sandbox_mode(&block)
+  Paypal.sandbox!
+  yield
+ensure
+  Paypal.sandbox = false
+end

metadata

@@ -0,0 +1,225 @@
+--- !ruby/object:Gem::Specification
+name: dfg-paypal
+version: !ruby/object:Gem::Version
+  version: 0.8.2
+platform: ruby
+authors:
+- Dmitry Fedyuk
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2016-12-12 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.3'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.3'
+- !ruby/object:Gem::Dependency
+  name: rest-client
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: attr_required
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.0.5
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.0.5
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0.8'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0.8'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.99'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.99'
+- !ruby/object:Gem::Dependency
+  name: fakeweb
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.3.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.3.0
+description: This gem is used for my Discourse plugins.
+email: admin@discourse.pro
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- ".document"
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
+- Gemfile
+- Rakefile
+- VERSION
+- dfg-paypal.gemspec
+- lib/paypal.rb
+- lib/paypal/base.rb
+- lib/paypal/exception.rb
+- lib/paypal/exception/api_error.rb
+- lib/paypal/exception/http_error.rb
+- lib/paypal/express.rb
+- lib/paypal/express/request.rb
+- lib/paypal/express/response.rb
+- lib/paypal/ipn.rb
+- lib/paypal/nvp/request.rb
+- lib/paypal/nvp/response.rb
+- lib/paypal/payment/common/amount.rb
+- lib/paypal/payment/recurring.rb
+- lib/paypal/payment/recurring/activation.rb
+- lib/paypal/payment/recurring/billing.rb
+- lib/paypal/payment/recurring/summary.rb
+- lib/paypal/payment/request.rb
+- lib/paypal/payment/request/item.rb
+- lib/paypal/payment/response.rb
+- lib/paypal/payment/response/address.rb
+- lib/paypal/payment/response/info.rb
+- lib/paypal/payment/response/item.rb
+- lib/paypal/payment/response/payer.rb
+- lib/paypal/payment/response/reference.rb
+- lib/paypal/payment/response/refund.rb
+- lib/paypal/util.rb
+- spec/fake_response/BillAgreementUpdate/fetch.txt
+- spec/fake_response/BillAgreementUpdate/revoke.txt
+- spec/fake_response/CreateBillingAgreement/success.txt
+- spec/fake_response/CreateRecurringPaymentsProfile/failure.txt
+- spec/fake_response/CreateRecurringPaymentsProfile/success.txt
+- spec/fake_response/DoCapture/failure.txt
+- spec/fake_response/DoCapture/success.txt
+- spec/fake_response/DoExpressCheckoutPayment/failure.txt
+- spec/fake_response/DoExpressCheckoutPayment/success.txt
+- spec/fake_response/DoExpressCheckoutPayment/success_with_billing_agreement.txt
+- spec/fake_response/DoExpressCheckoutPayment/success_with_many_items.txt
+- spec/fake_response/DoReferenceTransaction/failure.txt
+- spec/fake_response/DoReferenceTransaction/success.txt
+- spec/fake_response/DoVoid/success.txt
+- spec/fake_response/GetExpressCheckoutDetails/failure.txt
+- spec/fake_response/GetExpressCheckoutDetails/success.txt
+- spec/fake_response/GetExpressCheckoutDetails/with_billing_accepted_status.txt
+- spec/fake_response/GetRecurringPaymentsProfileDetails/failure.txt
+- spec/fake_response/GetRecurringPaymentsProfileDetails/success.txt
+- spec/fake_response/GetTransactionDetails/failure.txt
+- spec/fake_response/GetTransactionDetails/success.txt
+- spec/fake_response/IPN/invalid.txt
+- spec/fake_response/IPN/valid.txt
+- spec/fake_response/ManageRecurringPaymentsProfileStatus/failure.txt
+- spec/fake_response/ManageRecurringPaymentsProfileStatus/success.txt
+- spec/fake_response/RefundTransaction/full.txt
+- spec/fake_response/SetExpressCheckout/failure.txt
+- spec/fake_response/SetExpressCheckout/success.txt
+- spec/helpers/fake_response_helper.rb
+- spec/paypal/exception/api_error_spec.rb
+- spec/paypal/exception/http_error_spec.rb
+- spec/paypal/express/request_spec.rb
+- spec/paypal/express/response_spec.rb
+- spec/paypal/ipn_spec.rb
+- spec/paypal/nvp/request_spec.rb
+- spec/paypal/nvp/response_spec.rb
+- spec/paypal/payment/common/amount_spec.rb
+- spec/paypal/payment/recurring/activation_spec.rb
+- spec/paypal/payment/recurring_spec.rb
+- spec/paypal/payment/request/item_spec.rb
+- spec/paypal/payment/request_spec.rb
+- spec/paypal/payment/response/address_spec.rb
+- spec/paypal/payment/response/info_spec.rb
+- spec/paypal/payment/response/item_spec.rb
+- spec/paypal/payment/response/payer_spec.rb
+- spec/paypal/payment/response_spec.rb
+- spec/paypal/util_spec.rb
+- spec/spec_helper.rb
+homepage: https://github.com/discourse-pro/dfg-paypal
+licenses:
+- Nonstandard
+metadata: {}
+post_install_message: 
+rdoc_options:
+- "--charset=UTF-8"
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: 1.3.6
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.5.1
+signing_key: 
+specification_version: 4
+summary: PayPal Express Checkout API Client for Instance, Recurring and Digital Goods
+  Payment.
+test_files: []