devtools 0.1.19 → 0.1.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 1c2270dfb75f85fcf1a74d5dd59a150e0b085e53
-  data.tar.gz: 79016f9af38770aa4a428bc60d6233d8474e0792
+SHA256:
+  metadata.gz: 0616e5015d96abe24a54140716e172d0c643937cacf4df99e7e425b9c809fcd4
+  data.tar.gz: 192fc5ed731193186e401fec71e4acd6dff379af89c926e76921a93f1c3868b7
 SHA512:
-  metadata.gz: dd74658d9892ee698a38afa92c216d7be73044af47ecf0a601ce1596b146961c583a306aba05422c3973ebcb1ffd45d0f721b2e8253f95dcd190c682e7b45c3d
-  data.tar.gz: 31ac2c0e8bfaad3b1be3477ba39292908a098e95bb57c208ed1abd6f8bebe70930238be6c73eb89a9eaa66997de9722ca03e11ba0caf65c409c1797d84689c8e
+  metadata.gz: b51df5fdff2ce21a96f56cd8fd430e5a156818d0d1b822d0a9d2ce405a0511b56e988d57ea504ac0cda661d0a3c839860d229a47c1041978406a9978813106c2
+  data.tar.gz: 7ffa20c5a8eccb1a45ce67e80f1fb6227bfde2bf8ae622fc1a4f5a95cc1aa58f5dbd7badc3bbd46a7919ce81547e1b8104e28539ba143eb9cf34a47525d9d4fc

data/Rakefile

@@ -1,4 +1,3 @@
-# rubocop:disable Naming/FileName
 require 'devtools'
 
 ENV['DEVTOOLS_SELF'] = '1'

data/config/flay.yml

@@ -1,3 +1,3 @@
 ---
 threshold: 8
-total_score: 115
+total_score: 122

data/config/flog.yml

@@ -1,2 +1,2 @@
 ---
-threshold: 19.7
+threshold: 13.5

data/config/rubocop.yml

@@ -1,9 +1,18 @@
 inherit_from: ../.rubocop.yml
 
+AllCops:
+  TargetRubyVersion: 2.3.0
+
 Metrics/BlockLength:
   Exclude:
   # Ignore RSpec DSL
-  - spec/**/*
+    - spec/**/*
+  # Ignore gemspec DSL
+    - '*.gemspec'
+
+Naming/FileName:
+  Exclude:
+    - Rakefile
 
 # Avoid parameter lists longer than five parameters.
 ParameterLists:

data/devtools.gemspec

@@ -1,7 +1,6 @@
-# rubocop:disable Metrics/BlockLength
 Gem::Specification.new do |gem|
   gem.name        = 'devtools'
-  gem.version     = '0.1.19'
+  gem.version     = '0.1.20'
   gem.authors     = ['Markus Schirp']
   gem.email       = ['mbj@schirp-dso.com']
   gem.description = 'A metagem wrapping development tools'
@@ -14,7 +13,7 @@ Gem::Specification.new do |gem|
   gem.executables           = %w[]
   gem.test_files            = `git ls-files -- spec`.split("\n")
   gem.extra_rdoc_files      = %w[README.md]
-  gem.required_ruby_version = '>= 2.1'
+  gem.required_ruby_version = '>= 2.3'
 
   gem.add_runtime_dependency 'abstract_type', '~> 0.0.7'
   gem.add_runtime_dependency 'adamantium',    '~> 0.2.0'
@@ -25,13 +24,13 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency 'mutant',        '~> 0.8.14'
   gem.add_runtime_dependency 'mutant-rspec',  '~> 0.8.14'
   gem.add_runtime_dependency 'procto',        '~> 0.0.3'
-  gem.add_runtime_dependency 'rake',          '~> 12.0.0'
+  gem.add_runtime_dependency 'rake',          '~> 12.3.0'
   gem.add_runtime_dependency 'reek',          '~> 4.7.3'
   gem.add_runtime_dependency 'rspec',         '~> 3.6.0'
   gem.add_runtime_dependency 'rspec-core',    '~> 3.6.0'
   gem.add_runtime_dependency 'rspec-its',     '~> 1.2.0'
-  gem.add_runtime_dependency 'rubocop',       '~> 0.51.0'
-  gem.add_runtime_dependency 'simplecov',     '~> 0.14.0'
-  gem.add_runtime_dependency 'yard',          '~> 0.9.9'
+  gem.add_runtime_dependency 'rubocop',       '~> 0.52.1'
+  gem.add_runtime_dependency 'simplecov',     '~> 0.15.1'
+  gem.add_runtime_dependency 'yard',          '~> 0.9.12'
   gem.add_runtime_dependency 'yardstick',     '~> 0.9.9'
 end

data/lib/devtools.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Stdlib infrastructure
 require 'pathname'
 require 'rake'
@@ -20,19 +22,18 @@ require 'simplecov'
 
 # Main devtools namespace population
 module Devtools
-
   ROOT                    = Pathname.new(__FILE__).parent.parent.freeze
   PROJECT_ROOT            = Pathname.pwd.freeze
   SHARED_PATH             = ROOT.join('shared').freeze
   SHARED_SPEC_PATH        = SHARED_PATH.join('spec').freeze
   DEFAULT_CONFIG_PATH     = ROOT.join('default/config').freeze
   RAKE_FILES_GLOB         = ROOT.join('tasks/**/*.rake').to_s.freeze
-  LIB_DIRECTORY_NAME      = 'lib'.freeze
-  SPEC_DIRECTORY_NAME     = 'spec'.freeze
-  RAKE_FILE_NAME          = 'Rakefile'.freeze
-  SHARED_SPEC_PATTERN     = '{shared,support}/**/*.rb'.freeze
-  UNIT_TEST_PATH_REGEXP   = %r{\bspec/unit/}.freeze
-  DEFAULT_CONFIG_DIR_NAME = 'config'.freeze
+  LIB_DIRECTORY_NAME      = 'lib'
+  SPEC_DIRECTORY_NAME     = 'spec'
+  RAKE_FILE_NAME          = 'Rakefile'
+  SHARED_SPEC_PATTERN     = '{shared,support}/**/*.rb'
+  UNIT_TEST_PATH_REGEXP   = %r{\bspec/unit/}
+  DEFAULT_CONFIG_DIR_NAME = 'config'
 
   private_constant(*constants(false))
 

data/lib/devtools/config.rb

@@ -1,5 +1,6 @@
-module Devtools
+# frozen_string_literal: true
 
+module Devtools
   # Abstract base class of tool configuration
   class Config
     include Adamantium::Flat, AbstractType, Concord.new(:config_dir)
@@ -12,8 +13,8 @@ module Devtools
       # Type check against expected class
       include Concord.new(:name, :allowed_classes)
 
-      ERROR_FORMAT = '%<name>s: Got instance of %<got>s expected %<allowed>s'.freeze
-      CLASS_DELIM  = ','.freeze
+      ERROR_FORMAT = '%<name>s: Got instance of %<got>s expected %<allowed>s'
+      CLASS_DELIM  = ','
 
       # Check value for instance of expected class
       #
@@ -22,13 +23,14 @@ module Devtools
       # @return [Object]
       def call(value)
         klass = value.class
+        format_values = {
+          name: name,
+          got: klass,
+          allowed: allowed_classes.join(CLASS_DELIM)
+        }
 
         unless allowed_classes.any?(&klass.method(:equal?))
-          fail TypeError, ERROR_FORMAT % {
-            name:    name,
-            got:     klass,
-            allowed: allowed_classes.join(CLASS_DELIM)
-          }
+          fail TypeError, format(ERROR_FORMAT, format_values)
         end
 
         value
@@ -99,18 +101,18 @@ module Devtools
 
     # Rubocop configuration
     class Rubocop < self
-      FILE = 'rubocop.yml'.freeze
+      FILE = 'rubocop.yml'
     end # Rubocop
 
     # Reek configuration
     class Reek < self
-      FILE = 'reek.yml'.freeze
+      FILE = 'reek.yml'
     end # Reek
 
     # Flay configuration
     #
     class Flay < self
-      FILE             = 'flay.yml'.freeze
+      FILE             = 'flay.yml'
       DEFAULT_LIB_DIRS = %w[lib].freeze
       DEFAULT_EXCLUDES = %w[].freeze
 
@@ -122,7 +124,7 @@ module Devtools
 
     # Yardstick configuration
     class Yardstick < self
-      FILE    = 'yardstick.yml'.freeze
+      FILE    = 'yardstick.yml'
       OPTIONS = %w[
         threshold
         rules
@@ -145,7 +147,7 @@ module Devtools
 
     # Flog configuration
     class Flog < self
-      FILE             = 'flog.yml'.freeze
+      FILE             = 'flog.yml'
       DEFAULT_LIB_DIRS = %w[lib].freeze
 
       attribute :total_score, [Float]
@@ -155,9 +157,9 @@ module Devtools
 
     # Mutant configuration
     class Mutant < self
-      FILE             = 'mutant.yml'.freeze
-      DEFAULT_NAME     = ''.freeze
-      DEFAULT_STRATEGY = 'rspec'.freeze
+      FILE             = 'mutant.yml'
+      DEFAULT_NAME     = ''
+      DEFAULT_STRATEGY = 'rspec'
 
       attribute :name,            [String],                default: DEFAULT_NAME
       attribute :strategy,        [String],                default: DEFAULT_STRATEGY
@@ -169,7 +171,7 @@ module Devtools
 
     # Devtools configuration
     class Devtools < self
-      FILE                      = 'devtools.yml'.freeze
+      FILE                      = 'devtools.yml'
       DEFAULT_UNIT_TEST_TIMEOUT = 0.1  # 100ms
 
       attribute :unit_test_timeout, [Float], default: DEFAULT_UNIT_TEST_TIMEOUT

data/lib/devtools/flay.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Devtools
   module Flay
     # Measure flay mass relative to size of duplicated sexps
@@ -46,7 +48,7 @@ module Devtools
     class FileList
       include Procto.call, Concord.new(:includes, :excludes)
 
-      GLOB = '**/*.{rb,erb}'.freeze
+      GLOB = '**/*.{rb,erb}'
 
       # Expand includes and filter by excludes
       #

data/lib/devtools/project/initializer/rake.rb

@@ -11,7 +11,9 @@ module Devtools
         #
         # @api rpivate
         def self.call
-          FileList.glob(RAKE_FILES_GLOB).each(&::Rake.application.method(:add_import))
+          FileList
+            .glob(RAKE_FILES_GLOB)
+            .each(&::Rake.application.method(:add_import))
           self
         end
 

data/lib/devtools/project/initializer/rspec.rb

@@ -44,7 +44,9 @@ module Devtools
         #
         def enable_unit_test_timeout
           timeout = project.devtools.unit_test_timeout
-          RSpec.configuration.around(file_path: UNIT_TEST_PATH_REGEXP) do |example|
+          RSpec
+            .configuration
+            .around(file_path: UNIT_TEST_PATH_REGEXP) do |example|
             Timeout.timeout(timeout, &example)
           end
         end

data/lib/devtools/rake/flay.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Devtools
   module Rake
     # Flay metric runner
@@ -6,39 +8,28 @@ module Devtools
               Procto.call(:verify),
               Adamantium
 
-      BELOW_THRESHOLD = 'Adjust flay threshold down to %d'.freeze
-      TOTAL_MISMATCH  = 'Flay total is now %d, but expected %d'.freeze
-      ABOVE_THRESHOLD = '%d chunks have a duplicate mass > %d'.freeze
+      BELOW_THRESHOLD = 'Adjust flay threshold down to %<mass>d'
+      TOTAL_MISMATCH  = 'Flay total is now %<mass>d, but expected %<expected>d'
+      ABOVE_THRESHOLD = '%<mass>d chunks have a duplicate mass > %<threshold>d'
 
       # Verify code specified by `files` does not violate flay expectations
       #
       # @raise [SystemExit] if a violation is found
       # @return [undefined] otherwise
       #
-      # rubocop:disable MethodLength
       #
       # @api private
       def verify
         # Run flay first to ensure the max mass matches the threshold
-        if below_threshold?
-          Devtools.notify_metric_violation(
-            BELOW_THRESHOLD % largest_mass
-          )
-        end
-
-        if total_mismatch?
-          Devtools.notify_metric_violation(
-            TOTAL_MISMATCH % [total_mass, total_score]
-          )
-        end
+        below_threshold_message if below_threshold?
+
+        total_mismatch_message if total_mismatch?
 
         # Run flay a second time with the threshold set
         return unless above_threshold?
 
         restricted_flay_scale.flay_report
-        Devtools.notify_metric_violation(
-          ABOVE_THRESHOLD % [restricted_mass_size, threshold]
-        )
+        above_threshold_message
       end
 
     private
@@ -79,6 +70,40 @@ module Devtools
         !total_mass.equal?(total_score)
       end
 
+      # Above threshold message
+      #
+      # @return [String]
+      #
+      # @api private
+      def above_threshold_message
+        format_values = { mass: restricted_mass_size, threshold: threshold }
+        Devtools.notify_metric_violation(
+          format(ABOVE_THRESHOLD, format_values)
+        )
+      end
+
+      # Below threshold message
+      #
+      # @return [String]
+      #
+      # @api private
+      def below_threshold_message
+        Devtools.notify_metric_violation(
+          format(BELOW_THRESHOLD, mass: largest_mass)
+        )
+      end
+
+      # Total mismatch message
+      #
+      # @return [String]
+      #
+      # @api private
+      def total_mismatch_message
+        Devtools.notify_metric_violation(
+          format(TOTAL_MISMATCH, mass: total_mass, expected: total_score)
+        )
+      end
+
       # Size of mass measured by `Flay::Scale` and filtered by `threshold`
       #
       # @return [Integer]

data/shared/spec/shared/idempotent_method_behavior.rb

@@ -1,7 +1,8 @@
 shared_examples_for 'an idempotent method' do
   it 'is idempotent' do
     first = subject
-    fail 'RSpec not configured for threadsafety' unless RSpec.configuration.threadsafe?
+    error = 'RSpec not configured for threadsafety'
+    fail error unless RSpec.configuration.threadsafe?
     mutex = __memoized.instance_variable_get(:@mutex)
     memoized = __memoized.instance_variable_get(:@memoized)
     mutex.synchronize { memoized.delete(:subject) }

data/spec/integration/devtools/rake/flay/verify_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe Devtools::Rake::Flay, '#verify' do
   let(:tempfile)    { Tempfile.new(%w[file .rb], Dir.mktmpdir) }
   let(:file)        { Pathname(tempfile.path)                  }
@@ -29,7 +31,7 @@ describe Devtools::Rake::Flay, '#verify' do
 
   context 'reporting' do
     let(:options) do
-      { threshold: 3, total_score: 3, lib_dirs: directories, excludes: [] }.freeze
+      { threshold: 3, total_score: 3, lib_dirs: directories, excludes: [] }
     end
 
     let(:instance) { described_class.new(options) }
@@ -49,7 +51,12 @@ describe Devtools::Rake::Flay, '#verify' do
 
   context 'when theshold is too low' do
     let(:instance) do
-      described_class.new(threshold: 0, total_score: 0, lib_dirs: directories, excludes: [])
+      described_class.new(
+        threshold: 0,
+        total_score: 0,
+        lib_dirs: directories,
+        excludes: []
+      )
     end
 
     specify do
@@ -61,7 +68,12 @@ describe Devtools::Rake::Flay, '#verify' do
 
   context 'when threshold is too high' do
     let(:instance) do
-      described_class.new(threshold: 1000, total_score: 0, lib_dirs: directories, excludes: [])
+      described_class.new(
+        threshold: 1000,
+        total_score: 0,
+        lib_dirs: directories,
+        excludes: []
+      )
     end
 
     specify do
@@ -73,7 +85,12 @@ describe Devtools::Rake::Flay, '#verify' do
 
   context 'when total is too high' do
     let(:instance) do
-      described_class.new(threshold: 3, total_score: 50, lib_dirs: directories, excludes: [])
+      described_class.new(
+        threshold: 3,
+        total_score: 50,
+        lib_dirs: directories,
+        excludes: []
+      )
     end
 
     specify do
@@ -105,10 +122,16 @@ Similar code found in :defn (mass = 10)
   #{file}:1
   #{file}:5
 REPORT
+      # rubocop:enable Layout/IndentHeredoc
     end
 
     let(:instance) do
-      described_class.new(threshold: 3, total_score: 5, lib_dirs: directories, excludes: [])
+      described_class.new(
+        threshold: 3,
+        total_score: 5,
+        lib_dirs: directories,
+        excludes: []
+      )
     end
 
     specify do
@@ -144,7 +167,12 @@ REPORT
     end
 
     let(:instance) do
-      described_class.new(threshold: 5, total_score: 8, lib_dirs: directories, excludes: [])
+      described_class.new(
+        threshold: 5,
+        total_score: 8,
+        lib_dirs: directories,
+        excludes: []
+      )
     end
 
     it 'sums masses for total' do
@@ -155,7 +183,12 @@ REPORT
   context 'when no duplication masses' do
     let(:ruby) { '' }
     let(:instance) do
-      described_class.new(threshold: 0, total_score: 0, lib_dirs: directories, excludes: [])
+      described_class.new(
+        threshold: 0,
+        total_score: 0,
+        lib_dirs: directories,
+        excludes: []
+      )
     end
 
     specify do

data/spec/spec_helper.rb

@@ -3,9 +3,8 @@ require 'tempfile'
 require 'tmpdir'
 
 if ENV['COVERAGE'] == 'true'
-  SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
-    SimpleCov::Formatter::HTMLFormatter,
-  ]
+  formatter = [SimpleCov::Formatter::HTMLFormatter]
+  SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(formatter)
 
   SimpleCov.start do
     command_name 'spec:unit'

data/spec/unit/devtools/flay/scale/measure_spec.rb

@@ -1,7 +1,7 @@
 describe Devtools::Flay::Scale, '#measure' do
   subject(:measure) { instance.measure }
 
-  let(:minimum_mass) { 0        }
+  let(:minimum_mass) { 0 }
   let(:files)        { [instance_double(File)] }
   let(:flay_masses) { { 0 => 5, 1 => 10 } }
 

data/spec/unit/devtools/project_spec.rb

@@ -5,7 +5,8 @@ RSpec.describe Devtools::Project do
     subject { object.init_rspec }
 
     it 'calls the rspec initializer' do
-      expect(Devtools::Project::Initializer::Rspec).to receive(:call).with(Devtools.project)
+      expect(Devtools::Project::Initializer::Rspec)
+        .to receive(:call).with(Devtools.project)
       expect(subject).to be(object)
     end
   end

data/tasks/metrics/coverage.rake

@@ -4,6 +4,7 @@ namespace :metrics do
     begin
       # rubocop:disable Style/ParallelAssignment
       original, ENV['COVERAGE'] = ENV['COVERAGE'], 'true'
+      # rubocop:enable Style/ParallelAssignment
       Rake::Task['spec:unit'].execute
     ensure
       ENV['COVERAGE'] = original

data/tasks/metrics/flog.rake

@@ -40,3 +40,4 @@ namespace :metrics do
     end
   end
 end
+# rubocop:enable Metrics/BlockLength

data/tasks/metrics/mutant.rake

@@ -40,3 +40,4 @@ namespace :metrics do
     end
   end
 end
+# rubocop:enable Metrics/BlockLength

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: devtools
 version: !ruby/object:Gem::Version
-  version: 0.1.19
+  version: 0.1.20
 platform: ruby
 authors:
 - Markus Schirp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-17 00:00:00.000000000 Z
+date: 2018-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: abstract_type
@@ -142,14 +142,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 12.0.0
+        version: 12.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 12.0.0
+        version: 12.3.0
 - !ruby/object:Gem::Dependency
   name: reek
   requirement: !ruby/object:Gem::Requirement
@@ -212,42 +212,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.51.0
+        version: 0.52.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.51.0
+        version: 0.52.1
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.0
+        version: 0.15.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.0
+        version: 0.15.1
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.9
+        version: 0.9.12
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.9
+        version: 0.9.12
 - !ruby/object:Gem::Dependency
   name: yardstick
   requirement: !ruby/object:Gem::Requirement
@@ -334,7 +334,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.1'
+      version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -342,7 +342,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: A metagem wrapping development tools