devloop 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7bdfbb6b5c25d903818042b071bf95090cccb324fd993957d8a6c9232310d6b3
-  data.tar.gz: dc18174f6087bca3656a47d072baa8c9b3ef177252ba20a50bdac21660417d9d
+  metadata.gz: 1aacef492d0bf184908275bc5df40ba6915cf3a1215edc39fb41374fa18574e0
+  data.tar.gz: aa92fd7489fcd1fbefaf1ad01e7fddcf9b39b8ab9ba9d9964794ba15cba15559
 SHA512:
-  metadata.gz: dee4939c6e441d48e24d96d70ae4d215376adbbca9fc31f3f69374d0dfd7cc643dd5e2f2fd41975dd5476f477858b95e8bfe1c49716a5657721b74d28a551edc
-  data.tar.gz: 8f94d9393b420e40028c53748f27415e0e587252ce94cb67b0b7ebf86f4aa6ff05e9bc1c7617c81d75c4835050b4a7d736d0874eb4807915e50968160ec42e7d
+  metadata.gz: a26d307a8957fba390304bdcacbb6e3b2b23c4f86bb3fcbbc9b3a2fc0e14b69a16836cf7f4cb9e6b68efcc24a775113bdc5b64b639c0da3921ab9f2a835f006e
+  data.tar.gz: 4444e6eede7525a922044f6c2f7c7d1363b5d9490d94dce08499b52d2021338d04acdb1a95eaf3dfc43fed50edfd2a800a006a3b4d8701dcb152c1caa9e958dc

data/lib/devloop/diff_parser.rb

@@ -21,7 +21,13 @@ module Devloop
       end.uniq
 
       # Remove filenames with line number if filename without line number is present
-      results.reject { |result| results.include?(result.split(":").first) && result.include?(":") }
+      res = results.reject { |result| results.include?(result.split(":").first) && result.include?(":") }.map do |el|
+        if el.split(":").last == "0"
+          el.split(":").first
+        else
+          el
+        end
+      end
     end
 
     private

data/lib/devloop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Devloop
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/spec/diff_parser_spec.rb

@@ -96,4 +96,53 @@ describe Devloop::DiffParser do
       expect(Devloop::DiffParser.call(diff)).to eq(["spec/models/team_spec.rb:19", "spec/models/team_spec.rb:24"])
     end
   end
+
+  context "removes 0 line numbers" do
+    let(:diff) do
+      <<~DIFF
+        diff --git a/spec/config_spec.rb b/spec/config_spec.rb
+        index d9716e7..b470ec2 100644
+        --- a/spec/config_spec.rb
+        +++ b/spec/config_spec.rb
+        @@ -5 +5 @@ require "spec_helper"
+        -describe "PgLocksMonitor::Confiuration" do
+        +describe "PgLocksMonitor::Configuration" do
+        @@ -8,2 +8,5 @@ describe "PgLocksMonitor::Confiuration" do
+        -    expect(config.notify_locks).to eq true
+        -    expect(config.notify_blocking).to eq true
+        +    expect(config.monitor_locks).to eq true
+        +    expect(config.monitor_blocking).to eq true
+        +    expect(config.locks_min_duration_ms).to eq 200
+        +    expect(config.blocking_min_duration_ms).to eq 100
+        +    expect(config.notifier_class).to eq PgLocksMonitor::DefaultNotifier
+        @@ -14 +17 @@ describe "PgLocksMonitor::Confiuration" do
+        -      config.notify_locks = false
+        +      config.monitor_locks = false
+        @@ -17 +20 @@ describe "PgLocksMonitor::Confiuration" do
+        -    expect(PgLocksMonitor.configuration.notify_locks).to eq false
+        +    expect(PgLocksMonitor.configuration.monitor_locks).to eq false
+        diff --git a/spec/default_notifier_spec.rb b/spec/default_notifier_spec.rb
+        new file mode 100644
+        index 0000000..d99d3a1
+        --- /dev/null
+        +++ b/spec/default_notifier_spec.rb
+        @@ -0,0 +1,11 @@
+        +# frozen_string_literal: true
+        +
+        +require "spec_helper"
+        +
+        +describe PgLocksMonitor::DefaultNotifier do
+        +  it "requires correct config if Slack notifications enabled" do
+        +    expect {
+        +      PgLocksMonitor::DefaultNotifier.call({})
+        +    }.not_to raise_error
+        +  end
+        +end
+      DIFF
+    end
+
+    it "parses the diff correctly" do
+      expect(Devloop::DiffParser.call(diff)).to eq(["spec/config_spec.rb:5", "spec/config_spec.rb:8", "spec/config_spec.rb:14", "spec/config_spec.rb:17", "spec/default_notifier_spec.rb"])
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: devloop
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - pawurb