devise_saml_authenticatable 1.6.1 → 1.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d3ca38cfe51cdf71fc8a264de868fc285bfa413307aa4798e097fbf88e85020d
-  data.tar.gz: 2371ef1371e29547b4eb9681066fa43f0b6d39236b7df8676236bf13678e2d01
+  metadata.gz: c0d1e1f1df121795583d9fc25cab40edac01bb61f8adbdb4fac7c0c15bfe4b0c
+  data.tar.gz: 0d7770994b0c119da178a3b19ced6d52a88364d561279c5bd759ce5580fb5fe5
 SHA512:
-  metadata.gz: 872bfb214a00504735d9183d169e4119ebb9c6ae3129de729be642f39c4675b57040bb1c9d46899e73d534aa82d7ac9291c425109c10eaeb290831480e7976ab
-  data.tar.gz: 3269ef293937aef443afa9a325acc0addf027c3ad7421865a9ebe1554d7215461767ffe9e34cd4cc2bf8edbae831e7e342dd3c47245d57209d8ddd820a128212
+  metadata.gz: d849dc5dff4bd09d0dd034449ed3e68494f0f1c82c8e31c708b7d6e0d3a366a2fd119fb24704d0e5a946b6fc206dbe072fadbf7218489abffdbe1b3644d41419
+  data.tar.gz: e64b35109ed35b61e804fa5e06d3b3c299210cf75804f706e299147d02a7ddb929246c1a7fdb65aee12f5ceed5348267d3c6e4657544288e3a45741474d5e30d

data/lib/devise_saml_authenticatable/model.rb

@@ -66,12 +66,7 @@ module Devise
           end
 
           if Devise.saml_update_user || (resource.new_record? && Devise.saml_create_user)
-            begin
-              Devise.saml_update_resource_hook.call(resource, decorated_response, auth_value)
-            rescue
-              logger.info("User(#{auth_value}) failed to create or update.")
-              return nil
-            end
+            Devise.saml_update_resource_hook.call(resource, decorated_response, auth_value)
           end
 
           resource

data/lib/devise_saml_authenticatable/version.rb

@@ -1,3 +1,3 @@
 module DeviseSamlAuthenticatable
-  VERSION = "1.6.1"
+  VERSION = "1.6.2"
 end

data/spec/devise_saml_authenticatable/model_spec.rb

@@ -104,12 +104,6 @@ describe Devise::Models::SamlAuthenticatable do
         expect(model.name).to  eq('A User')
         expect(model.saved).to be(true)
       end
-
-      it "returns nil if it fails to create a user" do
-        expect(Model).to receive(:where).with(email: 'user@example.com').and_return([])
-        expect(Devise).to receive(:saml_update_resource_hook).and_raise(StandardError.new)
-        expect(Model.authenticate_with_saml(response, nil)).to be_nil
-      end
     end
 
     context "when configured to update a user and the user is found" do
@@ -125,13 +119,6 @@ describe Devise::Models::SamlAuthenticatable do
         expect(model.name).to  eq('A User')
         expect(model.saved).to be(true)
       end
-
-      it "returns nil if it fails to update a user" do
-        user = Model.new(new_record: false)
-        expect(Model).to receive(:where).with(email: 'user@example.com').and_return([user])
-        expect(Devise).to receive(:saml_update_resource_hook).and_raise(StandardError.new)
-        expect(Model.authenticate_with_saml(response, nil)).to be_nil
-      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: devise_saml_authenticatable
 version: !ruby/object:Gem::Version
-  version: 1.6.1
+  version: 1.6.2
 platform: ruby
 authors:
 - Josef Sauter
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-09-14 00:00:00.000000000 Z
+date: 2020-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: devise