devise 4.5.0 → 4.6.0

data/test/integration/registerable_test.rb

@@ -1,365 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-
-class RegistrationTest < Devise::IntegrationTest
-
-  test 'a guest admin should be able to sign in successfully' do
-    get new_admin_session_path
-    click_link 'Sign up'
-
-    assert_template 'registrations/new'
-
-    fill_in 'email', with: 'new_user@test.com'
-    fill_in 'password', with: 'new_user123'
-    fill_in 'password confirmation', with: 'new_user123'
-    click_button 'Sign up'
-
-    assert_contain 'You have signed up successfully'
-    assert warden.authenticated?(:admin)
-    assert_current_url "/admin_area/home"
-
-    admin = Admin.to_adapter.find_first(order: [:id, :desc])
-    assert_equal admin.email, 'new_user@test.com'
-  end
-
-  test 'a guest admin should be able to sign in and be redirected to a custom location' do
-    Devise::RegistrationsController.any_instance.stubs(:after_sign_up_path_for).returns("/?custom=1")
-    get new_admin_session_path
-    click_link 'Sign up'
-
-    fill_in 'email', with: 'new_user@test.com'
-    fill_in 'password', with: 'new_user123'
-    fill_in 'password confirmation', with: 'new_user123'
-    click_button 'Sign up'
-
-    assert_contain 'Welcome! You have signed up successfully.'
-    assert warden.authenticated?(:admin)
-    assert_current_url "/?custom=1"
-  end
-
-  test 'a guest admin should not see a warning about minimum password length' do
-    get new_admin_session_path
-    assert_not_contain 'characters minimum'
-  end
-
-  def user_sign_up
-    ActionMailer::Base.deliveries.clear
-
-    get new_user_registration_path
-
-    fill_in 'email', with: 'new_user@test.com'
-    fill_in 'password', with: 'new_user123'
-    fill_in 'password confirmation', with: 'new_user123'
-    click_button 'Sign up'
-  end
-
-  test 'a guest user should see a warning about minimum password length' do
-    get new_user_registration_path
-    assert_contain '7 characters minimum'
-  end
-
-  test 'a guest user should be able to sign up successfully and be blocked by confirmation' do
-    user_sign_up
-
-    assert_contain 'A message with a confirmation link has been sent to your email address. Please follow the link to activate your account.'
-    assert_not_contain 'You have to confirm your account before continuing'
-    assert_current_url "/"
-
-    refute warden.authenticated?(:user)
-
-    user = User.to_adapter.find_first(order: [:id, :desc])
-    assert_equal user.email, 'new_user@test.com'
-    refute user.confirmed?
-  end
-
-  test 'a guest user should receive the confirmation instructions from the default mailer' do
-    user_sign_up
-    assert_equal ['please-change-me@config-initializers-devise.com'], ActionMailer::Base.deliveries.first.from
-  end
-
-  test 'a guest user should receive the confirmation instructions from a custom mailer' do
-    User.any_instance.stubs(:devise_mailer).returns(Users::Mailer)
-    user_sign_up
-    assert_equal ['custom@example.com'], ActionMailer::Base.deliveries.first.from
-  end
-
-  test 'a guest user should be blocked by confirmation and redirected to a custom path' do
-    Devise::RegistrationsController.any_instance.stubs(:after_inactive_sign_up_path_for).returns("/?custom=1")
-    get new_user_registration_path
-
-    fill_in 'email', with: 'new_user@test.com'
-    fill_in 'password', with: 'new_user123'
-    fill_in 'password confirmation', with: 'new_user123'
-    click_button 'Sign up'
-
-    assert_current_url "/?custom=1"
-    refute warden.authenticated?(:user)
-  end
-
-  test 'a guest user cannot sign up with invalid information' do
-    # Dirty tracking behavior prevents email validations from being applied:
-    #    https://github.com/mongoid/mongoid/issues/756
-    (pending "Fails on Mongoid < 2.1"; break) if defined?(Mongoid) && Mongoid::VERSION.to_f < 2.1
-
-    get new_user_registration_path
-
-    fill_in 'email', with: 'invalid_email'
-    fill_in 'password', with: 'new_user123'
-    fill_in 'password confirmation', with: 'new_user321'
-    click_button 'Sign up'
-
-    assert_template 'registrations/new'
-    assert_have_selector '#error_explanation'
-    assert_contain "Email is invalid"
-    assert_contain "Password confirmation doesn't match Password"
-    assert_contain "2 errors prohibited"
-    assert_nil User.to_adapter.find_first
-
-    refute warden.authenticated?(:user)
-  end
-
-  test 'a guest should not sign up with email/password that already exists' do
-    # Dirty tracking behavior prevents email validations from being applied:
-    #    https://github.com/mongoid/mongoid/issues/756
-    (pending "Fails on Mongoid < 2.1"; break) if defined?(Mongoid) && Mongoid::VERSION.to_f < 2.1
-
-    create_user
-    get new_user_registration_path
-
-    fill_in 'email', with: 'user@test.com'
-    fill_in 'password', with: '123456'
-    fill_in 'password confirmation', with: '123456'
-    click_button 'Sign up'
-
-    assert_current_url '/users'
-    assert_contain(/Email.*already.*taken/)
-
-    refute warden.authenticated?(:user)
-  end
-
-  test 'a guest should not be able to change account' do
-    get edit_user_registration_path
-    assert_redirected_to new_user_session_path
-    follow_redirect!
-    assert_contain 'You need to sign in or sign up before continuing.'
-  end
-
-  test 'a signed in user should not be able to access sign up' do
-    sign_in_as_user
-    get new_user_registration_path
-    assert_redirected_to root_path
-  end
-
-  test 'a signed in user should be able to edit their account' do
-    sign_in_as_user
-    get edit_user_registration_path
-
-    fill_in 'email', with: 'user.new@example.com'
-    fill_in 'current password', with: '12345678'
-    click_button 'Update'
-
-    assert_current_url '/'
-    assert_contain 'Your account has been updated successfully.'
-
-    assert_equal "user.new@example.com", User.to_adapter.find_first.email
-  end
-
-  test 'a signed in user should still be able to use the website after changing their password' do
-    sign_in_as_user
-    get edit_user_registration_path
-
-    fill_in 'password', with: '1234567890'
-    fill_in 'password confirmation', with: '1234567890'
-    fill_in 'current password', with: '12345678'
-    click_button 'Update'
-
-    assert_contain 'Your account has been updated successfully.'
-    get users_path
-    assert warden.authenticated?(:user)
-  end
-
-  test 'a signed in user should not change their current user with invalid password' do
-    sign_in_as_user
-    get edit_user_registration_path
-
-    fill_in 'email', with: 'user.new@example.com'
-    fill_in 'current password', with: 'invalid'
-    click_button 'Update'
-
-    assert_template 'registrations/edit'
-    assert_contain 'user@test.com'
-    assert_have_selector 'form input[value="user.new@example.com"]'
-
-    assert_equal "user@test.com", User.to_adapter.find_first.email
-  end
-
-  test 'a signed in user should be able to edit their password' do
-    sign_in_as_user
-    get edit_user_registration_path
-
-    fill_in 'password', with: 'pass1234'
-    fill_in 'password confirmation', with: 'pass1234'
-    fill_in 'current password', with: '12345678'
-    click_button 'Update'
-
-    assert_current_url '/'
-    assert_contain 'Your account has been updated successfully.'
-
-    assert User.to_adapter.find_first.valid_password?('pass1234')
-  end
-
-  test 'a signed in user should not be able to edit their password with invalid confirmation' do
-    sign_in_as_user
-    get edit_user_registration_path
-
-    fill_in 'password', with: 'pas123'
-    fill_in 'password confirmation', with: ''
-    fill_in 'current password', with: '12345678'
-    click_button 'Update'
-
-    assert_contain "Password confirmation doesn't match Password"
-    refute User.to_adapter.find_first.valid_password?('pas123')
-  end
-  
-  test 'a signed in user should see a warning about minimum password length' do
-    sign_in_as_user
-    get edit_user_registration_path
-    assert_contain 'characters minimum'
-  end
-
-  test 'a signed in user should be able to cancel their account' do
-    sign_in_as_user
-    get edit_user_registration_path
-
-    click_button "Cancel my account"
-    assert_contain "Bye! Your account has been successfully cancelled. We hope to see you again soon."
-
-    assert User.to_adapter.find_all.empty?
-  end
-
-  test 'a user should be able to cancel sign up by deleting data in the session' do
-    get "/set"
-    assert_equal "something", @request.session["devise.foo_bar"]
-
-    get "/users/sign_up"
-    assert_equal "something", @request.session["devise.foo_bar"]
-
-    get "/users/cancel"
-    assert_nil @request.session["devise.foo_bar"]
-    assert_redirected_to new_user_registration_path
-  end
-
-  test 'a user with XML sign up stub' do
-    get new_user_registration_path(format: 'xml')
-    assert_response :success
-    assert_match %(<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<user>), response.body
-    assert_no_match(/<confirmation-token/, response.body)
-  end
-
-  test 'a user with JSON sign up stub' do
-    get new_user_registration_path(format: 'json')
-    assert_response :success
-    assert_match %({"user":), response.body
-    assert_no_match(/"confirmation_token"/, response.body)
-  end
-
-  test 'an admin sign up with valid information in XML format should return valid response' do
-    post admin_registration_path(format: 'xml'), params: { admin: { email: 'new_user@test.com', password: 'new_user123', password_confirmation: 'new_user123' } }
-    assert_response :success
-    assert response.body.include? %(<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<admin>)
-
-    admin = Admin.to_adapter.find_first(order: [:id, :desc])
-    assert_equal admin.email, 'new_user@test.com'
-  end
-
-  test 'a user sign up with valid information in XML format should return valid response' do
-    post user_registration_path(format: 'xml'), params: { user: { email: 'new_user@test.com', password: 'new_user123', password_confirmation: 'new_user123' } }
-    assert_response :success
-    assert response.body.include? %(<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<user>)
-
-    user = User.to_adapter.find_first(order: [:id, :desc])
-    assert_equal user.email, 'new_user@test.com'
-  end
-
-  test 'a user sign up with invalid information in XML format should return invalid response' do
-    post user_registration_path(format: 'xml'), params: { user: { email: 'new_user@test.com', password: 'new_user123', password_confirmation: 'invalid' } }
-    assert_response :unprocessable_entity
-    assert response.body.include? %(<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<errors>)
-  end
-
-  test 'a user update information with valid data in XML format should return valid response' do
-    user = sign_in_as_user
-    put user_registration_path(format: 'xml'), params: { user: { current_password: '12345678', email: 'user.new@test.com' } }
-    assert_response :success
-    assert_equal user.reload.email, 'user.new@test.com'
-  end
-
-  test 'a user update information with invalid data in XML format should return invalid response' do
-    user = sign_in_as_user
-    put user_registration_path(format: 'xml'), params: { user: { current_password: 'invalid', email: 'user.new@test.com' } }
-    assert_response :unprocessable_entity
-    assert_equal user.reload.email, 'user@test.com'
-  end
-
-  test 'a user cancel their account in XML format should return valid response' do
-    sign_in_as_user
-    delete user_registration_path(format: 'xml')
-    assert_response :success
-    assert_equal User.to_adapter.find_all.size, 0
-  end
-end
-
-class ReconfirmableRegistrationTest < Devise::IntegrationTest
-  test 'a signed in admin should see a more appropriate flash message when editing their account if reconfirmable is enabled' do
-    sign_in_as_admin
-    get edit_admin_registration_path
-
-    fill_in 'email', with: 'admin.new@example.com'
-    fill_in 'current password', with: '123456'
-    click_button 'Update'
-
-    assert_current_url '/admin_area/home'
-    assert_contain 'but we need to verify your new email address'
-    assert_equal 'admin.new@example.com', Admin.to_adapter.find_first.unconfirmed_email
-
-    get edit_admin_registration_path
-    assert_contain 'Currently waiting confirmation for: admin.new@example.com'
-  end
-
-  test 'a signed in admin should not see a reconfirmation message if they did not change their password' do
-    sign_in_as_admin
-    get edit_admin_registration_path
-
-    fill_in 'password', with: 'pas123'
-    fill_in 'password confirmation', with: 'pas123'
-    fill_in 'current password', with: '123456'
-    click_button 'Update'
-
-    assert_current_url '/admin_area/home'
-    assert_contain 'Your account has been updated successfully.'
-
-    assert Admin.to_adapter.find_first.valid_password?('pas123')
-  end
-
-  test 'a signed in admin should not see a reconfirmation message if they did not change their email, despite having an unconfirmed email' do
-    sign_in_as_admin
-
-    get edit_admin_registration_path
-    fill_in 'email', with: 'admin.new@example.com'
-    fill_in 'current password', with: '123456'
-    click_button 'Update'
-
-    get edit_admin_registration_path
-    fill_in 'password', with: 'pas123'
-    fill_in 'password confirmation', with: 'pas123'
-    fill_in 'current password', with: '123456'
-    click_button 'Update'
-
-    assert_current_url '/admin_area/home'
-    assert_contain 'Your account has been updated successfully.'
-
-    assert_equal "admin.new@example.com", Admin.to_adapter.find_first.unconfirmed_email
-    assert Admin.to_adapter.find_first.valid_password?('pas123')
-  end
-end

data/test/integration/rememberable_test.rb

@@ -1,219 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-
-class RememberMeTest < Devise::IntegrationTest
-  def create_user_and_remember(add_to_token='')
-    user = create_user
-    user.remember_me!
-    raw_cookie = User.serialize_into_cookie(user).tap { |a| a[1] << add_to_token }
-    cookies['remember_user_token'] = generate_signed_cookie(raw_cookie)
-    user
-  end
-
-  def generate_signed_cookie(raw_cookie)
-    request = if Devise::Test.rails51? || Devise::Test.rails52?
-      ActionController::TestRequest.create(Class.new) # needs a "controller class"
-    elsif Devise::Test.rails5?
-      ActionController::TestRequest.create
-    else
-      ActionController::TestRequest.new
-    end
-    request.cookie_jar.signed['raw_cookie'] = raw_cookie
-    request.cookie_jar['raw_cookie']
-  end
-
-  def signed_cookie(key)
-    controller.send(:cookies).signed[key]
-  end
-
-  def cookie_expires(key)
-    cookie  = response.headers["Set-Cookie"].split("\n").grep(/^#{key}/).first
-    expires = cookie.split(";").map(&:strip).grep(/^expires=/).first
-    Time.parse(expires).utc
-  end
-
-  test 'do not remember the user if they have not checked remember me option' do
-    sign_in_as_user
-    assert_nil request.cookies["remember_user_cookie"]
-  end
-
-  test 'handle unverified requests gets rid of caches' do
-    swap ApplicationController, allow_forgery_protection: true do
-      post exhibit_user_url(1)
-      refute warden.authenticated?(:user)
-
-      create_user_and_remember
-      post exhibit_user_url(1)
-      assert_equal "User is not authenticated", response.body
-      refute warden.authenticated?(:user)
-    end
-  end
-
-  test 'handle unverified requests does not create cookies on sign in' do
-    swap ApplicationController, allow_forgery_protection: true do
-      get new_user_session_path
-      assert request.session[:_csrf_token]
-
-      post user_session_path, params: {
-          authenticity_token: "oops",
-          user: { email: "jose.valim@gmail.com", password: "123456", remember_me: "1" }
-        }
-      refute warden.authenticated?(:user)
-      refute request.cookies['remember_user_token']
-    end
-  end
-
-  test 'generate remember token after sign in' do
-    sign_in_as_user remember_me: true
-    assert request.cookies['remember_user_token']
-  end
-
-  test 'generate remember token after sign in setting cookie options' do
-    # We test this by asserting the cookie is not sent after the redirect
-    # since we changed the domain. This is the only difference with the
-    # previous test.
-    swap Devise, rememberable_options: { domain: "omg.somewhere.com" } do
-      sign_in_as_user remember_me: true
-      assert_nil request.cookies["remember_user_token"]
-    end
-  end
-
-  test 'generate remember token with a custom key' do
-    swap Devise, rememberable_options: { key: "v1lat_token" } do
-      sign_in_as_user remember_me: true
-      assert request.cookies["v1lat_token"]
-    end
-  end
-
-  test 'generate remember token after sign in setting session options' do
-    begin
-      Rails.configuration.session_options[:domain] = "omg.somewhere.com"
-      sign_in_as_user remember_me: true
-      assert_nil request.cookies["remember_user_token"]
-    ensure
-      Rails.configuration.session_options.delete(:domain)
-    end
-  end
-
-  test 'remember the user before sign in' do
-    user = create_user_and_remember
-    get users_path
-    assert_response :success
-    assert warden.authenticated?(:user)
-    assert warden.user(:user) == user
-  end
-
-  test 'remember the user before sign up and redirect them to their home' do
-    create_user_and_remember
-    get new_user_registration_path
-    assert warden.authenticated?(:user)
-    assert_redirected_to root_path
-  end
-
-  test 'does not extend remember period through sign in' do
-    swap Devise, extend_remember_period: true, remember_for: 1.year do
-      user = create_user
-      user.remember_me!
-
-      user.remember_created_at = old = 10.days.ago
-      user.save
-
-      sign_in_as_user remember_me: true
-      user.reload
-
-      assert warden.user(:user) == user
-      assert_equal old.to_i, user.remember_created_at.to_i
-    end
-  end
-
-  test 'extends remember period when extend remember period config is true' do
-    swap Devise, extend_remember_period: true, remember_for: 1.year do
-      create_user_and_remember
-      old_remember_token = nil
-
-      travel_to 1.day.ago do
-        get root_path
-        old_remember_token = request.cookies['remember_user_token']
-      end
-
-      get root_path
-      current_remember_token = request.cookies['remember_user_token']
-
-      refute_equal old_remember_token, current_remember_token
-    end
-  end
-
-  test 'does not extend remember period when extend period config is false' do
-    swap Devise, extend_remember_period: false, remember_for: 1.year do
-      create_user_and_remember
-      old_remember_token = nil
-
-      travel_to 1.day.ago do
-        get root_path
-        old_remember_token = request.cookies['remember_user_token']
-      end
-
-      get root_path
-      current_remember_token = request.cookies['remember_user_token']
-
-      assert_equal old_remember_token, current_remember_token
-    end
-  end
-
-  test 'do not remember other scopes' do
-    create_user_and_remember
-    get root_path
-    assert_response :success
-    assert warden.authenticated?(:user)
-    refute warden.authenticated?(:admin)
-  end
-
-  test 'do not remember with invalid token' do
-    create_user_and_remember('add')
-    get users_path
-    refute warden.authenticated?(:user)
-    assert_redirected_to new_user_session_path
-  end
-
-  test 'do not remember with expired token' do
-    create_user_and_remember
-    swap Devise, remember_for: 0.days do
-      get users_path
-      refute warden.authenticated?(:user)
-      assert_redirected_to new_user_session_path
-    end
-  end
-
-  test 'do not remember the user anymore after forget' do
-    create_user_and_remember
-    get users_path
-    assert warden.authenticated?(:user)
-
-    delete destroy_user_session_path
-    refute warden.authenticated?(:user)
-    assert_nil warden.cookies['remember_user_token']
-
-    get users_path
-    refute warden.authenticated?(:user)
-  end
-
-  test 'changing user password expires remember me token' do
-    user = create_user_and_remember
-    user.password = "another_password"
-    user.password_confirmation = "another_password"
-    user.save!
-
-    get users_path
-    refute warden.authenticated?(:user)
-  end
-
-  test 'valid sign in calls after_remembered callback' do
-    user = create_user_and_remember
-
-    User.expects(:serialize_from_cookie).returns user
-    user.expects :after_remembered
-
-    get new_user_registration_path
-  end
-end