devise-twilio-verify 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1fc8af9da1425014bde8b7bb0294faae2edc0b47e9cf635ec07b9b5300fbc6fb
-  data.tar.gz: 99440a90447a85010a85c5fe77c37dab1a69969b20c855016291b32900632084
+  metadata.gz: 474f80f30182d50c461662ac4927abeb8a7e896b7f2bc92b538073e1538db06f
+  data.tar.gz: 27dfc2219f247de90a1bfb7d32546050cfb505f1f0afefe1b5d442ce00500a6b
 SHA512:
-  metadata.gz: e24dd31ecee36c3366391eda08bec3e119df74e2af8c7a48c49eff9453fd572c5203aa81efd026eca2599f0001648933dda91e2fac8a26d4539a05410ac24d43
-  data.tar.gz: 676fbd754e2fd134b38e931902ac2e730b009f11865cc3e084f2b8678cbb20c965a720a85087523b47ff8098327c98d4b06e2b443a43406aec164bd7f5e65396
+  metadata.gz: 5c553ebfcecf53b015eb4767c4ff3acba7386eb861ad1854ee9c712d53b7d20f1fdf37e6a657837730ffa7a60c2fc4cd604b7cd3c49dadc4854b14427659fe01
+  data.tar.gz: 2b31f9e9319e89a49db84b6aa6cf34e022c781dba6ed14d185ebf37446928e37379589b42c5ced9f4b939124896c9ca6a76e6a37ca140681b47d379697eb20c9

data/.github/workflows/build.yml

@@ -8,13 +8,17 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: [2.5, 2.6, 2.7, "3.0", 3.1, head]
+        ruby: [2.7, "3.0", 3.1, 3.2, 3.3, head]
         gemfile: [rails_5_2, rails_6]
         exclude:
           - ruby: "3.0"
             gemfile: rails_5_2
           - ruby: 3.1
             gemfile: rails_5_2
+          - ruby: 3.2
+            gemfile: rails_5_2
+          - ruby: 3.3
+            gemfile: rails_5_2
           - ruby: head
             gemfile: rails_5_2
     continue-on-error: ${{ endsWith(matrix.ruby, 'head') }}

data/.rspec

@@ -1,2 +1,2 @@
 --color
---require ./spec/spec_helper
+--require ./spec/spec_helper

data/CHANGELOG.md

@@ -5,6 +5,15 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [0.2.0] - 2024-12-21
+
+### Changed
+
+- Bugfix to not return any users when the mobile phone number is missing when querying for a user with `User.find_by_mobile_phone`
+- Fixed test coverage from the initial fork from Authy to Twilio Verify API
+- Disabled specs for TOTP setup. Currently there's just a method exposed to generate a code with the Twilio Verify service. Rails apps consuming the gem are expected to to generate a qr code with this code and present it to the user to scan. This feature can be added in the future
+- Restored original flash message behavior from authy-devise on a few endpoints. Despite this being the original behavior, due to this change I will bump versioning as minor version release for Rails apps that did not migrate from devise-authy
+
 ## [0.1.1] - 2023-04-12
 
 ### Changed

data/app/controllers/devise/devise_twilio_verify_controller.rb

@@ -34,7 +34,7 @@ class Devise::DeviseTwilioVerifyController < DeviseController
       verification_check = false
     end
 
-    # Hack to reproduce authy functionality of being able to verify 2FA via SMS or TOTP
+    # Reproduce authy functionality of being able to verify 2FA via SMS or TOTP
     # not ideal as there could be network delays, but there is currently no alternative
     if !verification_check && @resource.twilio_totp_factor_sid.present?
       verification_check = TwilioVerifyService.verify_totp_token(@resource, params[:token])
@@ -51,6 +51,15 @@ class Devise::DeviseTwilioVerifyController < DeviseController
     end
   end
 
+  def GET_enable_twilio_verify
+    if resource.twilio_verify_enabled?
+      set_flash_message(:notice, :already_enabled)
+      redirect_to after_twilio_verify_enabled_path_for(resource)
+    else
+      render :enable_twilio_verify
+    end
+  end
+
   # enable 2fa
   def POST_enable_twilio_verify
     if resource.update(twilio_verify_enabled: true)
@@ -64,7 +73,13 @@ class Devise::DeviseTwilioVerifyController < DeviseController
   # Disable 2FA
   def POST_disable_twilio_verify
     resource.assign_attributes(twilio_verify_enabled: false)
-    resource.save(:validate => false)
+    if resource.save(validate: false)
+      forget_device
+      set_flash_message(:notice, :disabled)
+    else
+      set_flash_message(:error, :not_disabled)
+    end
+
     redirect_to after_twilio_verify_disabled_path_for(resource)
   end
 
@@ -83,9 +98,9 @@ class Devise::DeviseTwilioVerifyController < DeviseController
 
     verification_check = TwilioVerifyService.verify_sms_token(@resource.mobile_phone, params[:token])
 
-    self.resource.twilio_verify_enabled = token.ok?
+    self.resource.twilio_verify_enabled = verification_check.status == 'approved'
 
-    if token.ok? && self.resource.save
+    if verification_check.status == 'approved' && self.resource.save
       remember_device(@resource.id) if params[:remember_device].to_i == 1
       record_twilio_verify_authentication
       set_flash_message(:notice, :enabled)

data/devise-twilio-verify.gemspec

@@ -46,4 +46,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "generator_spec"
   spec.add_development_dependency "database_cleaner", "~> 1.7"
   spec.add_development_dependency "factory_bot_rails", "~> 5.1.1"
+  spec.add_development_dependency "mutex_m", "~> 0.3.0"
+  spec.add_development_dependency "drb", "~> 2.2.1"
+  spec.add_development_dependency "observer", "~> 0.1.2"
 end

data/lib/devise-twilio-verify/models/twilio_verify_authenticatable.rb

@@ -10,6 +10,8 @@ module Devise
 
       module ClassMethods
         def find_by_mobile_phone(mobile_phone)
+          return if mobile_phone.blank?
+
           where(mobile_phone: mobile_phone).first
         end
 

data/lib/devise-twilio-verify/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DeviseTwilioVerify
-  VERSION = '0.1.1'
+  VERSION = '0.2.0'
 end

data/lib/generators/active_record/templates/migration.rb

@@ -4,14 +4,13 @@ class DeviseTwilioVerifyAddTo<%= table_name.camelize %> < ActiveRecord::Migratio
       t.string    :authy_id
       t.datetime  :last_sign_in_with_twilio_verify
       t.boolean   :twilio_verify_enabled, :default => false
+      t.string    :twilio_totp_factor_sid
     end
-
-    add_index :<%= table_name %>, :authy_id
   end
 
   def self.down
     change_table :<%= table_name %> do |t|
-      t.remove :authy_id, :last_sign_in_with_twilio_verify, :twilio_verify_enabled
+      t.remove :authy_id, :last_sign_in_with_twilio_verify, :twilio_verify_enabled, :twilio_totp_factor_sid
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: devise-twilio-verify
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Jay Wolff
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-04-13 00:00:00.000000000 Z
+date: 2024-12-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: devise
@@ -262,6 +262,48 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 5.1.1
+- !ruby/object:Gem::Dependency
+  name: mutex_m
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.3.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.3.0
+- !ruby/object:Gem::Dependency
+  name: drb
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.2.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.2.1
+- !ruby/object:Gem::Dependency
+  name: observer
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.2
 description: Twilio Verify plugin to add two factor authentication to Devise. This
   gem is meant to make migrating from authy to twilio verify as simple as possible,
   please see the README for details.