devise-security 0.14.0 → 0.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f875949c3596aacd2a09f825b702622301681f698c670d2b6c168cb094683cb6
-  data.tar.gz: a6fc0fa7ec647e3b42fbf2d87f8b8e021519c5b0a452a5f6d1a343e3ccbd6756
+  metadata.gz: 1d065158ce85c823918ca0fb7ad40382ca9957f7c5e0847e1fec86e1eaed0ffb
+  data.tar.gz: fa07606b583076da6b68ceeddf70f74f80c05f3adf752a057b8f935c9af68fb6
 SHA512:
-  metadata.gz: 02a70ddfe0355473ec47e4e44a573e18e9e1c3687ac748d2aac0a72b6df41dae012e722eec8d27c02dbc2ec8610c4141a7f06cd4e92237d88f25e98ce1993dd2
-  data.tar.gz: c0f4bf76ad2e033523de11ecba217c1fb21666eda4922ca6b7564dd7df34fa2d95d058ab3bdb78e8bb52dd4f7b9419bbd62a71e92554ccaaac2d59333127f99d
+  metadata.gz: 7f18a70374b20c80908006811184fc4757c4f678e11ff226d60b78ff0a3c1cf2612382185911b23692c6c7ed1553914f1361ab1243948ad1e1ff3ac91fdb5ab7
+  data.tar.gz: 68e392e9f0049659ad62977a0bb31910d4942b26ab24fab11b28e1e875286f2b48e9da20dd952f94bc4ac8350b1cd5199d9984e431d4664c865544a095b274b8

data/README.md

@@ -1,28 +1,45 @@
 # Devise Security
 
-[![Build Status](https://travis-ci.org/devise-security/devise-security.svg?branch=master)](https://travis-ci.org/devise-security/devise-security)[![Coverage Status](https://coveralls.io/repos/github/devise-security/devise-security/badge.svg?branch=master)](https://coveralls.io/github/devise-security/devise-security?branch=master)[![Maintainability](https://api.codeclimate.com/v1/badges/ace7cd003a0db8bffa5a/maintainability)](https://codeclimate.com/github/devise-security/devise-security/maintainability)
+[![Build Status](https://travis-ci.org/devise-security/devise-security.svg?branch=master)](https://travis-ci.org/devise-security/devise-security)
+[![Coverage Status](https://coveralls.io/repos/github/devise-security/devise-security/badge.svg?branch=master)](https://coveralls.io/github/devise-security/devise-security?branch=master)
+[![Maintainability](https://api.codeclimate.com/v1/badges/ace7cd003a0db8bffa5a/maintainability)](https://codeclimate.com/github/devise-security/devise-security/maintainability)
 
-A [Devise](https://github.com/plataformatec/devise) extension to add additional security features required by modern web applications. Forked from [Devise Security Extension](https://github.com/phatworx/devise_security_extension)
+A [Devise](https://github.com/heartcombo/devise) extension to add additional
+security features required by modern web applications. Forked from
+[Devise Security Extension](https://github.com/phatworx/devise_security_extension)
 
 It is composed of 7 additional Devise modules:
 
-- `:password_expirable` - passwords will expire after a configured time (and will need to be changed by the user). You will most likely want to use `:password_expirable` together with the `:password_archivable` module to [prevent the current expired password being reused](https://github.com/phatworx/devise_security_extension/issues/175) immediately as the new password.
-- `:secure_validatable` - better way to validate a model (email, stronger password validation). Don't use with Devise `:validatable` module!
-- `:password_archivable` - save used passwords in an `old_passwords` table for history checks (don't be able to use a formerly used password)
-- `:session_limitable` - ensures, that there is only one session usable per account at once
-- `:expirable` - expires a user account after x days of inactivity (default 90 days)
-- `:security_questionable` - as accessible substitution for captchas (security question with captcha fallback)
-- `:paranoid_verification` - admin can generate verification code that user needs to fill in otherwise he wont be able to use the application.
+- `:password_expirable` - passwords will expire after a configured time (and
+  will need to be changed by the user). You will most likely want to use
+  `:password_expirable` together with the `:password_archivable` module to
+  [prevent the current expired password from being reused](https://github.com/phatworx/devise_security_extension/issues/175)
+  immediately as the new password.
+- `:secure_validatable` - better way to validate a model (email, stronger
+  password validation). Don't use with Devise `:validatable` module!
+- `:password_archivable` - save used passwords in an `old_passwords` table for
+  history checks (prevent reusing passwords)
+- `:session_limitable` - ensures, that there is only one session usable per
+  account at once
+- `:expirable` - expires a user account after x days of inactivity (default 90
+  days)
+- `:security_questionable` - as accessible substitution for captchas (security
+  question with captcha fallback)
+- `:paranoid_verification` - admin can generate verification code that user
+  needs to fill in otherwise he won't be able to use the application.
 
 Configuration and database schema for each module below.
 
 ## Additional features
 
-- **captcha support** for `sign_up`, `sign_in`, `recover` and `unlock` (to make automated mass creation and brute forcing of accounts harder)
+**captcha support** for `sign_up`, `sign_in`, `recover` and `unlock` (to make
+automated mass creation and brute forcing of accounts harder)
 
 ## Getting started
 
-Devise Security works with Devise on Rails 4.2 onwards. You can add it to your Gemfile after you successfully set up Devise (see [Devise documentation](https://github.com/plataformatec/devise)) with:
+Devise Security works with Devise on Rails >= 5.0. You can add it to your
+Gemfile after you successfully set up Devise (see
+[Devise documentation](https://github.com/heartcombo/devise)) with:
 
 ```ruby
 gem 'devise-security'
@@ -36,7 +53,10 @@ After you installed Devise Security you need to run the generator:
 rails generate devise_security:install
 ```
 
-The generator adds optional configurations to `config/initializers/devise-security.rb`. Enable the modules you wish to use in the initializer you are ready to add Devise Security modules on top of Devise modules to any of your Devise models:
+The generator adds optional configurations to
+`config/initializers/devise_security.rb`. Enable the modules you wish to use in
+the initializer you are ready to add Devise Security modules on top of Devise
+modules to any of your Devise models:
 
 ```ruby
 devise :password_expirable, :secure_validatable, :password_archivable, :session_limitable, :expirable
@@ -44,13 +64,16 @@ devise :password_expirable, :secure_validatable, :password_archivable, :session_
 
 ### E-mail Validation
 
-for `:secure_validatable` you need to have a way to validate an e-mail. There are multiple libraries that support this, and even a way built into Ruby!
+For `:secure_validatable` you need to have a way to validate an e-mail. There
+are multiple libraries that support this, and even a way built into Ruby!
 
-[Ruby Constant](http://yogodoshi.com/ruby-already-has-its-own-regular-expression-to-validate-emails/)
-  * Note: This method would require a `email_validation` method to be defined in order to hook into the `validates` method defined here.
-[email_address](https://github.com/afair/email_address) gem
-[valid_email2](https://github.com/micke/valid_email2) gem
-[rails_email_validator](https://github.com/phatworx/rails_email_validator) gem (deprecated)
+- (Recommended) Ruby built-in `URI::MailTo::EMAIL_REGEXP` constant
+  > Note: This method would require a `email_validation` method to be defined in
+  > order to hook into the `validates` method defined here.
+- [email_address](https://github.com/afair/email_address) gem
+- [valid_email2](https://github.com/micke/valid_email2) gem
+- [rails_email_validator](https://github.com/phatworx/rails_email_validator) gem
+  (deprecated)
 
 ## Configuration
 
@@ -61,7 +84,7 @@ Devise.setup do |config|
 
   # Password expires after a configurable time (in seconds).
   # Or expire passwords on demand by setting this configuration to `true`
-  # Use `user.need_password_change!` to expire a password.
+  # Use `user.need_change_password!` to expire a password.
   # Setting the configuration to `false` will completely disable expiration checks.
   # config.expire_password_after = 3.months | true | false
 
@@ -101,65 +124,76 @@ Devise.setup do |config|
   # ==> Configuration for :expirable
   # Time period for account expiry from last_activity_at
   # config.expire_after = 90.days
+
+  # Allow passwords to be equal to email (false, true)
+  # config.allow_passwords_equal_to_email = false
 end
 ```
 
 ## Other ORMs
 
-Devise-security supports [Mongoid](https://rubygems.org/gems/mongoid) as an alternative ORM to active_record.  To use this ORM, add this to your `Gemfile`.
+Devise-security supports [Mongoid](https://rubygems.org/gems/mongoid) as an
+alternative ORM to active_record. To use this ORM, add this to your `Gemfile`.
 
-    gem 'mongoid'
+```ruby
+gem 'mongoid'
+```
 
 And then ensure that the environment variable `DEVISE_ORM=mongoid` is set.
 
 For local development you will need to have MongoDB installed locally.
 
-    brew install mongodb
+```bash
+brew install mongodb
+```
 
 ### Rails App setup example with Mongoid
 
 ```ruby
 # inside config/application.rb
-require File.expand_path('../boot', __FILE__)
-#...
-DEVISE_ORM=:mongoid
+    require File.expand_path('../boot', __FILE__)
+    #...
+    DEVISE_ORM=:mongoid
 
 # Require the gems listed in Gemfile, including any gems
 # you've limited to :test, :development, or :production.
-Bundler.require(*Rails.groups)
+    Bundler.require(*Rails.groups)
 
-module MyApp
+    module MyApp
   class Application < Rails::Application
     #...
   end
-end  
+end
 ```
 
 ## Captcha-Support
 
-The captcha support depends on [EasyCaptcha](https://github.com/phatworx/easy_captcha). See further documentation there.
+The captcha support depends on
+[EasyCaptcha](https://github.com/phatworx/easy_captcha). See further
+documentation there.
 
 ### Installation
 
 1. Add EasyCaptcha to your `Gemfile` with
 
-```ruby
-gem 'easy_captcha'
-```
+   ```ruby
+   gem 'easy_captcha'
+   ```
 
-1. Run the initializer
+2. Run the initializer
 
-```ruby
-rails generate easy_captcha:install
-```
+   ```ruby
+   rails generate easy_captcha:install
+   ```
 
-1. Enable captcha - see "Configuration" of Devise Security above.
-1. Add the captcha in the generated devise views for each controller you have activated
+3. Enable captcha - see "Configuration" of Devise Security above.
+4. Add the captcha in the generated devise views for each controller you have
+   activated.
 
-```erb
-<p><%= captcha_tag %></p>
-<p><%= text_field_tag :captcha %></p>
-```
+   ```erb
+   <p><%= captcha_tag %></p>
+   <p><%= text_field_tag :captcha %></p>
+   ```
 
 ## Schema
 
@@ -174,7 +208,8 @@ end
 add_index :the_resources, :password_changed_at
 ```
 
-Note: setting `password_changed_at` to `nil` will require the user to change their password.
+Note: setting `password_changed_at` to `nil` will require the user to change
+their password.
 
 ### Password archivable
 
@@ -195,10 +230,24 @@ add_index :old_passwords, [:password_archivable_type, :password_archivable_id],
 create_table :the_resources do |t|
   # other devise fields
 
-  t.string :unique_session_id, limit: 20
+  t.string :unique_session_id
 end
 ```
 
+#### Bypassing session limitable
+
+Sometimes it's useful to impersonate a user without authentication (e.g.
+[administrator impersonating a user](https://github.com/heartcombo/devise/wiki/How-To:-Sign-in-as-another-user-if-you-are-an-admin)),
+in this case the `session_limitable` strategy will log out the user, and if the
+user logs in while the administrator is still logged in, the administrator will
+be logged out.
+
+For such cases the following can be used:
+
+```ruby
+sign_in(User.find(params[:id]), scope: :user, skip_session_limitable: true)
+```
+
 ### Expirable
 
 ```ruby
@@ -271,13 +320,13 @@ end
 
 ## Requirements
 
-* Devise (<https://github.com/plataformatec/devise>)
-* Rails 4.2 onwards (<http://github.com/rails/rails>)
-* recommendations:
-    - `autocomplete-off` (<http://github.com/phatworx/autocomplete-off>)
-    - `easy_captcha` (<http://github.com/phatworx/easy_captcha>)
-    - `mongodb` (<https://www.mongodb.com/>)
-    - `rvm` (<https://rvm.io/>)
+- Devise (<https://github.com/heartcombo/devise>)
+- Rails 5.0 onwards (<http://github.com/rails/rails>)
+- recommendations:
+  - `autocomplete-off` (<http://github.com/phatworx/autocomplete-off>)
+  - `easy_captcha` (<http://github.com/phatworx/easy_captcha>)
+  - `mongodb` (<https://www.mongodb.com/>)
+  - `rvm` (<https://rvm.io/>)
 
 ## Todo
 
@@ -295,7 +344,8 @@ end
 - 0.8 Support for Rails 4 (+ variety of patches)
 - 0.11 Support for Rails 5. Forked to allow project maintenance and features
 
-See also [Github Releases](https://github.com/devise-security/devise-security/releases)
+See also
+[Github Releases](https://github.com/devise-security/devise-security/releases)
 
 ## Maintainers
 
@@ -305,22 +355,36 @@ See also [Github Releases](https://github.com/devise-security/devise-security/re
 
 ## Contributing to devise-security
 
-- Check out the latest master to make sure the feature hasn't been implemented or the bug hasn't been fixed yet
-- Check out the issue tracker to make sure someone already hasn't requested it and/or contributed it
+- Check out the latest master to make sure the feature hasn't been implemented
+  or the bug hasn't been fixed yet
+- Check out the issue tracker to make sure someone already hasn't requested it
+  and/or contributed it
 - Fork the project
 - Start a feature/bugfix branch
 - Commit and push until you are happy with your contribution
-- Make sure to add tests for it. This is important so I don't break it in a future version unintentionally.
-- Please try not to mess with the Rakefile, version, or history. If you want to have your own version, or is otherwise necessary, that is fine, but please isolate to its own commit so I can cherry-pick around it.
+- Make sure to add tests for it. This is important so I don't break it in a
+  future version unintentionally.
+- Please try not to mess with the Rakefile, version, or history. If you want to
+  have your own version, or is otherwise necessary, that is fine, but please
+  isolate to its own commit so I can cherry-pick around it.
 
 ## Running tests
 
-Standard tests can be invoked using `rake`.  To run the tests against the `mongoid` ORM, use `DEVISE_ORM=mongoid rake` while `mongodb` is running.
+Standard tests can be invoked using `rake`. To run the tests against the
+`mongoid` ORM, use `DEVISE_ORM=mongoid rake` while `mongodb` is running.
+
+## Maintenance Policy
 
-To locally simulate what travis-ci will run when you push code use:
+We are committed to maintain support for `devise-security` for all normal or
+security maintenance versions of the Ruby language
+[as listed here](https://www.ruby-lang.org/en/downloads/branches/), and for the
+Ruby on Rails framework
+[as per their maintenance policy](https://rubyonrails.org/maintenance/).
 
-    $ gem install bundler -v '1.17.3'
-    $ BUNDLER_VERSION=1.17.3 wwtd
+In order to avoid introducing bugs caused by backwardly incompatible Ruby
+language features, it is highly recommended that all development work be done
+using the oldest supported ruby version. The contents of the `.ruby-version`
+file should reflect this.
 
 ## Copyright
 

data/app/controllers/devise/password_expired_controller.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 class Devise::PasswordExpiredController < DeviseController
+  before_action :verify_requested_format!
   skip_before_action :handle_password_change
   before_action :skip_password_change, only: [:show, :update]
   prepend_before_action :authenticate_scope!, only: [:show, :update]
@@ -9,13 +10,21 @@ class Devise::PasswordExpiredController < DeviseController
     respond_with(resource)
   end
 
+  # Update the password stored on the `resource`.
+  # @note if a common data format like :json or :xml are requested
+  #   this will respond with a 204 No Content and set the Location header.
+  #   Useful for dealing with APIs when JS clients would otherwise automatically
+  #   follow the redirect, which can be problematic.
+  # @see https://stackoverflow.com/questions/228225/prevent-redirection-of-xmlhttprequest
+  # @see https://github.com/axios/axios/issues/932#issuecomment-307390761
+  # @see https://github.com/devise-security/devise-security/pull/111
   def update
     resource.extend(Devise::Models::DatabaseAuthenticatablePatch)
     if resource.update_with_password(resource_params)
       warden.session(scope)['password_expired'] = false
       set_flash_message :notice, :updated
       bypass_sign_in resource, scope: scope
-      redirect_to stored_location_for(scope) || :root
+      respond_with({}, location: stored_location_for(scope) || :root)
     else
       clean_up_passwords(resource)
       respond_with(resource, action: :show)
@@ -32,11 +41,7 @@ class Devise::PasswordExpiredController < DeviseController
   def resource_params
     permitted_params = [:current_password, :password, :password_confirmation]
 
-    if params.respond_to?(:permit)
-      params.require(resource_name).permit(*permitted_params)
-    else
-      params[scope].slice(*permitted_params)
-    end
+    params.require(resource_name).permit(*permitted_params)
   end
 
   def scope

data/app/views/devise/paranoid_verification_code/show.html.erb

@@ -1,10 +1,10 @@
-<h2>Submit verification code</h2>
+<h2>t('.submit_verification_code')</h2>
 
 <%= form_for(resource, as: resource_name, url: [resource_name, :paranoid_verification_code], html: { method: :put }) do |f| %>
   <%= render partial: 'devise/shared/error_messages' %>
 
-  <p><%= f.label :paranoid_verification_code, 'Verification code' %><br />
+  <p><%= f.label :paranoid_verification_code, t('.verification_code') %><br />
   <%= f.text_field :paranoid_verification_code, value: '' %></p>
 
-  <p><%= f.submit 'Submit' %></p>
+  <p><%= f.submit t('.submit') %></p>
 <% end %>

data/app/views/devise/password_expired/show.html.erb

@@ -1,16 +1,16 @@
-<h2>Renew your password</h2>
+<h2><%= t('.renew_your_password') %></h2>
 
 <%= form_for(resource, as: resource_name, url: [resource_name, :password_expired], html: { method: :put }) do |f| %>
   <%= render partial: 'devise/shared/error_messages' %>
 
-  <p><%= f.label :current_password, 'Current password' %><br />
+  <p><%= f.label :current_password, t('.current_password') %><br />
   <%= f.password_field :current_password %></p>
 
-  <p><%= f.label :password, 'New password' %><br />
+  <p><%= f.label :password, t('.new_password') %><br />
   <%= f.password_field :password %></p>
 
-  <p><%= f.label :password_confirmation, 'Confirm new password' %><br />
+  <p><%= f.label :password_confirmation, t('.new_password_confirmation') %><br />
   <%= f.password_field :password_confirmation %></p>
 
-  <p><%= f.submit 'Change my password' %></p>
+  <p><%= f.submit t('.change_my_password') %></p>
 <% end %>

data/config/locales/by.yml

@@ -0,0 +1,49 @@
+by:
+  errors:
+    messages:
+      taken_in_past: 'ужо раней выкарыстоўваўся.'
+      equal_to_current_password: 'павінен адрознівацца ад сучаснага пароля.'
+      equal_to_email: 'павінна адрознівацца ад электроннай пошты.'
+      password_complexity:
+        digit:
+          one: 'павінен утрымліваць хоць адну лічбу'
+          few: 'павінен утрымліваць хоць %{count} лічбы'
+          many: 'павінен утрымліваць хоць %{count} лічбы'
+          other: 'павінен утрымліваць хоць %{count} лічбы'
+        lower:
+          one: 'павінен утрымліваць хоць адну маленькую літару'
+          few: 'павінен утрымліваць хоць %{count} малыx літары'
+          many: 'павінен утрымліваць хоць %{count} малыx літары'
+          other: 'павінен утрымліваць хоць %{count} малыx літары'
+        symbol:
+          one: 'павінен утрымліваць хоць адзін знак пунктуацыі або сімвал'
+          few: 'павінен утрымліваць хоць %{count} знака пунктуацыі або сімвала'
+          many: 'павінен утрымліваць хоць %{count} знака пунктуацыі або сімвала'
+          other: 'павінен утрымліваць хоць %{count} знака пунктуацыі або сімвала'
+        upper:
+          one: 'павінен утрымліваць хоць адну вялікую літару'
+          few: 'павінен утрымліваць хоць %{count} вялікіx літары'
+          many: 'павінен утрымліваць хоць %{count} вялікіx літары'
+          other: 'павінен утрымліваць хоць %{count} вялікіx літары'
+  devise:
+    invalid_captcha: 'Уведзены няправільны код капчы.'
+    invalid_security_question: 'Адказ на сакрэтнае пытанне быў няправільны.'
+    paranoid_verify:
+      code_required: 'Калі ласка, увядзіце код, атрыманы ад нашай каманды падтрымкі'
+    paranoid_verification_code:
+      show:
+        submit_verification_code: 'Увод кода пацверджання'
+        verification_code: 'Код пацверджання'
+        submit: 'Адправіць'
+    password_expired:
+      updated: 'Ваш новы пароль захаваны.'
+      change_required: 'Ваш пароль састарэў. Калі ласка, усталюйце новы.'
+      show:
+        renew_your_password: 'Змена пароля'
+        current_password: 'Сучасны пароль'
+        new_password: 'Новы пароль'
+        new_password_confirmation: 'Пацвердзіце новы пароль'
+        change_my_password: 'Змяніць пароль'
+    failure:
+      session_limited: 'Вашы параметры ўваходу выкарыстоўваюцца ў іншым браўзэры. Калі ласка, аўтарызуйцеся зноў, каб працягнуць у гэтым браўзэры.'
+      expired: 'Ваш уліковы запіс састарэў з-за неактыўнасці. Калі ласка, звяжыцеся з адміністратарам.'