devise-jwt 0.5.6 → 0.5.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a1dcf5432b3eca3682d6eda74ea8659a4de99692
-  data.tar.gz: 98ca51ba3d3e16558f3e2690504f517fffe45b73
+  metadata.gz: ce25f0119df28a2ff0682ec57b228e7cd3d0d24a
+  data.tar.gz: f86dd338edbeb3e38992d1a3407888405e566a3d
 SHA512:
-  metadata.gz: 5f4a10c20c6dd4638f7fdf661f7715d93a7337dc1e7458f507a2c0f0dcebc80ca58108783a2ded9cbf3c6efda25773e6ce8916a17029b542726ea512eb2ce161
-  data.tar.gz: 930058ffefc9dfcfcf47143fbbb27cc81ad10e5528ec99e860d8d0e64ee144fee8b0ed5684ade1f83f28fe1e397cc9a63038ff77f0c5acb0058583bc08634754
+  metadata.gz: d92f20f3d3a4dff6b9eacb4bc2f00633be267e2d0835ed3b50beb22c0c0a720cc9200ca16d9399877927d3249efb43d1644543e9f57496f5107c6351a309dfee
+  data.tar.gz: 0431acb342abb8d861c9750fa5fa3b121a7b0c05b01ac15bfa407564c0442107f3f93c72ab800da6b86aac7290f377f80a421072b159042fb563664a19cac18e

data/.travis.yml

@@ -1,9 +1,10 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.2.6
-  - 2.3.3
-  - 2.4.0
+  - 2.2.9
+  - 2.3.6
+  - 2.4.3
+  - 2.5.0
 before_install:
   - gem update --system --no-doc
   - bundle install --gemfile=.overcommit_gems.rb

data/CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/) 
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [0.5.7] - 2018-06-22
+### Added
+- Use `primary_key` instead of `id` to fetch resource.
+
 ## [0.5.6] - 2018-02-22
 ### Fixed
 - Work with more than one `sign_out_via` configured

data/README.md

@@ -26,7 +26,7 @@ You can read about which security concerns this library takes into account and a
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'devise-jwt', '~> 0.5.6'
+gem 'devise-jwt', '~> 0.5.7'
 ```
 
 And then execute:
@@ -182,7 +182,7 @@ Then, you have to add the strategy to the model class and configure it according
 ```ruby
 class User < ApplicationRecord
   include Devise::JWT::RevocationStrategies::JTIMatcher
-  
+
   devise :database_authenticatable,
          :jwt_authenticatable, jwt_revocation_strategy: self
 end
@@ -276,13 +276,13 @@ def change
     # If you want to leverage the `aud` claim, add to it a `NOT NULL` constraint:
     # t.string :aud, null: false
     t.datetime :exp, null: false
-    t.references :your_user_table, foreign_key: true
+    t.references :your_user_table, foreign_key: { on_delete: :cascade }, null: false
   end
-  
+
   add_index :whitelisted_jwts, :jti, unique: true
 end
 ```
-Important: You are encouraged to set a unique index in the jti column. This way we can be sure at the database level that there aren't two valid tokens with same jti at the same time.
+Important: You are encouraged to set a unique index in the jti column. This way we can be sure at the database level that there aren't two valid tokens with same jti at the same time. Definining `foreign_key: { on_delete: :cascade }, null: false` on `t.references :your_user_table` helps to keep referential integrity of your database.
 
 And then, the model:
 
@@ -291,12 +291,12 @@ class WhitelistedJwt < ApplicationRecord
 end
 ```
 
-Finally, include de strategy in the model and configure it:
+Finally, include the strategy in the model and configure it:
 
 ```ruby
 class User < ApplicationRecord
   include Devise::JWT::RevocationStrategies::Whitelist
-  
+
   devise :database_authenticatable,
          :jwt_authenticatable, jwt_revocation_strategy: self
 end
@@ -333,7 +333,7 @@ module MyCustomStrategy
   def self.jwt_revoked?(payload, user)
     # Does something to check whether the JWT token is revoked for given user
   end
-  
+
   def self.revoke_jwt(payload, user)
     # Does something to revoke the JWT token for given user
   end
@@ -378,9 +378,9 @@ require 'devise/jwt/test_helpers'
     headers = { 'Accept' => 'application/json', 'Content-Type' => 'application/json' }
     # This will add a valid token for `user` in the `Authorization` header
     auth_headers = Devise::JWT::TestHelpers.auth_headers(headers, user)
-    
+
     get '/my/end_point', headers: auth_headers
-    
+
     expect_something()
   end
 ```
@@ -425,7 +425,7 @@ jwt.dispatch_requests = [
 
 **Important**: You are encouraged to delimit your regular expression with `^` and `$` to avoid unintentional matches.
 
-#### revocation_requests 
+#### revocation_requests
 
 Besides the destroy session one, additional requests where JWT tokens should be revoked.
 

data/issue_template.md

@@ -0,0 +1,28 @@
+Please, for a bug report fill in the following template. Before that, make sure to read the whole [README](https://github.com/waiting-for-dev/devise-jwt/blob/master/README.md) and check if your issue is not related with [CORS](https://github.com/waiting-for-dev/devise-jwt#model-configuration).
+
+Feature requests and questions about `devise-jwt` are also accepted. It isn't the place for generic questions about using `devise` with an API. For that, read our [wiki page](https://github.com/waiting-for-dev/devise-jwt/wiki/Configuring-devise-for-APIs) or ask somewhere else like [stackoverflow](https://stackoverflow.com/)
+
+## Expected behavior
+
+## Actual behavior
+
+## Steps to Reproduce the Problem
+
+1.
+2.
+3.
+
+## Debugging information
+
+Provide following information. Please, format pasted output as code. Feel free to remove the secret key value.
+
+- Version of `devise-jwt` in use
+- Version of `rails` in use
+- Output of `Devise::JWT.config`
+- Output of `Warden::JWTAuth.config`
+- Output of `Devise.mappings`
+- If your issue is related with not getting a JWT from the server:
+  - Involved request path, method and request headers
+  - Response headers for that request
+- If your issue is related with not being able to revoke a JWT:
+  - Involved request path, method and request headers

data/lib/devise/jwt/models/jwt_authenticatable.rb

@@ -17,7 +17,7 @@ module Devise
 
       included do
         def self.find_for_jwt_authentication(sub)
-          find_by(id: sub)
+          find_by(primary_key => sub)
         end
       end
 

data/lib/devise/jwt/version.rb

@@ -2,6 +2,6 @@
 
 module Devise
   module JWT
-    VERSION = '0.5.6'
+    VERSION = '0.5.7'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: devise-jwt
 version: !ruby/object:Gem::Version
-  version: 0.5.6
+  version: 0.5.7
 platform: ruby
 authors:
 - Marc Busqué
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-02-22 00:00:00.000000000 Z
+date: 2018-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: devise
@@ -190,6 +190,7 @@ files:
 - bin/setup
 - devise-jwt.gemspec
 - docker-compose.yml
+- issue_template.md
 - lib/devise/jwt.rb
 - lib/devise/jwt/defaults_generator.rb
 - lib/devise/jwt/mapping_inspector.rb