devise-jira-authenticable 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bafd1e409aa04147e2d5dcddfd52334038604fc0
-  data.tar.gz: 76b1a215d43773824ff54c8d897107939926f040
+  metadata.gz: c0841c79636ea594b8f5b8d79bb2d86ad3933482
+  data.tar.gz: 9d51a3baf75e08986d60d771039dbfee628215a1
 SHA512:
-  metadata.gz: 217e5ea46b6ae4ab49f4f517ec315f069f24b2abcf0d8dbce6a8ad4af92ea5092e573136b27138f64e8af9d8c3b084e083f5b7da55d00963439a7c08fa16704b
-  data.tar.gz: a05940bc9793e4ad31da67454bfc1b1ee121ab8fbda9df9bddfb6d6b983cde70bf8572a170da9fe741227d949826d57bacafffa5257c215c6374e05f7bbd008d
+  metadata.gz: 392ae4cbd6da39b4e58a1d0dc428753aeb48413f31a03f26aac3a3baa7179e21bf7a85d3f63dca4cf67023a81a5525530558f6e69fec7eae1d80d86ffc455afc
+  data.tar.gz: e4f664f4fd6a8eb569a7755124744d9fd7270abb30bb9d5e621e2f1751fa64e722b82b22ae22c6c2844ea5b247a66f7c8837e537832faf080156e5d9b2004d4b

data/README.md

@@ -2,9 +2,15 @@
 
 This provides a mechanism to allow devise to authenticate using a JIRA instance.  It integrates with the jira-ruby.gem.  Even if you intend only to use a `jira-authenticable` strategy within Devise, I suggest starting by getting Devise going with the `database-authenticable` strategy.
 
-
 The following instructions assume that you want to use the `jira-authenticable strategy` alongside another strategy such as `database-authenticatable`.
 
+> I had originally designed jira-authenticable to work both standalone and in conjunction
+> with database_authenticatable.  However, I have run into an issue.  In standalone mode
+> my user model needs to define a password method that is used elsewhere.  However, if
+> I define a password method it may overwrite the password method defined by the
+> database_authenticatable strategy.  So a no-win situation.  For now, please use the two
+> strategies together.
+
 ## Devise Preparation
 
 As JIRA uses usernames rather than email addresses for login credentials I would also make the changes to your app to use a username within Devise before adding adding this Gem.  That way you can test that you have successfully implemented the user authentication before worrying about the JIRA interface.

data/lib/devise/jira_authenticable/version.rb

@@ -1,5 +1,5 @@
 module Devise
   module JiraAuthenticable
-    VERSION = '0.0.1'
+    VERSION = '0.0.2'
   end
 end

data/lib/devise/models/jira_authenticable.rb

@@ -41,7 +41,6 @@ module Devise
 
       included do
         attr_accessor :jira_client
-        attr_accessor :password
       end
 
       # Use the currently configured JIRA server to attempt to authenticate the
@@ -52,7 +51,7 @@ module Devise
       # Parameters::
       # * +username+: The username to send to the radius server
       # * +password+: The password to send to the radius server
-      def valid_jira_password?(username, password)
+      def valid_jira_password?(password)
         self.jira_client = JIRA::Client.new(
           username: username,
           password: password,
@@ -82,7 +81,7 @@ module Devise
 
           resource = find_for_authentication( username: username )
 
-          resource&.valid_jira_password?(username, password) ? resource : nil
+          resource&.valid_jira_password?(password) ? resource : nil
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: devise-jira-authenticable
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - trapeze.bell.peter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-10 00:00:00.000000000 Z
+date: 2017-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: devise
@@ -296,7 +296,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Provide Devise authentication using a JIRA instance.