devise-edge 1.2.rc

data/test/integration/confirmable_test.rb

@@ -0,0 +1,104 @@
+require 'test_helper'
+
+class ConfirmationTest < ActionController::IntegrationTest
+
+  def visit_user_confirmation_with_token(confirmation_token)
+    visit user_confirmation_path(:confirmation_token => confirmation_token)
+  end
+
+  test 'user should be able to request a new confirmation' do
+    user = create_user(:confirm => false)
+    ActionMailer::Base.deliveries.clear
+
+    visit new_user_session_path
+    click_link "Didn't receive confirmation instructions?"
+
+    fill_in 'email', :with => user.email
+    click_button 'Resend confirmation instructions'
+
+    assert_current_url '/users/sign_in'
+    assert_contain 'You will receive an email with instructions about how to confirm your account in a few minutes'
+    assert_equal 1, ActionMailer::Base.deliveries.size
+  end
+
+  test 'user with invalid confirmation token should not be able to confirm an account' do
+    visit_user_confirmation_with_token('invalid_confirmation')
+    assert_have_selector '#error_explanation'
+    assert_contain /Confirmation token(.*)invalid/
+  end
+
+  test 'user with valid confirmation token should be able to confirm an account' do
+    user = create_user(:confirm => false)
+    assert_not user.confirmed?
+    visit_user_confirmation_with_token(user.confirmation_token)
+
+    assert_contain 'Your account was successfully confirmed.'
+    assert_current_url '/'
+    assert user.reload.confirmed?
+  end
+
+  test 'already confirmed user should not be able to confirm the account again' do
+    user = create_user(:confirm => false)
+    user.confirmed_at = Time.now
+    user.save
+    visit_user_confirmation_with_token(user.confirmation_token)
+
+    assert_have_selector '#error_explanation'
+    assert_contain 'already confirmed'
+  end
+
+  test 'already confirmed user should not be able to confirm the account again neither request confirmation' do
+    user = create_user(:confirm => false)
+    user.confirmed_at = Time.now
+    user.save
+
+    visit_user_confirmation_with_token(user.confirmation_token)
+    assert_contain 'already confirmed'
+
+    fill_in 'email', :with => user.email
+    click_button 'Resend confirmation instructions'
+    assert_contain 'already confirmed'
+  end
+
+  test 'sign in user automatically after confirming it\'s email' do
+    user = create_user(:confirm => false)
+    visit_user_confirmation_with_token(user.confirmation_token)
+
+    assert warden.authenticated?(:user)
+  end
+
+  test 'increases sign count when signed in through confirmation' do
+    user = create_user(:confirm => false)
+    visit_user_confirmation_with_token(user.confirmation_token)
+
+    user.reload
+    assert_equal 1, user.sign_in_count
+  end
+
+  test 'not confirmed user with setup to block without confirmation should not be able to sign in' do
+    swap Devise, :confirm_within => 0.days do
+      sign_in_as_user(:confirm => false)
+
+      assert_contain 'You have to confirm your account before continuing'
+      assert_not warden.authenticated?(:user)
+    end
+  end
+
+  test 'not confirmed user but configured with some days to confirm should be able to sign in' do
+    swap Devise, :confirm_within => 1.day do
+      sign_in_as_user(:confirm => false)
+
+      assert_response :success
+      assert warden.authenticated?(:user)
+    end
+  end
+
+  test 'error message is configurable by resource name' do
+    store_translations :en, :devise => {
+      :failure => { :user => { :unconfirmed => "Not confirmed user" } }
+    } do
+      sign_in_as_user(:confirm => false)
+      assert_contain 'Not confirmed user'
+    end
+  end
+end

data/test/integration/database_authenticatable_test.rb

@@ -0,0 +1,38 @@
+require 'test_helper'
+
+class DatabaseAuthenticationTest < ActionController::IntegrationTest
+  test 'sign in should not authenticate if not using proper authentication keys' do
+    swap Devise, :authentication_keys => [:username] do
+      sign_in_as_user
+      assert_not warden.authenticated?(:user)
+    end
+  end
+
+  test 'sign in with invalid email should return to sign in form with error message' do
+    sign_in_as_admin do
+      fill_in 'email', :with => 'wrongemail@test.com'
+    end
+
+    assert_contain 'Invalid email or password'
+    assert_not warden.authenticated?(:admin)
+  end
+
+  test 'sign in with invalid pasword should return to sign in form with error message' do
+    sign_in_as_admin do
+      fill_in 'password', :with => 'abcdef'
+    end
+
+    assert_contain 'Invalid email or password'
+    assert_not warden.authenticated?(:admin)
+  end
+
+  test 'error message is configurable by resource name' do
+    store_translations :en, :devise => { :failure => { :admin => { :invalid => "Invalid credentials" } } } do
+      sign_in_as_admin do
+        fill_in 'password', :with => 'abcdef'
+      end
+
+      assert_contain 'Invalid credentials'
+    end
+  end
+end

data/test/integration/http_authenticatable_test.rb

@@ -0,0 +1,64 @@
+require 'test_helper'
+
+class HttpAuthenticationTest < ActionController::IntegrationTest
+
+  test 'sign in should authenticate with http' do
+    sign_in_as_new_user_with_http
+    assert_response :success
+    assert_match '<email>user@test.com</email>', response.body
+    assert warden.authenticated?(:user)
+  end
+
+  test 'returns a custom response with www-authenticate header on failures' do
+    sign_in_as_new_user_with_http("unknown")
+    assert_equal 401, status
+    assert_equal 'Basic realm="Application"', headers["WWW-Authenticate"]
+  end
+
+  test 'uses the request format as response content type' do
+    sign_in_as_new_user_with_http("unknown")
+    assert_equal 401, status
+    assert_equal "application/xml; charset=utf-8", headers["Content-Type"]
+    assert_match "<error>Invalid email or password.</error>", response.body
+  end
+
+  test 'returns a custom response with www-authenticate and chosen realm' do
+    swap Devise, :http_authentication_realm => "MyApp" do
+      sign_in_as_new_user_with_http("unknown")
+      assert_equal 401, status
+      assert_equal 'Basic realm="MyApp"', headers["WWW-Authenticate"]
+    end
+  end
+
+  test 'sign in should authenticate with http even with specific authentication keys' do
+    swap Devise, :authentication_keys => [:username] do
+      sign_in_as_new_user_with_http("usertest")
+      assert_response :success
+      assert_match '<email>user@test.com</email>', response.body
+      assert warden.authenticated?(:user)
+    end
+  end
+
+  test 'test request with oauth2 header doesnt get mistaken for basic authentication' do
+    swap Devise, :http_authenticatable => true do
+      add_oauth2_header
+      assert_equal 401, status
+      assert_equal 'Basic realm="Application"', headers["WWW-Authenticate"]
+    end
+  end
+
+  private
+
+    def sign_in_as_new_user_with_http(username="user@test.com", password="123456")
+      user = create_user
+      get users_path(:format => :xml), {}, "HTTP_AUTHORIZATION" => "Basic #{ActiveSupport::Base64.encode64("#{username}:#{password}")}"
+      user
+    end
+    
+    # Sign in with oauth2 token. This is just to test that it isn't misinterpreted as basic authentication
+    def add_oauth2_header
+      user = create_user
+      get users_path(:format => :xml), {}, "HTTP_AUTHORIZATION" => "OAuth #{ActiveSupport::Base64.encode64("#{user.email}:123456")}"
+    end
+
+end

data/test/integration/lockable_test.rb

@@ -0,0 +1,109 @@
+require 'test_helper'
+
+class LockTest < ActionController::IntegrationTest
+  
+  def visit_user_unlock_with_token(unlock_token)
+    visit user_unlock_path(:unlock_token => unlock_token)
+  end
+
+  test 'user should be able to request a new unlock token' do
+    user = create_user(:locked => true)
+    ActionMailer::Base.deliveries.clear
+
+    visit new_user_session_path
+    click_link "Didn't receive unlock instructions?"
+
+    fill_in 'email', :with => user.email
+    click_button 'Resend unlock instructions'
+
+    assert_template 'sessions/new'
+    assert_contain 'You will receive an email with instructions about how to unlock your account in a few minutes'
+    assert_equal 1, ActionMailer::Base.deliveries.size
+  end
+
+  test 'unlocked user should not be able to request a unlock token' do
+    user = create_user(:locked => false)
+    ActionMailer::Base.deliveries.clear
+
+    visit new_user_session_path
+    click_link "Didn't receive unlock instructions?"
+
+    fill_in 'email', :with => user.email
+    click_button 'Resend unlock instructions'
+
+    assert_template 'unlocks/new'
+    assert_contain 'not locked'
+    assert_equal 0, ActionMailer::Base.deliveries.size
+  end
+
+  test 'unlocked pages should not be available if email strategy is disabled' do
+    visit "/admins/sign_in"
+
+    assert_raise Webrat::NotFoundError do
+      click_link "Didn't receive unlock instructions?"
+    end
+
+    assert_raise NameError do
+      visit new_admin_unlock_path
+    end
+
+    visit "/admins/unlock/new"
+    assert_response :not_found
+  end
+
+  test 'user with invalid unlock token should not be able to unlock an account' do
+    visit_user_unlock_with_token('invalid_token')
+
+    assert_response :success
+    assert_current_url '/users/unlock?unlock_token=invalid_token'
+    assert_have_selector '#error_explanation'
+    assert_contain /Unlock token(.*)invalid/
+  end
+
+  test "locked user should be able to unlock account" do
+    user = create_user(:locked => true)
+    assert user.access_locked?
+
+    visit_user_unlock_with_token(user.unlock_token)
+
+    assert_current_url '/'
+    assert_contain 'Your account was successfully unlocked.'
+
+    assert_not user.reload.access_locked?
+  end
+
+  test "sign in user automatically after unlocking it's account" do
+    user = create_user(:locked => true)
+    visit_user_unlock_with_token(user.unlock_token)
+    assert warden.authenticated?(:user)
+  end
+
+  test "user should not be able to sign in when locked" do
+    user = sign_in_as_user(:locked => true)
+    assert_template 'sessions/new'
+    assert_contain 'Your account is locked.'
+    assert_not warden.authenticated?(:user)
+  end
+
+  test "user should not send a new e-mail if already locked" do
+    user = create_user(:locked => true)
+    user.failed_attempts = User.maximum_attempts + 1
+    user.save!
+
+    ActionMailer::Base.deliveries.clear
+
+    sign_in_as_user(:password => "invalid")
+    assert_contain 'Your account is locked.'
+    assert ActionMailer::Base.deliveries.empty?
+  end
+
+  test 'error message is configurable by resource name' do
+    store_translations :en, :devise => {
+      :failure => { :user => { :locked => "You are locked!" } }
+    } do
+      user = sign_in_as_user(:locked => true)
+      assert_contain 'You are locked!'
+    end
+  end
+
+end

data/test/integration/oauthable_test.rb

@@ -0,0 +1,258 @@
+require 'test_helper'
+
+class OAuthableIntegrationTest < ActionController::IntegrationTest
+  FACEBOOK_INFO = {
+    :username => 'usertest',
+    :email => 'user@test.com'
+  }
+
+  ACCESS_TOKEN = {
+    :access_token => "plataformatec"
+  }
+
+  setup do
+    Devise::Oauth.short_circuit_authorizers!
+  end
+
+  teardown do
+    Devise::Oauth.unshort_circuit_authorizers!
+    Devise::Oauth.reset_stubs!
+    User.singleton_class.remove_possible_method(:find_for_github_oauth)
+  end
+
+  def stub_github!(times=1)
+    def User.find_for_github_oauth(*); end
+
+    Devise::Oauth.stub!(:github) do |b|
+      b.post('/login/oauth/access_token') { [200, {}, ACCESS_TOKEN.to_json] }
+    end
+  end
+
+  def stub_facebook!(times=1)
+    # If times != 1, use invalid data
+    data = (times != 1) ? FACEBOOK_INFO.except(:email) : FACEBOOK_INFO
+
+    Devise::Oauth.stub!(:facebook) do |b|
+      b.post('/oauth/access_token') { [200, {}, ACCESS_TOKEN.to_json] }
+      times.times {
+        b.get('/me?access_token=plataformatec') { [200, {}, data.to_json] }
+      }
+    end
+  end
+
+  test "[BASIC] setup with persisted user" do
+    stub_facebook!
+
+    assert_difference "User.count", 1 do
+      visit "/users/sign_in"
+      click_link "Sign in with Facebook"
+    end
+
+    assert_current_url "/"
+    assert_contain "Successfully authorized from Facebook account."
+
+    assert warden.authenticated?(:user)
+    assert_not warden.authenticated?(:admin)
+    assert "plataformatec", warden.user(:user).facebook_token
+  end
+
+  test "[BASIC] setup with not persisted user and follow up" do
+    stub_facebook!(2)
+
+    assert_no_difference "User.count" do
+      visit "/users/sign_in"
+      click_link "Sign in with Facebook"
+    end
+
+    assert_contain "1 error prohibited this user from being saved"
+    assert_contain "Email can't be blank"
+
+    assert_not warden.authenticated?(:user)
+    assert_not warden.authenticated?(:admin)
+
+    fill_in "Email", :with => "user.form@test.com"
+    click_button "Sign up"
+
+    assert_current_url "/"
+    assert_contain "You have signed up successfully."
+    assert_contain "Hello User user.form@test.com"
+
+    assert warden.authenticated?(:user)
+    assert_not warden.authenticated?(:admin)
+    assert "plataformatec", warden.user(:user).facebook_token
+  end
+
+  test "[BASIC] setup updating an existing user in database" do
+    stub_facebook!
+    user = create_user
+
+    assert_no_difference "User.count" do
+      visit "/users/sign_in"
+      click_link "Sign in with Facebook"
+    end
+
+    assert_current_url "/"
+    assert_contain "Successfully authorized from Facebook account."
+
+    assert_equal user, warden.user(:user)
+    assert_equal "plataformatec", user.reload.facebook_token
+  end
+
+  test "[BASIC] setup updating an existing user in session" do
+    stub_facebook!
+
+    # Create an user and change his e-mail
+    user = sign_in_as_user
+    user.email = "another@test.com"
+    user.save!
+
+    assert_no_difference "User.count" do
+      visit "/"
+      click_link "Sign in with Facebook"
+    end
+
+    assert_current_url "/"
+    assert_contain "Successfully authorized from Facebook account."
+
+    assert_equal user, warden.user(:user)
+    assert_equal "another@test.com", warden.user(:user).email
+    assert_equal "plataformatec", user.reload.facebook_token
+  end
+
+  test "[SESSION CLEANUP] ensures session is cleaned up after sign up" do
+    stub_facebook!(2)
+
+    assert_no_difference "User.count" do
+      visit "/users/sign_in"
+      click_link "Sign in with Facebook"
+    end
+
+    assert_contain "1 error prohibited this user from being saved"
+    fill_in "Email", :with => "user.form@test.com"
+    click_button "Sign up"
+
+    assert_contain "You have signed up successfully."
+    visit "/users/sign_out"
+
+    user = sign_in_as_user
+    assert_nil warden.user(:user).facebook_token
+    assert_equal user, warden.user(:user)
+  end
+
+  test "[SESSION CLEANUP] ensures session is cleaned up on cancel" do
+    stub_facebook!(2)
+
+    assert_no_difference "User.count" do
+      visit "/users/sign_in"
+      click_link "Sign in with Facebook"
+    end
+
+    assert_contain "1 error prohibited this user from being saved"
+    visit "/users/cancel"
+
+    user = sign_in_as_user
+    assert_nil warden.user(:user).facebook_token
+    assert_equal user, warden.user(:user)
+  end
+
+  test "[SESSION CLEANUP] ensures session is cleaned up on sign in" do
+    stub_facebook!(2)
+
+    assert_no_difference "User.count" do
+      visit "/users/sign_in"
+      click_link "Sign in with Facebook"
+    end
+
+    assert_contain "1 error prohibited this user from being saved"
+
+    user = sign_in_as_user
+    assert_nil warden.user(:user).facebook_token
+    assert_equal user, warden.user(:user)
+  end
+
+  test "[I18N] scopes messages based on oauth callback for success" do
+    stub_facebook!
+
+    store_translations :en, :devise => { :oauth_callbacks => {
+      :facebook => { :success => "Welcome facebooker" } } } do
+      visit "/users/sign_in"
+      click_link "Sign in with Facebook"
+      assert_contain "Welcome facebooker"
+    end
+  end
+
+  test "[I18N] scopes messages based on oauth callback and resource name for success" do
+    stub_facebook!
+
+    store_translations :en, :devise => { :oauth_callbacks => {
+      :user => { :facebook => { :success => "Welcome facebooker user" } },
+      :facebook => { :success => "Welcome facebooker" } } } do
+      visit "/users/sign_in"
+      click_link "Sign in with Facebook"
+      assert_contain "Welcome facebooker user"
+    end
+  end
+
+  test "[FAILURE] shows 404 if no code or error are given as params" do
+    assert_raise AbstractController::ActionNotFound do
+      visit "/users/oauth/facebook/callback"
+    end
+  end
+
+  test "[FAILURE] raises an error if model does not implement a hook" do
+    begin
+      visit "/users/oauth/github/callback?code=123456"
+      raise "Expected visit to raise an error"
+    rescue Exception => e
+      assert_match "User does not respond to find_for_github_oauth", e.message 
+    end
+  end
+
+  test "[FAILURE] handles callback error parameter according to the specification" do
+    visit "/users/oauth/facebook/callback?error=access_denied"
+    assert_current_url "/users/sign_in"
+    assert_contain 'Could not authorize you from Facebook because "Access denied".'
+  end
+
+  test "[FAILURE] handles callback error_reason just for Facebook compatibility" do
+    visit "/users/oauth/facebook/callback?error_reason=access_denied"
+    assert_current_url "/users/sign_in"
+    assert_contain 'Could not authorize you from Facebook because "Access denied".'
+  end
+
+  test "[FAILURE][I18N] uses I18n for custom messages" do
+    store_translations :en, :devise => { :oauth_callbacks => { :access_denied => "Access denied bro" } } do
+      visit "/users/oauth/facebook/callback?error=access_denied"
+      assert_current_url "/users/sign_in"
+      assert_contain "Access denied bro"
+    end
+  end
+
+  test "[FAILURE][I18N] uses I18n with oauth callback scope for custom messages" do
+    store_translations :en, :devise => { :oauth_callbacks => {
+      :facebook => { :access_denied => "Access denied bro" } } } do
+      visit "/users/oauth/facebook/callback?error=access_denied"
+      assert_current_url "/users/sign_in"
+      assert_contain "Access denied bro"
+    end
+  end
+
+  test "[FAILURE][I18N] uses I18n with oauth callback scope and resource name for custom messages" do
+    store_translations :en, :devise => { :oauth_callbacks => {
+      :user => { :facebook => { :access_denied => "Access denied user" } },
+      :facebook => { :access_denied => "Access denied bro" } } } do
+      visit "/users/oauth/facebook/callback?error=access_denied"
+      assert_current_url "/users/sign_in"
+      assert_contain "Access denied user"
+    end
+  end
+
+  test "[FAILURE][I18N] trim messages to avoid long symbols lookups" do
+    store_translations :en, :devise => { :oauth_callbacks => {
+      :facebook => { ("a"*25) => "Access denied bro" } } } do
+      visit "/users/oauth/facebook/callback?error=#{"a"*100}"
+      assert_current_url "/users/sign_in"
+      assert_contain "Access denied bro"
+    end
+  end
+end