devise-async 1.0.0beta → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8d0faaf77bf8419f09993b61edb2b44e0bca1a7e
-  data.tar.gz: 200860ed39d65593dc110ddc46927cf8e736dd7e
+  metadata.gz: 9b371e54937dd66d336e24152c8a3bdd30cbc24e
+  data.tar.gz: 0d066d3fab7d1d1b8d564691688bb88273582a62
 SHA512:
-  metadata.gz: 14dbc73e63bbf8b6286a335cf1a2dd4b8c244e0bd2e70925feefe50652230c43b38232ee1672b5b0759488ab35cd0950ca7276eb149d9ef71ab80459950c5ef3
-  data.tar.gz: 32ab6b13c47b1059a826b49009b53c430578acce8c0e7ef48c47ae7c84cf8597122a099a5820b4e254ccb4176f29cd766b38ccfb6f94c42bd2fb505e11314849
+  metadata.gz: dba241c296c5001d81a8848c0747cf5402dac71c20f099c936e6b12c53237ee0b693f99f92ac47b81891bfeb37cb2eba429b0bdd4a6bd0eaf4fb3e70d11e1534
+  data.tar.gz: 8c4372972c8303580626d9c12406d70770fce86d22fb569f2c30fc45fd7d15a42408e6194e8ffc9213840b71ab701515d33d2685681f98dbea595b6e919d58da

data/.travis.yml

@@ -6,3 +6,5 @@ rvm:
 
 before_install:
   - gem install bundler -v 1.15
+
+script: bundle exec rspec

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.0.0
+
+* Updates the readme
+
 ## 1.0.0beta
 
 * Adds support for Rails 5

data/README.md

@@ -2,18 +2,7 @@
 
 [![Tag](https://img.shields.io/github/tag/mhfs/devise-async.svg?style=flat-square)](https://github.com/mhfs/devise-async/releases) [![Build Status](https://img.shields.io/travis/mhfs/devise-async.svg?style=flat-square)](https://travis-ci.org/mhfs/devise-async) [![Code Climate](https://img.shields.io/codeclimate/github/mhfs/devise-async.svg?style=flat-square)](https://codeclimate.com/github/mhfs/devise-async)
 
-Devise Async provides an easy way to configure Devise to send its emails asynchronously using your preferred queuing backend.
-
-Supported backends:
-
-* Resque
-* Sidekiq
-* Delayed::Job
-* QueueClassic
-* Torquebox
-* Backburner
-* Que
-* SuckerPunch
+Devise Async provides an easy way to configure Devise to send its emails asynchronously using ActiveJob.
 
 ## Installation
 
@@ -33,7 +22,8 @@ Or install it yourself as:
 
 ## Usage
 
-Add `:async` to the `devise` call in your model:
+1. Setup [ActiveJob](http://edgeguides.rubyonrails.org/active_job_basics.html),
+2. Add `:async` to the `devise` call in your model:
 
 ```ruby
 class User < ActiveRecord::Base
@@ -41,16 +31,7 @@ class User < ActiveRecord::Base
 end
 ```
 
-Set your queuing backend by creating `config/initializers/devise_async.rb`:
-
-```ruby
-# Supported options: :resque, :sidekiq, :delayed_job, :queue_classic, :torquebox, :backburner, :que, :sucker_punch
-Devise::Async.backend = :resque
-```
-
-Tip: it defaults to Resque. You don't need to create the initializer if using it.
-
-## Advanced Options
+## Options
 
 ### Enabling via config
 
@@ -61,33 +42,6 @@ The gem can be enabled/disabled easily via config, for example based on environm
 Devise::Async.enabled = true # | false
 ```
 
-### Custom mailer class
-
-Customize `Devise.mailer` at will and `devise-async` will honor it.
-
-Upgrade note: if you're upgrading from any version < 0.6 and getting errors
-trying to set `Devise::Async.mailer` just use `Devise.mailer` instead.
-
-### Custom queue
-
-Let you specify a custom queue where to enqueue your background Devise jobs.
-Defaults to :mailer.
-
-```ruby
-# config/initializers/devise_async.rb
-Devise::Async.queue = :my_custom_queue
-```
-
-### Custom priority
-
-You can specify a custom priority for created background jobs in Devise or Backburner.
-If no value is specified, jobs will be enqueued with whatever default priority is configured in Devise or Backburner.
-
-```ruby
-# config/initializers/devise_async.rb
-Devise::Async.priority = 10
-```
-
 ### Setup via block
 
 To avoid repeating `Devise::Async` in the initializer file you can use the block syntax
@@ -97,40 +51,22 @@ similar to what `Devise` offers.
 # config/initializers/devise_async.rb
 Devise::Async.setup do |config|
   config.enabled = true
-  config.backend = :resque
-  config.queue   = :my_custom_queue
-end
-```
-
-## Troubleshooting
-
-If you are using Sidekiq and your jobs are enqueued but not processed you might need to set a queue explicitly:
-
-```ruby
-# config/initializers/devise_async.rb
-Devise::Async.setup do |config|
-  config.backend = :sidekiq
-  config.queue   = :default
 end
 ```
 
-## Testing
-
-Be aware that since version 0.3.0 devise-async enqueues the background job in active
-record's `after_commit` hook. If you're using rspec's `use_transactional_fixtures` the jobs
-might not be enqueued as you'd expect.
+### Custom mailer class
 
-More details in this stackoverflow [thread](http://stackoverflow.com/questions/13406248/how-do-i-get-devise-async-working-with-cucumber/13465089#13465089).
+Customize `Devise.mailer` at will and `devise-async` will honor it.
 
-## Devise < 2.2
+## Older versions of Rails and devise
 
-Older versions of Devise are supported in the [devise_2_1](https://github.com/mhfs/devise-async/tree/devise_2_1) branch and in the 0.5 series of devise-async.
+If you want to use this gem with Rails < 5 and/or devise < 4 check out older releases, please.
 
-Please refer to that branch README for further info.
+## Testing
 
-## Devise >= 4.0
+RSpec is used for testing. The following should be enough for running the test:
 
-The current state of this gem does not support Devise 4.0 and up. Have a look into [the Github issue](https://github.com/mhfs/devise-async/issues/94) addressing this. If you are in need for a solution to send Devise messages delayed [a switch to ActiveJob](https://github.com/plataformatec/devise#activejob-integration) is strongly advised.
+    $ bundle exec rspec
 
 ## Contributing
 

data/Rakefile

@@ -1,14 +1,3 @@
 #!/usr/bin/env rake
 
 require "bundler/gem_tasks"
-require "rake/testtask"
-
-task :default => :test
-
-Rake::TestTask.new do |t|
-  t.libs << "lib"
-  t.libs << "test"
-  t.test_files = FileList["test/**/*_test.rb"]
-  t.verbose = true
-  t.warning = false
-end

data/lib/devise/async/version.rb

@@ -1,5 +1,5 @@
 module Devise
   module Async
-    VERSION = '1.0.0beta'
+    VERSION = '1.0.0'
   end
 end

data/spec/devise/async/model_spec.rb

@@ -1,14 +1,12 @@
 RSpec.describe Devise::Models::Async do
-  before :each do
+  before do
     ActiveJob::Base.queue_adapter = :test
   end
 
   context 'with unchanged model' do
-    subject { create_admin }
+    subject { admin }
 
-    before :each do
-      subject
-    end
+    let!(:admin) { create_admin }
 
     it 'enqueues notifications immediately when the model did not change' do
       expect(ActionMailer::DeliveryJob).to have_been_enqueued
@@ -47,7 +45,7 @@ RSpec.describe Devise::Models::Async do
     end
 
     context 'with saving the model' do
-      let(:save_admin) { admin.save }
+      let(:saved_admin) { admin.save }
 
       it 'accumulates a pending notification to be sent after commit' do
         expect(subject).to eq([
@@ -59,13 +57,13 @@ RSpec.describe Devise::Models::Async do
         subject
 
         expect {
-          save_admin
+          saved_admin
         }.to have_enqueued_job(ActionMailer::DeliveryJob)
       end
 
       it 'forwards the correct data to the job' do
         subject
-        save_admin
+        saved_admin
 
         job_data = ActiveJob::Base.queue_adapter.enqueued_jobs.first[:args]
         expected_job_data = ['Devise::Mailer', 'confirmation_instructions', admin.send(:confirmation_token)]
@@ -76,7 +74,7 @@ RSpec.describe Devise::Models::Async do
   end
 
   context 'when devise async is disabled' do
-    around :each do |example|
+    around do |example|
       Devise::Async.enabled = false
       example.run
       Devise::Async.enabled = true

data/spec/rails_helper.rb

@@ -18,6 +18,6 @@ RSpec.configure do |config|
   config.include TestHelpers
 
   config.before :each do
-    load File.dirname(__FILE__) + '/support/rails_app/db/schema.rb'
+    load "#{File.dirname(__FILE__)}/support/rails_app/db/schema.rb"
   end
 end

data/spec/spec_helper.rb

@@ -11,7 +11,7 @@ RSpec.configure do |config|
   config.filter_run_when_matching :focus
   config.example_status_persistence_file_path = "spec/examples.txt"
   config.disable_monkey_patching!
-  config.warnings = true
+  config.warnings = false
   config.order = :random
 
   if config.files_to_run.one?

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: devise-async
 version: !ruby/object:Gem::Version
-  version: 1.0.0beta
+  version: 1.0.0
 platform: ruby
 authors:
 - Sebastian Oelke
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-25 00:00:00.000000000 Z
+date: 2017-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: devise
@@ -185,9 +185,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.4.5.1