device_detector_regexes 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 24497676df61d5343c44418e2f8c4c8904eed8947cb5db1212196ac542ab91e0
-  data.tar.gz: c9bd55656c6e3daee2a7d995d3f057b5ea87b09f4e0c423a5d90eaa0df77e1d2
+  metadata.gz: 5fa92b28e6542f50833c1ea09bc983cd68a1a1bf81432769cf363ca1f7e35039
+  data.tar.gz: 26e4ce16e1e5fb4220531911b526b39025b2512acb30b5e52c369401969eb18e
 SHA512:
-  metadata.gz: e5fafe5b9c03bd69c37ee0240d9c4fd86210ed3e20ae55d089be998c809e3cd1e5d445077ee8d7d939ce3307ddb2c760479166d997f4d0f271808f0c3e62e738
-  data.tar.gz: 4e130d6639c97c4afb210477289bdde0be6bbce0f1ca15df2e24199ab51e947c94b82f11452782ea9dbc03b32bbf115f58bac4d72dc1dcb32633200dfc513940
+  metadata.gz: 606a041f2257a535298fd6ee3924d93e1edace18fc99e655adb0a4d173acab91c5f4c920d61a252bf1aaba9db7deb07fba6d2aaa4dd9f2d315a43771b95d9ea0
+  data.tar.gz: 51e5e8c098816dd0bf12e3eb4ed6011d30ad2e2392760d206d72cd727e552d377d2937bb6ce3fbc1326c4ea99048200458407968930bd347e37756eb5c1c6019

data/.rubocop.yml

@@ -0,0 +1,5 @@
+Style/Documentation:
+  Enabled: false
+
+Layout/LineLength:
+  Max: 140

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Change log
 
+## [0.1.5]
+Add rubocop, fix offences
+
 ## [0.1.4]
 Add an abillity to skip the piwik dd prefix, refactoring
 

data/Gemfile

@@ -1,5 +1,5 @@
-source "https://rubygems.org"
+# frozen_string_literal: true
 
-gemspec
+source 'https://rubygems.org'
 
-gem "rake", "~> 12.0"
+gemspec

data/Gemfile.lock

@@ -7,15 +7,31 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
+    ast (2.4.0)
     device_detector (1.0.3)
-    rake (12.3.3)
+    jaro_winkler (1.5.4)
+    parallel (1.19.1)
+    parser (2.7.0.4)
+      ast (~> 2.4.0)
+    rainbow (3.0.0)
+    rexml (3.2.4)
+    rubocop (0.80.1)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.7.0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      rexml
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 1.7)
+    ruby-progressbar (1.10.1)
+    unicode-display_width (1.6.1)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   device_detector_regexes!
-  rake (~> 12.0)
+  rubocop
 
 BUNDLED WITH
    1.17.2

data/bin/console

@@ -1,7 +1,9 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "device_detector_regexes"
+# frozen_string_literal: true
+
+require 'bundler/setup'
+require 'device_detector_regexes'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +12,5 @@ require "device_detector_regexes"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start(__FILE__)

data/device_detector_regexes.gemspec

@@ -1,30 +1,33 @@
+# frozen_string_literal: true
+
 require_relative 'lib/device_detector_regexes/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "device_detector_regexes"
-  spec.version       = DeviceDetectorRegexes::VERSION
-  spec.authors       = ["Kirill Karpinovsky"]
-  spec.email         = ["karpinovsky@gmail.com"]
+  spec.name = 'device_detector_regexes'
+  spec.version = DeviceDetectorRegexes::VERSION
+  spec.authors = ['Kirill Karpinovsky']
+  spec.email = ['karpinovsky@gmail.com']
 
-  spec.summary       = %q{device_detector regexes extender}
-  spec.description   = %q{DeviceDetectorRegexes is an extension for device_detector gem that makes it easy to add new regular expressions}
-  spec.homepage      = "https://github.com/karpinovsky/device_detector_regexes"
-  spec.license       = "MIT"
-  spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0")
+  spec.summary = 'device_detector regexes extender'
+  spec.description = 'DeviceDetectorRegexes is an extension for device_detector gem that makes it easy to add new regular expressions'
+  spec.homepage = 'https://github.com/karpinovsky/device_detector_regexes'
+  spec.license = 'MIT'
+  spec.required_ruby_version = Gem::Requirement.new('>= 2.3.0')
 
-  spec.metadata["homepage_uri"] = spec.homepage
-  spec.metadata["bug_tracker_uri"] = "https://github.com/karpinovsky/device_detector_regexes/issues"
-  spec.metadata["source_code_uri"] = spec.homepage
-  spec.metadata["changelog_uri"] = "https://github.com/karpinovsky/device_detector_regexes/blob/master/CHANGELOG.md"
+  spec.metadata['homepage_uri'] = spec.homepage
+  spec.metadata['bug_tracker_uri'] = 'https://github.com/karpinovsky/device_detector_regexes/issues'
+  spec.metadata['source_code_uri'] = spec.homepage
+  spec.metadata['changelog_uri'] = 'https://github.com/karpinovsky/device_detector_regexes/blob/master/CHANGELOG.md'
 
-  spec.extra_rdoc_files = Dir["README.md", "CHANGELOG.md", "LICENSE.txt"]
+  spec.extra_rdoc_files = Dir['README.md', 'CHANGELOG.md', 'LICENSE.txt']
 
-  spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
+  spec.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
-  spec.bindir        = "exe"
+  spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_dependency "device_detector"
+  spec.add_dependency 'device_detector'
+  spec.add_development_dependency 'rubocop'
 end

data/lib/device_detector_regexes.rb

@@ -1,4 +1,6 @@
-require "device_detector"
+# frozen_string_literal: true
+
+require 'device_detector'
 
 module DeviceDetectorRegexes; end
 
@@ -14,32 +16,30 @@ class DeviceDetector
       end
     end
   end
-end
 
-class DeviceDetector::Parser
-  def filepaths
-    filenames.each_with_object([]) do |filename, filenames|
+  class Parser
+    def filepaths
+      filenames.each_with_object([]) do |filename, filenames|
+        # push custom files first due to higher precedence lookup than default files
+        custom_file_path = File.expand_path(filename, File.join(DeviceDetector.config.dir, 'regexes'))
+        filenames << [filename.to_sym, custom_file_path] if File.exist?(custom_file_path)
 
-      # push custom files first due to higher precedence lookup than default files
-      custom_file_path = File.expand_path(filename, File.join(DeviceDetector.config.dir, "regexes"))
-      if File.exists?(custom_file_path)
-        filenames << [filename.to_sym, custom_file_path]
+        filenames << [filename.to_sym, File.join(ROOT, 'regexes', filename)]
       end
-
-      filenames << [filename.to_sym, File.join(ROOT, "regexes", filename)]
     end
-  end
 
-  def parse_regexes(path, raw_regexes)
-    raw_regexes.map do |meta|
-      fail "invalid device spec: #{meta.inspect}" unless meta[:regex].is_a? String
-      meta[:regex] = build_regex(meta[:regex], meta[:prefix])
-      meta[:path] = path
-      meta
+    def parse_regexes(path, raw_regexes)
+      raw_regexes.map do |meta|
+        raise "invalid device spec: #{meta.inspect}" unless meta[:regex].is_a? String
+
+        meta[:regex] = build_regex(meta[:regex], meta[:prefix])
+        meta[:path] = path
+        meta
+      end
     end
-  end
 
-  def build_regex(src, prefix = true)
-    Regexp.new (prefix ? '(?:^|[^A-Z0-9\-_]|[^A-Z0-9\-]_|sprd-)(?:' + src + ')' : src), Regexp::IGNORECASE
+    def build_regex(src, prefix = true)
+      Regexp.new (prefix ? '(?:^|[^A-Z0-9\-_]|[^A-Z0-9\-]_|sprd-)(?:' + src + ')' : src), Regexp::IGNORECASE
+    end
   end
 end

data/lib/device_detector_regexes/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DeviceDetectorRegexes
-  VERSION = "0.1.4"
+  VERSION = '0.1.5'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: device_detector_regexes
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Kirill Karpinovsky
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: DeviceDetectorRegexes is an extension for device_detector gem that makes
   it easy to add new regular expressions
 email:
@@ -36,6 +50,7 @@ extra_rdoc_files:
 - LICENSE.txt
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -47,7 +62,6 @@ files:
 - bin/setup
 - device_detector_regexes.gemspec
 - lib/device_detector_regexes.rb
-- lib/device_detector_regexes/device_detector.rb
 - lib/device_detector_regexes/version.rb
 homepage: https://github.com/karpinovsky/device_detector_regexes
 licenses:

data/lib/device_detector_regexes/device_detector.rb

@@ -1,14 +0,0 @@
-# module DeviceDetectorRegexes
-    # def self.included(base)
-      # base.extend(Dry::Configurable)
-      # base.instance_eval do
-        # setting(:custom_dir, "/Users/kirill/Work/device_detector_regexes") { |dir| Pathname(dir) }
-      # end
-      # base.extend(ClassMethods)
-    # end
-
-    # module ClassMethods
-      # extend Dry::Configurable
-      # setting(:custom_dir, Dir.pwd) { |dir| Pathname(dir) }
-    # end
-# end