devfile 0.0.12.pre.alpha1-arm64-darwin → 0.0.14.pre.alpha1-arm64-darwin

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 51f867c9659b085063e543b19d4aa1b368e0c5586dfb3753657195a0988a3477
-  data.tar.gz: 6fe5ebe8e2126969d14084a2b94df0056e42f00f7dd2bd66124f1e8e18e72fe3
+  metadata.gz: a51dbd46d989075807ea91333a1bcabca598d5bbfb6a6010c0aca3eb82a6cd83
+  data.tar.gz: 1f6dde67b986ef69691c6a577209332f6bd88095b50de0e6fdc1a8b1c776f81e
 SHA512:
-  metadata.gz: a34eb8c12d90069e173cf18ea080e3a4c15e82d6e6e71ae969e7b1c192300c7f6eb36779faba39a44608522950c2eaeb6f0c948cc870ba1aad7ef5e998371b3f
-  data.tar.gz: d5cff0dd5b7d067cc42ba9f2d6c3c91c6ab0d3bf8253ab3406611a1791b1c28eb1d62dba3399dcc37d364875469ca5e5b4658f842e2a40d0618d489b05199642
+  metadata.gz: 1ca4a2dbdda67b2f53e0a2159564b99297ba2eeb24595a6ece5b45720881484ca826dbccedb20028b5aee0090806d8ff8e4707c6b0da4c21304b0cabb358efe9
+  data.tar.gz: dcde2fe0951b7654eed898eb81165d20f8b0e0c2b5e0339b642099ea13709b8795ac9f9dd75a42372e708422cca07e81bc21a333a54791ad7a359b92887b35fc

data/ext/devfile.go

@@ -2,8 +2,6 @@ package main
 
 import (
 	"bytes"
-	"fmt"
-	"sort"
 	"strconv"
 	"text/template"
 
@@ -24,14 +22,21 @@ type Devfile struct {
 	devfileObj parser.DevfileObj
 }
 
-type volumeOptions struct {
-	Info        generator.VolumeInfo
-	Size        string
-	IsEphemeral bool
+type pvcOptions struct {
+	Name string
+	Size string
 }
 
 func (d Devfile) getDeployment(name, namespace string, labels, annotations map[string]string, replicas int) (*appsv1.Deployment, error) {
-	containers, initContainers, volumes, _, err := d.getContainersAndVolumes(name)
+	containers, err := generator.GetContainers(d.devfileObj, common.DevfileOptions{})
+	if err != nil {
+		return nil, err
+	}
+	initContainers, err := generator.GetInitContainers(d.devfileObj)
+	if err != nil {
+		return nil, err
+	}
+	volumes, _, err := d.getVolumesAndVolumeMounts(containers, initContainers, name)
 	if err != nil {
 		return nil, err
 	}
@@ -147,24 +152,29 @@ func (d Devfile) getIngress(name, namespace string, labels, annotations map[stri
 }
 
 func (d Devfile) getPVC(name, namespace string, labels, annotations map[string]string) ([]*corev1.PersistentVolumeClaim, error) {
-	_, _, volumes, volumeNameToVolumeOptions, err := d.getContainersAndVolumes(name)
+	containers, err := generator.GetContainers(d.devfileObj, common.DevfileOptions{})
+	if err != nil {
+		return nil, err
+	}
+	initContainers, err := generator.GetInitContainers(d.devfileObj)
+	if err != nil {
+		return nil, err
+	}
+	_, pvcNameToPvcOptions, err := d.getVolumesAndVolumeMounts(containers, initContainers, name)
 	if err != nil {
 		return nil, err
 	}
+
 	pvcs := make([]*corev1.PersistentVolumeClaim, 0)
-	for _, volume := range volumes {
-		volumeOptions := volumeNameToVolumeOptions[volume.Name]
-		if volumeOptions.IsEphemeral {
-			continue
-		}
-		quantity, err := resource.ParseQuantity(volumeOptions.Size)
+	for _, options := range pvcNameToPvcOptions {
+		quantity, err := resource.ParseQuantity(options.Size)
 		if err != nil {
 			return nil, err
 		}
 		pvcParams := generator.PVCParams{
 			TypeMeta: generator.GetTypeMeta("PersistentVolumeClaim", "v1"),
 			ObjectMeta: metav1.ObjectMeta{
-				Name:        volumeOptions.Info.PVCName,
+				Name:        options.Name,
 				Namespace:   namespace,
 				Labels:      labels,
 				Annotations: annotations,
@@ -212,65 +222,6 @@ func (d Devfile) getAll(name, namespace string, labels, annotations map[string]s
 	return result, nil
 }
 
-func (d Devfile) getContainersAndVolumes(name string) ([]corev1.Container, []corev1.Container, []corev1.Volume, map[string]volumeOptions, error) {
-	containers, err := generator.GetContainers(d.devfileObj, common.DevfileOptions{})
-	if err != nil {
-		return nil, nil, nil, nil, err
-	}
-	initContainers, err := generator.GetInitContainers(d.devfileObj)
-	if err != nil {
-		return nil, nil, nil, nil, err
-	}
-	allContainers := append(containers, initContainers...)
-
-	volumeComponents, err := d.devfileObj.Data.GetDevfileVolumeComponents(common.DevfileOptions{})
-	if err != nil {
-		return nil, nil, nil, nil, err
-	}
-	volumeNameToVolumeOptions := map[string]volumeOptions{}
-	volumeNameToVolumeInfo := map[string]generator.VolumeInfo{}
-	for _, volumeComponent := range volumeComponents {
-		info := generator.VolumeInfo{
-			PVCName:    fmt.Sprintf("%s-%s", name, volumeComponent.Name),
-			VolumeName: volumeComponent.Name,
-		}
-		volumeNameToVolumeInfo[volumeComponent.Name] = info
-		volumeNameToVolumeOptions[volumeComponent.Name] = volumeOptions{
-			Info:        info,
-			Size:        volumeComponent.Volume.Size,
-			IsEphemeral: *volumeComponent.Volume.Ephemeral,
-		}
-	}
-
-	volumeParams := generator.VolumeParams{
-		Containers:             allContainers,
-		VolumeNameToVolumeInfo: volumeNameToVolumeInfo,
-	}
-	options := common.DevfileOptions{}
-	// "containers" and "initContainers" are updated in place with the volume mounts parameters
-	// after the following function is called
-	volumes, err := generator.GetVolumesAndVolumeMounts(d.devfileObj, volumeParams, options)
-	if err != nil {
-		return nil, nil, nil, nil, err
-	}
-	// sort all volumes and volume mounts in the containers and initContainers
-	// to keep the array order deterministic
-	sort.SliceStable(volumes, func(i, j int) bool {
-		return volumes[i].Name < volumes[j].Name
-	})
-	for _, container := range containers {
-		sort.SliceStable(container.VolumeMounts, func(i, j int) bool {
-			return container.VolumeMounts[i].Name < container.VolumeMounts[j].Name
-		})
-	}
-	for _, initContainer := range initContainers {
-		sort.SliceStable(initContainer.VolumeMounts, func(i, j int) bool {
-			return initContainer.VolumeMounts[i].Name < initContainer.VolumeMounts[j].Name
-		})
-	}
-	return containers, initContainers, volumes, volumeNameToVolumeOptions, nil
-}
-
 func (d Devfile) hasContainerComponents() (bool, error) {
 	containers, err := generator.GetContainers(d.devfileObj, common.DevfileOptions{})
 	if err != nil {

data/ext/volume.go

@@ -0,0 +1,118 @@
+package main
+
+import (
+	"fmt"
+	"github.com/devfile/library/v2/pkg/devfile/generator"
+	"github.com/devfile/library/v2/pkg/devfile/parser/data/v2/common"
+	corev1 "k8s.io/api/core/v1"
+	"k8s.io/apimachinery/pkg/api/resource"
+	"strings"
+)
+
+func (d Devfile) getVolumesAndVolumeMounts(containers []corev1.Container, initContainers []corev1.Container, volumeNamePrefix string) ([]corev1.Volume, map[string]pvcOptions, error) {
+	containerComponents, err := d.devfileObj.Data.GetDevfileContainerComponents(common.DevfileOptions{})
+	if err != nil {
+		return nil, nil, err
+	}
+	volumeComponents, err := d.devfileObj.Data.GetDevfileVolumeComponents(common.DevfileOptions{})
+	if err != nil {
+		return nil, nil, err
+	}
+
+	var volumes []corev1.Volume
+	pvcNameToPvcOptions := map[string]pvcOptions{}
+	for _, volumeComponent := range volumeComponents {
+		volName := volumeComponent.Name
+		if bool(*volumeComponent.Volume.Ephemeral) == true {
+			emptyDir, err := getEmptyDir(volName, volumeComponent.Volume.Size)
+			if err != nil {
+				return nil, nil, err
+			}
+			volumes = append(volumes, emptyDir)
+		} else {
+			pvcName := fmt.Sprintf("%s-%s", volumeNamePrefix, volumeComponent.Name)
+			pvcNameToPvcOptions[volumeComponent.Name] = pvcOptions{
+				Name: pvcName,
+				Size: volumeComponent.Volume.Size,
+			}
+			volumes = append(volumes, getPersistentVolumeClaim(volName, pvcName))
+		}
+		// containerNameToMountPaths is a map of the Devfile container name to their Devfile Volume Mount Paths for a given Volume Name
+		containerNameToMountPaths := make(map[string][]string)
+		for _, containerComp := range containerComponents {
+			for _, volumeMount := range containerComp.Container.VolumeMounts {
+				if volName == volumeMount.Name {
+					containerNameToMountPaths[containerComp.Name] = append(containerNameToMountPaths[containerComp.Name], generator.GetVolumeMountPath(volumeMount))
+				}
+			}
+		}
+
+		addVolumeMountToContainers(containers, initContainers, volumeComponent.Name, containerNameToMountPaths)
+	}
+
+	return volumes, pvcNameToPvcOptions, nil
+}
+
+// addVolumeMountToContainers adds the Volume Mounts in containerNameToMountPaths to the containers for a given pvc and volumeName
+// containerNameToMountPaths is a map of a container name to an array of its Mount Paths.
+// To be moved to devfile/library.
+func addVolumeMountToContainers(containers []corev1.Container, initContainers []corev1.Container, volumeName string, containerNameToMountPaths map[string][]string) {
+
+	for containerName, mountPaths := range containerNameToMountPaths {
+		for i := range containers {
+			if containers[i].Name == containerName {
+				for _, mountPath := range mountPaths {
+					containers[i].VolumeMounts = append(containers[i].VolumeMounts, corev1.VolumeMount{
+						Name:      volumeName,
+						MountPath: mountPath,
+						SubPath:   "",
+					},
+					)
+				}
+			}
+		}
+		for i := range initContainers {
+			if strings.HasPrefix(initContainers[i].Name, containerName) {
+				for _, mountPath := range mountPaths {
+					initContainers[i].VolumeMounts = append(initContainers[i].VolumeMounts, corev1.VolumeMount{
+						Name:      volumeName,
+						MountPath: mountPath,
+						SubPath:   "",
+					},
+					)
+				}
+			}
+		}
+	}
+}
+
+// getPersistentVolumeClaim gets a pvc type volume with the given volume name and pvc name.
+func getPersistentVolumeClaim(volumeName, pvcName string) corev1.Volume {
+
+	return corev1.Volume{
+		Name: volumeName,
+		VolumeSource: corev1.VolumeSource{
+			PersistentVolumeClaim: &corev1.PersistentVolumeClaimVolumeSource{
+				ClaimName: pvcName,
+			},
+		},
+	}
+}
+
+// getEmptyDir gets an emptyDir type volume with the given volume name and size.
+// size should be parseable as a Kubernetes `Quantity` or an error will be returned
+func getEmptyDir(volumeName string, size string) (corev1.Volume, error) {
+
+	emptyDir := &corev1.EmptyDirVolumeSource{}
+	qty, err := resource.ParseQuantity(size)
+	if err != nil {
+		return corev1.Volume{}, err
+	}
+	emptyDir.SizeLimit = &qty
+	return corev1.Volume{
+		Name: volumeName,
+		VolumeSource: corev1.VolumeSource{
+			EmptyDir: emptyDir,
+		},
+	}, nil
+}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: devfile
 version: !ruby/object:Gem::Version
-  version: 0.0.12.pre.alpha1
+  version: 0.0.14.pre.alpha1
 platform: arm64-darwin
 authors:
 - GitLab
@@ -24,6 +24,7 @@ files:
 - ext/go.mod
 - ext/go.sum
 - ext/main.go
+- ext/volume.go
 - lib/devfile.rb
 homepage: https://gitlab.com
 licenses: