detour 0.0.1 → 0.0.2

data/spec/features/flag_in_flags_spec.rb

@@ -0,0 +1,118 @@
+require "spec_helper"
+
+describe "counting flaggable flags" do
+  let!(:flag) { create :flag_in_flag }
+
+  before do
+    visit "/detour/flags/users"
+  end
+
+  it "displays the defined groups" do
+    within "tr#feature_#{flag.feature.id} td.flag-in-count" do
+      page.should have_content 1
+    end
+  end
+end
+
+describe "listing flag_in_flags" do
+  let!(:flag) { create :flag_in_flag }
+
+  before do
+    User.instance_variable_set "@detour_flaggable_find_by", :email
+    visit "/detour/flag-ins/#{flag.feature.name}/users"
+  end
+
+  it "displays the flagged-in model's find-by" do
+    page.should have_content flag.flaggable.email
+  end
+end
+
+describe "creating flag-ins", js: true do
+  let(:user) { create :user }
+  let!(:feature) { create :feature }
+
+  before do
+    User.instance_variable_set "@detour_flaggable_find_by", :email
+    visit "/detour/flag-ins/#{feature.name}/users"
+    page.find("[data-target='#create-flaggable-flag']").click
+  end
+
+  context "when creating multiple flag-ins" do
+    let(:user2) { create :user, email: "another_user@example.com" }
+
+    context "when successful" do
+      before do
+        fill_in "ids", with: [user.email, user2.email].join(",")
+        click_button "Create Flag-in"
+      end
+
+      it "displays a success message" do
+        page.should have_content "Users #{user.email}, #{user2.email} have been flagged in to #{feature.name}"
+      end
+    end
+
+    context "when unsuccessful" do
+      before do
+        fill_in "ids", with: "#{user.email},foo"
+        click_button "Create Flag-in"
+      end
+
+      it "displays error messages" do
+        page.should have_content "Couldn't find User with email = foo"
+      end
+    end
+  end
+
+  context "when creating single flag-ins" do
+    context "when successful" do
+      before do
+        fill_in "ids", with: user.email
+        click_button "Create Flag-in"
+      end
+
+      it "displays a success message" do
+        page.should have_content "User #{user.email} has been flagged in to #{feature.name}"
+      end
+
+      it "renders the new flag-in" do
+        within "table" do
+          page.should have_content user.email
+        end
+      end
+    end
+
+    context "when unsuccessful" do
+      before do
+        fill_in "ids", with: "foo"
+        click_button "Create Flag-in"
+      end
+
+      it "displays error messages" do
+        page.should have_content "Couldn't find User with email = foo"
+      end
+    end
+  end
+end
+
+describe "destroying flag-ins", js: true do
+  let!(:flag) { create :flag_in_flag }
+
+  before do
+    visit "/detour/flag-ins/#{flag.feature.name}/users"
+    page.find(".delete-flag").click
+    click_link "Delete Flag-in"
+  end
+
+  it "displays a flash message" do
+    page.should have_content "#{flag.feature.name} flag-in for User #{flag.flaggable.send flag.flaggable_type.constantize.detour_flaggable_find_by} has been deleted."
+  end
+
+  it "destroys the flag-in" do
+    expect { flag.reload }.to raise_error ActiveRecord::RecordNotFound
+  end
+
+
+  it "removes the flag from the list" do
+    page.should_not have_content flag.flaggable.email
+  end
+end

data/spec/features/group_flags_spec.rb

@@ -0,0 +1,49 @@
+require "spec_helper"
+
+describe "listing defined groups" do
+  before do
+    Detour.config.define_user_group :admins do |user|
+    end
+
+    visit "/detour/flags/users"
+  end
+
+  it "displays the defined groups" do
+    page.should have_content "admins"
+  end
+end
+
+describe "creating defined group flags" do
+  let!(:feature) { create :feature }
+
+  before do
+    Detour.config.define_user_group :admins do |user|
+    end
+
+    visit "/detour/flags/users"
+    check "features[#{feature.name}][users_group_flags_attributes[admins]][to_keep]"
+    click_button "Save Changes"
+  end
+
+  it "creates the group flag" do
+    feature.reload.users_group_flags.first.group_name.should eq "admins"
+  end
+end
+
+describe "removing defined group flags" do
+  let(:feature)     { create :feature }
+  let!(:group_flag) { create :group_flag, feature: feature, group_name: "admins" }
+
+  before do
+    Detour.config.define_user_group :admins do |user|
+    end
+
+    visit "/detour/flags/users"
+    uncheck "features[#{feature.name}][users_group_flags_attributes[admins]][to_keep]"
+    click_button "Save Changes"
+  end
+
+  it "creates the group flag" do
+    feature.reload.users_group_flags.should be_empty
+  end
+end

data/spec/features/home_page_spec.rb

@@ -0,0 +1,11 @@
+require "spec_helper"
+
+describe "the home page" do
+  before do
+    visit "/detour"
+  end
+
+  it "displays the name of the gem" do
+    page.should have_content "Detour"
+  end
+end

data/spec/features/opt_out_flags_spec.rb

@@ -0,0 +1,105 @@
+require "spec_helper"
+
+describe "counting opt out flags" do
+  let!(:flag) { create :opt_out_flag }
+
+  before do
+    visit "/detour/flags/users"
+  end
+
+  it "displays the defined groups" do
+    within "tr#feature_#{flag.feature.id} td.opt-out-count" do
+      page.should have_content 1
+    end
+  end
+end
+
+describe "creating opt-outs", js: true do
+  let(:user) { create :user }
+  let!(:feature) { create :feature }
+
+  before do
+    User.instance_variable_set "@detour_flaggable_find_by", :email
+    visit "/detour/opt-outs/#{feature.name}/users"
+    page.find("[data-target='#create-flaggable-flag']").click
+  end
+
+  context "when creating multiple opt-outs" do
+    let(:user2) { create :user, email: "another_user@example.com" }
+
+    context "when successful" do
+      before do
+        fill_in "ids", with: [user.email, user2.email].join(",")
+        click_button "Create Opt-out"
+      end
+
+      it "displays a success message" do
+        page.should have_content "Users #{user.email}, #{user2.email} have been opted out of #{feature.name}"
+      end
+    end
+
+    context "when unsuccessful" do
+      before do
+        fill_in "ids", with: "#{user.email},foo"
+        click_button "Create Opt-out"
+      end
+
+      it "displays error messages" do
+        page.should have_content "Couldn't find User with email = foo"
+      end
+    end
+  end
+
+  context "when creating single opt-outs" do
+    context "when successful" do
+      before do
+        fill_in "ids", with: user.email
+        click_button "Create Opt-out"
+      end
+
+      it "displays a success message" do
+        page.should have_content "User #{user.email} has been opted out of #{feature.name}"
+      end
+
+      it "renders the new opt-out" do
+        within "table" do
+          page.should have_content user.email
+        end
+      end
+    end
+
+    context "when unsuccessful" do
+      before do
+        fill_in "ids", with: "foo"
+        click_button "Create Opt-out"
+      end
+
+      it "displays error messages" do
+        page.should have_content "Couldn't find User with email = foo"
+      end
+    end
+  end
+end
+
+describe "destroying opt-outs", js: true do
+  let!(:flag) { create :opt_out_flag }
+
+  before do
+    visit "/detour/opt-outs/#{flag.feature.name}/users"
+    page.find(".delete-flag").click
+    click_link "Delete Opt-out"
+  end
+
+  it "displays a flash message" do
+    page.should have_content "#{flag.feature.name} opt-out for User #{flag.flaggable.send flag.flaggable_type.constantize.detour_flaggable_find_by} has been deleted."
+  end
+
+  it "destroys the opt-out" do
+    expect { flag.reload }.to raise_error ActiveRecord::RecordNotFound
+  end
+
+
+  it "removes the flag from the list" do
+    page.should_not have_content flag.flaggable.email
+  end
+end

data/spec/features/percentage_flags_spec.rb

@@ -0,0 +1,63 @@
+require "spec_helper"
+
+describe "listing percentage flags for a type" do
+  let(:feature)          { create :feature }
+  let!(:percentage_flag) { create :percentage_flag, feature: feature }
+
+  before do
+    visit "/detour/flags/users"
+  end
+
+  it "displays the percentage flag for the feature" do
+    page.find("#features_#{feature.name}_users_percentage_flag_attributes_percentage").value.to_i.should eq percentage_flag.percentage
+  end
+end
+
+describe "creating a percentage flag" do
+  let!(:feature) { create :feature }
+
+  before do
+    visit "/detour/flags/users"
+  end
+
+  context "when successful" do
+    before do
+      fill_in "features[#{feature.name}][users_percentage_flag_attributes][percentage]", with: "50"
+      click_button "Save Changes"
+    end
+
+    it "saves the new feature" do
+      feature.users_percentage_flag.percentage.should eq 50
+    end
+
+    it "displays a success message" do
+      page.should have_content "Your flags have been successfully updated."
+    end
+  end
+
+  context "when unsuccessful" do
+    before do
+      fill_in "features[#{feature.name}][users_percentage_flag_attributes][percentage]", with: "foo"
+      click_button "Save Changes"
+    end
+
+    it "displays error messages" do
+      page.should have_content "#{feature.name}: Users percentage flag percentage is not a number"
+    end
+  end
+end
+
+describe "destroying a percentage flag" do
+  let(:feature)          { create :feature }
+  let!(:percentage_flag) { create :percentage_flag, feature: feature }
+
+  before do
+    visit "/detour/flags/users"
+    fill_in "features[#{feature.name}][users_percentage_flag_attributes][percentage]", with: ""
+    click_button "Save Changes"
+  end
+
+  it "destroys the percentage flag" do
+    feature.users_percentage_flag.should be_nil
+  end
+end

data/spec/integration/group_rollout_spec.rb

@@ -7,7 +7,7 @@ describe "group rollouts" do
 
   describe "creating a group rollout" do
     before do
-      Detour::Feature.define_user_group "foo_users" do |user|
+      Detour.config.define_user_group "foo_users" do |user|
         user.name == "foo"
       end
     end

data/spec/lib/detour/acts_as_flaggable_spec.rb

@@ -0,0 +1,45 @@
+require "spec_helper"
+
+describe Detour::ActsAsFlaggable do
+  subject { User.new }
+
+  it { should have_many :flag_in_flags }
+  it { should have_many :opt_out_flags }
+  it { should have_many(:features).through(:flag_in_flags) }
+
+  it "includes Detour::Flaggable" do
+    subject.class.ancestors.should include Detour::Flaggable
+  end
+
+  describe "#acts_as_flaggable" do
+    describe "Detour::Feature associations" do
+      subject { Detour::Feature.new }
+      it { should have_many(:users_group_flags).class_name("Detour::GroupFlag").dependent(:destroy) }
+      it { should allow_mass_assignment_of(:users_group_flags_attributes) }
+      it { should accept_nested_attributes_for(:users_group_flags) }
+
+      it { should have_one(:users_percentage_flag).class_name("Detour::PercentageFlag").dependent(:destroy) }
+      it { should allow_mass_assignment_of(:users_percentage_flag_attributes) }
+      it { should accept_nested_attributes_for(:users_percentage_flag) }
+
+      it { should have_many(:users_flag_ins).class_name("Detour::FlagInFlag").dependent(:destroy) }
+      it { should have_many(:users_opt_outs).class_name("Detour::OptOutFlag").dependent(:destroy) }
+    end
+
+    context "when given a :find_by parameter" do
+      class Foo < ActiveRecord::Base
+        acts_as_flaggable find_by: :email
+      end
+
+      it "sets the appropriate class variable on the class" do
+        Foo.instance_variable_get("@detour_flaggable_find_by").should eq :email
+      end
+    end
+
+    context "when not given a :find_by parameter" do
+      it "uses the default :id value for flaggable_find_by" do
+        User.instance_variable_get("@detour_flaggable_find_by").should eq :id
+      end
+    end
+  end
+end

data/spec/lib/detour/configuration_spec.rb

@@ -0,0 +1,23 @@
+require "spec_helper"
+
+describe Detour::Configuration do
+  describe ".define_group_for_class" do
+    let(:block) { Proc.new {} }
+
+    before do
+      subject.send :define_group_for_class, "User", "user_id_1", &block
+    end
+
+    it "defines a group for the given class" do
+      subject.defined_groups["User"].should eq({ "user_id_1" => block })
+    end
+  end
+
+  describe ".define_{klass}_group" do
+    let(:block) { Proc.new {} }
+    it "defines a group for the given class" do
+      subject.should_receive(:define_group_for_class).with("User", :id_is_1)
+      subject.define_user_group :id_is_1, block
+    end
+  end
+end

data/spec/lib/detour/flag_form_spec.rb

@@ -0,0 +1,84 @@
+require "spec_helper"
+
+describe Detour::FlagForm do
+  subject { Detour::FlagForm.new("users") }
+
+  let!(:feature) { create :feature, name: "foo_feature" }
+
+  describe "#features" do
+    before do
+      Detour.config.grep_dirs = ["spec/dummy/app/**/*.{rb,erb}"]
+    end
+
+    it "returns every feature including lines" do
+      subject.features.collect(&:name).should eq Detour::Feature.with_lines.collect(&:name)
+    end
+  end
+
+  describe "#group_names" do
+    before do
+      Detour.config.define_user_group :admins do |user|
+      end
+    end
+
+    it "returns the name of defined groups" do
+      subject.group_names.should eq ["admins"]
+    end
+  end
+
+  describe "#update_attributes" do
+    let(:features_params) do
+      {
+        "foo_feature" => { users_percentage_flag_attributes: {} }
+      }
+    end
+
+    it "updates the feature attributes" do
+      Detour::Feature.any_instance.should_receive :assign_attributes
+      Detour::Feature.any_instance.stub(:changed_for_autosave?) { true }
+      Detour::Feature.any_instance.should_receive :save
+      subject.update_attributes({ features: features_params })
+    end
+
+    context "when successful" do
+      it "returns true" do
+        subject.update_attributes({ features: features_params }).should be_true
+      end
+    end
+
+    context "when unsuccessful" do
+      it "returns nil" do
+        subject.update_attributes({ features: { "foo_feature" => { users_percentage_flag_attributes: { percentage: "foo" } } } }).should be_nil
+      end
+
+      it "uses a transaction" do
+        feature2 = create :feature, name: "foo_feature_2"
+
+        subject.update_attributes({ features: {
+          "foo_feature_2" => { users_percentage_flag_attributes: { percentage: 10 } },
+          "foo_feature" => { users_percentage_flag_attributes: { percentage: "foo" } }
+        } })
+
+        feature2.users_percentage_flag.should be_nil
+      end
+    end
+
+    context "when a percentage flag should be removed" do
+      let!(:percentage_flag) { create :percentage_flag, feature: feature }
+
+      let(:features_params) do
+        {
+          "foo_feature" => { users_percentage_flag_attributes: { percentage: "" } },
+        }
+      end
+
+      before do
+        subject.update_attributes({ features: features_params });
+      end
+
+      it "destroys the percentage flag" do
+        feature.reload.users_percentage_flag.should be_nil
+      end
+    end
+  end
+end

data/spec/lib/{active_record/rollout → detour}/flaggable_spec.rb

@@ -24,29 +24,29 @@ describe Detour::Flaggable do
   end
 
   describe "#has_feature?" do
-    let(:user) { User.create(name: "foo") }
-    let(:feature) { Detour::Feature.create(name: "bar") }
+    let(:user)    { create :user }
+    let(:feature) { create :feature }
 
     it "memoizes found features" do
       Detour::Feature.stub(:find_by_name) { feature }
-      feature.flaggable_flags.create(flaggable: user)
+      feature.flag_in_flags.create(flaggable: user)
 
       feature.should_receive(:match?).with(user).and_return(true)
-      user.has_feature?(:bar)
+      user.has_feature?(feature.name)
 
       feature.should_not_receive(:match?).with(user)
-      user.has_feature?(:bar)
+      user.has_feature?(feature.name)
     end
 
     context "when given a block" do
       context "and the user is flagged in" do
         before do
-          feature.flaggable_flags.create(flaggable: user)
+          feature.flag_in_flags.create(flaggable: user)
         end
 
         it "calls the block" do
           foo = "foo"
-          user.has_feature?(:bar) { foo = "bar" }
+          user.has_feature?(feature.name) { foo = "bar" }
           foo.should eq "bar"
         end
 
@@ -64,7 +64,7 @@ describe Detour::Flaggable do
         context "when the block raises an exception" do
           it "increments the failure_count of the feature" do
             begin
-              user.has_feature? :bar do
+              user.has_feature? feature.name do
                 raise "This is an exception"
               end
             rescue
@@ -74,7 +74,7 @@ describe Detour::Flaggable do
 
           it "raises the exception" do
             expect do
-              user.has_feature? :bar do
+              user.has_feature? feature.name do
                 raise "This is an exception"
               end
             end.to raise_error "This is an exception"
@@ -85,7 +85,7 @@ describe Detour::Flaggable do
       context "and the user is not flagged in" do
         it "does not call the block" do
           foo = "foo"
-          user.has_feature?(:bar) { foo = "bar" }
+          user.has_feature?(feature.name) { foo = "bar" }
           foo.should eq "foo"
         end
       end
@@ -93,30 +93,30 @@ describe Detour::Flaggable do
 
     context "when the user is not flagged in" do
       it "returns false" do
-        user.has_feature?(:bar).should be_false
+        user.has_feature?(feature.name).should be_false
       end
     end
 
     context "when the user is flagged in" do
       context "and the user is opted out" do
         before do
-          feature.flaggable_flags.create(flaggable: user)
+          feature.flag_in_flags.create(flaggable: user)
           feature.opt_out_flags.create(flaggable: user)
         end
 
         it "returns false" do
-          user.has_feature?(:bar).should be_false
+          user.has_feature?(feature.name).should be_false
         end
       end
 
       context "and the user is not opted out" do
         context "and the user is flagged in individually" do
           before do
-            feature.flaggable_flags.create(flaggable: user)
+            feature.flag_in_flags.create(flaggable: user)
           end
 
           it "returns true" do
-            user.has_feature?(:bar).should be_true
+            user.has_feature?(feature.name).should be_true
           end
         end
 
@@ -126,21 +126,21 @@ describe Detour::Flaggable do
           end
 
           it "returns true" do
-            user.has_feature?(:bar).should be_true
+            user.has_feature?(feature.name).should be_true
           end
         end
 
         context "and the user is flagged in via a group" do
           before do
-            Detour::Feature.define_user_group "name_foo" do |user|
-              user.name == "foo"
+            Detour.config.define_user_group "name_foo" do |_user|
+              _user.name == user.name
             end
 
             feature.group_flags.create(flaggable_type: "User", group_name: "name_foo")
           end
 
           it "returns true" do
-            user.has_feature?(:bar).should be_true
+            user.has_feature?(feature.name).should be_true
           end
         end
       end