determinator 2.9.1 → 2.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 227a75590dfa088f7096c65a51ab2d2950f9605ed3f29c7d62119df86e2c3721
-  data.tar.gz: 77c7e9ae41428c7e898f3dca7464d6987210379723bd8bc73906a8c73cbd62d2
+  metadata.gz: '009b70756437db9c6dc88091752e870588fe171bc729d7ec16cfcddb8e8033e2'
+  data.tar.gz: ac042540a864bc4af7fffd016b4e0d6a94243e1c764d6770c71b818a516d77fc
 SHA512:
-  metadata.gz: 59fcec1ac83528e76f9ccdfb5985732d336fc6bb177055a4d5c02a4929f20c98b1a6052c96fa3397430c40d40733b4b8fb2fb801db041a3a125db64bd68276cf
-  data.tar.gz: dc73504e3e55e79d10a0939e3a32f16525523b8e480da280aae2a0400b578b3e04cb893ef593967767ffab88370ef118310d37b7df906cc48ea547dcb8570e91
+  metadata.gz: c1a7f55c7e672d7e647b23ed79ba84af1fdeeb761460d8126742564d395ad541b53cd050c1bbf232933ddfca3f8eb9b6124c21d3f661c7b1cc37d1ba8d383c42
+  data.tar.gz: 9a70fe0809c9309cb330571fef09511debcbf951d9cf73ab2eae8ec22001adc4eaba3f8d684b1ed7e8943454c350196471914e9d10d20781b4c647616d6ba918

data/CHANGELOG.md

@@ -1,3 +1,14 @@
+# 2.9.3
+
+Feature:
+- Add optional `feature` argument to `feature_flag_on?` and `which_variant` methods of ActorControl, to reuse an existing feature.
+- Add mutex to synchronise access to caches in Cache::FetchWrapper.
+
+# 2.9.2
+
+Bug fix:
+- Fix parsing fixed determinations when the variant is an empty string
+
 # 2.9.1
 
 Feature:

data/Gemfile

@@ -2,3 +2,5 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in determinator.gemspec
 gemspec
+
+gem 'byebug'

data/lib/determinator/actor_control.rb

@@ -14,22 +14,24 @@ module Determinator
     end
 
     # @see Determinator::Control#which_variant
-    def which_variant(name, properties: {})
+    def which_variant(name, properties: {}, feature: nil)
       controller.which_variant(
         name,
         id: id,
         guid: guid,
-        properties: default_properties.merge(properties)
+        properties: default_properties.merge(properties),
+        feature: feature
       )
     end
 
     # @see Determinator::Control#feature_flag_on?
-    def feature_flag_on?(name, properties: {})
+    def feature_flag_on?(name, properties: {}, feature: nil)
       controller.feature_flag_on?(
         name,
         id: id,
         guid: guid,
-        properties: default_properties.merge(properties)
+        properties: default_properties.merge(properties),
+        feature: feature
       )
     end
 

data/lib/determinator/cache/fetch_wrapper.rb

@@ -7,12 +7,16 @@ module Determinator
       def initialize(*caches, cache_missing: true)
         @cache_missing = cache_missing
         @caches = caches
+        @mutex = Mutex.new
       end
 
       # Call walks through each cache, returning a value if the item exists in
       # any cache, otherwise popularing each cache with the value of yield.
       def call(feature_name)
-        value = read_and_upfill(feature_name)
+        value =
+          @mutex.synchronize do
+            read_and_upfill(feature_name)
+          end
 
         # if the value is missing and we cache it, return the missing response
         return value if value.is_a?(MissingResponse) && @cache_missing
@@ -22,14 +26,20 @@ module Determinator
 
         value_to_write = yield
         return value_to_write if value_to_write.is_a?(ErrorResponse)
-        @caches.each do |cache|
-          cache.write(key(feature_name), value_to_write)
+
+        @mutex.synchronize do
+          @caches.each do |cache|
+            cache.write(key(feature_name), value_to_write)
+          end
         end
+
         return value_to_write
       end
 
       def expire(feature_name)
-        @caches.each{ |c| c.delete(key(feature_name)) }
+        @mutex.synchronize do
+          @caches.each{ |c| c.delete(key(feature_name)) }
+        end
       end
 
       private
@@ -52,9 +62,11 @@ module Determinator
             @caches[0...index].each do |cache|
               cache.write(key(feature_name), value)
             end
+
             return value
           end
         end
+
         return nil
       end
     end

data/lib/determinator/feature.rb

@@ -100,10 +100,10 @@ module Determinator
       return fixed_determination if fixed_determination.is_a? FixedDetermination
 
       variant = fixed_determination['variant']
-      return nil if variant && !variants.keys.include?(variant)
+      return nil if variant.present? && !variants.keys.include?(variant)
 
       # if a variant is present the fixed determination should always be on
-      return nil if variant && !fixed_determination['feature_on']
+      return nil if variant.present? && !fixed_determination['feature_on']
 
       constraints = fixed_determination['constraints'].to_h
 

data/lib/determinator/version.rb

@@ -1,3 +1,3 @@
 module Determinator
-  VERSION = '2.9.1'
+  VERSION = '2.9.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: determinator
 version: !ruby/object:Gem::Version
-  version: 2.9.1
+  version: 2.9.3
 platform: ruby
 authors:
 - JP Hastings-Spital
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-07-21 00:00:00.000000000 Z
+date: 2023-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -251,7 +251,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3.1
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: Determine which experiments and features a specific actor should see.