determinator 2.8.0 → 2.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9dcdd00664fa1b47134a36911b0d0319c98d8fdb3c012b54342f97a160f63424
-  data.tar.gz: b85ac99ae90d9e5b5fd009227f2f07f39dea8ce8a3ba6854cb7cd524850c785a
+  metadata.gz: 14629ea70bc6ef083ef707b43a00dcf3b5cb1e8234ad91c202efd5a70b1e6dac
+  data.tar.gz: a7b8af30577d40b93c948e0ff726ac12236fee899ae5be8f9b165e1e934a93d0
 SHA512:
-  metadata.gz: 845d3d1f0b96da3835a3ca7aec37dbdbaeac4a10d574277111f1642ccb55ff4b86abd420363a943f430efad68071bc34720d9fd03ba35cbcd12fd62332cb392b
-  data.tar.gz: bf1f7889514902a82c72db708d030e789228abbc5237c94c3869d19bf5cee8a8888527d49f220c3f2d0afc12ce8d726dfaf9f00070f4bbc64c080bc79d155fd6
+  metadata.gz: 4daeb35cd313579c5916e1a88300062e99b4185d6dab9fa5e825e1de56d65d8d2028ba37d22da398b730103f9d6f7ca3725d331b42b90e204d2c016eacce43ae
+  data.tar.gz: 6fc1b952241c2a8d58a94cdc0fe5f7c9255d41ed1e1228f5b35da4a16bebd94539388b1b1f4b0f7bec4ec17f1e17569006443e0ba787df5d9a54e822db68759e

data/CHANGELOG.md

@@ -1,3 +1,18 @@
+# 2.9.2
+
+Bug fix:
+- Fix parsing fixed determinations when the variant is an empty string
+
+# 2.9.1
+
+Feature:
+- Add `callback` argument to Control, allowing custom logic to notice the determination.
+
+# 2.9.0
+
+Feature:
+- When an app_version does not comply with semantic versioning specifications (e.g.: 2021.11.05 with a trailing zero instead of the correct 2021.11.5), return false.
+
 # 2.8.0
 
 Feature:

data/lib/determinator/control.rb

@@ -72,6 +72,20 @@ module Determinator
       '#<Determinator::Control>'
     end
 
+    # Defines code that should execute when a determination is completed. This is particularly
+    # helpful for comparing determinations made by this control with other mechanisms.
+    #
+    # Please note that this block will be executed _synchronously_ before delivering the determination to the callsite.
+    #
+    # @yield [name, arguments, determination] Will be called when a determination was requested for the
+    #   specified feature with `name`, with the given keyword arguments.
+    # @yieldparam name [String, nil] The name of the feature
+    # @yieldparam args [Hash] The keyword arguments passed to the determination method. This includes :id, :guid, :properties.
+    # @yieldparam determination [String,Boolean] The result of the determination
+    def on_determination(&block)
+      @determination_callback = block
+    end
+
     private
 
     Indicators = Struct.new(:rollout, :variant)
@@ -81,12 +95,15 @@ module Determinator
 
       if feature.nil? || feature.is_a?(ErrorResponse) || feature.is_a?(MissingResponse)
         Determinator.notice_missing_feature(name)
+        run_determination_callback(name, {id: id, guid: guid, properties: properties}, false)
         return false
       end
 
-      determinate(feature, id: id, guid: guid, properties: properties).tap do |determination|
+      result = determinate(feature, id: id, guid: guid, properties: properties).tap do |determination|
         Determinator.notice_determination(id, guid, feature, determination)
       end
+      run_determination_callback(name, {id: id, guid: guid, properties: properties}, result)
+      result
     end
 
     def determinate(feature, id:, guid:, properties:)
@@ -241,7 +258,9 @@ module Determinator
         !v.match?(Semantic::Version::SemVerRegexp)
       end
       invalid_groups = required.flatten.select do |v|
-        !v.match?(/\d/)
+        version_sections = v.split(/(\d(.+)?)/, 2)
+        without_operator = version_sections[1]&.strip || ''
+        !without_operator.match?(Semantic::Version::SemVerRegexp)
       end
 
       return false if (invalid_properties + invalid_groups).any?
@@ -318,5 +337,10 @@ module Determinator
         hash[name.to_s] = [*values].map(&:to_s)
       end
     end
+
+    def run_determination_callback(name, args, determination)
+      return unless @determination_callback
+      @determination_callback.call(name, args, determination)
+    end
   end
 end

data/lib/determinator/feature.rb

@@ -100,10 +100,10 @@ module Determinator
       return fixed_determination if fixed_determination.is_a? FixedDetermination
 
       variant = fixed_determination['variant']
-      return nil if variant && !variants.keys.include?(variant)
+      return nil if variant.present? && !variants.keys.include?(variant)
 
       # if a variant is present the fixed determination should always be on
-      return nil if variant && !fixed_determination['feature_on']
+      return nil if variant.present? && !fixed_determination['feature_on']
 
       constraints = fixed_determination['constraints'].to_h
 

data/lib/determinator/version.rb

@@ -1,3 +1,3 @@
 module Determinator
-  VERSION = '2.8.0'
+  VERSION = '2.9.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: determinator
 version: !ruby/object:Gem::Version
-  version: 2.8.0
+  version: 2.9.2
 platform: ruby
 authors:
 - JP Hastings-Spital
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-01-25 00:00:00.000000000 Z
+date: 2022-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday