determinator 2.7.1 → 2.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 54342b4c971ac191030bf2aa264c419e0afc3f8dc1b2558f140ad99b021dbb7c
-  data.tar.gz: '049f2d041afbaa2556f08f636c6ff43397f0625c910a2a05ee95b57875882d14'
+  metadata.gz: 227a75590dfa088f7096c65a51ab2d2950f9605ed3f29c7d62119df86e2c3721
+  data.tar.gz: 77c7e9ae41428c7e898f3dca7464d6987210379723bd8bc73906a8c73cbd62d2
 SHA512:
-  metadata.gz: 381afb82fb6f1e0085aaa20ad681562f2ced69c4196bee3d3ac7fb96e186df748a73f462d73711a0e36e520031ca20d91c7a5ec7d9b61d13d8bf76464629a51c
-  data.tar.gz: e6676ae384f5d61b2af9f5f248e55d88ffd6dff680672e353cab4d380d2564f5c9947ad59f0e483e3ffbe30de6e7cbba029ba8ead4feb660f874d93867c24eae
+  metadata.gz: 59fcec1ac83528e76f9ccdfb5985732d336fc6bb177055a4d5c02a4929f20c98b1a6052c96fa3397430c40d40733b4b8fb2fb801db041a3a125db64bd68276cf
+  data.tar.gz: dc73504e3e55e79d10a0939e3a32f16525523b8e480da280aae2a0400b578b3e04cb893ef593967767ffab88370ef118310d37b7df906cc48ea547dcb8570e91

data/CHANGELOG.md

@@ -1,3 +1,18 @@
+# 2.9.1
+
+Feature:
+- Add `callback` argument to Control, allowing custom logic to notice the determination.
+
+# 2.9.0
+
+Feature:
+- When an app_version does not comply with semantic versioning specifications (e.g.: 2021.11.05 with a trailing zero instead of the correct 2021.11.5), return false.
+
+# 2.8.0
+
+Feature:
+- When a GUID bucketed feature is misconfigured, handle the error and return false.
+
 # 2.7.1
 
 Feature:

data/lib/determinator/control.rb

@@ -72,6 +72,20 @@ module Determinator
       '#<Determinator::Control>'
     end
 
+    # Defines code that should execute when a determination is completed. This is particularly
+    # helpful for comparing determinations made by this control with other mechanisms.
+    #
+    # Please note that this block will be executed _synchronously_ before delivering the determination to the callsite.
+    #
+    # @yield [name, arguments, determination] Will be called when a determination was requested for the
+    #   specified feature with `name`, with the given keyword arguments.
+    # @yieldparam name [String, nil] The name of the feature
+    # @yieldparam args [Hash] The keyword arguments passed to the determination method. This includes :id, :guid, :properties.
+    # @yieldparam determination [String,Boolean] The result of the determination
+    def on_determination(&block)
+      @determination_callback = block
+    end
+
     private
 
     Indicators = Struct.new(:rollout, :variant)
@@ -81,12 +95,15 @@ module Determinator
 
       if feature.nil? || feature.is_a?(ErrorResponse) || feature.is_a?(MissingResponse)
         Determinator.notice_missing_feature(name)
+        run_determination_callback(name, {id: id, guid: guid, properties: properties}, false)
         return false
       end
 
-      determinate(feature, id: id, guid: guid, properties: properties).tap do |determination|
+      result = determinate(feature, id: id, guid: guid, properties: properties).tap do |determination|
         Determinator.notice_determination(id, guid, feature, determination)
       end
+      run_determination_callback(name, {id: id, guid: guid, properties: properties}, result)
+      result
     end
 
     def determinate(feature, id:, guid:, properties:)
@@ -124,13 +141,9 @@ module Determinator
       # require_variant_determination?
       return true unless require_variant_determination?(feature)
 
-
-
       explainer.log(:chosen_variant) {
         variant_for(feature, indicators.variant)
       }
-    rescue ArgumentError
-      raise
 
     rescue => e
       Determinator.notice_error(e)
@@ -245,7 +258,9 @@ module Determinator
         !v.match?(Semantic::Version::SemVerRegexp)
       end
       invalid_groups = required.flatten.select do |v|
-        !v.match?(/\d/)
+        version_sections = v.split(/(\d(.+)?)/, 2)
+        without_operator = version_sections[1]&.strip || ''
+        !without_operator.match?(Semantic::Version::SemVerRegexp)
       end
 
       return false if (invalid_properties + invalid_groups).any?
@@ -322,5 +337,10 @@ module Determinator
         hash[name.to_s] = [*values].map(&:to_s)
       end
     end
+
+    def run_determination_callback(name, args, determination)
+      return unless @determination_callback
+      @determination_callback.call(name, args, determination)
+    end
   end
 end

data/lib/determinator/version.rb

@@ -1,3 +1,3 @@
 module Determinator
-  VERSION = '2.7.1'
+  VERSION = '2.9.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: determinator
 version: !ruby/object:Gem::Version
-  version: 2.7.1
+  version: 2.9.1
 platform: ruby
 authors:
 - JP Hastings-Spital
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-12-13 00:00:00.000000000 Z
+date: 2022-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday