determinator 2.5.4 → 2.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7e5cd27cbcca013e18d0a941c9a196e9b8e7e908a97d67b857514f58d35def5d
-  data.tar.gz: 18c86d3448b136bb996702d0bbcdba97f5280f496bd580daf145013b2dd054f8
+  metadata.gz: 9fe6fd684f160e1d955e9528bd225942068320361d554102b63667125503e610
+  data.tar.gz: f70731d2a63bffa170ee0d545fa9efbc2271fc32995c6635fc4feea33ac38c65
 SHA512:
-  metadata.gz: f892fed72664d8dd47fb50d710678ff33ebe274f25fa8885ab048a13a7b3db5e496b7e39d67ce1fcea14c805bfaa390cc905241fb6e3e63405687d0ea2fe8355
-  data.tar.gz: a9c104b252ba508445957ee1f249f39ace127f294104693153e96afae9f3903c7dcf497ead2d1b255b1ff429fde9340db37551d82ecee6888576bae01eea6395
+  metadata.gz: 0debe679036a419091917171e90ce4360ec0ea8afdc3d2b0d536b1796cd93b2ffe1fe3b6dc933cfe03642be61bde94c12b471a6aca2d7a04c087f24e6b6b8e94
+  data.tar.gz: 423c16ff61e48e2da9e8883329b70a031819be4741b2f9031fe0cd6c1681e0df43d52f98028b5002a6e6ad82f6774aa24fed5ddf227b56a8d75bb59e3a81ccde

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# 2.6.0
+
+Interface change:
+- A `feature_cache` is now required to use Determinator. See the `examples/determinator-rails/config/initializers/determinator.rb` for a quick start.
+
 # 2.5.4
 
 Bug fix:

data/lib/determinator.rb

@@ -15,13 +15,13 @@ module Determinator
   class << self
     attr_reader :feature_cache, :retrieval
     # @param :retrieval [Determinator::Retrieve::Routemaster] A retrieval instance for Features
+    # @param :feature_cache [#call] a caching proc, accepting a feature name, which will return the named feature or yield (and store) if not available
     # @param :errors [#call, nil] a proc, accepting an error, which will be called with any errors which occur while determinating
     # @param :missing_feature [#call, nil] a proc, accepting a feature name, which will be called any time a feature is requested but isn't available
-    # @param :feature_cache [#call, nil] a caching proc, accepting a feature name, which will return the named feature or yield (and store) if not available
-    def configure(retrieval:, errors: nil, missing_feature: nil, feature_cache: nil)
+    def configure(retrieval:, feature_cache:, errors: nil, missing_feature: nil)
       self.on_error(&errors) if errors
       self.on_missing_feature(&missing_feature) if missing_feature
-      @feature_cache = feature_cache if feature_cache.respond_to?(:call)
+      @feature_cache = feature_cache
       @retrieval = retrieval
       @instance = Control.new(retrieval: retrieval)
     end

data/lib/determinator/version.rb

@@ -1,3 +1,3 @@
 module Determinator
-  VERSION = '2.5.4'
+  VERSION = '2.6.0'
 end

data/lib/rspec/determinator.rb

@@ -3,6 +3,9 @@ require_relative '../determinator/retrieve/in_memory_retriever'
 
 module RSpec
   module Determinator
+
+    DO_NOT_USE_IN_PRODUCTION_CODE_NULL_FEATURE_CACHE = -> (name, &block) { block.call(name) }
+
     def self.included(by)
       by.extend(DSL)
 
@@ -12,10 +15,10 @@ module RSpec
         old_retriever = ::Determinator.instance.retrieval
         begin
           fake_retriever.clear!
-          ::Determinator.configure(retrieval: fake_retriever)
+          ::Determinator.configure(retrieval: fake_retriever, feature_cache: DO_NOT_USE_IN_PRODUCTION_CODE_NULL_FEATURE_CACHE)
           example.run
         ensure
-          ::Determinator.configure(retrieval: old_retriever)
+          ::Determinator.configure(retrieval: old_retriever, feature_cache: DO_NOT_USE_IN_PRODUCTION_CODE_NULL_FEATURE_CACHE)
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: determinator
 version: !ruby/object:Gem::Version
-  version: 2.5.4
+  version: 2.6.0
 platform: ruby
 authors:
 - JP Hastings-Spital
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-07-15 00:00:00.000000000 Z
+date: 2021-01-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -150,7 +150,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description:
 email:
 - jp@deliveroo.co.uk
 executables: []
@@ -234,7 +234,7 @@ homepage: https://github.com/deliveroo/determinator
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -250,7 +250,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.0.3
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Determine which experiments and features a specific actor should see.
 test_files: []