determinator 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3b01c8573e10fbc219e4cd44c85696a8c34f4283
-  data.tar.gz: f7a43c6e60f22ef9947fbe04e5313db4b28982c8
+  metadata.gz: 532bf3e49ff1811ae99eb4e9655c1ab8c3f4ec9b
+  data.tar.gz: 69a37c14086d2a79fad647ad9a7924a35f3b6050
 SHA512:
-  metadata.gz: 66c567515540a0cc5adc1b9978b2a33b57d7f66135a0d6413847bccc68ee69d7a0954979333dda96bad701eba3879b1ac9e4c38785f18a4bf5c9ddc0f51ac668
-  data.tar.gz: 3329ee1b0ea3c1f59dc010675e2e2f89173dfc7c346b06ccb4248cb67e8c29b1ff13041a969f0400911a41fa93e0656b921ec5c9d9984e7d44f4634cec2c1a59
+  metadata.gz: 486f995cedb81e7053aa5baecc54861bfc3153a382c0614d1917652f9c785e720804a031027494759d0a817b292581c1c3f20b369d5385212cce676298802a66
+  data.tar.gz: c5325f6116a94d4f2e0af17d814a1cb7ca72bf3d3ac0fe72ecd4c7c9a31a58f84247e36e9af52225de670afb03824ce2a8c1d653eb86cde070b6a21b712c7cdc

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+# v1.1.0 (2018-02-07)
+
+⚠️ This release includes breaking changes to `RSpec::Determinator` ⚠️
+
+Breaking change:
+- If two `forced_determination`s are made within one rspec test case, it is now the _last_ one that takes precedence (not the first). (#47)
+
+Bug fix:
+- `forced_determination`s which are called with differently typed parameters (eg. integer vs. string, boolean vs. string) will now work in the same way that real determination will. (#47)
+
 # v1.0.0 (2018-02-05)
 
 ⚠️ This release includes breaking changes ⚠️

data/README.md

@@ -179,10 +179,21 @@ RSpec.describe "something", :determinator_support do
     forced_determination(:my_lazyexperiment, :some_lazy_variable)
     let(:some_lazy_variable) { 'variant_b' }
 
+    forced_determination(:my_targeted_feature_flag, true, only_for: { employee: true })
+    forced_determination(:my_targeted_feature_flag, false, only_for: { id: 12345 })
+
     it "uses forced_determination" do
-      expect(Determinator.instance.feature_flag_on?(:my_feature_flag)).to eq(true)
-      expect(Determinator.instance.which_variant(:my_experiment)).to eq("variant_a")
-      expect(Determinator.instance.which_variant(:my_lazy_experiment)).to eq("variant_b")
+      determinator = Determinator.for_actor(id: 1)
+
+      expect(determinator.feature_flag_on?(:my_feature_flag)).to be true
+      expect(determinator.which_variant(:my_experiment)).to eq("variant_a")
+      expect(determinator.which_variant(:my_lazy_experiment)).to eq("variant_b")
+
+      expect(determinator.feature_flag_on?(:my_targeted_feature_flag, properties: { employee: false })).to be false
+      expect(determinator.feature_flag_on?(:my_targeted_feature_flag, properties: { employee: true })).to be true
+
+      # The last forced determination takes precedence
+      expect(Determinator.instance.feature_flag_on?(:my_targeted_feature_flag, id: 12345, properties: { employee: true })).to be false
     end
   end
 end

data/examples/determinator-rails/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../..
   specs:
-    determinator (0.12.1)
+    determinator (1.0.0)
       routemaster-drain (~> 3.0)
 
 GEM
@@ -65,7 +65,7 @@ GEM
       multipart-post (>= 1.2, < 3)
     faraday_middleware (0.12.2)
       faraday (>= 0.7.4, < 1.0)
-    ffi (1.9.18)
+    ffi (1.9.21)
     globalid (0.3.7)
       activesupport (>= 4.1.0)
     hashie (3.5.7)

data/lib/determinator/version.rb

@@ -1,3 +1,3 @@
 module Determinator
-  VERSION = '1.0.0'
+  VERSION = '1.1.0'
 end

data/lib/rspec/determinator.rb

@@ -45,14 +45,14 @@ module RSpec
       end
 
       def mock_result(name, result, only_for: {})
-        @mocked_results[name.to_s][only_for] = result
+        @mocked_results[name.to_s][normalize_properties(only_for)] = result
       end
 
       def fake_determinate(name, id: nil, guid: nil, properties: {})
         properties[:id] = id if id
         properties[:guid] = guid if guid
 
-        outcome_for_feature_given_properties(name.to_s, properties)
+        outcome_for_feature_given_properties(name.to_s, normalize_properties(properties))
       end
       alias_method :feature_flag_on?, :fake_determinate
       alias_method :which_variant, :fake_determinate
@@ -62,11 +62,18 @@ module RSpec
       def outcome_for_feature_given_properties(feature_name, requirements)
         req_array = requirements.to_a
 
-        _, forced = @mocked_results[feature_name].find do |given, outcome|
+        keys_in_priority_order = @mocked_results[feature_name].keys.reverse
+        key = keys_in_priority_order.find do |given|
           (given.to_a - req_array).empty?
         end
 
-        forced || false
+        @mocked_results[feature_name][key] || false
+      end
+
+      def normalize_properties(properties)
+        properties.each_with_object({}) do |(key, value), hash|
+          hash[key.to_s] = [*value].map(&:to_s)
+        end
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: determinator
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - JP Hastings-Spital
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-02-05 00:00:00.000000000 Z
+date: 2018-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: routemaster-drain