determinator 0.9.1 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0a7faec5d84de6789a94db7db9ff1de4fe22f947
-  data.tar.gz: 7c6f139261beea20a8f5c64f5071582a2314e4f1
+  metadata.gz: ecd2a7d802e9ad2562fbdf9708ff34a84242b91e
+  data.tar.gz: 5b1918806a440a52f4c337286164b79376059fef
 SHA512:
-  metadata.gz: cda841470760af3175a63d5d6e4a464bce9b71f6c3df6953e140fbae31dd8b1c6cdeae89504e71ac66dab8298b364c0eab641cca6cc98e39ed915e626ac7dd06
-  data.tar.gz: e3a5d769418dc6be72b97df333f8feafbb662fcb78331381863c6cb21193ad5d4b67d68c1b2bf0f513b660347f0676ec02f122f674cd821d4b44c29886eb6a04
+  metadata.gz: f1a2cf800a27d2b5bf007d50507bc8a1394c596cc0563b4b73fa6cb5dabe3ea43f8558b64840df9baad51ed571c2837409f20aef17e3a5ac4c895264326bb56f
+  data.tar.gz: 64035bfedb2ed42cb72f27bf48cc09d875a1764f5ecec945f8a409a95c8aab09ac66893b0ef9432d4852689093ccc1c3d137e248285e00dfc27826d0479f4116

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# v0.10.0 (2017-09-15)
+
+Feature:
+- Determinator can now be configured to log errors with any external service (#32)
+
 # v0.9.1 (2017-09-14)
 
 Bug fix:

data/README.md

@@ -55,7 +55,8 @@ Determinator.configure(
   retrieval: Determinator::Retrieve::Routemaster.new(
     discovery_url: 'https://florence.dev/'
     retrieval_cache: ActiveSupport::Cache::MemoryStore.new(expires_in: 1.minute)
-  )
+  ),
+  errors: -> error { NewRelic::Agent.notice_error(error) }
 )
 ```
 

data/examples/determinator-rails/config/initializers/determinator.rb

@@ -5,4 +5,6 @@ Determinator.configure(
     discovery_url: 'https://florence.dev/'
     retrieval_cache: ActiveSupport::Cache::MemoryStore.new(expires_in: 1.minute)
   )
+  # The following would allow tracking of errors in NewRelic
+  # errors: -> error { NewRelic::Agent.notice_error(error) }
 )

data/lib/determinator.rb

@@ -6,7 +6,10 @@ require 'determinator/retrieve/routemaster'
 require 'determinator/retrieve/null_retriever'
 
 module Determinator
-  def self.configure(retrieval:)
+  # @param :retrieval [Determinator::Retrieve::Routemaster] A retrieval instance for Features
+  # @param :errors [Proc, nil] a proc, accepting an error, which will be called with any errors which occur while determinating
+  def self.configure(retrieval:, errors: nil)
+    @error_logger = errors if errors.respond_to?(:call)
     @instance = Control.new(retrieval: retrieval)
   end
 
@@ -14,4 +17,10 @@ module Determinator
     raise "No singleton Determinator instance defined" unless @instance
     @instance
   end
+
+  def self.notice_error(error)
+    return unless @error_logger
+
+    @error_logger.call(error)
+  end
 end

data/lib/determinator/retrieve/routemaster.rb

@@ -31,7 +31,8 @@ module Determinator
         cached_feature_lookup(feature_id) do
           @actor_service.feature.show(feature_id)
         end
-      rescue ::Routemaster::Errors::ResourceNotFound
+      rescue => e
+        Determinator.notice_error(e)
         nil
       end
 

data/lib/determinator/version.rb

@@ -1,3 +1,3 @@
 module Determinator
-  VERSION = '0.9.1'
+  VERSION = '0.10.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: determinator
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.10.0
 platform: ruby
 authors:
 - JP Hastings-Spital
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-09-14 00:00:00.000000000 Z
+date: 2017-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: routemaster-drain