despamilator 0.8 → 1.0

data/spec/despamilator_spec.rb

@@ -1,5 +1,3 @@
-require File.dirname(__FILE__) + '/spec_helper.rb'
-
 describe Despamilator do
   before :each do
     @dspam = Despamilator.new('this text is absolutely fine')

data/spec/filter_base_spec.rb

@@ -0,0 +1,30 @@
+require 'despamilator/filter_base'
+
+class UnimplementedFilter < Despamilator::FilterBase
+end
+
+describe Despamilator::FilterBase do
+  describe "abstract method" do
+
+    before do
+      @filter = UnimplementedFilter.new
+    end
+
+    [
+            ['name', 'No name defined for UnimplementedFilter'],
+            ['description', 'No description defined for UnimplementedFilter'],
+
+    ].each do |method, exception|
+
+      it "should throw an error when the child class has not implemented a '#{method}' method" do
+        -> {@filter.send(method)}.should raise_error(exception)
+      end
+
+    end
+
+    it "should throw an error when the child class has not implemented a 'parse' method" do
+      -> {@filter.parse('abc')}.should raise_error('No parse defined for UnimplementedFilter')
+    end
+
+  end
+end

data/spec/filters/funky_consonant_spec.rb

@@ -1,39 +1,9 @@
-require File.dirname(__FILE__) + '/../spec_helper.rb'
+describe DespamilatorFilter::FunkyConsonant do
+  the_name_should_be 'Funky Consonant'
+  the_description_should_be 'Detects and scores each occurrence of a consonant next to an unlikely character'
 
-describe "FunkyConsonant" do
-  it "should return a score for 1 misplaced z" do
-    dspam = Despamilator.new('zt')
-    dspam.score.should == 0.05
-  end
+  despamilator_should_apply_the_filter_for('zt')  
 
-  describe 'attributes' do
-    before :each do
-      @filter = Despamilator.new('vtjk').matched_by.first
-    end
-
-    it "should have a filename" do
-      @filter.filename.should == 'funky_consonant.rb'
-    end
-
-    it "should have a name" do
-      @filter.name.should == 'Funky Consonant'
-    end
-
-    it "should have a description" do
-      @filter.description.should == 'Detects and scores each occurrence of a consonant next to an unlikely character'
-    end
-
-    it "should have a number of matches" do
-      @filter.matches.should == 2
-    end
-
-    it "should have a score" do
-      @filter.score.should == 0.1
-    end
-  end
-
-  it "should score more for 3 misplaced q's" do
-    dspam = Despamilator.new('ztgb')
-    dspam.score.to_s.should == 0.1.to_s
-  end
+  a_single_match_of('zt', should_score: 0.05)
+  a_multiple_match_of('ztzt', should_score: [0.1, 2.times])
 end

data/spec/filters/html_tags_spec.rb

@@ -1,147 +1,129 @@
-require File.dirname(__FILE__) + '/../spec_helper.rb'
+describe DespamilatorFilter::HtmlTags do
 
-context "HtmlTags" do
-  describe "filtering" do
-    [
-            '!--',
-            '!DOCTYPE',
-            'a',
-            'abbr',
-            'acronym',
-            'address',
-            'applet',
-            'area',
-            'b',
-            'base',
-            'basefont',
-            'bdo',
-            'big',
-            'blockquote',
-            'body',
-            'br',
-            'button',
-            'caption',
-            'center',
-            'cite',
-            'code',
-            'col',
-            'colgroup',
-            'dd',
-            'del',
-            'dfn',
-            'dir',
-            'div',
-            'dl',
-            'dt',
-            'em',
-            'fieldset',
-            'font',
-            'form',
-            'frame',
-            'frameset',
-            'h1',
-            'h2',
-            'h3',
-            'h4',
-            'h5',
-            'h6',
-            'head',
-            'hr',
-            'html',
-            'i',
-            'iframe',
-            'img',
-            'input',
-            'ins',
-            'isindex',
-            'kbd',
-            'label',
-            'legend',
-            'li',
-            'link',
-            'map',
-            'menu',
-            'meta',
-            'noframes',
-            'noscript',
-            'object',
-            'ol',
-            'optgroup',
-            'option',
-            'p',
-            'param',
-            'pre',
-            'q',
-            's',
-            'samp',
-            'select',
-            'small',
-            'span',
-            'strike',
-            'strong',
-            'style',
-            'sub',
-            'sup',
-            'table',
-            'tbody',
-            'td',
-            'textarea',
-            'tfoot',
-            'th',
-            'thead',
-            'title',
-            'tr',
-            'tt',
-            'u',
-            'ul',
-            'var',
-            'xmp'
-    ].each do |script_tag|
-      [script_tag.upcase, script_tag.downcase].each do |script_tag|
-        [
-                "<#{script_tag}>",
-                "<#{script_tag}/>",
-                "< #{script_tag} >",
-                "<#{script_tag} />",
-                "<\n#{script_tag}\n/>",
-                "<\n#{script_tag} >",
-                "<#{script_tag}\n/>",
-                "<\r#{script_tag}\r/>"
-        ].each do |tag|
-          it "should detect '#{tag}'" do
-            dspam = Despamilator.new(tag)
-            dspam.score.should == 0.3
-          end
-        end
-      end
-    end
+  the_name_should_be 'HTML tags'
+  the_description_should_be 'Detects HTML tags in text'
 
-    describe 'attributes' do
-      before :all do
-        @dspam = Despamilator.new('<xmp>').matched_by.first
-      end
+  despamilator_should_apply_the_filter_for('<xmp>')
 
-      it "should have a name" do
-        @dspam.name.should == 'Detects HTML tags in text'
-      end
-
-      it "should have a description" do
-        @dspam.description.should == 'Searches for various HTML tags'
-      end
+  a_single_match_of('<xmp>', should_score: 0.3)
+  a_multiple_match_of('<h1></h1> <h2></h2>', should_score: [0.6, 2.times])
 
-      it "should have a filename" do
-        @dspam.filename.should == 'html_tags.rb'
-      end
-    end
+  [
+          '!--',
+          '!DOCTYPE',
+          'a',
+          'abbr',
+          'acronym',
+          'address',
+          'applet',
+          'area',
+          'b',
+          'base',
+          'basefont',
+          'bdo',
+          'big',
+          'blockquote',
+          'body',
+          'br',
+          'button',
+          'caption',
+          'center',
+          'cite',
+          'code',
+          'col',
+          'colgroup',
+          'dd',
+          'del',
+          'dfn',
+          'dir',
+          'div',
+          'dl',
+          'dt',
+          'em',
+          'fieldset',
+          'font',
+          'form',
+          'frame',
+          'frameset',
+          'h1',
+          'h2',
+          'h3',
+          'h4',
+          'h5',
+          'h6',
+          'head',
+          'hr',
+          'html',
+          'i',
+          'iframe',
+          'img',
+          'input',
+          'ins',
+          'isindex',
+          'kbd',
+          'label',
+          'legend',
+          'li',
+          'link',
+          'map',
+          'menu',
+          'meta',
+          'noframes',
+          'noscript',
+          'object',
+          'ol',
+          'optgroup',
+          'option',
+          'p',
+          'param',
+          'pre',
+          'q',
+          's',
+          'samp',
+          'select',
+          'small',
+          'span',
+          'strike',
+          'strong',
+          'style',
+          'sub',
+          'sup',
+          'table',
+          'tbody',
+          'td',
+          'textarea',
+          'tfoot',
+          'th',
+          'thead',
+          'title',
+          'tr',
+          'tt',
+          'u',
+          'ul',
+          'var',
+          'xmp'
+  ].each do |script_tag|
+    [script_tag.upcase, script_tag.downcase].each do |script_tag|
+      [
+              "<#{script_tag}>",
+              "<#{script_tag}/>",
+              "< #{script_tag} >",
+              "<#{script_tag} />",
+              "<\n#{script_tag}\n/>",
+              "<\n#{script_tag} >",
+              "<#{script_tag}\n/>",
+              "<\r#{script_tag}\r/>"
+      ].each do |tag|
+        it "should detect '#{tag}'" do
+          dspam = DespamilatorFilter::HtmlTags.new
+          dspam.parse(tag)
+          dspam.score.should == 0.3
+        end
 
-    describe 'bug fixes' do
-      it "should detect an h1" do
-        Despamilator.new('<h1>TITLE!!</h1>').score.should == 0.3
       end
 
-      it "should not detect tags twice" do
-        Despamilator.new('<i>italic</i>').score.should == 0.3
-      end
     end
+
   end
-end
+
+end

data/spec/filters/ip_address_url_spec.rb

@@ -1,29 +1,11 @@
-require File.dirname(__FILE__) + '/../spec_helper.rb'
+describe DespamilatorFilter::IPAddressURL do
 
-describe "IP Address URL" do
-  describe 'attributes' do
-    before :each do
-      @filter = Despamilator.new('http://12.34.56.78/').matched_by.first
-    end
+  the_name_should_be 'IP Address URL'
+  the_description_should_be 'Detects IP address URLs'
 
-    it "should have a filename" do
-      @filter.filename.should == 'ip_address_url.rb'
-    end
+  despamilator_should_apply_the_filter_for('http://12.34.56.78/')
 
-    it "should have a name" do
-      @filter.name.should == 'IP Address URL'
-    end
+  a_single_match_of('http://12.34.56.78/', should_score: 0.5)
+  a_multiple_match_of('http://12.34.56.78/ http://98.76.54.32/', should_score: [0.5, 1.times])
 
-    it "should have a description" do
-      @filter.description.should == 'Detects IP address URLs'
-    end
-
-    it "should have a number of matches" do
-      @filter.matches.should == 1
-    end
-
-    it "should have a score" do
-      @filter.score.should == 0.5
-    end
-  end
 end

data/spec/filters/long_words_spec.rb

@@ -1,34 +1,11 @@
-require File.dirname(__FILE__) + '/../spec_helper.rb'
+describe DespamilatorFilter::LongWords do
 
-describe "LongWords" do
-  it "should return a score for 1 long word" do
-    dspam = Despamilator.new('honorificabilitudinitatibus')
-    dspam.score.should == 0.1
-  end
+  the_name_should_be 'Long Words'
+  the_description_should_be 'Detects long and unbroken strings'
 
-  describe 'attributes' do
-    before :each do
-      @filter = Despamilator.new('honorificabilitudinitatibus antidisestablishmentarianism').matched_by.first
-    end
+  despamilator_should_apply_the_filter_for('honorificabilitudinitatibus')
 
-    it "should have a filename" do
-      @filter.filename.should == 'long_words.rb'
-    end
+  a_single_match_of('honorificabilitudinitatibus', should_score: 0.1)
+  a_multiple_match_of('honorificabilitudinitatibus antidisestablishmentarianism', should_score: [0.2, 2.times])
 
-    it "should have a name" do
-      @filter.name.should == 'Long Words'
-    end
-
-    it "should have a description" do
-      @filter.description.should == 'Detects long and unbroken strings'
-    end
-
-    it "should have a number of matches" do
-      @filter.matches.should == 2
-    end
-
-    it "should have a score" do
-      @filter.score.to_s.should == 0.2.to_s
-    end
-  end
 end

data/spec/filters/naughty_q_spec.rb

@@ -1,39 +1,11 @@
-require File.dirname(__FILE__) + '/../spec_helper.rb'
+describe DespamilatorFilter::NaughtyQ do
 
-describe "NaughtyQ" do
-  it "should return a score for 1 misplaced q" do
-    dspam = Despamilator.new('qtu')
-    dspam.score.should == 0.2
-  end
+  the_name_should_be 'Naughty Q'
+  the_description_should_be 'Detects possible misuse of the letter Q (English language)'
 
-  describe 'attributes' do
-    before :each do
-      @filter = Despamilator.new('qtqt').matched_by.first
-    end
+  despamilator_should_apply_the_filter_for('qtu')
 
-    it "should have a filename" do
-      @filter.filename.should == 'naughty_q.rb'
-    end
+  a_single_match_of('qtu', should_score: 0.2)
+  a_multiple_match_of('qtq', should_score: [0.4, 2.times])
 
-    it "should have a name" do
-      @filter.name.should == 'Naughty Q'
-    end
-
-    it "should have a description" do
-      @filter.description.should == 'Detects possible misuse of the letter Q (English language)'
-    end
-
-    it "should have a number of matches" do
-      @filter.matches.should == 3
-    end
-
-    it "should have a score" do
-      @filter.score.to_s.should == 0.6.to_s
-    end
-  end
-
-  it "should score more for 3 misplaced q's" do
-    dspam = Despamilator.new('qtuqsq')
-    dspam.score.to_s.should == 0.6.to_s
-  end
 end