deprecool 0.1.1 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e52876064a919fd936c1ce856a936497321260b30bb28d4af9583f1c4f408b2f
-  data.tar.gz: e2f181b5779334b951ab52f209533608d565764a09d9633c22bcc282ff604b04
+  metadata.gz: eca3a279e6790babeed0e659c1093f1b1a9086d9695a637460dda7cfa69d7182
+  data.tar.gz: a9a735cbd4232f568e002c643370c42491bad699a4ee1cfdd8eaae8e8493c723
 SHA512:
-  metadata.gz: 2054d49032593500337f9f406c298852b0fb11b03e745217c0ebdda4d5e26aa89ea06ed9d84855269a7c1079d38c09a6bb27fd5ac5a35b9138ac626f2fc0db72
-  data.tar.gz: f5014e5d52b173c5071f5622d892fc72783cbf61585cbed8d8a6845994ec704db0f3152055d2ae1074988b8be0331cac04134c73d797b6b8bc05c4dcdab7af34
+  metadata.gz: e8ce7b248608aecf4281f836bedc94c5cc6b493a9581145b22d01a9fee87266a304ce389193841dba4c5e1e5e0029af6fb63397b61e7ca877b4bf19e81b974db
+  data.tar.gz: 37d39d356843be3105baff39d2f4021b48f9edbf31816b241e715a43f19d489d0b72f3f5abe04de8e4c23749409158c5b5d05470608f3788b618c907faf6c572

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Deprecool
 
-## [0.1.0] - 2026-08-13
+## [0.1.3] - 2026-08-24
+ - Added Finder for: "Passing `binds` as a positional argument to `insert` deprecated", see [original commit](https://github.com/rails/rails/commit/2dca5457ab2097626481fdbec233ea56d3fb9ee3)
+ - Added `effort` to the CLI output
+
+## [0.1.2] - 2026-08-14
+
+- Add Finder for Rails's deprecation of `write_attribute(:id, value)`
+
+## [0.1.0], [0.1.1] - 2026-08-13
 
 - Initial Release

data/README.md

@@ -6,7 +6,8 @@ A helpful tool for any developer who has ever ignored a gem's warning and then r
 
 ## Usage
 
-Add to your Gemfile: `gem 'deprecool'`
+Add to your Gemfile: `gem 'deprecool'`, and `bundle install`
+
 Or directly `gem install deprecool`
 
 Then you can run `deprecool` in the command line to get:

data/lib/deprecool/cli.rb

@@ -24,7 +24,7 @@ module Deprecool
         option :gems, type: :array, desc: 'Specify gem name(s) to list which versions have deprecation tracking available'
 
         def call(gems:)
-          CLI.list_finders(Finder.registry)
+          CLI.list_finders(Finder.subclasses)
 
           # TODO: REPL to filter through the available finders?
         end
@@ -116,7 +116,7 @@ module Deprecool
       def text_report(offenses, finders)
         if offenses.empty?
           puts colorize('No deprecations found.', :green)
-          puts "(#{finders.size} finder#{'s' unless finders.size == 1} active)"
+          puts "(#{finders.size} finder(s) active)"
           return
         end
 
@@ -125,10 +125,13 @@ module Deprecool
         offenses.each_value do |offense_array|
           offense = offense_array.first
 
-          puts "\n#{colorize(offense.title, :bold)}\n"
+          puts "\n#{colorize(offense.title, :bold)}"
+          puts
           puts " * #{offense.summary}"
-          puts "  #{colorize('fix:', :green)} #{offense.suggestion}" if offense.suggestion
-          puts "  #{colorize('source:', :green)} #{offense.reference}" if offense.reference
+          puts
+          puts "  #{colorize('effort:', :green).ljust(16)} #{colorize_effort(offense.effort)}"
+          puts "  #{colorize('fix:', :green).ljust(16)} #{offense.suggestion}"   if offense.suggestion
+          puts "  #{colorize('source(s):', :green).ljust(16)} #{offense.reference}" if offense.reference
           puts '  Found At:'
           offense_array.each do |o|
             offense_count   += 1
@@ -158,6 +161,17 @@ module Deprecool
 
         "\e[#{colors.fetch(color, nil)}m#{text}\e[0m"
       end
+
+      def colorize_effort(effort)
+        # the effort method raises if you set anything but these
+        # values so it's safe to assume, it would also be a hassle
+        # to remove duplication here so oh well
+        effort_colors = { low:    :green,
+                          medium: :yellow,
+                          high: :red }
+
+        colorize(effort, effort_colors[effort])
+      end
     end
   end
 end

data/lib/deprecool/finder.rb

@@ -31,17 +31,7 @@ module Deprecool
   class Finder
     include PrismHelpers
 
-    @registry = []
-
     class << self
-      # All finder subclasses, in definition order.
-      attr_reader :registry
-
-      def inherited(subclass)
-        Finder.registry << subclass
-        super
-      end
-
       # defines class methods that set instance variables
       %i[gem title summary suggestion reference].each do |attribute|
         define_method(attribute) do |value = (getter = true)|

data/lib/deprecool/finders/rails/v7.1.0/serializer_positional_class_argument.rb

@@ -25,11 +25,10 @@ module Deprecool
 
           def on_call_node(node)
             return unless node.name == :serialize
+            return unless arguments_are_length(node.arguments, 2)
+            return unless unwrap_arguments(node.arguments)[1].is_a?(Prism::ConstantReadNode)
 
-            arguments_array = unwrap_arguments(node.arguments)
-            return unless arguments_array && arguments_array[1]
-
-            add_offense(node, confidence: :high) if arguments_array[1].is_a?(Prism::ConstantReadNode)
+            add_offense(node, confidence: :high)
           end
         end
       end

data/lib/deprecool/finders/rails/v8.2.0/no_binds_to_insert_update_delete.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+module Deprecool
+  module Finders
+    module Rails
+      module V8_2_0
+        class InsertUpdateDeleteBinds < Deprecool::Finder
+          gem           :rails
+          deprecated_in '8.2.0'
+          removed_in    '9.0.0'
+          title         'Binds being bassed to Insert Update Delete is deprecated'
+          summary       ' Now that `Arel.sql(sql_with_placeholders, *binds)` wraps SQL and its binds' \
+                        'together as an `Arel::Nodes::BoundSqlLiteral`, just like ' \
+                        '`Model.where("... = ?", value)`, the separate positional is no longer needed'
+          suggestion    'Old: `connection.insert("INSERT INTO topics (title) VALUES (?)", nil, nil, ["hello"])` ' \
+                        'New: `connection.insert(Arel.sql("INSERT INTO topics (title) VALUES (?)", "hello"))`'
+          reference     'Original Commit: https://github.com/rails/rails/commit/2dca5457ab2097626481fdbec233ea56d3fb9ee3'
+          effort        :low
+
+          def on_call_node(node)
+            return unless %i[insert update delete].include?(node.name)
+            return unless arguments = unwrap_arguments(node.arguments)
+            return unless arguments.length > 1
+
+            confidence = confidence_from_arguments(arguments)
+            return if confidence == :none
+
+            add_offense(node, confidence: confidence)
+          end
+
+          private
+
+          def confidence_from_arguments(arguments)
+            first = arguments[0]
+
+            # if first argument is string node that starts with "INSERT" "UPDATE" "DELETE" then :high
+            # if first argument is a variable then :low confidence
+            # it it's a Prism::CallNode, and not a variable call, then I don't know what it is here,
+            # maybe it's like 'connection.update(generate_sql(some_arg), ["name"])' and if you are doing that
+            # then good luck?
+            if first.is_a?(Prism::CallNode)
+              return :low if first.variable_call? # can't tell what's stored in the variable, https://docs.ruby-lang.org/en/master/Prism/CallNode.html#method-i-variable_call-3F
+              :none
+            elsif %w[INSERT UPDATE DELETE].include?(first.unescaped[..5].upcase)
+              :high
+            else
+              :none
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/deprecool/finders/rails/v8.2.0/to_sql_binds.rb

@@ -7,7 +7,7 @@ module Deprecool
         class ToSqlBinds < Deprecool::Finder
           gem           :rails
           deprecated_in '8.2.0'
-          removed_in    '8.3.0'
+          removed_in    '9.0.0'
           title         'Passing "binds" into "to_sql" is deprecated'
           summary       'Since Rails 5.2, bind parameters live on the Arel AST ' \
                         'to_sql_and_binds no longer uses binds for SQL construction, ' \
@@ -26,9 +26,7 @@ module Deprecool
             # if a method called 'to_sql' is passed two arguments and the second is an
             # array that's probably good enough
             return unless node.name == :to_sql
-
-            arguments_array = unwrap_arguments(node.arguments)
-            return unless arguments_array && arguments_array[1]
+            return unless arguments_are_length(node.arguments, 2)
 
             add_offense(node, confidence: :high)
           end

data/lib/deprecool/finders/rails/v8.2.0/write_attribute_id.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+module Deprecool
+  module Finders
+    module Rails
+      module V8_2_0
+        class WriteAttributeId < Deprecool::Finder
+          gem           :rails
+          deprecated_in '8.2.0'
+          removed_in    '9.0.0'
+          title         'Using "write_attribute" for the primary key is deprecated'
+          summary       'Just like Rails 7.1\'s deprecation of calling "read_attribute(:id)", '\
+                        '"write_attribute(:id)" is now deprecated and will be removed in the next version of Rails. ' \
+                        'making :id refer only to the id column, not the primary key.'
+          suggestion    'Use "#id=" on a model whose primary key is not named "id"'
+          reference     'Original Rails Commit: https://github.com/rails/rails/commit/1a90632bbe62dae2626de7a058bc18c29f77aea6'
+          effort        :low
+
+          def on_call_node(node)
+            return unless node.name == :write_attribute
+            return unless arguments_are_length(node.arguments, 2)
+            return unless arguments_contain(node.arguments, "id", position: 0)
+
+            add_offense(node, confidence: :high)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/deprecool/finders/ruby/v4.0.0/object_space_id2ref.rb

@@ -27,9 +27,9 @@ module Deprecool
             # I don't think we need much more than this
             # I'm open to be wrong though, maybe lots of people are subclassing
             # ObjectSpace or defining '_id2ref' on custom classes
-            confidence = node.receiver.name == :ObjectSpace ? :high : nil
+            confidence = node.receiver.name == :ObjectSpace ? :high : :none
 
-            return unless confidence
+            return if confidence == :none
 
             add_offense node, confidence: confidence
           end

data/lib/deprecool/finders/ruby/v4.0.0/to_set_arguments.rb

@@ -11,8 +11,8 @@ module Deprecool
           title         'Passing arguments to #to_set is deprecated'
           summary       'Since Ruby 4.0, passing arguments to Set#to_set / Enumerable#to_set ' \
                         'is deprecated and will be removed.'
-          suggestion    'Call #to_set with no arguments. If you were building a ' \
-                        'Set subclass, construct it explicitly instead.'
+          suggestion    'Call #to_set with no arguments. If you want an instance of a subclass of Set' \
+                        'from an enumerable construct it explicitly instead: MySetSubclass.new(enumerable)'
           reference     'https://bugs.ruby-lang.org/issues/21390 https://github.com/ruby/ruby/pull/13489'
           effort        :low
 
@@ -21,7 +21,7 @@ module Deprecool
             return unless node.arguments
 
             confidence = confidence_from_receiver_node(node.receiver)
-            return unless confidence
+            return if confidence == :none
 
             add_offense(node, confidence:)
           end
@@ -35,12 +35,12 @@ module Deprecool
             # a plain `to_set(x)` call to the current scope's own
             # method. This is probably not Enumerable#to_set unless someone has
             # monkeypatched Enumerable and is using to_set with an argument, I guess
-            when nil then nil
+            when nil then :none
             when Prism::ConstantReadNode, Prism::ConstantPathNode
               # These nodes can constants like:
               # MY_DATA.to_set(arg) => likely an array, but can't be sure so :low
               # MyClass.to_set(arg) => has lowercase letters so it's a class method
-              receiver&.name&.match?(/[a-z]/) ? nil : :low
+              receiver&.name&.match?(/[a-z]/) ? :none : :low
             else
               # this branch is when the receiver is some
               # local var, instance variable, method chain, safe navigation, etc.

data/lib/deprecool/helpers/prism_helpers.rb

@@ -36,4 +36,28 @@ module PrismHelpers
 
     node.child_nodes
   end
+
+  def arguments_are_length(node, length)
+    return false unless node.is_a?(Prism::ArgumentsNode)
+
+    unwrap_arguments(node.arguments).length == length
+  end
+
+  def arguments_contain(node, value, position: -1, kwarg: nil)
+    return false unless node.is_a?(Prism::ArgumentsNode)
+
+    arguments = unwrap_arguments(node)
+
+    return (value_from_argument(arguments[position]) == value) if position >= 0
+
+    arguments.any? do |arg|
+      value_from_argument(arg) == value
+    end
+  end
+
+  def value_from_argument(node)
+    case node
+    when Prism::SymbolNode, Prism::StringNode then node.unescaped
+    end
+  end
 end

data/lib/deprecool/registry.rb

@@ -7,7 +7,7 @@ module Deprecool
 
     # All the subclasses of Finder
     def all_finders
-      Finder.registry
+      @all ||= Finder.subclasses
     end
 
     # Gets finders that apply to the given versions.

data/lib/deprecool/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module Deprecool
-  VERSION = '0.1.1'
+  VERSION = '0.1.3'
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: deprecool
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.3
 platform: ruby
 authors:
 - Zac Radford
@@ -56,8 +56,10 @@ files:
 - lib/deprecool/cli.rb
 - lib/deprecool/finder.rb
 - lib/deprecool/finders/rails/v7.1.0/serializer_positional_class_argument.rb
+- lib/deprecool/finders/rails/v8.2.0/no_binds_to_insert_update_delete.rb
 - lib/deprecool/finders/rails/v8.2.0/redis_cache_store_default_redis_options.rb
 - lib/deprecool/finders/rails/v8.2.0/to_sql_binds.rb
+- lib/deprecool/finders/rails/v8.2.0/write_attribute_id.rb
 - lib/deprecool/finders/ruby/v4.0.0/object_space_id2ref.rb
 - lib/deprecool/finders/ruby/v4.0.0/to_set_arguments.rb
 - lib/deprecool/helpers/prism_helpers.rb