deprecation_toolkit 2.2.2 → 2.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6764813c0b9b8522fa1e755f59e4f3e7137fa229a24e5b96ae05fbcbd53efdc7
-  data.tar.gz: 5e570bcbf742061e36c5aeb4b1073a3ba546c47e5caefaba2b1d33abaaf1c037
+  metadata.gz: 928c5fd8932b5f69fd9a51ea255ff5db6977fedc011c9ff211de0e3d73f4cc4e
+  data.tar.gz: f514ee0194329683cad36aa454280acaa0a8ecd84ba02d698b45b7b1c84cf0f8
 SHA512:
-  metadata.gz: 9c851ca5d25bdaed7522be6f1736766bd92a66f454993ec060c048fe6f09feb9f28d3d7c608ba248a31492b8c6656782871507d6e9fd138af85e03b53446dda7
-  data.tar.gz: f8ba1b548b6cde09de40768dce5f2b79ba23dd3bf69620cc6255520efc6fe11c4f8839978d7f0d1ecfa1f0c77307ddf2743cd219d1834ae181f3f762d2f3a80a
+  metadata.gz: 65c66a322df4cfcd5977531d5b0fa60221c096d8d36e7e653b2c9f6d571e175d1fa6a868b53d85c63c80e768a115b7813f65494a61697d96a9456c786a4267e9
+  data.tar.gz: 149af66da445071b2b586373cffaf03f43d24b59210d102529b70024a8b5c94bdc5d465270ed2e25709e86133ebae43ba43946e4941fe888677c0d9ae1776257

data/lib/deprecation_toolkit/deprecation_subscriber.rb

@@ -5,8 +5,54 @@ require "active_support/subscriber"
 module DeprecationToolkit
   class DeprecationSubscriber < ActiveSupport::Subscriber
     class << self
-      def already_attached?
-        notifier != nil
+      def attach_to(gem_name, subscriber = new, notifier = ActiveSupport::Notifications, inherit_all: false)
+        return if already_attached_to?(gem_name)
+
+        super(gem_name, subscriber, notifier, inherit_all: inherit_all)
+      end
+
+      def detach_from(gem_name, notifier = ActiveSupport::Notifications)
+        @namespace  = gem_name
+        @subscriber = find_attached_subscriber(gem_name)
+        @notifier = notifier
+
+        return unless subscriber
+
+        subscribers.delete(subscriber)
+
+        # Remove event subscribers of all existing methods on the class.
+        fetch_public_methods(subscriber, true).each do |event|
+          remove_event_subscriber(event)
+        end
+
+        @notifier = nil unless any_subscribers_attached?
+      end
+
+      private
+
+      def already_attached_to?(gem_name)
+        subscribers.any? do |subscriber|
+          attached_subscriber?(subscriber, gem_name)
+        end
+      end
+
+      def any_subscribers_attached?
+        subscribers.any? do |subscriber|
+          subscriber.is_a?(self)
+        end
+      end
+
+      def find_attached_subscriber(gem_name)
+        subscribers.find do |attached_subscriber|
+          attached_subscriber?(attached_subscriber, gem_name)
+        end
+      end
+
+      def attached_subscriber?(subscriber, gem_name)
+        subscriber.is_a?(self) &&
+          subscriber.patterns.keys.any? do |pattern|
+            pattern.end_with?(".#{gem_name}")
+          end
       end
     end
 

data/lib/deprecation_toolkit/read_write_helper.rb

@@ -15,32 +15,29 @@ module DeprecationToolkit
     end
 
     def write(deprecation_file, deprecations_to_record)
-      create_deprecation_file(deprecation_file) unless deprecation_file.exist?
+      original_deprecations = deprecation_file.exist? ? YAML.load_file(deprecation_file) : {}
+      updated_deprecations = original_deprecations.dup
 
-      content = YAML.load_file(deprecation_file)
-
-      deprecations_to_record.each do |test, deprecations|
-        if deprecations.any?
-          content[test] = deprecations
+      deprecations_to_record.each do |test, deprecation_to_record|
+        if deprecation_to_record.any?
+          updated_deprecations[test] = deprecation_to_record
         else
-          content.delete(test)
+          updated_deprecations.delete(test)
         end
       end
 
-      if content.any?
-        deprecation_file.write(YAML.dump(content))
-      else
+      if updated_deprecations.any?
+        if updated_deprecations != original_deprecations
+          deprecation_file.dirname.mkpath
+          deprecation_file.write(YAML.dump(updated_deprecations.sort.to_h))
+        end
+      elsif deprecation_file.exist?
         deprecation_file.delete
       end
     end
 
     private
 
-    def create_deprecation_file(deprecation_file)
-      deprecation_file.dirname.mkpath
-      deprecation_file.write(YAML.dump({}))
-    end
-
     def recorded_deprecations_path(test)
       deprecation_folder = if Configuration.deprecation_path.is_a?(Proc)
         Configuration.deprecation_path.call(test_location(test))

data/lib/deprecation_toolkit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DeprecationToolkit
-  VERSION = "2.2.2"
+  VERSION = "2.2.4"
 end

data/lib/deprecation_toolkit.rb

@@ -16,6 +16,9 @@ module DeprecationToolkit
     autoload :Raise,                   "deprecation_toolkit/behaviors/raise"
     autoload :Record,                  "deprecation_toolkit/behaviors/record"
     autoload :CIRecordHelper,          "deprecation_toolkit/behaviors/ci_record_helper"
+    autoload :DeprecationIntroduced,   "deprecation_toolkit/behaviors/raise"
+    autoload :DeprecationRemoved,      "deprecation_toolkit/behaviors/raise"
+    autoload :DeprecationMismatch,     "deprecation_toolkit/behaviors/raise"
   end
 
   class << self
@@ -32,8 +35,6 @@ module DeprecationToolkit
     end
 
     def attach_subscriber
-      return if DeprecationSubscriber.already_attached?
-
       Configuration.attach_to.each do |gem_name|
         DeprecationSubscriber.attach_to(gem_name)
       end

data/lib/minitest/deprecation_toolkit_plugin.rb

@@ -14,6 +14,10 @@ module Minitest
 
     require "deprecation_toolkit"
 
+    setup_deprecation_toolkit(options)
+  end
+
+  def setup_deprecation_toolkit(options)
     if options[:record_deprecations]
       DeprecationToolkit::Configuration.behavior = DeprecationToolkit::Behaviors::Record
     end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: deprecation_toolkit
 version: !ruby/object:Gem::Version
-  version: 2.2.2
+  version: 2.2.4
 platform: ruby
 authors:
 - Shopify
 bindir: bin
 cert_chain: []
-date: 2025-01-23 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -53,7 +53,7 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/shopify/deprecation_toolkit
-  source_code_uri: https://github.com/Shopify/deprecation_toolkit/tree/v2.2.2
+  source_code_uri: https://github.com/Shopify/deprecation_toolkit/tree/v2.2.4
   changelog_uri: https://github.com/Shopify/deprecation_toolkit/blob/main/CHANGELOG.md
   allowed_push_host: https://rubygems.org
 rdoc_options: []
@@ -70,7 +70,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.7.1
 specification_version: 4
 summary: Deprecation Toolkit around ActiveSupport::Deprecation
 test_files: []