deployangel 0.1.37 → 0.1.39

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 618c24521dbd9aa6102fdd7c3a6c105494abcde74072fa37d8bd2e27f2737f49
-  data.tar.gz: 55e402796d95fe4aee557b342fcb0814933b9f39c965bba504b160fdaf557c0d
+  metadata.gz: d930ff0701b6c48f6793339eaff985418ae4a6b0332689e7c87d85047f80a082
+  data.tar.gz: a1848b93327d98249e6bd98acf595047b62b926604c9940ed92f17334db3b093
 SHA512:
-  metadata.gz: 4df4ece416d4c1d16729bbaaff61c0e196d3635796f1a743b754b189d91109891c38232bd484e1240fa55a28db6c85898a3b550fd3bd781337de4f05d18ecfc3
-  data.tar.gz: 4a523fc4d15f677b80671a3a09490e267ad1c322fcd0b45d7f2c37dd68ea54586c36efd6204e22f2d20cea15185a2d2072c53bf5f0857fa5011442198ad61431
+  metadata.gz: '00943ef2bac8f6acb697ec20243c211b96779b4eb33dc8c4da1aff53cd789b14ca569320fa06d960de7811a0dd15e4aacab06e6656f4ffe1240a8b63cf1467eb'
+  data.tar.gz: 9e8ede3e14497f6afaf02b08f0438876397ee73b95f7ba79bbff8d43dc84ad69e018e0bffb903ce722458b1a5df48c2eb372580c034699a00315f09335a92235

data/CHANGELOG.md

@@ -1,5 +1,26 @@
 # Changelog
 
+## 0.1.39 (2026-11-04)
+
+- `deployangel doctor` warns when the project's AGENTS.md or CLAUDE.md has
+  an older copy of the block `deployangel install agents` writes, and
+  `deployangel status` says so on stderr at the start of a session, where
+  a coding agent reads it. Running `deployangel install agents` updates
+  it. Hand-written instructions without the block's markers aren't
+  checked.
+
+## 0.1.38 (2026-11-04)
+
+- `deployangel verify` shows a volume drop (servers from 2026-11-04) as
+  what ran against what was expected (`0 requests, about 27 expected`),
+  and lists findings a person accepted as an intended change, with who
+  and why. A failing finding that could be intended gets the link where a
+  person can accept it; the CLI and MCP server can't, so an agent never
+  accepts its own failure.
+- The MCP server's instructions, and the block `deployangel install
+  agents` writes, tell agents to hand that link to the user with their
+  evidence and never report the release as a success.
+
 ## 0.1.37 (2026-11-03)
 
 - An exception raised entirely in gems, with no frame from the app's

data/lib/deployangel/cli/formatter.rb

@@ -10,7 +10,7 @@ module DeployAngel
         "job_failure_rate" => "Job failure rate", "job_duration" => "Job duration p95", "queue_latency" => "Queue latency p95",
         "new_fingerprint" => "New exception", "fingerprint_amplification" => "Exception amplification",
         "missing_recurring_job" => "Recurring job", "first_use_failure" => "First-use failure", "external_check" => "External check",
-        "checkpoint_rate" => "Checkpoint"
+        "checkpoint_rate" => "Checkpoint", "volume_drop" => "Volume"
       }.freeze
       DURATIONS = %w[p95_latency job_duration queue_latency].freeze
       # Exercise plan statuses with something worth running now.
@@ -18,6 +18,9 @@ module DeployAngel
       REASONS = { "normally_active" => "normally active", "changed_in_release" => "changed in this release",
                   "rarely_used" => "rarely used", "critical_flow" => "critical flow" }.freeze
       COUNTS = %w[new_fingerprint checkpoint_rate].freeze
+      # Findings worth listing: problems, and changes a person accepted as
+      # intended (servers from 2026-11-04 send "accepted").
+      LISTED = %w[failing warning accepted].freeze
 
       module_function
 
@@ -26,7 +29,10 @@ module DeployAngel
         problems = problems(document)
         if problems.any?
           lines << "Findings:"
-          problems.each { |f| lines << "  #{f["status"].ljust(8)} #{finding_line(f)}" }
+          problems.each do |f|
+            lines << "  #{f["status"].ljust(8)} #{finding_line(f)}"
+            acceptance_lines(f).each { |line| lines << "           #{line}" }
+          end
         end
         if (gathering = gathering_line(document))
           lines << "#{gathering} (--format=json for details)"
@@ -44,7 +50,7 @@ module DeployAngel
         problems = problems(document)
         if problems.any?
           lines.push("", "| Status | Finding |", "| --- | --- |")
-          problems.each { |f| lines << "| #{f["status"]} | #{cell(finding_line(f))} |" }
+          problems.each { |f| lines << "| #{f["status"]} | #{cell([ finding_line(f), *acceptance_lines(f) ].join(". "))} |" }
         end
         if (gathering = gathering_line(document))
           lines.push("", gathering)
@@ -85,7 +91,19 @@ module DeployAngel
       end
 
       def problems(document)
-        Array(document["findings"]).select { |f| %w[failing warning].include?(f["status"]) }
+        Array(document["findings"]).select { |f| LISTED.include?(f["status"]) }
+      end
+
+      # Who accepted a finding as an intended change, or where a person can.
+      # Only a person can, on the release page: the API can't.
+      def acceptance_lines(finding)
+        if (accepted = finding["accepted_as_intended"])
+          [ "Accepted as intended by #{accepted["by"]}: #{accepted["note"]}" ]
+        elsif finding["accept_url"]
+          [ "If this change was intended, a person can accept it: #{finding["accept_url"]}" ]
+        else
+          []
+        end
       end
 
       def gathering_line(document)
@@ -216,7 +234,12 @@ module DeployAngel
 
       def finding_line(finding)
         label = "#{LABELS.fetch(finding["signal"], finding["signal"])} on #{finding["scope"]}"
-        if COUNTS.include?(finding["signal"])
+        if finding["signal"] == "volume_drop"
+          # Its baseline value is what the release before predicts for this
+          # much traffic.
+          unit = finding["scope"].to_s.start_with?("route:") ? "requests" : "runs"
+          "#{label}: #{finding["observed_value"].to_i} #{unit}, about #{finding["baseline_value"].to_f.round} expected"
+        elsif COUNTS.include?(finding["signal"])
           "#{label}: #{finding["observed_value"].to_i} occurrences"
         elsif finding["signal"] == "missing_recurring_job"
           # Its value is the job's interval in seconds, not a rate.

data/lib/deployangel/cli.rb

@@ -112,6 +112,10 @@ module DeployAngel
         investigate the likely cause, and propose a fix. `next_steps` names the last
         cleared release a rollback would go to. Do not roll back or change
         production without explicit approval.
+      - A failed release whose failing finding is a volume or checkpoint drop you
+        made on purpose (a route or job you removed): you can't accept it. Tell the
+        user why you think it was intended, with your evidence, and give them the
+        finding's `accept_url` so a person decides. It stays failed until then.
       - Exit 3: still verifying; run the command again.
       - Not cleared yet: call `get_exercise_plan` (or `bundle exec deployangel plan`).
         If its status is "exercisable" or "waiting_for_activity", run
@@ -254,6 +258,7 @@ module DeployAngel
         output(document, options[:format]) { Formatter.verification(document) }
         step_summary(Formatter.markdown(document))
         @stderr.puts("deployangel: timed out; verification is still in progress") if outcome.timed_out
+        stale_instructions_note if status
         outcome.exit_code
       end
 
@@ -402,6 +407,15 @@ module DeployAngel
       # What this checkout will report and what DeployAngel has seen of the
       # app. Warnings are advice, so only errors (a rejected token, an
       # unreachable server, no agent in the bundle) fail it.
+      # At the start of a session (`status`), where an agent reads it and can
+      # update the instructions it's following.
+      def stale_instructions_note
+        stale = Doctor.stale_instructions(@root)
+        return if stale.empty?
+
+        @stderr.puts("deployangel: #{Doctor.stale_instructions_note(stale)}; run `deployangel install agents` to update")
+      end
+
       def doctor
         format = parse(format: nil) { |o, opts| o.on("--format=FORMAT", %w[text json]) { |v| opts[:format] = v } }[:format]
         doctor = Doctor.new(root: @root, client: doctor_client, env: @env)

data/lib/deployangel/doctor.rb

@@ -36,10 +36,29 @@ module DeployAngel
     def checks
       @checks ||= begin
         @setup, server = server_checks
-        [ *agent_checks, here_check, schedule_check, *server, release_check, *comparison_checks ].compact
+        [ *agent_checks, here_check, schedule_check, *server, release_check, *comparison_checks, instructions_check ].compact
       end
     end
 
+    # Files whose DeployAngel block (between the markers `deployangel install
+    # agents` writes) differs from this version's: agents keep following the
+    # older copy until it's updated. Hand-written instructions without the
+    # markers aren't checked.
+    def self.stale_instructions(root)
+      block = /#{Regexp.escape(CLI::AGENTS_START)}.*?#{Regexp.escape(CLI::AGENTS_END)}/m
+      %w[AGENTS.md CLAUDE.md].select do |name|
+        path = File.join(root, name)
+        found = File.file?(path) && File.read(path)[block]
+        found && found != CLI::AGENT_INSTRUCTIONS.chomp
+      end
+    rescue SystemCallError
+      []
+    end
+
+    def self.stale_instructions_note(files)
+      "#{files.join(" and ")} #{files.one? ? "has" : "have"} an older copy of DeployAngel's agent instructions"
+    end
+
     def failed?
       checks.any? { |check| check.status == :error }
     end
@@ -57,6 +76,14 @@ module DeployAngel
         [ Check.new(status: :error, message: "The agent isn't in the bundle", fix: "Add gem \"deployangel\" to the Gemfile and run bundle install.") ]
       end
 
+      def instructions_check
+        stale = self.class.stale_instructions(@root)
+        return if stale.empty?
+
+        Check.new(status: :warn, message: self.class.stale_instructions_note(stale),
+          fix: "Run deployangel install agents to update #{stale.one? ? "it" : "them"}.")
+      end
+
       def schedule_check
         counts = local_schedules.group_by { |schedule| schedule["source"] }.map { |source, list| "#{SOURCES.fetch(source, source)} #{list.size}" }
         later = [ ("GoodJob's cron" if read("Gemfile.lock").to_s.include?(" good_job (")), "config.recurring_jobs" ].compact

data/lib/deployangel/mcp.rb

@@ -31,6 +31,11 @@ module DeployAngel
         Only act on status "exercisable" or "waiting_for_activity"; for "warm_up" or
         "no_baseline" nothing you run can clear it. Exercise routes marked mutating only with a test account
         or after asking. Report what you ran with the plan's report_with command (deployangel check).
+        A failing volume_drop or checkpoint_rate finding with an accept_url may be an intended change, such as
+        a route or job you removed on purpose. You cannot accept it, and must not try: tell the user why you
+        think it was intended, with your evidence, and give them the accept_url so a person decides. Until
+        someone accepts it, the release is failed: never report it as success. A finding with status
+        accepted was accepted as intended by the person in accepted_as_intended.
       TEXT
 
       TARGET_PROPERTIES = {

data/lib/deployangel/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DeployAngel
-  VERSION = "0.1.37"
+  VERSION = "0.1.39"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: deployangel
 version: !ruby/object:Gem::Version
-  version: 0.1.37
+  version: 0.1.39
 platform: ruby
 authors:
 - Jordan Owens