deployangel 0.1.36 → 0.1.38

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eb03031f58bd01feb61e1f478f4108eb3c969527e28cf86d970355a6bede0031
-  data.tar.gz: 3dd9679d37e80b23e449ee99ffd29bd3db9700bf8e2b5bfa665bf4413e2e4fb7
+  metadata.gz: 9a0944295d3cbddf9d6ff41ce21ad608b3c9615dc2910bfed6ef9745ffde6e93
+  data.tar.gz: 7197967f339bb1af5057528e2b08b9e894379051401d059f02a91ec6cd3083ad
 SHA512:
-  metadata.gz: bbaff8f03fce84081cdf13786dac7d26912ffeb9eae1c3f032f91d3b00afd23ba95a076c6213846cd44390017e8b7f8cdfd7b63833a07fcef9f782b4e9576dc0
-  data.tar.gz: 2919b83e169d1ac91175c733d9366df8e05b4910f8722a99cb3fdae57a07dda205be55dce418f2c0c7e1d8e382dc17a9007e23c96126b0174d24ed24588c13be
+  metadata.gz: 9fc73a15daea7553d4a04121c001a49feef7a15195b0313b1115ab572a387cc053bf80196d6c8d79baee8c980df2833c198cdf7a2e0dcdeda18d81235dd3c208
+  data.tar.gz: 4d5fe66f67476bd5c0e41137d6f3f38746d31da776ea295526e4becd463da21f61bf4d23a5d0ebfaac61df4c84d0d4692b67e49797d5e05a6cb63fa5e59a706f

data/CHANGELOG.md

@@ -1,5 +1,25 @@
 # Changelog
 
+## 0.1.38 (2026-11-04)
+
+- `deployangel verify` shows a volume drop (servers from 2026-11-04) as
+  what ran against what was expected (`0 requests, about 27 expected`),
+  and lists findings a person accepted as an intended change, with who
+  and why. A failing finding that could be intended gets the link where a
+  person can accept it; the CLI and MCP server can't, so an agent never
+  accepts its own failure.
+- The MCP server's instructions, and the block `deployangel install
+  agents` writes, tell agents to hand that link to the user with their
+  evidence and never report the release as a success.
+
+## 0.1.37 (2026-11-03)
+
+- An exception raised entirely in gems, with no frame from the app's
+  code, now sends its first library frames as its stack trace
+  (`net-smtp/lib/net/smtp.rb#start`), normalized like the top frame, with
+  no absolute paths or versions. Before, it sent none, so an error such as
+  a mailer job's `Net::ReadTimeout` showed no trace.
+
 ## 0.1.36 (2026-11-01)
 
 - `deployangel exercise --param id=42` fills path parameters (`:id`,

data/README.md

@@ -149,7 +149,8 @@ the dashboard says so.
 - Release identity, runtime versions, and a per-process instance ID.
 
 - Exceptions: a stable fingerprint, the exception class, the first line of the
-  message, and application frames only. In the message, numbers, IDs, emails,
+  message, and application frames only, or the first library frames (gem
+  paths without versions) when none is the app's. In the message, numbers, IDs, emails,
   UUIDs, long hex strings, and quoted values are replaced with placeholders, and
   so are the request's host and, with ros-apartment, the tenants the request or
   job switched to. Other words are kept: `Payment failed for Jane Doe` is sent
@@ -238,7 +239,7 @@ end
 ### Exception messages
 
 To send exceptions without any message, only their class, fingerprint, and
-application frames:
+stack frames:
 
 ```ruby
 DeployAngel.configure do |config|

data/lib/deployangel/cli/formatter.rb

@@ -10,7 +10,7 @@ module DeployAngel
         "job_failure_rate" => "Job failure rate", "job_duration" => "Job duration p95", "queue_latency" => "Queue latency p95",
         "new_fingerprint" => "New exception", "fingerprint_amplification" => "Exception amplification",
         "missing_recurring_job" => "Recurring job", "first_use_failure" => "First-use failure", "external_check" => "External check",
-        "checkpoint_rate" => "Checkpoint"
+        "checkpoint_rate" => "Checkpoint", "volume_drop" => "Volume"
       }.freeze
       DURATIONS = %w[p95_latency job_duration queue_latency].freeze
       # Exercise plan statuses with something worth running now.
@@ -18,6 +18,9 @@ module DeployAngel
       REASONS = { "normally_active" => "normally active", "changed_in_release" => "changed in this release",
                   "rarely_used" => "rarely used", "critical_flow" => "critical flow" }.freeze
       COUNTS = %w[new_fingerprint checkpoint_rate].freeze
+      # Findings worth listing: problems, and changes a person accepted as
+      # intended (servers from 2026-11-04 send "accepted").
+      LISTED = %w[failing warning accepted].freeze
 
       module_function
 
@@ -26,7 +29,10 @@ module DeployAngel
         problems = problems(document)
         if problems.any?
           lines << "Findings:"
-          problems.each { |f| lines << "  #{f["status"].ljust(8)} #{finding_line(f)}" }
+          problems.each do |f|
+            lines << "  #{f["status"].ljust(8)} #{finding_line(f)}"
+            acceptance_lines(f).each { |line| lines << "           #{line}" }
+          end
         end
         if (gathering = gathering_line(document))
           lines << "#{gathering} (--format=json for details)"
@@ -44,7 +50,7 @@ module DeployAngel
         problems = problems(document)
         if problems.any?
           lines.push("", "| Status | Finding |", "| --- | --- |")
-          problems.each { |f| lines << "| #{f["status"]} | #{cell(finding_line(f))} |" }
+          problems.each { |f| lines << "| #{f["status"]} | #{cell([ finding_line(f), *acceptance_lines(f) ].join(". "))} |" }
         end
         if (gathering = gathering_line(document))
           lines.push("", gathering)
@@ -85,7 +91,19 @@ module DeployAngel
       end
 
       def problems(document)
-        Array(document["findings"]).select { |f| %w[failing warning].include?(f["status"]) }
+        Array(document["findings"]).select { |f| LISTED.include?(f["status"]) }
+      end
+
+      # Who accepted a finding as an intended change, or where a person can.
+      # Only a person can, on the release page: the API can't.
+      def acceptance_lines(finding)
+        if (accepted = finding["accepted_as_intended"])
+          [ "Accepted as intended by #{accepted["by"]}: #{accepted["note"]}" ]
+        elsif finding["accept_url"]
+          [ "If this change was intended, a person can accept it: #{finding["accept_url"]}" ]
+        else
+          []
+        end
       end
 
       def gathering_line(document)
@@ -216,7 +234,12 @@ module DeployAngel
 
       def finding_line(finding)
         label = "#{LABELS.fetch(finding["signal"], finding["signal"])} on #{finding["scope"]}"
-        if COUNTS.include?(finding["signal"])
+        if finding["signal"] == "volume_drop"
+          # Its baseline value is what the release before predicts for this
+          # much traffic.
+          unit = finding["scope"].to_s.start_with?("route:") ? "requests" : "runs"
+          "#{label}: #{finding["observed_value"].to_i} #{unit}, about #{finding["baseline_value"].to_f.round} expected"
+        elsif COUNTS.include?(finding["signal"])
           "#{label}: #{finding["observed_value"].to_i} occurrences"
         elsif finding["signal"] == "missing_recurring_job"
           # Its value is the job's interval in seconds, not a rate.

data/lib/deployangel/cli.rb

@@ -112,6 +112,10 @@ module DeployAngel
         investigate the likely cause, and propose a fix. `next_steps` names the last
         cleared release a rollback would go to. Do not roll back or change
         production without explicit approval.
+      - A failed release whose failing finding is a volume or checkpoint drop you
+        made on purpose (a route or job you removed): you can't accept it. Tell the
+        user why you think it was intended, with your evidence, and give them the
+        finding's `accept_url` so a person decides. It stays failed until then.
       - Exit 3: still verifying; run the command again.
       - Not cleared yet: call `get_exercise_plan` (or `bundle exec deployangel plan`).
         If its status is "exercisable" or "waiting_for_activity", run

data/lib/deployangel/core/fingerprint.rb

@@ -46,10 +46,14 @@ module DeployAngel
       "#{normalize_path(path, root)}##{label}"
     end
 
-    # Application frames only, relative to the root.
+    # Application frames only, relative to the root. An exception raised
+    # entirely in gems (a mailer job's SMTP timeout) has none, so it gets its
+    # first frames instead, normalized as in top_frame: they're the only way
+    # to tell which gem's path failed.
     def backtrace(exception, root:)
-      locations(exception).select { |path, _| app_path?(path, root) }.first(MAX_BACKTRACE)
-        .map { |path, label| "#{normalize_path(path, root)}##{label}" }
+      frames = locations(exception)
+      app = frames.select { |path, _| app_path?(path, root) }
+      (app.empty? ? frames : app).first(MAX_BACKTRACE).map { |path, label| "#{normalize_path(path, root)}##{label}" }
     end
 
     # Only quoted values, numbers, emails, UUIDs, and long hex are replaced;

data/lib/deployangel/mcp.rb

@@ -31,6 +31,11 @@ module DeployAngel
         Only act on status "exercisable" or "waiting_for_activity"; for "warm_up" or
         "no_baseline" nothing you run can clear it. Exercise routes marked mutating only with a test account
         or after asking. Report what you ran with the plan's report_with command (deployangel check).
+        A failing volume_drop or checkpoint_rate finding with an accept_url may be an intended change, such as
+        a route or job you removed on purpose. You cannot accept it, and must not try: tell the user why you
+        think it was intended, with your evidence, and give them the accept_url so a person decides. Until
+        someone accepts it, the release is failed: never report it as success. A finding with status
+        accepted was accepted as intended by the person in accepted_as_intended.
       TEXT
 
       TARGET_PROPERTIES = {
@@ -117,7 +122,7 @@ module DeployAngel
             TARGET_PROPERTIES),
           tool("list_deployments", "Recent deployments with their verification state and verdict.",
             { "limit" => { "type" => "integer", "minimum" => 1, "maximum" => 50, "default" => 10 } }),
-          tool("get_exception", "Sanitized details and the application stack trace for an exception fingerprint.",
+          tool("get_exception", "Sanitized details and a representative stack trace (application frames, or library frames when there are none) for an exception fingerprint.",
             { "fingerprint" => { "type" => "string" } }, required: %w[fingerprint]),
           tool("list_late_regressions", "Failures found after a release was cleared, on paths the clearance did not cover.",
             { "since" => { "type" => "string", "description" => "ISO 8601 time" },

data/lib/deployangel/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DeployAngel
-  VERSION = "0.1.36"
+  VERSION = "0.1.38"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: deployangel
 version: !ruby/object:Gem::Version
-  version: 0.1.36
+  version: 0.1.38
 platform: ruby
 authors:
 - Jordan Owens