depengine 3.0.20 → 3.0.21

data/lib/depengine/processor/erb_template.rb

@@ -1,65 +1,61 @@
 module Processor
-  class Erb_template
+  class ErbTemplate
     include Processor
     attr_accessor :basepath
-    attr_writer   :cdb
+    attr_writer :cdb
 
     # Render a template and write the output to a file or directory
     # structure under 'basepath'
-    def parse_template(template_source, content, outdir, options={})
-      Helper.validates_presence_of basepath, "Basepath not set for template engine"
+    def parse_template(template_source, _content, outdir, options = {})
+      Helper.validates_presence_of basepath, 'Basepath not set for template engine'
       # expand basepath
       self.basepath = File.expand_path basepath
 
-      if File.file?( File.join( basepath, template_source ) )
-        source_root_path = File.join( basepath, File.dirname(template_source) )
-        single_file      = File.join( basepath, template_source )
+      if File.file?(File.join(basepath, template_source))
+        source_root_path = File.join(basepath, File.dirname(template_source))
+        single_file      = File.join(basepath, template_source)
       else
         # source is a directory
-        source_root_path = File.join( basepath, template_source)
+        source_root_path = File.join(basepath, template_source)
         single_file      = nil
       end
-      target_root_path = File.join( basepath, outdir )
+      target_root_path = File.join(basepath, outdir)
       target_path      = target_root_path
 
-      Find.find( single_file || source_root_path ) do |path|
+      Find.find(single_file || source_root_path) do |path|
         # next if we found ourself
         next if path == source_root_path
-          
-        sub_dir     = File.join( File.dirname( path ).split(/\//) - \
-                      source_root_path.split(/\//) )
-        target_path = File.join( target_root_path, sub_dir )
-        target      = File.join( target_path, File.basename( path ) )
 
-        if not options[:excludes].nil?
+        sub_dir     = File.join(File.dirname(path).split(/\//) - \
+                      source_root_path.split(/\//))
+        target_path = File.join(target_root_path, sub_dir)
+        target      = File.join(target_path, File.basename(path))
+
+        if options[:excludes]
           options[:excludes].each do |exclude|
-            if target.include? exclude
-              $log.writer.debug "Skip template #{target}"
-              Find.prune
-              next
-            end
+            next unless target.include? exclude
+            $log.writer.debug "Skip template #{target}"
+            Find.prune
           end
         end
 
         if File.directory? path
-          if not File.directory? target
-            FileUtils.mkdir_p( target )
+          unless File.directory? target
+            FileUtils.mkdir_p(target)
             $log.writer.debug "Create directory #{target}"
           end
         else
-          target_file = File.join( target_path, \
-                                   File.basename(target, ".erb"))
+          target_file = File.join(target_path, \
+                                  File.basename(target, '.erb'))
           begin
             if not File.binary? path and not File.zero? path
               writer = File.new(target_file, 'w')
-              # writer.write(parse(path, content))
-              writer.write(ERB.new(File.read(path)).result())
-              writer.close if not writer.nil?
-              writer = nil
+              writer.write(ERB.new(File.read(path)).result)
+              writer.close unless writer.nil?
             else
               FileUtils.cp(path, File.expand_path(target_file))
             end
-          rescue Exception => e
+          rescue => e
             $log.writer.error "Can not write output from template to #{target_file}"
             $log.writer.error e.message
             exit 1
@@ -78,50 +74,49 @@ module Processor
     def parse(template, content)
       context = load_tags(content, @cdb)
       begin
-        parser           = Radius::Parser.new(context, :tag_prefix => 't')  
-        template_content = ""
-        result           = ""
+        parser           = Radius::Parser.new(context, tag_prefix: 't')
+        template_content = ''
+        result           = ''
         if File.file? template
-          read_mode        = ""
+          read_mode        = ''
           if RUBY_VERSION < '1.9'
             read_mode = 'r'
           else
             read_mode = 'rb'
           end
           File.open(template, read_mode) do |f|
-            c = ""
-            f.ungetc c unless (c = f.getc)=="\uFEFF" # remove BOM, if present
-            while line = f.gets
+            c = '' # rubocop:disable Lint/UselessAssignment
+            f.ungetc c unless (c = f.getc) == "\uFEFF" # remove BOM, if present
+            while line = f.gets # rubocop:disable Lint/AssignmentInCondition
               template_content << line
             end
           end
         else
           template_content = template
         end
- 
-        result          = parser.parse(template_content) 
-        nested_result_1 = ""
+
+        result          = parser.parse(template_content)
+        nested_result_1 = ''
         nested_result_2 = result
         nested_loop     = 0
-        while( nested_result_1 != nested_result_2 )
+        while ( nested_result_1 != nested_result_2)
           if nested_loop >= 100
-            $log.writer.error "Template stack overflow, too many nested tags"
+            $log.writer.error 'Template stack overflow, too many nested tags'
             exit 1
           end
           nested_result_1 = parser.parse(nested_result_2)
           nested_result_2 = parser.parse(nested_result_1)
 
           nested_loop = nested_loop + 1
-       end
-       result = nested_result_2
-      rescue Exception => e
+        end
+        result = nested_result_2
+      rescue => e
         $log.writer.error "Error in template processing: #{template}"
         $log.writer.error e.message
         exit 1
       end
-  
+
       result
     end
   end
 end
-

data/lib/depengine/processor/fileops.rb

@@ -1,74 +1,66 @@
 module Processor
-  def copy(source, target, options={})
-    begin
-      if not options[:match].nil? and File.directory? source
-        Dir.glob(File.join(source, "*")) do |entry|
-          if File.fnmatch(options[:match], entry)
-            $log.writer.debug "Copy #{entry} to #{target}"
-            FileUtils.cp_r(entry, target)
-          end
+  def copy(source, target, options = {})
+    if not options[:match].nil? and File.directory? source
+      Dir.glob(File.join(source, '*')) do |entry|
+        if File.fnmatch(options[:match], entry)
+          $log.writer.debug "Copy #{entry} to #{target}"
+          FileUtils.cp_r(entry, target)
         end
-      else
-        $log.writer.debug "Copy #{source} to #{target}"
-        FileUtils.cp_r(source, target)
       end
-    rescue Exception => e
-      $log.writer.error "Can not copy #{source} to #{target}"
-      $log.writer.error e.message
-      exit 1
+    else
+      $log.writer.debug "Copy #{source} to #{target}"
+      FileUtils.cp_r(source, target)
     end
+  rescue => e
+    $log.writer.error "Can not copy #{source} to #{target}"
+    $log.writer.error e.message
+    exit 1
   end
   module_function :copy
 
   def mkdir(directory)
-    begin
-      FileUtils.mkdir_p(directory)
-      $log.writer.debug "Create directory #{directory}"
-    rescue Exception => e
-      $log.writer.error "Can not create directory #{directory}"
-      $log.writer.error e.message
-      exit 1
-    end
+    FileUtils.mkdir_p(directory)
+    $log.writer.debug "Create directory #{directory}"
+  rescue => e
+    $log.writer.error "Can not create directory #{directory}"
+    $log.writer.error e.message
+    exit 1
   end
   module_function :mkdir
 
-  def chmod(file, mode, options={})
-    begin
-      if not options[:recursive].nil? and options[:recursive] == true
-        FileUtils.chmod_R(mode, file)
-      else
-        FileUtils.chmod(mode, file)
-      end
-      $log.writer.debug "Chmod #{file} to #{mode}"
-    rescue Exception => e
-      $log.writer.error "Can not change mode on file #{file}"
-      $log.writer.error e.message
-      exit 1
+  def chmod(file, mode, options = {})
+    if not options[:recursive].nil? and options[:recursive] == true
+      FileUtils.chmod_R(mode, file)
+    else
+      FileUtils.chmod(mode, file)
     end
+    $log.writer.debug "Chmod #{file} to #{mode}"
+  rescue => e
+    $log.writer.error "Can not change mode on file #{file}"
+    $log.writer.error e.message
+    exit 1
   end
   module_function :chmod
 
   def remove(file)
-    begin
-      FileUtils.rm_rf(file)
-      $log.writer.debug "Delete #{file}"
-    rescue Exception => e
-      $log.writer.error "Can not delete file #{file}"
-      $log.writer.error e.message
-      exit 1
-    end
+    FileUtils.rm_rf(file)
+    $log.writer.debug "Delete #{file}"
+  rescue => e
+    $log.writer.error "Can not delete file #{file}"
+    $log.writer.error e.message
+    exit 1
   end
   module_function :remove
 
   def mklink(source, target)
-    if not File.exists? source
+    unless File.exist? source
       $log.writer.debug \
-        "Create link to nowhere, this deployment is broken by design!"
+        'Create link to nowhere, this deployment is broken by design!'
     end
     begin
       $log.writer.debug "Create link from #{source} to #{target}"
       FileUtils.ln_s(source, target)
-    rescue Exception => e
+    rescue => e
       $log.writer.error "Can not create link #{target}"
       $log.writer.error e.message
       exit 1
@@ -80,7 +72,7 @@ module Processor
     CSV.foreach(list) do |file|
       if not file.nil? and not file.first.nil?
         $log.writer.debug "Checking file #{File.join(target, file.first)}"
-        if not File.exists?( File.join(target, file.first) )
+        unless File.exist?(File.join(target, file.first))
           $log.writer.error "Necessary file not found: #{file}"
           exit 1
         end
@@ -89,4 +81,3 @@ module Processor
   end
   module_function :check_filelist
 end
-

data/lib/depengine/processor/local_execute.rb

@@ -1,17 +1,19 @@
 module Processor
-
   def local_execute(shell_cmds)
+    outputs = []
     shell_cmds.each do |shell_cmd|
+      outputs.push shell_cmd
       $log.writer.debug "executing: #{shell_cmd}"
-      output = %x[ /bin/bash --login -c \"#{shell_cmd}\" ]
-      if $?.exitstatus == 0
+      output = ` /bin/bash --login -c \"#{shell_cmd}\" `
+      outputs.push output
+      if $CHILD_STATUS.exitstatus == 0
         $log.writer.debug output
       else
         $log.writer.error output
         exit 1
       end
     end
+    outputs
   end
   module_function :local_execute
-
 end

data/lib/depengine/processor/properties.rb

@@ -1,49 +1,41 @@
 module Processor
   class Properties
-
     attr_accessor :properties_hash
     attr_accessor :assigner
 
-    def initialize()
-      properties_hash = {}
-      assigner        = "="
+    def initialize
+      @properties_hash = {}
+      @assigner        = '='
     end
 
     ### patch properties (key/value)
     def patch(source, target)
-
-      if not File.file? source
+      unless File.file? source
         $log.writer.error "File #{source} does not exists"
         exit 1
       end
 
       if target.nil?
-        $log.writer.error "Parameter target not set"
+        $log.writer.error 'Parameter target not set'
         exit 1
       end
 
       if target.length == 0
-        $log.writer.error "Parameter target not set"
+        $log.writer.error 'Parameter target not set'
         exit 1
       end
 
       data = File.open(source, 'rb').readlines
-      target_file = File.open(target, "w")
+      target_file = File.open(target, 'w')
 
-      data.each { |entry|
+      data.each do |entry|
         if entry.include? assigner
-          keyvalue = entry.split(assigner,2)
+          keyvalue = entry.split(assigner, 2)
 
           # convert all inputs to String
-          if keyvalue[0].class != String
-            keyvalue[0] = keyvalue[0].to_s
-          end
-          if keyvalue[1].class != String
-            keyvalue[1] = keyvalue[1].to_s
-          end
-          if properties_hash[keyvalue[0].strip].class != String
-            properties_hash[keyvalue[0].strip] = properties_hash[keyvalue[0].strip].to_s
-          end
+          keyvalue[0] = keyvalue[0].to_s if keyvalue[0].class != String
+          keyvalue[1] = keyvalue[1].to_s if keyvalue[1].class != String
+          properties_hash[keyvalue[0].strip] = properties_hash[keyvalue[0].strip].to_s if properties_hash[keyvalue[0].strip].class != String
 
           if not properties_hash[keyvalue[0].strip].nil? and
              not properties_hash[keyvalue[0].strip].empty?
@@ -63,63 +55,56 @@ module Processor
           end
         end
         target_file.puts entry
-      }
+      end
 
       target_file.close
-
     end
 
     ### patch strings
     def substitute(source, target)
-
-      if not File.file? source
+      unless File.file? source
         $log.writer.error "File #{source} does not exists"
         exit 1
       end
 
       data        = File.open(source, 'rb').readlines
-      target_file = File.open(target, "w")
+      target_file = File.open(target, 'w')
 
-      data.each { |entry|
-        properties_hash.keys.each { |hashkey|
+      data.each do |entry|
+        properties_hash.keys.each do |hashkey|
           hashkey = hashkey.to_s
           entry = entry.sub(hashkey, properties_hash[hashkey].to_s)
           ### patch global variable
-          if not entry.nil? and entry.include?('<t:db_endpoint_1/>')
-            entry = entry.sub(/<t\:db_endpoint_1\/>/, properties_hash['db_endpoint_1'])
-          end
-          if not entry.nil? and entry.include?('<t:db_endpoint_2/>')
-            entry = entry.sub(/<t\:db_endpoint_2\/>/, properties_hash['db_endpoint_2'])
-          end
+          next if entry.nil?
+          entry = entry.sub(/<t\:db_endpoint_1\/>/, properties_hash['db_endpoint_1']) if entry.include?('<t:db_endpoint_1/>')
+          entry = entry.sub(/<t\:db_endpoint_2\/>/, properties_hash['db_endpoint_2']) if entry.include?('<t:db_endpoint_2/>')
 
-        }
+        end
         target_file.puts entry
-      }
+      end
 
       target_file.close
-
     end
 
     ### patch all recursive directory
     def substitute_r(source, target)
-
-      if not File.directory? source
+      unless File.directory? source
         $log.writer.error "Directory #{source} does not exists"
         exit 1
       end
 
       basepath_array = source.split('/')
 
-      Dir.glob( source + "/**/*" ) do |file|
+      Dir.glob(source + '/**/*') do |file|
         keep_path = File.join(file.split('/') - basepath_array)
         if File.file? file
-          target_path = File.join( target, keep_path)
-          target_basepath = File.join( File.split(target_path).first )
+          target_path = File.join(target, keep_path)
+          target_basepath = File.join(File.split(target_path).first)
 
-          if not File.directory?(target_basepath)
+          unless File.directory?(target_basepath)
             begin
               FileUtils.mkdir_p target_basepath
-            rescue Exception => e
+            rescue => e
               $log.writer.error "Can not create directory #{target_basepath}"
               $log.writer.error e.message
               exit 1
@@ -128,31 +113,24 @@ module Processor
           substitute(file, target_path)
         end
       end
-
     end
 
     ### append strings
     def add(source, target)
-
-      if not File.file? source
+      unless File.file? source
         $log.writer.error "File #{source} does not exists"
-        exit 1
+        fail "File #{source} does not exists"
       end
 
-      if source.strip != target.strip
-         FileUtils.copy_file(source, target)
-      end
+      FileUtils.copy_file(source, target) if source.strip != target.strip
 
-      target_file = File.open(target, "a")
+      target_file = File.open(target, 'a')
 
-      properties_hash.each_value { |value|
+      properties_hash.each_value do |value|
         target_file.puts value
-      }
+      end
 
       target_file.close
-
     end
-
   end
-
 end

data/lib/depengine/processor/sed.rb

@@ -1,40 +1,36 @@
   module Sed
-
     def self.copy(source, target, pattern, replacement)
-      if not File.file? source
+      unless File.file? source
         $log.writer.error "File #{source} does not exists"
         exit 1
       end
-  
-      File.open(source, "r:UTF-8") do |source_file|
+
+      File.open(source, 'r:UTF-8') do |source_file|
         content = source_file.read
         content.gsub!(pattern, replacement)
-        File.open(target, "w:UTF-8") do |target_file|
+        File.open(target, 'w:UTF-8') do |target_file|
           target_file.write(content)
           target_file.close
         end
         source_file.close
       end
-
     end
 
     def self.patch(filename, pattern, replacement)
-      if not File.file? filename
+      unless File.file? filename
         $log.writer.error "File #{filename} does not exists"
         exit 1
       end
 
-      content = ""
-      File.open(filename, "r:UTF-8") do |source_file|
+      content = ''
+      File.open(filename, 'r:UTF-8') do |source_file|
         content = source_file.read
         content.gsub!(pattern, replacement)
         source_file.close
       end
-      File.open(filename, "w:UTF-8") do |target_file|
+      File.open(filename, 'w:UTF-8') do |target_file|
         target_file.write(content)
         target_file.close
       end
-
     end
-    
   end

data/lib/depengine/processor/tags.rb

@@ -2,21 +2,21 @@ module Processor
   def load_tags(content, cdb)
     begin
       context = Radius::Context.new do |c|
-        # map all parameters from 'content' to a tag with the same name 
+        # map all parameters from 'content' to a tag with the same name
         content.each do |content_param|
-          c.define_tag "#{content_param.first}" do |tag|
-            tag = content_param.last
+          c.define_tag "#{content_param.first}" do |_tag|
+            tag = content_param.last # rubocop:disable Lint/UselessAssignment
           end
         end
 
         # include external file
         c.define_tag 'include' do |tag|
           result   = ''
-          ext_file = File.join( ENV['WORKSPACE'], tag.attr['file'] )
-          if File.exists?(ext_file)
+          ext_file = File.join(ENV['WORKSPACE'], tag.attr['file'])
+          if File.exist?(ext_file)
             result = File.open(ext_file).read
           else
-            puts "Warning: can not read static data " + ext_file
+            puts 'Warning: can not read static data ' + ext_file
           end
           result
         end
@@ -40,13 +40,13 @@ module Processor
             puts "Warning: CDB not set for Template-Engine in tag 'feature_flag'"
           end
           result
-        end 
+        end
 
-        c.define_tag "echo" do |tag|
+        c.define_tag 'echo' do |tag|
           tag.expand
         end
       end
-    rescue Exception => e
+    rescue => e
       $log.writer.error "Error in tag definition: #{e.message}"
       $log.writer.error e.backtrace
       exit 1
@@ -55,4 +55,3 @@ module Processor
     context
   end
 end
-