dependent-auto-rails 0.1.1 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cc488255df657376a661c6c0271a4a6c715b7d9750eae2e7379c3f130394d9f5
-  data.tar.gz: 44027a37768078d613b2c8a5c9e39af7debab23b48fd238e09fd9b5ea6f7e0ae
+  metadata.gz: 9f580a4dd1d2381f710091f77c3f788db32d52454cbbc15a8d19234cfac2b6cc
+  data.tar.gz: 2b93ef9a7b4d3bf9a51040710f6f0234a5688286ea1f80b2dd77e16e46387f06
 SHA512:
-  metadata.gz: 3c47b956dd0dfdd5c70b70cab2ed468ee1be646c5e8b6743a3fca27a7becbcfc34c77f5bd1624f43f5b15794f62880861b71c42aba8eb48d55c4f0d7d6604252
-  data.tar.gz: 0e67e0329c0fd635b5112a5d064c177e7f6d0e4421b83bbde2c9721ba00d3310c05cac76c35c6f454cb9f9d33aaa3a7cd28f45c8ef718c2f83cc82033003b4bd
+  metadata.gz: 3cff57105377c3bce1c4d21a89201ee53b9a902041f24954ed7a6ad5df5d614adc409969538c9e7aaf4dc2f0c99f0f1daceff34764ce10084408257c51aa718f
+  data.tar.gz: b07c8991a259bcf4e0bab63e11927b848a4ef138495f827a02a790c42b4ac52b52a2bd09ce3a09349d982556daef63220911ad7e16c83759a37fc8c839bede84

data/lib/dependent-auto-rails/activerecord/associations/builder/association.rb

@@ -2,27 +2,66 @@
 
 module ActiveRecord::Associations::Builder
   class Association
-    def self.build(model, name, scope, options, &block)
-      if model.dangerous_attribute_method?(name)
-        raise ArgumentError, "You tried to define an association named #{name} on the model #{model.name}, but " \
-                             "this will conflict with a method #{name} already defined by Active Record. " \
-                             "Please choose a different association name."
-      end
+    def self.create_reflection(model, name, scope, options, &block)
+      raise ArgumentError, "association names must be a Symbol" unless name.is_a?(Symbol)
+
+      validate_options(options)
+
+      extension = define_extensions(model, name, &block)
+      options[:extend] = [*options[:extend], extension] if extension
+
+      scope = build_scope(scope)
+
+      ActiveRecord::Reflection.create(macro, name, scope, dynamic_reflection_options(model, options), model)
+    end
+
+    def self.dynamic_reflection_options(model, options)
+      DynamicReflectionOptionsHash.new.merge!(
+        options,
+        {
+          model_name: model.name,
+          association_type: if self < ActiveRecord::Associations::Builder::SingularAssociation
+                              :singular
+                            elsif self < ActiveRecord::Associations::Builder::CollectionAssociation
+                              :collection
+                            else
+                              raise DependentAutoRails::Error, "Unsupported association type"
+                            end
+        }
+      )
+    end
+
+    class DynamicReflectionOptionsHash < Hash
+      def [](key)
+        return super unless key == :dependent && super(:dependent) == :auto
+        return fallback_method if defining_dependent_callbacks?
 
-      if options[:dependent] == :auto
-        options[:dependent] = if model._destroy_callbacks.empty?
-          :destroy
-        else
-          :delete
+        model = super(:model_name).constantize
+        return :destroy unless valid_destroy_callbacks(model).empty?
+
+        case super(:association_type)
+        when :singular then :delete
+        when :collection then :delete_all
+        else fallback_method
         end
       end
 
-      reflection = create_reflection(model, name, scope, options, &block)
-      define_accessors model, reflection
-      define_callbacks model, reflection
-      define_validations model, reflection
-      define_change_tracking_methods model, reflection
-      reflection
+      private
+
+      def fallback_method
+        :destroy
+      end
+
+      def defining_dependent_callbacks?
+        caller.any? { |line| line.include?("active_record/associations/builder/association.rb") }
+      end
+
+      def valid_destroy_callbacks(model)
+        model._destroy_callbacks.reject do |callback|
+          # ignore #handle_dependency callback
+          callback.filter.to_s.include?("active_record/associations/builder/association.rb")
+        end
+      end
     end
   end
 end

data/lib/dependent-auto-rails/activerecord/associations/builder/belongs_to.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+module ActiveRecord::Associations::Builder
+  class BelongsTo < SingularAssociation
+    def self.valid_dependent_options
+      [:auto, :destroy, :delete, :destroy_async]
+    end
+    private_class_method :valid_dependent_options
+  end
+end

data/lib/dependent-auto-rails/activerecord/associations/builder/has_many.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+module ActiveRecord::Associations::Builder
+  class HasMany < CollectionAssociation
+    def self.valid_dependent_options
+      [:auto, :destroy, :delete_all, :nullify, :restrict_with_error, :restrict_with_exception, :destroy_async]
+    end
+    private_class_method :valid_dependent_options
+  end
+end

data/lib/dependent-auto-rails/activerecord/associations/builder/has_one.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+module ActiveRecord::Associations::Builder
+  class HasOne < SingularAssociation
+    def self.valid_dependent_options
+      [:auto, :destroy, :destroy_async, :delete, :nullify, :restrict_with_error, :restrict_with_exception]
+    end
+    private_class_method :valid_dependent_options
+  end
+end

data/lib/dependent-auto-rails/dependent_auto_rails.rb

@@ -1,3 +1,15 @@
 # frozen_string_literal: true
 
-require "dependent-auto-rails/activerecord/associations/builder/association"
+require "active_record"
+require "active_support"
+
+ActiveSupport.on_load(:active_record) do
+  require "dependent-auto-rails/activerecord/associations/builder/belongs_to"
+  require "dependent-auto-rails/activerecord/associations/builder/has_one"
+  require "dependent-auto-rails/activerecord/associations/builder/has_many"
+  require "dependent-auto-rails/activerecord/associations/builder/association"
+end
+
+module DependentAutoRails
+  class Error < StandardError; end
+end

data/lib/dependent-auto-rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DependentAutoRails
-  VERSION = "0.1.1"
+  VERSION = "0.1.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dependent-auto-rails
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.3
 platform: ruby
 authors:
 - Joshua Young
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '7'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description:
 email:
 - djry1999@gmail.com
@@ -36,6 +50,9 @@ files:
 - LICENSE.txt
 - README.md
 - lib/dependent-auto-rails/activerecord/associations/builder/association.rb
+- lib/dependent-auto-rails/activerecord/associations/builder/belongs_to.rb
+- lib/dependent-auto-rails/activerecord/associations/builder/has_many.rb
+- lib/dependent-auto-rails/activerecord/associations/builder/has_one.rb
 - lib/dependent-auto-rails/dependent_auto_rails.rb
 - lib/dependent-auto-rails/version.rb
 homepage: https://github.com/joshuay03/dependent-auto-rails
@@ -64,6 +81,6 @@ requirements: []
 rubygems_version: 3.5.3
 signing_key:
 specification_version: 4
-summary: Automatically and safely decides between :destroy and :delete for your Rails
-  associations.
+summary: Automatically and safely decides between :destroy and :delete / :delete_all
+  for your Rails associations.
 test_files: []