dependabot-nuget 0.332.0 → 0.334.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e6bbee42facfccb155527977271b6e2c13a20efb4a2c090d9595574eaa58c56e
-  data.tar.gz: ff25f01a12aab33d132a6afff2f3a43d022c2dd7ea6568a05a9f80ce4a267ccf
+  metadata.gz: d5bc345f5a8be77b0f05bc15e1b0a59d0d3ccff75e11d29a6947bd43fa29e51a
+  data.tar.gz: adc18fffb9a39e742ddacfa761693070290b0b0679fa9c2ca5193694e02d9f47
 SHA512:
-  metadata.gz: beb497e8f6f3de50529210ee903cb483d0bbc03216a3cf2fd44a5fcde61699a9c0ffcd3785c544da1168768f32f734070752172ffb0f63ed7df33352e4947bb9
-  data.tar.gz: 777c2a8d6a61915f1f9fcf3bedb906dac7f79d9916609524f056d58bd3a2328d46290b83ba9bc5399f8462c20942367ebd378f1e5cc057f43502f0426ee46ffa
+  metadata.gz: f7e0a0f0bc859b36a0ddc02bb1e77418c56108cfe1993665598742f74fc2191f574ad7063b73b09a579864b13921db088509423ebb93bb3716a2cce5e95c3c5b
+  data.tar.gz: c39e5e3021996dad4a12616f79beb0493e47fa81baa75e23aaf192d9acfc0dc067720137184b22088d0ea7e7e2e35108f8ba50717e4393b9a21f2547b21485c7

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/DiscoveryWorker.cs

@@ -106,7 +106,11 @@ public partial class DiscoveryWorker : IDiscoveryWorker
             _logger.Info($"Workspace path [{workspacePath}] does not exist.");
         }
 
-        //if any projectResults are not successful, return a failed result
+        // filter to only projects in the repo that could possibly be updated
+        var repoRoot = new DirectoryInfo(repoRootPath);
+        projectResults = [.. projectResults.Where(p => PathHelper.IsFileUnderDirectory(repoRoot, new FileInfo(Path.Join(workspacePath, p.FilePath))))];
+
+        // if any projectResults are not successful, return a failed result
         if (projectResults.Any(p => p.IsSuccess == false))
         {
             var failedProjectResult = projectResults.Where(p => p.IsSuccess == false).First();

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/ExperimentsManager.cs

@@ -7,14 +7,12 @@ namespace NuGetUpdater.Core;
 
 public record ExperimentsManager
 {
-    public bool EnableCooldown { get; init; } = false;
     public bool GenerateSimplePrBody { get; init; } = false;
 
     public Dictionary<string, object> ToDictionary()
     {
         return new()
         {
-            ["enable_cooldown_for_nuget"] = EnableCooldown,
             ["nuget_generate_simple_pr_body"] = GenerateSimplePrBody,
         };
     }
@@ -23,7 +21,6 @@ public record ExperimentsManager
     {
         return new ExperimentsManager()
         {
-            EnableCooldown = IsEnabled(experiments, "enable_cooldown_for_nuget"),
             GenerateSimplePrBody = IsEnabled(experiments, "nuget_generate_simple_pr_body"),
         };
     }

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Run/UpdateHandlers/GroupUpdateAllVersionsHandler.cs

@@ -104,7 +104,7 @@ internal class GroupUpdateAllVersionsHandler : IUpdateHandler
                         continue;
                     }
 
-                    var dependencyInfo = RunWorker.GetDependencyInfo(job, dependency, allowCooldown: experimentsManager.EnableCooldown);
+                    var dependencyInfo = RunWorker.GetDependencyInfo(job, dependency, allowCooldown: true);
                     var analysisResult = await analyzeWorker.RunAsync(repoContentsPath.FullName, discoveryResult, dependencyInfo);
                     if (analysisResult.Error is not null)
                     {
@@ -207,7 +207,7 @@ internal class GroupUpdateAllVersionsHandler : IUpdateHandler
                         continue;
                     }
 
-                    var dependencyInfo = RunWorker.GetDependencyInfo(job, dependency, allowCooldown: experimentsManager.EnableCooldown);
+                    var dependencyInfo = RunWorker.GetDependencyInfo(job, dependency, allowCooldown: true);
                     var analysisResult = await analyzeWorker.RunAsync(repoContentsPath.FullName, discoveryResult, dependencyInfo);
                     if (analysisResult.Error is not null)
                     {

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Run/UpdateHandlers/RefreshGroupUpdatePullRequestHandler.cs

@@ -93,7 +93,7 @@ internal class RefreshGroupUpdatePullRequestHandler : IUpdateHandler
                 var dependencyName = dependencyGroupToUpdate.Key;
                 var relevantDependenciesToUpdate = dependencyGroupToUpdate.Value
                     .Where(o => !job.IsDependencyIgnoredByNameOnly(o.Dependency.Name))
-                    .Select(o => (o.ProjectPath, o.Dependency, RunWorker.GetDependencyInfo(job, o.Dependency, allowCooldown: experimentsManager.EnableCooldown)))
+                    .Select(o => (o.ProjectPath, o.Dependency, RunWorker.GetDependencyInfo(job, o.Dependency, allowCooldown: true)))
                     .ToArray();
 
                 foreach (var (projectPath, dependency, dependencyInfo) in relevantDependenciesToUpdate)

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Run/UpdateHandlers/RefreshVersionUpdatePullRequestHandler.cs

@@ -81,7 +81,7 @@ internal class RefreshVersionUpdatePullRequestHandler : IUpdateHandler
                 var dependencyName = dependencyUpdatesToPerform.Key;
                 var dependencyInfosToUpdate = dependencyUpdatesToPerform.Value
                     .Where(o => !job.IsDependencyIgnoredByNameOnly(o.Dependency.Name))
-                    .Select(o => (o.ProjectPath, o.Dependency, RunWorker.GetDependencyInfo(job, o.Dependency, allowCooldown: experimentsManager.EnableCooldown)))
+                    .Select(o => (o.ProjectPath, o.Dependency, RunWorker.GetDependencyInfo(job, o.Dependency, allowCooldown: true)))
                     .ToArray();
 
                 foreach (var (projectPath, dependency, dependencyInfo) in dependencyInfosToUpdate)

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Run/MiscellaneousTests.cs

@@ -515,9 +515,9 @@ public class MiscellaneousTests
 
     [Theory]
     [MemberData(nameof(DependencyInfoFromJobData))]
-    public void DependencyInfoFromJob(Job job, Dependency dependency, bool enableCooldown, DependencyInfo expectedDependencyInfo)
+    public void DependencyInfoFromJob(Job job, Dependency dependency, DependencyInfo expectedDependencyInfo)
     {
-        var actualDependencyInfo = RunWorker.GetDependencyInfo(job, dependency, enableCooldown);
+        var actualDependencyInfo = RunWorker.GetDependencyInfo(job, dependency, allowCooldown: true);
         var expectedString = JsonSerializer.Serialize(expectedDependencyInfo, AnalyzeWorker.SerializerOptions);
         var actualString = JsonSerializer.Serialize(actualDependencyInfo, AnalyzeWorker.SerializerOptions);
         Assert.Equal(expectedString, actualString);
@@ -634,8 +634,6 @@ public class MiscellaneousTests
             },
             // dependency
             new Dependency("Some.Dependency", "1.0.0", DependencyType.PackageReference),
-            // enableCooldown
-            true,
             // expectedDependencyInfo
             new DependencyInfo()
             {
@@ -681,8 +679,6 @@ public class MiscellaneousTests
             },
             // dependency
             new Dependency("Some.Dependency", "1.0.0", DependencyType.PackageReference),
-            // enableCooldown
-            true,
             // expectedDependencyInfo
             new DependencyInfo()
             {
@@ -716,8 +712,6 @@ public class MiscellaneousTests
             },
             // dependency
             new Dependency("Some.Dependency", "1.0.0", DependencyType.PackageReference),
-            // enableCooldown
-            true,
             // expectedDependencyInfo
             new DependencyInfo()
             {
@@ -759,8 +753,6 @@ public class MiscellaneousTests
             },
             // dependency
             new Dependency("Some.Dependency", "1.0.0", DependencyType.PackageReference),
-            // enableCooldown
-            true,
             // expectedDependencyInfo
             new DependencyInfo()
             {
@@ -803,8 +795,6 @@ public class MiscellaneousTests
             },
             // dependency
             new Dependency("Some.Dependency", "1.0.0", DependencyType.PackageReference),
-            // enableCooldown
-            true,
             // expectedDependencyInfo
             new DependencyInfo()
             {
@@ -818,41 +808,6 @@ public class MiscellaneousTests
             },
         ];
 
-        // with cooldown object when `include` matches but experiment flag is false
-        yield return
-        [
-            // job
-            new Job()
-            {
-                Source = new()
-                {
-                    Provider = "github",
-                    Repo = "some/repo",
-                },
-                Cooldown = new()
-                {
-                    DefaultDays = 4,
-                    SemVerMajorDays = 3,
-                    SemVerMinorDays = 2,
-                    SemVerPatchDays = 1,
-                    Include = ["Some.*"],
-                }
-            },
-            // dependency
-            new Dependency("Some.Dependency", "1.0.0", DependencyType.PackageReference),
-            // enableCooldown
-            false,
-            // expectedDependencyInfo
-            new DependencyInfo()
-            {
-                Name = "Some.Dependency",
-                Version = "1.0.0",
-                IsVulnerable = false,
-                IgnoredVersions = [],
-                Vulnerabilities = [],
-                IgnoredUpdateTypes = [],
-                Cooldown = null
-            },
-        ];
+
     }
 }

data/helpers/lib/NuGetUpdater/global.json

@@ -1,5 +1,6 @@
 {
   "sdk": {
+    "// comment": "this version should be kept in sync with the files `.devcontainer/devcontainer.json` and `nuget/Dockerfile`",
     "version": "9.0.302",
     "rollForward": "latestMinor"
   }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dependabot-nuget
 version: !ruby/object:Gem::Version
-  version: 0.332.0
+  version: 0.334.0
 platform: ruby
 authors:
 - Dependabot
@@ -15,14 +15,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.332.0
+        version: 0.334.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.332.0
+        version: 0.334.0
 - !ruby/object:Gem::Dependency
   name: debug
   requirement: !ruby/object:Gem::Requirement
@@ -211,14 +211,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.18'
+        version: '3.25'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.18'
+        version: '3.25'
 - !ruby/object:Gem::Dependency
   name: webrick
   requirement: !ruby/object:Gem::Requirement
@@ -551,7 +551,7 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/dependabot/dependabot-core/issues
-  changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.332.0
+  changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.334.0
 rdoc_options: []
 require_paths:
 - lib