dependabot-nuget 0.322.0 → 0.322.1

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Update/PackageReferenceUpdaterTests.cs

@@ -11,164 +11,6 @@ namespace NuGetUpdater.Core.Test.Update;
 
 public class PackageReferenceUpdaterTests
 {
-    [Fact]
-    public async Task DirectBuildFileChangesAreMaintainedWhenPinningTransitiveDependency()
-    {
-        // arrange
-        using var tempDir = await TemporaryDirectory.CreateWithContentsAsync([("project.csproj", """
-            <Project Sdk="Microsoft.NET.Sdk">
-              <PropertyGroup>
-                <TargetFramework>net9.0</TargetFramework>
-              </PropertyGroup>
-              <ItemGroup>
-                <PackageReference Include="Completely.Different.Package" Version="1.0.0" />
-                <PackageReference Include="Some.Package" Version="1.0.0" />
-              </ItemGroup>
-            </Project>
-            """)]);
-        var packages = new[]
-        {
-            MockNuGetPackage.CreateSimplePackage("Completely.Different.Package", "1.0.0", "net9.0"),
-            MockNuGetPackage.CreateSimplePackage("Completely.Different.Package", "2.0.0", "net9.0"),
-            MockNuGetPackage.CreateSimplePackage("Some.Package", "1.0.0", "net9.0", [(null, [("Transitive.Package", "1.0.0")])]),
-            MockNuGetPackage.CreateSimplePackage("Transitive.Package", "1.0.0", "net9.0"),
-            MockNuGetPackage.CreateSimplePackage("Transitive.Package", "2.0.0", "net9.0"),
-        };
-        await UpdateWorkerTestBase.MockNuGetPackagesInDirectory(packages, tempDir.DirectoryPath);
-        var fullProjectPath = Path.Combine(tempDir.DirectoryPath, "project.csproj");
-        var buildFile = ProjectBuildFile.Open(tempDir.DirectoryPath, fullProjectPath);
-        var experimentsManager = new ExperimentsManager();
-
-        // act
-        // pin transitive dependency
-        var updatedFiles = await PackageReferenceUpdater.UpdateTransitiveDependencyAsync(
-            tempDir.DirectoryPath,
-            fullProjectPath,
-            "Transitive.Package",
-            "2.0.0",
-            [buildFile],
-            experimentsManager,
-            new TestLogger());
-
-        // subsequent update should not overwrite previous change
-        PackageReferenceUpdater.TryUpdateDependencyVersion([buildFile], "Completely.Different.Package", "1.0.0", "2.0.0", new TestLogger());
-
-        // assert
-        await buildFile.SaveAsync();
-        var actualContents = await File.ReadAllTextAsync(fullProjectPath, TestContext.Current.CancellationToken);
-        var expectedContents = """
-            <Project Sdk="Microsoft.NET.Sdk">
-              <PropertyGroup>
-                <TargetFramework>net9.0</TargetFramework>
-              </PropertyGroup>
-              <ItemGroup>
-                <PackageReference Include="Completely.Different.Package" Version="2.0.0" />
-                <PackageReference Include="Some.Package" Version="1.0.0" />
-                <PackageReference Include="Transitive.Package" Version="2.0.0" />
-              </ItemGroup>
-            </Project>
-            """;
-        Assert.Equal(expectedContents, actualContents);
-    }
-
-    [Fact]
-    public async Task DirectBuildFileChangesAreMaintainedWhenPinningTransitiveDependency_DirectoryPackagesPropsIsDiscovered()
-    {
-        // arrange
-        using var tempDir = await TemporaryDirectory.CreateWithContentsAsync(
-        [
-            ("project.csproj", """
-                 <Project Sdk="Microsoft.NET.Sdk">
-                   <PropertyGroup>
-                     <TargetFramework>net9.0</TargetFramework>
-                   </PropertyGroup>
-                   <ItemGroup>
-                     <PackageReference Include="Completely.Different.Package" />
-                     <PackageReference Include="Some.Package" />
-                   </ItemGroup>
-                 </Project>
-                 """),
-            ("Directory.Packages.props", """
-                <Project>
-                  <PropertyGroup>
-                    <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
-                  </PropertyGroup>
-                  <ItemGroup>
-                    <PackageVersion Include="Completely.Different.Package" Version="1.0.0" />
-                    <PackageVersion Include="Some.Package" Version="1.0.0" />
-                  </ItemGroup>
-                </Project>
-                """)
-        ]);
-        var packages = new[]
-        {
-             MockNuGetPackage.CreateSimplePackage("Completely.Different.Package", "1.0.0", "net9.0"),
-             MockNuGetPackage.CreateSimplePackage("Completely.Different.Package", "2.0.0", "net9.0"),
-             MockNuGetPackage.CreateSimplePackage("Some.Package", "1.0.0", "net9.0", [(null, [("Transitive.Package", "1.0.0")])]),
-             MockNuGetPackage.CreateSimplePackage("Transitive.Package", "1.0.0", "net9.0"),
-             MockNuGetPackage.CreateSimplePackage("Transitive.Package", "2.0.0", "net9.0"),
-         };
-        await UpdateWorkerTestBase.MockNuGetPackagesInDirectory(packages, tempDir.DirectoryPath);
-        var fullProjectPath = Path.Combine(tempDir.DirectoryPath, "project.csproj");
-        var fullDirectoryPackagesPath = Path.Combine(tempDir.DirectoryPath, "Directory.Packages.props");
-        var buildFiles = new[]
-        {
-            ProjectBuildFile.Open(tempDir.DirectoryPath, fullProjectPath),
-            ProjectBuildFile.Open(tempDir.DirectoryPath, fullDirectoryPackagesPath)
-        }.ToImmutableArray();
-        var experimentsManager = new ExperimentsManager();
-
-        // act
-        // pin transitive dependency
-        var updatedFiles = await PackageReferenceUpdater.UpdateTransitiveDependencyAsync(
-            tempDir.DirectoryPath,
-            fullProjectPath,
-            "Transitive.Package",
-            "2.0.0",
-            buildFiles,
-            experimentsManager,
-            new TestLogger());
-
-        // subsequent update should not overwrite previous change
-        PackageReferenceUpdater.TryUpdateDependencyVersion(buildFiles, "Completely.Different.Package", "1.0.0", "2.0.0", new TestLogger());
-
-        // assert
-        foreach (var bf in buildFiles)
-        {
-            await bf.SaveAsync();
-        }
-
-        var actualProjectContents = await File.ReadAllTextAsync(fullProjectPath, TestContext.Current.CancellationToken);
-        var expectedProjectContents = """
-             <Project Sdk="Microsoft.NET.Sdk">
-               <PropertyGroup>
-                 <TargetFramework>net9.0</TargetFramework>
-               </PropertyGroup>
-               <ItemGroup>
-                 <PackageReference Include="Completely.Different.Package" />
-                 <PackageReference Include="Some.Package" />
-                 <PackageReference Include="Transitive.Package" />
-               </ItemGroup>
-             </Project>
-             """;
-        Assert.Equal(expectedProjectContents.Replace("\r", ""), actualProjectContents.Replace("\r", ""));
-
-        var actualDirectoryPackagesContents = await File.ReadAllTextAsync(fullDirectoryPackagesPath, TestContext.Current.CancellationToken);
-        var expectedDirectoryPackagesContents = """
-            <Project>
-              <PropertyGroup>
-                <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
-              </PropertyGroup>
-              <ItemGroup>
-                <PackageVersion Include="Completely.Different.Package" Version="2.0.0" />
-                <PackageVersion Include="Some.Package" Version="1.0.0" />
-                <PackageVersion Include="Transitive.Package" Version="2.0.0" />
-              </ItemGroup>
-            </Project>
-            """;
-        Assert.Equal(expectedDirectoryPackagesContents.Replace("\r", ""), actualDirectoryPackagesContents.Replace("\r", ""));
-    }
-
     [Theory]
     [MemberData(nameof(ComputeUpdateOperationsTestData))]
     public async Task ComputeUpdateOperations
@@ -182,7 +24,7 @@ public class PackageReferenceUpdaterTests
         // arrange
         using var repoRoot = await TemporaryDirectory.CreateWithContentsAsync(("project.csproj", "<Project Sdk=\"Microsoft.NET.Sdk\" />"));
         var projectPath = Path.Combine(repoRoot.DirectoryPath, "project.csproj");
-        var experimentsManager = new ExperimentsManager() { UseDirectDiscovery = true };
+        var experimentsManager = new ExperimentsManager();
         await UpdateWorkerTestBase.MockNuGetPackagesInDirectory([
             MockNuGetPackage.CreateSimplePackage("Parent.Package", "1.0.0", "net9.0", [(null, [("Transitive.Package", "1.0.0")])]),
             MockNuGetPackage.CreateSimplePackage("Parent.Package", "2.0.0", "net9.0", [(null, [("Transitive.Package", "2.0.0")])]),