dependabot-nuget 0.296.0 → 0.296.1

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Analyze/VersionFinderTests.cs

@@ -1,6 +1,11 @@
+using System.Collections.Immutable;
+
+using NuGet.Frameworks;
 using NuGet.Versioning;
 
 using NuGetUpdater.Core.Analyze;
+using NuGetUpdater.Core.Test.Update;
+using NuGetUpdater.Core.Test.Utilities;
 
 using Xunit;
 
@@ -190,4 +195,32 @@ public class VersionFinderTests
 
         Assert.True(result);
     }
+
+    [Fact]
+    public async Task TargetFrameworkIsConsideredForUpdatedVersions()
+    {
+        // arrange
+        using var tempDir = new TemporaryDirectory();
+        await UpdateWorkerTestBase.MockNuGetPackagesInDirectory(
+            [
+                MockNuGetPackage.CreateSimplePackage("Some.Package", "1.0.0", "net8.0"),
+                MockNuGetPackage.CreateSimplePackage("Some.Package", "2.0.0", "net8.0"), // can only update to this version because of the tfm
+                MockNuGetPackage.CreateSimplePackage("Some.Package", "3.0.0", "net9.0"),
+            ],
+            tempDir.DirectoryPath);
+
+        // act
+        var projectTfms = new[] { "net8.0" }.Select(NuGetFramework.Parse).ToImmutableArray();
+        var packageId = "Some.Package";
+        var currentVersion = NuGetVersion.Parse("1.0.0");
+        var logger = new TestLogger();
+        var nugetContext = new NuGetContext(tempDir.DirectoryPath);
+        var versionResult = await VersionFinder.GetVersionsAsync(projectTfms, packageId, currentVersion, nugetContext, logger, CancellationToken.None);
+        var versions = versionResult.GetVersions();
+
+        // assert
+        var actual = versions.Select(v => v.ToString()).ToArray();
+        var expected = new[] { "2.0.0" };
+        AssertEx.Equal(expected, actual);
+    }
 }

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Discover/DiscoveryWorkerTests.Project.cs

@@ -1131,7 +1131,7 @@ public partial class DiscoveryWorkerTests
                     ("src/project.csproj", """
                         <Project Sdk="Microsoft.NET.Sdk">
                           <PropertyGroup>
-                            <TargetFrameworks>net8.0-ios;net8.0-android;net8.0-macos;net8.0-maccatalyst</TargetFrameworks>
+                            <TargetFrameworks>net8.0-ios;net8.0-android;net8.0-macos;net8.0-maccatalyst;net8.0-windows</TargetFrameworks>
                           </PropertyGroup>
                           <ItemGroup>
                             <PackageReference Include="Some.Package" Version="1.2.3" />
@@ -1151,11 +1151,12 @@ public partial class DiscoveryWorkerTests
                                 new("Some.Package", "1.2.3", DependencyType.PackageReference, TargetFrameworks: ["net8.0-ios"], IsDirect: true),
                                 new("Some.Package", "1.2.3", DependencyType.PackageReference, TargetFrameworks: ["net8.0-maccatalyst"], IsDirect: true),
                                 new("Some.Package", "1.2.3", DependencyType.PackageReference, TargetFrameworks: ["net8.0-macos"], IsDirect: true),
+                                new("Some.Package", "1.2.3", DependencyType.PackageReference, TargetFrameworks: ["net8.0-windows"], IsDirect: true),
                             ],
                             Properties = [
-                                new("TargetFrameworks", "net8.0-ios;net8.0-android;net8.0-macos;net8.0-maccatalyst", @"src/project.csproj"),
+                                new("TargetFrameworks", "net8.0-ios;net8.0-android;net8.0-macos;net8.0-maccatalyst;net8.0-windows", @"src/project.csproj"),
                             ],
-                            TargetFrameworks = ["net8.0-android", "net8.0-ios", "net8.0-maccatalyst", "net8.0-macos"],
+                            TargetFrameworks = ["net8.0-android", "net8.0-ios", "net8.0-maccatalyst", "net8.0-macos", "net8.0-windows"],
                             ReferencedProjectPaths = [],
                             ImportedFiles = [],
                             AdditionalFiles = [],
@@ -1310,6 +1311,8 @@ public partial class DiscoveryWorkerTests
 
                           <PropertyGroup>
                             <TargetFramework>net8.0</TargetFramework>
+                            <!-- the SDK turns `<TargetFramework>net8.0</TargetFramework>` into the following -->
+                            <TargetFrameworkMoniker>.NETCoreApp,Version=8.0</TargetFrameworkMoniker>
                           </PropertyGroup>
 
                           <ItemGroup>
@@ -1360,7 +1363,8 @@ public partial class DiscoveryWorkerTests
                                 new("Test.Only.Package", "1.0.99", DependencyType.Unknown, TargetFrameworks: ["net8.0"], IsTransitive: true)
                             ],
                             Properties = [
-                                new("TargetFramework", "net8.0", "project.csproj")
+                                new("TargetFramework", "net8.0", "project.csproj"),
+                                new("TargetFrameworkMoniker", ".NETCoreApp,Version=8.0", "project.csproj"),
                             ],
                             TargetFrameworks = ["net8.0"],
                             ReferencedProjectPaths = [],

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Run/MiscellaneousTests.cs

@@ -1,8 +1,10 @@
+using System.Collections.Immutable;
 using System.Text.Json;
 
 using NuGet.Versioning;
 
 using NuGetUpdater.Core.Analyze;
+using NuGetUpdater.Core.Discover;
 using NuGetUpdater.Core.Run;
 using NuGetUpdater.Core.Run.ApiModel;
 
@@ -41,6 +43,59 @@ public class MiscellaneousTests
         Assert.Equal(expectedString, actualString);
     }
 
+    [Theory]
+    [MemberData(nameof(GetIncrementMetricData))]
+    public void GetIncrementMetric(Job job, IncrementMetric expected)
+    {
+        var actual = RunWorker.GetIncrementMetric(job);
+        var actualJson = HttpApiHandler.Serialize(actual);
+        var expectedJson = HttpApiHandler.Serialize(expected);
+        Assert.Equal(expectedJson, actualJson);
+    }
+
+    [Theory]
+    [MemberData(nameof(GetUpdateOperationsData))]
+    public void GetUpdateOperations(WorkspaceDiscoveryResult discovery, (string ProjectPath, string DependencyName)[] expectedUpdateOperations)
+    {
+        var updateOperations = RunWorker.GetUpdateOperations(discovery).ToArray();
+        var actualUpdateOperations = updateOperations.Select(uo => (uo.ProjectPath, uo.Dependency.Name)).ToArray();
+        Assert.Equal(expectedUpdateOperations, actualUpdateOperations);
+    }
+
+    public static IEnumerable<object[]> GetUpdateOperationsData()
+    {
+        static ProjectDiscoveryResult GetProjectDiscovery(string filePath, params string[] dependencyNames)
+        {
+            return new()
+            {
+                FilePath = filePath,
+                Dependencies = dependencyNames.Select(d => new Dependency(d, "1.0.0", DependencyType.PackageReference)).ToImmutableArray(),
+                ImportedFiles = [],
+                AdditionalFiles = [],
+            };
+        }
+
+        yield return
+        [
+            new WorkspaceDiscoveryResult()
+            {
+                Path = "",
+                Projects = [
+                    GetProjectDiscovery("src/Library.csproj", "Package.B", "Package.C"),
+                    GetProjectDiscovery("src/Common.csproj", "Package.A", "Package.C", "Package.D"),
+                ]
+            },
+            new (string, string)[]
+            {
+                ("/src/Common.csproj", "Package.A"),
+                ("/src/Library.csproj", "Package.B"),
+                ("/src/Common.csproj", "Package.C"),
+                ("/src/Library.csproj", "Package.C"),
+                ("/src/Common.csproj", "Package.D"),
+            },
+        ];
+    }
+
     public static IEnumerable<object?[]> RequirementsFromIgnoredVersionsData()
     {
         yield return
@@ -143,4 +198,124 @@ public class MiscellaneousTests
             }
         ];
     }
+
+    public static IEnumerable<object?[]> GetIncrementMetricData()
+    {
+        static Job GetJob(AllowedUpdate[] allowed, bool securityUpdatesOnly, bool updatingAPullRequest)
+        {
+            return new Job()
+            {
+                AllowedUpdates = allowed.ToImmutableArray(),
+                Source = new()
+                {
+                    Provider = "github",
+                    Repo = "some/repo"
+                },
+                SecurityUpdatesOnly = securityUpdatesOnly,
+                UpdatingAPullRequest = updatingAPullRequest,
+            };
+        }
+
+        // version update
+        yield return
+        [
+            GetJob(
+                allowed: [new AllowedUpdate() { UpdateType = UpdateType.All }],
+                securityUpdatesOnly: false,
+                updatingAPullRequest: false),
+            new IncrementMetric()
+            {
+                Metric = "updater.started",
+                Tags =
+                {
+                    ["operation"] = "group_update_all_versions"
+                }
+            }
+        ];
+
+        // version update - existing pr
+        yield return
+        [
+            GetJob(
+                allowed: [new AllowedUpdate() { UpdateType = UpdateType.All }],
+                securityUpdatesOnly: false,
+                updatingAPullRequest: true),
+            new IncrementMetric()
+            {
+                Metric = "updater.started",
+                Tags =
+                {
+                    ["operation"] = "update_version_pr"
+                }
+            }
+        ];
+
+        // create security pr - allowed security update
+        yield return
+        [
+            GetJob(
+                allowed: [new AllowedUpdate() { UpdateType = UpdateType.All }, new AllowedUpdate() { UpdateType = UpdateType.Security }],
+                securityUpdatesOnly: false,
+                updatingAPullRequest: false),
+            new IncrementMetric()
+            {
+                Metric = "updater.started",
+                Tags =
+                {
+                    ["operation"] = "create_security_pr"
+                }
+            }
+        ];
+
+        // create security pr - security only
+        yield return
+        [
+            GetJob(
+                allowed: [new AllowedUpdate() { UpdateType = UpdateType.All } ],
+                securityUpdatesOnly: true,
+                updatingAPullRequest: false),
+            new IncrementMetric()
+            {
+                Metric = "updater.started",
+                Tags =
+                {
+                    ["operation"] = "create_security_pr"
+                }
+            }
+        ];
+
+        // update security pr - allowed security update
+        yield return
+        [
+            GetJob(
+                allowed: [new AllowedUpdate() { UpdateType = UpdateType.All }, new AllowedUpdate() { UpdateType = UpdateType.Security } ],
+                securityUpdatesOnly: false,
+                updatingAPullRequest: true),
+            new IncrementMetric()
+            {
+                Metric = "updater.started",
+                Tags =
+                {
+                    ["operation"] = "update_security_pr"
+                }
+            }
+        ];
+
+        // update security pr - security only
+        yield return
+        [
+            GetJob(
+                allowed: [new AllowedUpdate() { UpdateType = UpdateType.All } ],
+                securityUpdatesOnly: true,
+                updatingAPullRequest: true),
+            new IncrementMetric()
+            {
+                Metric = "updater.started",
+                Tags =
+                {
+                    ["operation"] = "update_security_pr"
+                }
+            }
+        ];
+    }
 }

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Run/RunWorkerTests.cs

@@ -1147,7 +1147,7 @@ public class RunWorkerTests
                                 new ReportedRequirement()
                                 {
                                     Requirement = "1.0.0",
-                                    File = "/some-dir/ProjectB/ProjectB.csproj",
+                                    File = "/some-dir/ProjectA/ProjectA.csproj",
                                     Groups = ["dependencies"],
                                 }
                             ]
@@ -1161,7 +1161,7 @@ public class RunWorkerTests
                                 new ReportedRequirement()
                                 {
                                     Requirement = "2.0.0",
-                                    File = "/some-dir/ProjectB/ProjectB.csproj",
+                                    File = "/some-dir/ProjectA/ProjectA.csproj",
                                     Groups = ["dependencies"],
                                 }
                             ]
@@ -1175,7 +1175,7 @@ public class RunWorkerTests
                                 new ReportedRequirement()
                                 {
                                     Requirement = "1.0.0",
-                                    File = "/some-dir/ProjectA/ProjectA.csproj",
+                                    File = "/some-dir/ProjectB/ProjectB.csproj",
                                     Groups = ["dependencies"],
                                 }
                             ]
@@ -1189,7 +1189,7 @@ public class RunWorkerTests
                                 new ReportedRequirement()
                                 {
                                     Requirement = "2.0.0",
-                                    File = "/some-dir/ProjectA/ProjectA.csproj",
+                                    File = "/some-dir/ProjectB/ProjectB.csproj",
                                     Groups = ["dependencies"],
                                 }
                             ]
@@ -1218,7 +1218,7 @@ public class RunWorkerTests
                                 new ReportedRequirement()
                                 {
                                     Requirement = "1.0.1",
-                                    File = "/some-dir/ProjectB/ProjectB.csproj",
+                                    File = "/some-dir/ProjectA/ProjectA.csproj",
                                     Groups = ["dependencies"],
                                     Source = new()
                                     {
@@ -1233,35 +1233,35 @@ public class RunWorkerTests
                                 new ReportedRequirement()
                                 {
                                     Requirement = "1.0.0",
-                                    File = "/some-dir/ProjectB/ProjectB.csproj",
+                                    File = "/some-dir/ProjectA/ProjectA.csproj",
                                     Groups = ["dependencies"],
                                 }
                             ],
                         },
                         new ReportedDependency()
                         {
-                            Name = "Some.Package2",
-                            Version = "2.0.1",
+                            Name = "Some.Package",
+                            Version = "1.0.1",
                             Requirements =
                             [
                                 new ReportedRequirement()
                                 {
-                                    Requirement = "2.0.1",
+                                    Requirement = "1.0.1",
                                     File = "/some-dir/ProjectB/ProjectB.csproj",
                                     Groups = ["dependencies"],
                                     Source = new()
                                     {
-                                        SourceUrl = "https://nuget.example.com/some-package2",
+                                        SourceUrl = "https://nuget.example.com/some-package",
                                         Type = "nuget_repo",
                                     }
                                 }
                             ],
-                            PreviousVersion = "2.0.0",
+                            PreviousVersion = "1.0.0",
                             PreviousRequirements =
                             [
                                 new ReportedRequirement()
                                 {
-                                    Requirement = "2.0.0",
+                                    Requirement = "1.0.0",
                                     File = "/some-dir/ProjectB/ProjectB.csproj",
                                     Groups = ["dependencies"],
                                 }
@@ -1269,28 +1269,28 @@ public class RunWorkerTests
                         },
                         new ReportedDependency()
                         {
-                            Name = "Some.Package",
-                            Version = "1.0.1",
+                            Name = "Some.Package2",
+                            Version = "2.0.1",
                             Requirements =
                             [
                                 new ReportedRequirement()
                                 {
-                                    Requirement = "1.0.1",
+                                    Requirement = "2.0.1",
                                     File = "/some-dir/ProjectA/ProjectA.csproj",
                                     Groups = ["dependencies"],
                                     Source = new()
                                     {
-                                        SourceUrl = "https://nuget.example.com/some-package",
+                                        SourceUrl = "https://nuget.example.com/some-package2",
                                         Type = "nuget_repo",
                                     }
                                 }
                             ],
-                            PreviousVersion = "1.0.0",
+                            PreviousVersion = "2.0.0",
                             PreviousRequirements =
                             [
                                 new ReportedRequirement()
                                 {
-                                    Requirement = "1.0.0",
+                                    Requirement = "2.0.0",
                                     File = "/some-dir/ProjectA/ProjectA.csproj",
                                     Groups = ["dependencies"],
                                 }
@@ -1305,7 +1305,7 @@ public class RunWorkerTests
                                 new ReportedRequirement()
                                 {
                                     Requirement = "2.0.1",
-                                    File = "/some-dir/ProjectA/ProjectA.csproj",
+                                    File = "/some-dir/ProjectB/ProjectB.csproj",
                                     Groups = ["dependencies"],
                                     Source = new()
                                     {
@@ -1320,7 +1320,7 @@ public class RunWorkerTests
                                 new ReportedRequirement()
                                 {
                                     Requirement = "2.0.0",
-                                    File = "/some-dir/ProjectA/ProjectA.csproj",
+                                    File = "/some-dir/ProjectB/ProjectB.csproj",
                                     Groups = ["dependencies"],
                                 }
                             ],
@@ -1945,7 +1945,7 @@ public class RunWorkerTests
                     Metric = "updater.started",
                     Tags = new()
                     {
-                        ["operation"] = "group_update_all_versions"
+                        ["operation"] = "create_security_pr"
                     }
                 },
                 new CreatePullRequest()

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Run/SerializationTests.cs

@@ -541,6 +541,59 @@ public class SerializationTests
         Assert.True(jobWrapper.Job.CommitMessageOptions!.IncludeScope);
     }
 
+    [Fact]
+    public void SerializeClosePullRequest()
+    {
+        var close = new ClosePullRequest()
+        {
+            DependencyNames = ["dep"],
+        };
+        var actual = HttpApiHandler.Serialize(close);
+        var expected = """
+            {"data":{"dependency-names":["dep"],"reason":"up_to_date"}}
+            """;
+        Assert.Equal(expected, actual);
+    }
+
+    [Fact]
+    public void SerializeCreatePullRequest()
+    {
+        var create = new CreatePullRequest()
+        {
+            Dependencies = [new() { Name = "dep", Version = "ver2", PreviousVersion = "ver1", Requirements = [new() { Requirement = "ver2", File = "project.csproj" }], PreviousRequirements = [new() { Requirement = "ver1", File = "project.csproj" }] }],
+            UpdatedDependencyFiles = [new() { Name = "project.csproj", Directory = "/", Content = "updated content" }],
+            BaseCommitSha = "TEST-COMMIT-SHA",
+            CommitMessage = "commit message",
+            PrTitle = "pr title",
+            PrBody = "pr body"
+        };
+        var actual = HttpApiHandler.Serialize(create);
+        var expected = """
+            {"data":{"dependencies":[{"name":"dep","version":"ver2","requirements":[{"requirement":"ver2","file":"project.csproj","groups":[],"source":null}],"previous-version":"ver1","previous-requirements":[{"requirement":"ver1","file":"project.csproj","groups":[],"source":null}]}],"updated-dependency-files":[{"name":"project.csproj","content":"updated content","directory":"/","type":"file","support_file":false,"content_encoding":"utf-8","deleted":false,"operation":"update","mode":null}],"base-commit-sha":"TEST-COMMIT-SHA","commit-message":"commit message","pr-title":"pr title","pr-body":"pr body"}}
+            """;
+        Assert.Equal(expected, actual);
+    }
+
+    [Fact]
+    public void SerializeUpdatePullRequest()
+    {
+        var update = new UpdatePullRequest()
+        {
+            BaseCommitSha = "TEST-COMMIT-SHA",
+            DependencyNames = ["dep"],
+            UpdatedDependencyFiles = [new() { Name = "project.csproj", Directory = "/", Content = "updated content" }],
+            PrTitle = "pr title",
+            PrBody = "pr body",
+            CommitMessage = "commit message",
+            DependencyGroup = null,
+        };
+        var actual = HttpApiHandler.Serialize(update);
+        var expected = """
+            {"data":{"base-commit-sha":"TEST-COMMIT-SHA","dependency-names":["dep"],"updated-dependency-files":[{"name":"project.csproj","content":"updated content","directory":"/","type":"file","support_file":false,"content_encoding":"utf-8","deleted":false,"operation":"update","mode":null}],"pr-title":"pr title","pr-body":"pr body","commit-message":"commit message","dependency-group":null}}
+            """;
+        Assert.Equal(expected, actual);
+    }
+
     public static IEnumerable<object?[]> DeserializeErrorTypesData()
     {
         yield return
@@ -583,6 +636,22 @@ public class SerializationTests
             """
         ];
 
+        yield return
+        [
+            new PullRequestExistsForLatestVersion("dep", "ver"),
+            """
+            {"data":{"error-type":"pull_request_exists_for_latest_version","error-details":{"dependency-name":"dep","dependency-version":"ver"}}}
+            """
+        ];
+
+        yield return
+        [
+            new SecurityUpdateNotNeeded("dep"),
+            """
+            {"data":{"error-type":"security_update_not_needed","error-details":{"dependency-name":"dep"}}}
+            """
+        ];
+
         yield return
         [
             new UnknownError(new Exception("some message"), "JOB-ID"),

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Run/TestApiHandler.cs

@@ -33,6 +33,12 @@ internal class TestApiHandler : IApiHandler
         return Task.CompletedTask;
     }
 
+    public Task UpdatePullRequest(UpdatePullRequest updatePullRequest)
+    {
+        _receivedMessages.Add((updatePullRequest.GetType(), updatePullRequest));
+        return Task.CompletedTask;
+    }
+
     public Task MarkAsProcessed(MarkAsProcessed markAsProcessed)
     {
         _receivedMessages.Add((markAsProcessed.GetType(), markAsProcessed));

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Run/UpdatedDependencyListTests.cs

@@ -92,31 +92,31 @@ public class UpdatedDependencyListTests
                 },
                 new ReportedDependency()
                 {
-                    Name = "System.Text.Json",
-                    Version = "6.0.0",
+                    Name = "Newtonsoft.Json",
+                    Version = "13.0.1",
                     Requirements =
                     [
                         new ReportedRequirement()
                         {
-                            Requirement = "6.0.0",
+                            Requirement = "13.0.1",
                             File = "/src/c/project.csproj",
                             Groups = ["dependencies"],
-                        }
-                    ],
+                        },
+                    ]
                 },
                 new ReportedDependency()
                 {
-                    Name = "Newtonsoft.Json",
-                    Version = "13.0.1",
+                    Name = "System.Text.Json",
+                    Version = "6.0.0",
                     Requirements =
                     [
                         new ReportedRequirement()
                         {
-                            Requirement = "13.0.1",
+                            Requirement = "6.0.0",
                             File = "/src/c/project.csproj",
                             Groups = ["dependencies"],
-                        },
-                    ]
+                        }
+                    ],
                 },
             ],
             DependencyFiles = ["/src/a/packages.config", "/src/a/project.csproj", "/src/b/packages.config", "/src/b/project.csproj", "/src/c/packages.config", "/src/c/project.csproj"],

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Utilities/MSBuildHelperTests.cs

@@ -538,6 +538,89 @@ public class MSBuildHelperTests : TestBase
             """, evaluatedValue);
     }
 
+    [Theory]
+    [MemberData(nameof(GetTargetFrameworkValuesFromProjectData))]
+    public async Task GetTargetFrameworkValuesFromProject(string projectContents, string[] expectedTfms)
+    {
+        using var tempDir = await TemporaryDirectory.CreateWithContentsAsync(
+        [
+            ("Directory.Build.props", "<Project />"),
+            ("Directory.Build.targets", "<Project />"),
+            ("project.csproj", projectContents)
+        ]);
+        var projectPath = Path.Combine(tempDir.DirectoryPath, "project.csproj");
+        var experimentsManager = new ExperimentsManager();
+        var logger = new TestLogger();
+        var actualTfms = await MSBuildHelper.GetTargetFrameworkValuesFromProject(tempDir.DirectoryPath, projectPath, experimentsManager, logger);
+        AssertEx.Equal(expectedTfms, actualTfms);
+    }
+
+    public static IEnumerable<object[]> GetTargetFrameworkValuesFromProjectData()
+    {
+        // SDK-style projects
+        yield return
+        [
+            """
+            <Project Sdk="Microsoft.NET.Sdk">
+              <PropertyGroup>
+                <TargetFramework>net8.0</TargetFramework>
+              </PropertyGroup>
+            </Project>
+            """,
+            new[] { "net8.0" }
+        ];
+
+        yield return
+        [
+            """
+            <Project Sdk="Microsoft.NET.Sdk">
+              <PropertyGroup>
+                <TargetFrameworks> ; net8.0 ; </TargetFrameworks>
+              </PropertyGroup>
+            </Project>
+            """,
+            new[] { "net8.0" }
+        ];
+
+        yield return
+        [
+            """
+            <Project Sdk="Microsoft.NET.Sdk">
+              <PropertyGroup>
+                <TargetFrameworks>net8.0;net9.0</TargetFrameworks>
+              </PropertyGroup>
+            </Project>
+            """,
+            new[] { "net8.0", "net9.0" }
+        ];
+
+        yield return
+        [
+            """
+            <Project Sdk="Microsoft.NET.Sdk">
+              <PropertyGroup>
+                <TargetFramework>net8.0-windows7.0</TargetFramework>
+              </PropertyGroup>
+            </Project>
+            """,
+            new[] { "net8.0-windows7.0" }
+        ];
+
+        // legacy projects
+        yield return
+        [
+            """
+            <Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+              <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
+              <PropertyGroup>
+                <TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
+              </PropertyGroup>
+              <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
+            </Project>
+            """,
+            new[] { "net45" }
+        ];
+    }
 
     #region
     // Updating root package