dependabot-nuget 0.287.0 → 0.289.0

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dependabot-nuget
 version: !ruby/object:Gem::Version
-  version: 0.287.0
+  version: 0.289.0
 platform: ruby
 authors:
 - Dependabot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-11-19 00:00:00.000000000 Z
+date: 2024-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dependabot-common
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.287.0
+        version: 0.289.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.287.0
+        version: 0.289.0
 - !ruby/object:Gem::Dependency
   name: rubyzip
   requirement: !ruby/object:Gem::Requirement
@@ -266,11 +266,11 @@ files:
 - helpers/lib/NuGetUpdater/.editorconfig
 - helpers/lib/NuGetUpdater/.gitignore
 - helpers/lib/NuGetUpdater/Directory.Build.props
+- helpers/lib/NuGetUpdater/Directory.Build.targets
 - helpers/lib/NuGetUpdater/Directory.Common.props
 - helpers/lib/NuGetUpdater/Directory.Packages.props
 - helpers/lib/NuGetUpdater/NuGetProjects/Directory.Build.props
 - helpers/lib/NuGetUpdater/NuGetProjects/Directory.Build.targets
-- helpers/lib/NuGetUpdater/NuGetProjects/Directory.Packages.props
 - helpers/lib/NuGetUpdater/NuGetProjects/NuGet.Build.Tasks/NuGet.Build.Tasks.csproj
 - helpers/lib/NuGetUpdater/NuGetProjects/NuGet.CommandLine/AssemblyMetadataExtractor.cs
 - helpers/lib/NuGetUpdater/NuGetProjects/NuGet.CommandLine/NuGet.CommandLine.csproj
@@ -321,6 +321,7 @@ files:
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Discover/DiscoveryWorkerTests.Project.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Discover/DiscoveryWorkerTests.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Discover/ExpectedDiscoveryResults.cs
+- helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Discover/SdkProjectDiscoveryTests.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Files/DotNetToolsJsonBuildFileTests.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Files/GlobalJsonBuildFileTests.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Files/PackagesConfigBuildFileTests.cs
@@ -356,6 +357,7 @@ files:
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Utilities/AssertEx.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Utilities/DiffUtil.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Utilities/JsonHelperTests.cs
+- helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Utilities/LinuxOnlyAttribute.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Utilities/MSBuildHelperTests.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Utilities/PathHelperTests.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Utilities/SdkPackageUpdaterHelperTests.cs
@@ -367,7 +369,7 @@ files:
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Analyze/Extensions.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Analyze/NuGetContext.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Analyze/Requirement.cs
-- helpers/lib/NuGetUpdater/NuGetUpdater.Core/Analyze/RequirementConverter.cs
+- helpers/lib/NuGetUpdater/NuGetUpdater.Core/Analyze/RequirementArrayConverter.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Analyze/SecurityVulnerability.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Analyze/SecurityVulnerabilityExtensions.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Analyze/VersionFinder.cs
@@ -376,9 +378,9 @@ files:
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Clone/IGitCommandHandler.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Clone/ShellGitCommandHandler.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Dependency.cs
+- helpers/lib/NuGetUpdater/NuGetUpdater.Core/DependencyDiscovery.props
+- helpers/lib/NuGetUpdater/NuGetUpdater.Core/DependencyDiscovery.targets
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/DependencyType.cs
-- helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/DirectoryPackagesPropsDiscovery.cs
-- helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/DirectoryPackagesPropsDiscoveryResult.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/DiscoveryWorker.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/DotNetToolsJsonDiscovery.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/DotNetToolsJsonDiscoveryResult.cs
@@ -433,6 +435,7 @@ files:
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Run/IApiHandler.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Run/RunResult.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Run/RunWorker.cs
+- helpers/lib/NuGetUpdater/NuGetUpdater.Core/TargetFrameworkReporter.targets
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/UpdateNotPossibleException.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Updater/BindingRedirectManager.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Updater/BindingRedirectResolver.cs
@@ -447,6 +450,7 @@ files:
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Updater/UpdaterWorker.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Updater/WebApplicationTargetsConditionPatcher.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Updater/XmlFilePreAndPostProcessor.cs
+- helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/CollectionExtensions.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/ConsoleLogger.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/DependencyConflictResolver.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/HashSetExtensions.cs
@@ -455,8 +459,10 @@ files:
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/JsonHelper.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/MSBuildHelper.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/NuGetHelper.cs
+- helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/PathComparer.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/PathHelper.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/ProcessExtensions.cs
+- helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/ProjectHelper.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/XmlExtensions.cs
 - helpers/lib/NuGetUpdater/NuGetUpdater.sln
 - helpers/lib/NuGetUpdater/global.json
@@ -474,15 +480,12 @@ files:
 - lib/dependabot/nuget/discovery/property_details.rb
 - lib/dependabot/nuget/discovery/workspace_discovery.rb
 - lib/dependabot/nuget/file_fetcher.rb
-- lib/dependabot/nuget/file_fetcher/import_paths_finder.rb
-- lib/dependabot/nuget/file_fetcher/sln_project_paths_finder.rb
 - lib/dependabot/nuget/file_parser.rb
 - lib/dependabot/nuget/file_updater.rb
 - lib/dependabot/nuget/http_response_helpers.rb
 - lib/dependabot/nuget/metadata_finder.rb
 - lib/dependabot/nuget/native_discovery/native_dependency_details.rb
 - lib/dependabot/nuget/native_discovery/native_dependency_file_discovery.rb
-- lib/dependabot/nuget/native_discovery/native_directory_packages_props_discovery.rb
 - lib/dependabot/nuget/native_discovery/native_discovery_json_reader.rb
 - lib/dependabot/nuget/native_discovery/native_evaluation_details.rb
 - lib/dependabot/nuget/native_discovery/native_project_discovery.rb
@@ -511,7 +514,7 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/dependabot/dependabot-core/issues
-  changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.287.0
+  changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.289.0
 post_install_message: 
 rdoc_options: []
 require_paths:

data/helpers/lib/NuGetUpdater/NuGetProjects/Directory.Packages.props

@@ -1,29 +0,0 @@
-<Project>
-
-  <PropertyGroup>
-    <MicrosoftBuildVersion>17.5.0</MicrosoftBuildVersion>
-    <MicrosoftExtensionsFileProvidersAbstractionsPackageVersion>6.0.0</MicrosoftExtensionsFileProvidersAbstractionsPackageVersion>
-    <MicrosoftExtensionsFileSystemGlobbingPackageVersion>6.0.0</MicrosoftExtensionsFileSystemGlobbingPackageVersion>
-    <MicrosoftWebXdtPackageVersion>3.0.0</MicrosoftWebXdtPackageVersion>
-    <SystemPackagesVersion>4.3.0</SystemPackagesVersion>
-    <CryptographyPackagesVersion>5.0.0</CryptographyPackagesVersion>
-  </PropertyGroup>
-
-  <ItemGroup>
-    <PackageVersion Include="Microsoft.Build.Tasks.Core" Version="$(MicrosoftBuildVersion)" />
-    <PackageVersion Include="Microsoft.Build.Utilities.Core" Version="$(MicrosoftBuildVersion)" />
-    <PackageVersion Include="Microsoft.CSharp" Version="$(SystemPackagesVersion)" />
-    <PackageVersion Include="Microsoft.Extensions.FileProviders.Abstractions" Version="$(MicrosoftExtensionsFileProvidersAbstractionsPackageVersion)" />
-    <PackageVersion Include="Microsoft.Extensions.FileSystemGlobbing" Version="$(MicrosoftExtensionsFileSystemGlobbingPackageVersion)" />
-    <PackageVersion Include="Microsoft.VisualStudio.Setup.Configuration.Interop" Version="3.4.2244" />
-    <PackageVersion Include="Microsoft.Web.Xdt" Version="$(MicrosoftWebXdtPackageVersion)" />
-    <PackageVersion Include="Newtonsoft.Json" Version="13.0.1" />
-    <PackageVersion Include="NuGet.Core" Version="2.14.0-rtm-832" />
-    <PackageVersion Include="System.ComponentModel.Composition" Version="7.0.0" />
-    <PackageVersion Include="System.Security.Cryptography.Cng" Version="$(CryptographyPackagesVersion)" />
-    <PackageVersion Include="System.Security.Cryptography.Pkcs" Version="$(CryptographyPackagesVersion)" />
-    <PackageVersion Include="System.Security.Cryptography.ProtectedData" Version="4.4.0" />
-    <PackageVersion Include="System.Threading.Tasks.Dataflow" Version="6.0.0" />
-  </ItemGroup>
-
-</Project>

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Analyze/RequirementConverter.cs

@@ -1,17 +0,0 @@
-using System.Text.Json;
-using System.Text.Json.Serialization;
-
-namespace NuGetUpdater.Core.Analyze;
-
-public class RequirementConverter : JsonConverter<Requirement>
-{
-    public override Requirement? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
-    {
-        return Requirement.Parse(reader.GetString()!);
-    }
-
-    public override void Write(Utf8JsonWriter writer, Requirement value, JsonSerializerOptions options)
-    {
-        writer.WriteStringValue(value.ToString());
-    }
-}

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/DirectoryPackagesPropsDiscovery.cs

@@ -1,69 +0,0 @@
-using System.Collections.Immutable;
-
-namespace NuGetUpdater.Core.Discover;
-
-internal static class DirectoryPackagesPropsDiscovery
-{
-    public static DirectoryPackagesPropsDiscoveryResult? Discover(string repoRootPath, string workspacePath, ImmutableArray<ProjectDiscoveryResult> projectResults, ILogger logger)
-    {
-        var projectResult = projectResults.FirstOrDefault(
-            p => p.Properties.FirstOrDefault(prop => prop.Name.Equals("ManagePackageVersionsCentrally", StringComparison.OrdinalIgnoreCase)) is Property property
-                && string.Equals(property.Value, "true", StringComparison.OrdinalIgnoreCase));
-        if (projectResult is null)
-        {
-            logger.Log("  Central Package Management is not enabled.");
-            return null;
-        }
-
-        var projectFilePath = Path.GetFullPath(projectResult.FilePath, workspacePath);
-        if (!MSBuildHelper.TryGetDirectoryPackagesPropsPath(repoRootPath, projectFilePath, out var directoryPackagesPropsPath))
-        {
-            logger.Log("  No Directory.Packages.props file found.");
-            return null;
-        }
-
-        var relativeDirectoryPackagesPropsPath = Path.GetRelativePath(workspacePath, directoryPackagesPropsPath);
-        var directoryPackagesPropsFile = projectResults.FirstOrDefault(p => p.FilePath.Equals(relativeDirectoryPackagesPropsPath, StringComparison.OrdinalIgnoreCase));
-        if (directoryPackagesPropsFile is null)
-        {
-            logger.Log($"  No project file found for [{relativeDirectoryPackagesPropsPath}].");
-            return null;
-        }
-
-        logger.Log($"  Discovered [{directoryPackagesPropsFile.FilePath}] file.");
-
-        var isTransitivePinningEnabled = projectResult.Properties.FirstOrDefault(prop => prop.Name.Equals("EnableTransitivePinning", StringComparison.OrdinalIgnoreCase)) is Property property
-            && string.Equals(property.Value, "true", StringComparison.OrdinalIgnoreCase);
-        var properties = projectResult.Properties.ToImmutableDictionary(p => p.Name, StringComparer.OrdinalIgnoreCase);
-        var dependencies = GetDependencies(workspacePath, directoryPackagesPropsPath, properties)
-            .OrderBy(d => d.Name)
-            .ToImmutableArray();
-
-        return new()
-        {
-            FilePath = directoryPackagesPropsFile.FilePath,
-            IsTransitivePinningEnabled = isTransitivePinningEnabled,
-            Dependencies = dependencies,
-        };
-    }
-
-    private static IEnumerable<Dependency> GetDependencies(string workspacePath, string directoryPackagesPropsPath, ImmutableDictionary<string, Property> properties)
-    {
-        var dependencies = ProjectBuildFile.Open(workspacePath, directoryPackagesPropsPath).GetDependencies();
-        return dependencies.Select(d =>
-        {
-            if (d.Version == null)
-            {
-                return d;
-            }
-
-            var evaluation = MSBuildHelper.GetEvaluatedValue(d.Version, properties);
-            return d with
-            {
-                Version = evaluation.EvaluatedValue,
-                EvaluationResult = evaluation,
-                IsDirect = true,
-            };
-        });
-    }
-}

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/DirectoryPackagesPropsDiscoveryResult.cs

@@ -1,11 +0,0 @@
-using System.Collections.Immutable;
-
-namespace NuGetUpdater.Core.Discover;
-
-public sealed record DirectoryPackagesPropsDiscoveryResult : IDiscoveryResultWithDependencies
-{
-    public required string FilePath { get; init; }
-    public bool IsSuccess { get; init; } = true;
-    public bool IsTransitivePinningEnabled { get; init; }
-    public ImmutableArray<Dependency> Dependencies { get; init; }
-}

data/lib/dependabot/nuget/file_fetcher/import_paths_finder.rb

@@ -1,73 +0,0 @@
-# typed: strict
-# frozen_string_literal: true
-
-require "nokogiri"
-require "pathname"
-require "sorbet-runtime"
-
-require "dependabot/nuget/file_fetcher"
-
-module Dependabot
-  module Nuget
-    class FileFetcher
-      class ImportPathsFinder
-        extend T::Sig
-        sig { params(project_file: T.untyped).void }
-        def initialize(project_file:)
-          @project_file = T.let(project_file, Dependabot::DependencyFile)
-        end
-
-        sig { returns(T::Array[String]) }
-        def import_paths
-          doc = T.let(Nokogiri::XML(project_file.content), Nokogiri::XML::Document)
-          doc.remove_namespaces!
-          doc.xpath("/Project/Import").filter_map do |import_node|
-            path = import_node.attribute("Project").value.strip.tr("\\", "/")
-            path = File.join(current_dir, path) unless current_dir.nil?
-            Pathname.new(path).cleanpath.to_path
-          end
-        end
-
-        sig { returns(T::Array[String]) }
-        def project_reference_paths
-          doc = T.let(Nokogiri::XML(project_file.content), Nokogiri::XML::Document)
-          doc.remove_namespaces!
-          doc.xpath("/Project/ItemGroup/ProjectReference").filter_map do |node|
-            attribute = node.attribute("Include")
-            next unless attribute
-
-            path = attribute.value.strip.tr("\\", "/")
-            path = File.join(current_dir, path) unless current_dir.nil?
-            Pathname.new(path).cleanpath.to_path
-          end
-        end
-
-        sig { returns(T::Array[String]) }
-        def project_file_paths
-          doc = T.let(Nokogiri::XML(project_file.content), Nokogiri::XML::Document)
-          doc.remove_namespaces!
-          doc.xpath("/Project/ItemGroup/ProjectFile").filter_map do |node|
-            attribute = node.attribute("Include")
-            next unless attribute
-
-            path = attribute.value.strip.tr("\\", "/")
-            path = File.join(current_dir, path) unless current_dir.nil?
-            Pathname.new(path).cleanpath.to_path
-          end
-        end
-
-        private
-
-        sig { returns(Dependabot::DependencyFile) }
-        attr_reader :project_file
-
-        sig { returns(T.nilable(String)) }
-        def current_dir
-          current_dir = project_file.name.rpartition("/").first
-          current_dir = nil if current_dir == ""
-          current_dir
-        end
-      end
-    end
-  end
-end

data/lib/dependabot/nuget/file_fetcher/sln_project_paths_finder.rb

@@ -1,60 +0,0 @@
-# typed: strong
-# frozen_string_literal: true
-
-require "pathname"
-require "sorbet-runtime"
-
-require "dependabot/nuget/file_fetcher"
-
-module Dependabot
-  module Nuget
-    class FileFetcher
-      class SlnProjectPathsFinder
-        extend T::Sig
-
-        sig { params(sln_file: Dependabot::DependencyFile).void }
-        def initialize(sln_file:)
-          @sln_file = sln_file
-        end
-
-        sig { returns(T::Array[String]) }
-        def project_paths
-          paths = T.let([], T::Array[String])
-          return paths unless sln_file.content
-
-          sln_file_lines = T.must(sln_file.content).lines
-
-          sln_file_lines.each do |line|
-            next unless line.match?(/^\s*Project\(/)
-            next unless line.split('"')[5]
-
-            path = line.split('"')[5]
-            next unless path
-
-            path = path.tr("\\", "/")
-
-            # If the path doesn't have an extension it's probably a directory
-            next unless path.match?(/\.[a-z]{2}proj$/)
-
-            path = File.join(current_dir, path) unless current_dir.nil?
-            paths << Pathname.new(path).cleanpath.to_path
-          end
-
-          paths
-        end
-
-        private
-
-        sig { returns(Dependabot::DependencyFile) }
-        attr_reader :sln_file
-
-        sig { returns(T.nilable(String)) }
-        def current_dir
-          current_dir = sln_file.name.rpartition("/").first
-          current_dir = nil if current_dir == ""
-          current_dir
-        end
-      end
-    end
-  end
-end

data/lib/dependabot/nuget/native_discovery/native_directory_packages_props_discovery.rb

@@ -1,44 +0,0 @@
-# typed: strong
-# frozen_string_literal: true
-
-require "dependabot/nuget/native_discovery/native_dependency_details"
-require "sorbet-runtime"
-
-module Dependabot
-  module Nuget
-    class NativeDirectoryPackagesPropsDiscovery < NativeDependencyFileDiscovery
-      extend T::Sig
-
-      sig do
-        override.params(json: T.nilable(T::Hash[String, T.untyped]),
-                        directory: String).returns(T.nilable(NativeDirectoryPackagesPropsDiscovery))
-      end
-      def self.from_json(json, directory)
-        return nil if json.nil?
-
-        file_path = File.join(directory, T.let(json.fetch("FilePath"), String))
-        is_transitive_pinning_enabled = T.let(json.fetch("IsTransitivePinningEnabled"), T::Boolean)
-        dependencies = T.let(json.fetch("Dependencies"), T::Array[T::Hash[String, T.untyped]]).map do |dep|
-          NativeDependencyDetails.from_json(dep)
-        end
-
-        NativeDirectoryPackagesPropsDiscovery.new(file_path: file_path,
-                                                  is_transitive_pinning_enabled: is_transitive_pinning_enabled,
-                                                  dependencies: dependencies)
-      end
-
-      sig do
-        params(file_path: String,
-               is_transitive_pinning_enabled: T::Boolean,
-               dependencies: T::Array[NativeDependencyDetails]).void
-      end
-      def initialize(file_path:, is_transitive_pinning_enabled:, dependencies:)
-        super(file_path: file_path, dependencies: dependencies)
-        @is_transitive_pinning_enabled = is_transitive_pinning_enabled
-      end
-
-      sig { returns(T::Boolean) }
-      attr_reader :is_transitive_pinning_enabled
-    end
-  end
-end