dependabot-nuget 0.258.0 → 0.259.0

data/helpers/lib/NuGetUpdater/NuGetUpdater.Cli.Test/EntryPointTests.Update.cs

@@ -1,7 +1,4 @@
-using System;
-using System.IO;
 using System.Text;
-using System.Threading.Tasks;
 
 using NuGetUpdater.Core;
 using NuGetUpdater.Core.Test;
@@ -26,12 +23,18 @@ public partial class EntryPointTests
                     "--solution-or-project",
                     Path.Combine(path, "path/to/solution.sln"),
                     "--dependency",
-                    "Newtonsoft.Json",
+                    "Some.package",
                     "--new-version",
                     "13.0.1",
                     "--previous-version",
                     "7.0.1",
                 ],
+                packages:
+                [
+                    MockNuGetPackage.CreateSimplePackage("Some.Package", "7.0.1", "net45"),
+                    MockNuGetPackage.CreateSimplePackage("Some.Package", "13.0.1", "net45"),
+                ],
+                initialFiles:
                 [
                     ("path/to/solution.sln", """
                         Microsoft Visual Studio Solution File, Format Version 12.00
@@ -66,8 +69,8 @@ public partial class EntryPointTests
                             <None Include="packages.config" />
                           </ItemGroup>
                           <ItemGroup>
-                            <Reference Include="Newtonsoft.Json, Version=7.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed">
-                              <HintPath>packages\Newtonsoft.Json.7.0.1\lib\net45\Newtonsoft.Json.dll</HintPath>
+                            <Reference Include="Some.Package">
+                              <HintPath>packages\Some.Package.7.0.1\lib\net45\Some.Package.dll</HintPath>
                               <Private>True</Private>
                             </Reference>
                           </ItemGroup>
@@ -76,10 +79,11 @@ public partial class EntryPointTests
                         """),
                     ("path/to/packages.config", """
                         <packages>
-                          <package id="Newtonsoft.Json" version="7.0.1" targetFramework="net45" />
+                          <package id="Some.Package" version="7.0.1" targetFramework="net45" />
                         </packages>
                         """)
                 ],
+                expectedFiles:
                 [
                     ("path/to/my.csproj", """
                         <Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
@@ -91,8 +95,8 @@ public partial class EntryPointTests
                             <None Include="packages.config" />
                           </ItemGroup>
                           <ItemGroup>
-                            <Reference Include="Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed">
-                              <HintPath>packages\Newtonsoft.Json.13.0.1\lib\net45\Newtonsoft.Json.dll</HintPath>
+                            <Reference Include="Some.Package">
+                              <HintPath>packages\Some.Package.13.0.1\lib\net45\Some.Package.dll</HintPath>
                               <Private>True</Private>
                             </Reference>
                           </ItemGroup>
@@ -102,10 +106,11 @@ public partial class EntryPointTests
                     ("path/to/packages.config", """
                         <?xml version="1.0" encoding="utf-8"?>
                         <packages>
-                          <package id="Newtonsoft.Json" version="13.0.1" targetFramework="net45" />
+                          <package id="Some.Package" version="13.0.1" targetFramework="net45" />
                         </packages>
                         """)
-                ]);
+                ]
+            );
         }
 
         [Fact]
@@ -119,13 +124,19 @@ public partial class EntryPointTests
                     "--solution-or-project",
                     Path.Combine(path, "path/to/my.csproj"),
                     "--dependency",
-                    "Newtonsoft.Json",
+                    "Some.Package",
                     "--new-version",
                     "13.0.1",
                     "--previous-version",
                     "7.0.1",
                     "--verbose"
                 ],
+                packages:
+                [
+                    MockNuGetPackage.CreateSimplePackage("Some.Package", "7.0.1", "net45"),
+                    MockNuGetPackage.CreateSimplePackage("Some.Package", "13.0.1", "net45"),
+                ],
+                initialFiles:
                 [
                     ("path/to/my.csproj", """
                         <Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
@@ -137,8 +148,8 @@ public partial class EntryPointTests
                             <None Include="packages.config" />
                           </ItemGroup>
                           <ItemGroup>
-                            <Reference Include="Newtonsoft.Json, Version=7.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed">
-                              <HintPath>packages\Newtonsoft.Json.7.0.1\lib\net45\Newtonsoft.Json.dll</HintPath>
+                            <Reference Include="Some.Package">
+                              <HintPath>packages\Some.Package.7.0.1\lib\net45\Some.Package.dll</HintPath>
                               <Private>True</Private>
                             </Reference>
                           </ItemGroup>
@@ -147,10 +158,11 @@ public partial class EntryPointTests
                         """),
                     ("path/to/packages.config", """
                         <packages>
-                          <package id="Newtonsoft.Json" version="7.0.1" targetFramework="net45" />
+                          <package id="Some.Package" version="7.0.1" targetFramework="net45" />
                         </packages>
                         """)
                 ],
+                expectedFiles:
                 [
                     ("path/to/my.csproj", """
                         <Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
@@ -162,8 +174,8 @@ public partial class EntryPointTests
                             <None Include="packages.config" />
                           </ItemGroup>
                           <ItemGroup>
-                            <Reference Include="Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed">
-                              <HintPath>packages\Newtonsoft.Json.13.0.1\lib\net45\Newtonsoft.Json.dll</HintPath>
+                            <Reference Include="Some.Package">
+                              <HintPath>packages\Some.Package.13.0.1\lib\net45\Some.Package.dll</HintPath>
                               <Private>True</Private>
                             </Reference>
                           </ItemGroup>
@@ -173,10 +185,11 @@ public partial class EntryPointTests
                     ("path/to/packages.config", """
                         <?xml version="1.0" encoding="utf-8"?>
                         <packages>
-                          <package id="Newtonsoft.Json" version="13.0.1" targetFramework="net45" />
+                          <package id="Some.Package" version="13.0.1" targetFramework="net45" />
                         </packages>
                         """)
-                ]);
+                ]
+            );
         }
 
         [Fact]
@@ -190,13 +203,18 @@ public partial class EntryPointTests
                     "--solution-or-project",
                     $"{path}/some-dir/dirs.proj",
                     "--dependency",
-                    "NuGet.Versioning",
+                    "Some.Package",
                     "--new-version",
                     "6.6.1",
                     "--previous-version",
                     "6.1.0",
                     "--verbose"
                 ],
+                packages:
+                [
+                    MockNuGetPackage.CreateSimplePackage("Some.Package", "6.1.0", "net8.0"),
+                    MockNuGetPackage.CreateSimplePackage("Some.Package", "6.6.1", "net8.0"),
+                ],
                 initialFiles:
                 [
                     ("some-dir/dirs.proj", """
@@ -211,12 +229,12 @@ public partial class EntryPointTests
                         <Project Sdk="Microsoft.NET.Sdk">
                           <PropertyGroup>
                             <OutputType>Exe</OutputType>
-                            <TargetFramework>net6.0</TargetFramework>
+                            <TargetFramework>net8.0</TargetFramework>
                             <ImplicitUsings>enable</ImplicitUsings>
                             <Nullable>enable</Nullable>
                           </PropertyGroup>
                           <ItemGroup>
-                            <PackageReference Include="NuGet.Versioning" Version="6.1.0" />
+                            <PackageReference Include="Some.Package" Version="6.1.0" />
                           </ItemGroup>
                         </Project>
                         """),
@@ -224,12 +242,12 @@ public partial class EntryPointTests
                         <Project Sdk="Microsoft.NET.Sdk">
                           <PropertyGroup>
                             <OutputType>Exe</OutputType>
-                            <TargetFramework>net6.0</TargetFramework>
+                            <TargetFramework>net8.0</TargetFramework>
                             <ImplicitUsings>enable</ImplicitUsings>
                             <Nullable>enable</Nullable>
                           </PropertyGroup>
                           <ItemGroup>
-                            <PackageReference Include="NuGet.Versioning" Version="6.1.0" />
+                            <PackageReference Include="Some.Package" Version="6.1.0" />
                           </ItemGroup>
                         </Project>
                         """),
@@ -237,7 +255,7 @@ public partial class EntryPointTests
                         <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
                         
                           <ItemGroup>
-                            <PackageReference Include="NuGet.Versioning" Version="6.1.0" />
+                            <PackageReference Include="Some.Package" Version="6.1.0" />
                           </ItemGroup>
 
                         </Project>
@@ -258,12 +276,12 @@ public partial class EntryPointTests
                         <Project Sdk="Microsoft.NET.Sdk">
                           <PropertyGroup>
                             <OutputType>Exe</OutputType>
-                            <TargetFramework>net6.0</TargetFramework>
+                            <TargetFramework>net8.0</TargetFramework>
                             <ImplicitUsings>enable</ImplicitUsings>
                             <Nullable>enable</Nullable>
                           </PropertyGroup>
                           <ItemGroup>
-                            <PackageReference Include="NuGet.Versioning" Version="6.6.1" />
+                            <PackageReference Include="Some.Package" Version="6.6.1" />
                           </ItemGroup>
                         </Project>
                         """),
@@ -271,12 +289,12 @@ public partial class EntryPointTests
                         <Project Sdk="Microsoft.NET.Sdk">
                           <PropertyGroup>
                             <OutputType>Exe</OutputType>
-                            <TargetFramework>net6.0</TargetFramework>
+                            <TargetFramework>net8.0</TargetFramework>
                             <ImplicitUsings>enable</ImplicitUsings>
                             <Nullable>enable</Nullable>
                           </PropertyGroup>
                           <ItemGroup>
-                            <PackageReference Include="NuGet.Versioning" Version="6.6.1" />
+                            <PackageReference Include="Some.Package" Version="6.6.1" />
                           </ItemGroup>
                         </Project>
                         """),
@@ -284,7 +302,7 @@ public partial class EntryPointTests
                         <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
                         
                           <ItemGroup>
-                            <PackageReference Include="NuGet.Versioning" Version="6.1.0" />
+                            <PackageReference Include="Some.Package" Version="6.1.0" />
                           </ItemGroup>
 
                         </Project>
@@ -303,6 +321,14 @@ public partial class EntryPointTests
             // test this, it must be tested in a new process where MSBuild has not been loaded yet and the runner tool
             // must be started with its working directory at the test repo's root.
             using var tempDir = new TemporaryDirectory();
+
+            MockNuGetPackage[] testPackages =
+            [
+                MockNuGetPackage.CreateSimplePackage("Some.Package", "7.0.1", "net8.0"),
+                MockNuGetPackage.CreateSimplePackage("Some.Package", "13.0.1", "net8.0"),
+            ];
+            await MockNuGetPackagesInDirectory(testPackages, tempDir.DirectoryPath);
+
             var globalJsonPath = Path.Join(tempDir.DirectoryPath, "global.json");
             var srcGlobalJsonPath = Path.Join(tempDir.DirectoryPath, "src", "global.json");
             string globalJsonContent = """
@@ -322,20 +348,21 @@ public partial class EntryPointTests
                     <TargetFramework>net8.0</TargetFramework>
                   </PropertyGroup>
                   <ItemGroup>
-                    <PackageReference Include="Newtonsoft.Json" Version="7.0.1" />
+                    <PackageReference Include="Some.Package" Version="7.0.1" />
                   </ItemGroup>
                 </Project>
                 """);
-            var executableName = $"NuGetUpdater.Cli{(Environment.OSVersion.Platform == PlatformID.Win32NT ? ".exe" : "")}";
+            var executableName = Path.Join(Path.GetDirectoryName(GetType().Assembly.Location), "NuGetUpdater.Cli.dll");
             var executableArgs = string.Join(" ",
             [
+                executableName,
                 "update",
                 "--repo-root",
                 tempDir.DirectoryPath,
                 "--solution-or-project",
                 projectPath,
                 "--dependency",
-                "Newtonsoft.Json",
+                "Some.Package",
                 "--new-version",
                 "13.0.1",
                 "--previous-version",
@@ -350,7 +377,7 @@ public partial class EntryPointTests
                 workingDirectory = Path.Join(workingDirectory, workingDirectoryPath);
             }
 
-            var (exitCode, output, error) = await ProcessEx.RunAsync(executableName, executableArgs, workingDirectory: workingDirectory);
+            var (exitCode, output, error) = await ProcessEx.RunAsync("dotnet", executableArgs, workingDirectory: workingDirectory);
             Assert.True(exitCode == 0, $"Error running update on unsupported SDK.\nSTDOUT:\n{output}\nSTDERR:\n{error}");
 
             // verify project update
@@ -366,7 +393,7 @@ public partial class EntryPointTests
             Assert.Contains("99.99.99", updatedGlobalJsonContents);
         }
 
-        private static async Task Run(Func<string, string[]> getArgs, (string Path, string Content)[] initialFiles, (string, string)[] expectedFiles)
+        private static async Task Run(Func<string, string[]> getArgs, (string Path, string Content)[] initialFiles, (string, string)[] expectedFiles, MockNuGetPackage[]? packages = null)
         {
             var actualFiles = await RunUpdate(initialFiles, async path =>
             {
@@ -380,6 +407,7 @@ public partial class EntryPointTests
 
                 try
                 {
+                    await MockNuGetPackagesInDirectory(packages, path);
                     var args = getArgs(path);
                     var result = await Program.Main(args);
                     if (result != 0)

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/DiscoveryWorker.cs

@@ -2,6 +2,10 @@ using System.Collections.Immutable;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
+using Microsoft.Build.Construction;
+using Microsoft.Build.Definition;
+using Microsoft.Build.Evaluation;
+
 using NuGetUpdater.Core.Utilities;
 
 namespace NuGetUpdater.Core.Discover;
@@ -28,16 +32,15 @@ public partial class DiscoveryWorker
     {
         MSBuildHelper.RegisterMSBuild(Environment.CurrentDirectory, repoRootPath);
 
-        // When running under unit tests, the workspace path may not be rooted.
-        if (!Path.IsPathRooted(workspacePath) || !Directory.Exists(workspacePath))
-        {
-            workspacePath = Path.GetFullPath(Path.Join(repoRootPath, workspacePath));
-        }
-        else if (workspacePath == "/")
+        // the `workspacePath` variable is relative to a repository root, so a rooted path actually isn't rooted; the
+        // easy way to deal with this is to just trim the leading "/" if it exists
+        if (workspacePath.StartsWith("/"))
         {
-            workspacePath = repoRootPath;
+            workspacePath = workspacePath[1..];
         }
 
+        workspacePath = Path.Combine(repoRootPath, workspacePath);
+
         DotNetToolsJsonDiscoveryResult? dotNetToolsJsonDiscovery = null;
         GlobalJsonDiscoveryResult? globalJsonDiscovery = null;
         DirectoryPackagesPropsDiscoveryResult? directoryPackagesPropsDiscovery = null;
@@ -115,27 +118,117 @@ public partial class DiscoveryWorker
     private async Task<ImmutableArray<ProjectDiscoveryResult>> RunForDirectoryAsnyc(string repoRootPath, string workspacePath)
     {
         _logger.Log($"  Discovering projects beneath [{Path.GetRelativePath(repoRootPath, workspacePath)}].");
-        var projectPaths = FindProjectFiles(workspacePath);
-        if (projectPaths.IsEmpty)
+        var entryPoints = FindEntryPoints(workspacePath);
+        var projects = ExpandEntryPointsIntoProjects(entryPoints);
+        if (projects.IsEmpty)
         {
             _logger.Log("  No project files found.");
             return [];
         }
 
-        return await RunForProjectPathsAsync(repoRootPath, workspacePath, projectPaths);
+        return await RunForProjectPathsAsync(repoRootPath, workspacePath, projects);
     }
 
-    private static ImmutableArray<string> FindProjectFiles(string workspacePath)
+    private static ImmutableArray<string> FindEntryPoints(string workspacePath)
     {
-        return Directory.EnumerateFiles(workspacePath, "*.*proj", SearchOption.AllDirectories)
+        return Directory.EnumerateFiles(workspacePath)
             .Where(path =>
             {
-                var extension = Path.GetExtension(path).ToLowerInvariant();
-                return extension == ".proj" || extension == ".csproj" || extension == ".fsproj" || extension == ".vbproj";
+                string extension = Path.GetExtension(path).ToLowerInvariant();
+                switch (extension)
+                {
+                    case ".sln":
+                    case ".proj":
+                    case ".csproj":
+                    case ".fsproj":
+                    case ".vbproj":
+                        return true;
+                    default:
+                        return false;
+                }
             })
             .ToImmutableArray();
     }
 
+    private static ImmutableArray<string> ExpandEntryPointsIntoProjects(IEnumerable<string> entryPoints)
+    {
+        HashSet<string> expandedProjects = new();
+        HashSet<string> seenProjects = new();
+        Stack<string> filesToExpand = new(entryPoints);
+        while (filesToExpand.Count > 0)
+        {
+            string candidateEntryPoint = filesToExpand.Pop();
+            if (seenProjects.Add(candidateEntryPoint))
+            {
+                string extension = Path.GetExtension(candidateEntryPoint).ToLowerInvariant();
+                if (extension == ".sln")
+                {
+                    SolutionFile solution = SolutionFile.Parse(candidateEntryPoint);
+                    foreach (ProjectInSolution project in solution.ProjectsInOrder)
+                    {
+                        filesToExpand.Push(project.AbsolutePath);
+                    }
+                }
+                else if (extension == ".proj")
+                {
+                    IEnumerable<string> foundProjects = ExpandItemGroupFilesFromProject(candidateEntryPoint, "ProjectFile", "ProjectReference");
+                    foreach (string foundProject in foundProjects)
+                    {
+                        filesToExpand.Push(foundProject);
+                    }
+                }
+                else
+                {
+                    // .csproj, .fsproj, .vbproj
+                    // keep this project and check for references
+                    expandedProjects.Add(candidateEntryPoint);
+                    IEnumerable<string> referencedProjects = ExpandItemGroupFilesFromProject(candidateEntryPoint, "ProjectReference");
+                    foreach (string referencedProject in referencedProjects)
+                    {
+                        filesToExpand.Push(referencedProject);
+                    }
+                }
+            }
+        }
+
+        return expandedProjects.ToImmutableArray();
+    }
+
+    private static IEnumerable<string> ExpandItemGroupFilesFromProject(string projectPath, params string[] itemTypes)
+    {
+        if (!File.Exists(projectPath))
+        {
+            return [];
+        }
+
+        using ProjectCollection projectCollection = new();
+        Project project = Project.FromFile(projectPath, new ProjectOptions
+        {
+            LoadSettings = ProjectLoadSettings.IgnoreMissingImports | ProjectLoadSettings.IgnoreEmptyImports | ProjectLoadSettings.IgnoreInvalidImports,
+            ProjectCollection = projectCollection,
+        });
+
+        HashSet<string> allowableItemTypes = new(itemTypes, StringComparer.OrdinalIgnoreCase);
+        List<ProjectItem> projectItems = project.Items.Where(i => allowableItemTypes.Contains(i.ItemType)).ToList();
+        string projectDir = Path.GetDirectoryName(projectPath)!;
+        HashSet<string> seenItems = new(StringComparer.OrdinalIgnoreCase);
+        List<string> foundItems = new();
+        foreach (ProjectItem projectItem in projectItems)
+        {
+            // referenced projects commonly use the Windows-style directory separator which can cause problems on Unix
+            // but Windows is able to handle a Unix-style path, so we normalize everything to that then normalize again
+            // with regards to relative paths, e.g., "some/path/" + "..\other\file" => "some/other/file"
+            string referencedProjectPath = Path.Join(projectDir, projectItem.EvaluatedInclude.NormalizePathToUnix());
+            string normalizedReferenceProjectPath = new FileInfo(referencedProjectPath).FullName;
+            if (seenItems.Add(normalizedReferenceProjectPath))
+            {
+                foundItems.Add(normalizedReferenceProjectPath);
+            }
+        }
+
+        return foundItems;
+    }
+
     private async Task<ImmutableArray<ProjectDiscoveryResult>> RunForProjectPathsAsync(string repoRootPath, string workspacePath, IEnumerable<string> projectPaths)
     {
         var results = new Dictionary<string, ProjectDiscoveryResult>(StringComparer.OrdinalIgnoreCase);

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/MSBuildHelper.cs

@@ -480,11 +480,15 @@ internal static partial class MSBuildHelper
                 // We need to copy local package sources from the NuGet.Config file to the temp directory
                 foreach (var localSource in packageSources.Where(p => p.IsLocal))
                 {
-                    var subDir = localSource.Source.Split(nugetConfigDir)[1];
-                    var destPath = Path.Join(tempDir.FullName, subDir);
-                    if (Directory.Exists(localSource.Source))
+                    // if the source is relative to the original location, copy it to the temp directory
+                    if (PathHelper.IsSubdirectoryOf(nugetConfigDir!, localSource.Source))
                     {
-                        PathHelper.CopyDirectory(localSource.Source, destPath);
+                        string sourceRelativePath = Path.GetRelativePath(nugetConfigDir!, localSource.Source);
+                        string destPath = Path.Join(tempDir.FullName, sourceRelativePath);
+                        if (Directory.Exists(localSource.Source))
+                        {
+                            PathHelper.CopyDirectory(localSource.Source, destPath);
+                        }
                     }
                 }
             }
@@ -538,12 +542,12 @@ internal static partial class MSBuildHelper
               <PropertyGroup>
                 <!-- For Windows-specific apps -->
                 <EnableWindowsTargeting>true</EnableWindowsTargeting>
+                <ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally>
               </PropertyGroup>
             </Project>
             """);
 
         await File.WriteAllTextAsync(Path.Combine(tempDir.FullName, "Directory.Build.targets"), "<Project />");
-        await File.WriteAllTextAsync(Path.Combine(tempDir.FullName, "Directory.Packages.props"), "<Project />");
 
         return tempProjectPath;
     }

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/PathHelper.cs

@@ -111,4 +111,22 @@ internal static class PathHelper
             CopyDirectory(subDir.FullName, newDestinationDir);
         }
     }
+
+    public static bool IsSubdirectoryOf(string parentDirectory, string childDirectory)
+    {
+        var parentDirInfo = new DirectoryInfo(parentDirectory);
+        var childDirInfo = new DirectoryInfo(childDirectory);
+
+        while (childDirInfo.Parent is not null)
+        {
+            if (childDirInfo.Parent.FullName == parentDirInfo.FullName)
+            {
+                return true;
+            }
+
+            childDirInfo = childDirInfo.Parent;
+        }
+
+        return false;
+    }
 }

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Discover/DiscoveryWorkerTestBase.cs

@@ -3,9 +3,11 @@ using System.Diagnostics.CodeAnalysis;
 using System.Text.Json;
 
 using NuGetUpdater.Core.Discover;
+using NuGetUpdater.Core.Test.Update;
 using NuGetUpdater.Core.Test.Utilities;
 
 using Xunit;
+using Xunit.Sdk;
 
 namespace NuGetUpdater.Core.Test.Discover;
 
@@ -16,10 +18,13 @@ public class DiscoveryWorkerTestBase
     protected static async Task TestDiscoveryAsync(
         string workspacePath,
         TestFile[] files,
-        ExpectedWorkspaceDiscoveryResult expectedResult)
+        ExpectedWorkspaceDiscoveryResult expectedResult,
+        MockNuGetPackage[]? packages = null)
     {
         var actualResult = await RunDiscoveryAsync(files, async directoryPath =>
         {
+            await UpdateWorkerTestBase.MockNuGetPackagesInDirectory(packages, directoryPath);
+
             var worker = new DiscoveryWorker(new Logger(verbose: true));
             await worker.RunAsync(directoryPath, workspacePath, DiscoveryWorker.DiscoveryResultFileName);
         });

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Discover/DiscoveryWorkerTests.DotNetToolsJson.cs

@@ -10,6 +10,7 @@ public partial class DiscoveryWorkerTests
         public async Task DiscoversDependencies()
         {
             await TestDiscoveryAsync(
+                packages: [],
                 workspacePath: "",
                 files: [
                     (".config/dotnet-tools.json", """
@@ -45,13 +46,15 @@ public partial class DiscoveryWorkerTests
                         ]
                     },
                     ExpectedProjectCount = 0,
-                });
+                }
+            );
         }
 
         [Fact]
         public async Task ReportsFailure()
         {
             await TestDiscoveryAsync(
+                packages: [],
                 workspacePath: "",
                 files: [
                     (".config/dotnet-tools.json", """
@@ -85,7 +88,8 @@ public partial class DiscoveryWorkerTests
                         ExpectedDependencyCount = 0,
                     },
                     ExpectedProjectCount = 0,
-                });
+                }
+            );
         }
     }
 }

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Discover/DiscoveryWorkerTests.GlobalJson.cs

@@ -10,6 +10,7 @@ public partial class DiscoveryWorkerTests
         public async Task DiscoversDependencies()
         {
             await TestDiscoveryAsync(
+                packages: [],
                 workspacePath: "",
                 files: [
                     ("global.json", """
@@ -35,13 +36,15 @@ public partial class DiscoveryWorkerTests
                         ]
                     },
                     ExpectedProjectCount = 0,
-                });
+                }
+            );
         }
 
         [Fact]
         public async Task ReportsFailure()
         {
             await TestDiscoveryAsync(
+                packages: [],
                 workspacePath: "",
                 files: [
                     ("global.json", """
@@ -65,7 +68,8 @@ public partial class DiscoveryWorkerTests
                         ExpectedDependencyCount = 0,
                     },
                     ExpectedProjectCount = 0,
-                });
+                }
+            );
         }
     }
 }