dependabot-nuget 0.248.0 → 0.249.0

data/lib/dependabot/nuget/update_checker/tfm_finder.rb

@@ -1,8 +1,9 @@
-# typed: true
+# typed: strong
 # frozen_string_literal: true
 
 require "excon"
 require "nokogiri"
+require "sorbet-runtime"
 
 require "dependabot/update_checkers/base"
 require "dependabot/nuget/version"
@@ -13,15 +14,25 @@ require "dependabot/shared_helpers"
 module Dependabot
   module Nuget
     class TfmFinder
+      extend T::Sig
+
       require "dependabot/nuget/file_parser/packages_config_parser"
       require "dependabot/nuget/file_parser/project_file_parser"
 
+      sig do
+        params(
+          dependency_files: T::Array[Dependabot::DependencyFile],
+          credentials: T::Array[Dependabot::Credential],
+          repo_contents_path: T.nilable(String)
+        ).void
+      end
       def initialize(dependency_files:, credentials:, repo_contents_path:)
         @dependency_files       = dependency_files
         @credentials            = credentials
         @repo_contents_path     = repo_contents_path
       end
 
+      sig { params(dependency: Dependabot::Dependency).returns(T::Array[String]) }
       def frameworks(dependency)
         tfms = Set.new
         tfms += project_file_tfms(dependency)
@@ -31,14 +42,23 @@ module Dependabot
 
       private
 
-      attr_reader :dependency_files, :credentials, :repo_contents_path
+      sig { returns(T::Array[Dependabot::DependencyFile]) }
+      attr_reader :dependency_files
+
+      sig { returns(T::Array[Dependabot::Credential]) }
+      attr_reader :credentials
+
+      sig { returns(T.nilable(String)) }
+      attr_reader :repo_contents_path
 
+      sig { params(dependency: Dependabot::Dependency).returns(T::Array[String]) }
       def project_file_tfms(dependency)
         project_files_with_dependency(dependency).flat_map do |file|
           project_file_parser.target_frameworks(project_file: file)
         end
       end
 
+      sig { params(dependency: Dependabot::Dependency).returns(T::Array[Dependabot::DependencyFile]) }
       def project_files_with_dependency(dependency)
         project_files.select do |file|
           packages_config_contains_dependency?(file, dependency) ||
@@ -46,6 +66,7 @@ module Dependabot
         end
       end
 
+      sig { params(file: Dependabot::DependencyFile, dependency: Dependabot::Dependency).returns(T::Boolean) }
       def packages_config_contains_dependency?(file, dependency)
         config_file = find_packages_config_file(file)
         return false unless config_file
@@ -56,36 +77,48 @@ module Dependabot
         end
       end
 
+      sig { params(file: Dependabot::DependencyFile, dependency: Dependabot::Dependency).returns(T::Boolean) }
       def project_file_contains_dependency?(file, dependency)
         project_file_parser.dependency_set(project_file: file).dependencies.any? do |d|
           d.name.casecmp(dependency.name)&.zero?
         end
       end
 
+      sig { params(file: Dependabot::DependencyFile).returns(T.nilable(Dependabot::DependencyFile)) }
       def find_packages_config_file(file)
         return file if file.name.end_with?("packages.config")
 
         filename = File.basename(file.name)
         search_path = file.name.sub(filename, "packages.config")
 
-        dependency_files.find { |f| f.name.casecmp(search_path).zero? }
+        dependency_files.find { |f| f.name.casecmp(search_path)&.zero? }
       end
 
+      sig { returns(T::Array[String]) }
       def project_import_file_tfms
-        @project_import_file_tfms ||= project_import_files.flat_map do |file|
-          project_file_parser.target_frameworks(project_file: file)
-        end
+        @project_import_file_tfms ||=
+          T.let(
+            project_import_files.flat_map do |file|
+              project_file_parser.target_frameworks(project_file: file)
+            end,
+            T.nilable(T::Array[String])
+          )
       end
 
+      sig { returns(FileParser::ProjectFileParser) }
       def project_file_parser
         @project_file_parser ||=
-          FileParser::ProjectFileParser.new(
-            dependency_files: dependency_files,
-            credentials: credentials,
-            repo_contents_path: repo_contents_path
+          T.let(
+            FileParser::ProjectFileParser.new(
+              dependency_files: dependency_files,
+              credentials: credentials,
+              repo_contents_path: repo_contents_path
+            ),
+            T.nilable(FileParser::ProjectFileParser)
           )
       end
 
+      sig { returns(T::Array[Dependabot::DependencyFile]) }
       def project_files
         projfile = /\.[a-z]{2}proj$/
         packageprops = /[Dd]irectory.[Pp]ackages.props/
@@ -96,12 +129,14 @@ module Dependabot
         end
       end
 
+      sig { returns(T::Array[Dependabot::DependencyFile]) }
       def packages_config_files
         dependency_files.select do |f|
-          f.name.split("/").last.casecmp("packages.config").zero?
+          f.name.split("/").last&.casecmp("packages.config")&.zero?
         end
       end
 
+      sig { returns(T::Array[Dependabot::DependencyFile]) }
       def project_import_files
         dependency_files -
           project_files -
@@ -111,16 +146,19 @@ module Dependabot
           [dotnet_tools_json]
       end
 
+      sig { returns(T::Array[Dependabot::DependencyFile]) }
       def nuget_configs
         dependency_files.select { |f| f.name.match?(/nuget\.config$/i) }
       end
 
+      sig { returns(T.nilable(Dependabot::DependencyFile)) }
       def global_json
-        dependency_files.find { |f| f.name.casecmp("global.json").zero? }
+        dependency_files.find { |f| f.name.casecmp("global.json")&.zero? }
       end
 
+      sig { returns(T.nilable(Dependabot::DependencyFile)) }
       def dotnet_tools_json
-        dependency_files.find { |f| f.name.casecmp(".config/dotnet-tools.json").zero? }
+        dependency_files.find { |f| f.name.casecmp(".config/dotnet-tools.json")&.zero? }
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dependabot-nuget
 version: !ruby/object:Gem::Version
-  version: 0.248.0
+  version: 0.249.0
 platform: ruby
 authors:
 - Dependabot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-03-21 00:00:00.000000000 Z
+date: 2024-03-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dependabot-common
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.248.0
+        version: 0.249.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.248.0
+        version: 0.249.0
 - !ruby/object:Gem::Dependency
   name: rubyzip
   requirement: !ruby/object:Gem::Requirement
@@ -385,7 +385,7 @@ licenses:
 - Nonstandard
 metadata:
   bug_tracker_uri: https://github.com/dependabot/dependabot-core/issues
-  changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.248.0
+  changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.249.0
 post_install_message: 
 rdoc_options: []
 require_paths: