dependabot-nuget 0.145.0 → 0.146.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 412f424bef4ab86f23adf3d733500bc7277ff55b6874c6ee616fc234fe1a24b1
-  data.tar.gz: fdb5f85ca816523d02fe0818af0bcef2220ef6ac1051f945f2052f971c258cca
+  metadata.gz: 0733c5a197731c47f754e1487b34e13d7ed1ee12ab19a7a8c9b03b0d7449bc9d
+  data.tar.gz: 8ecb6ca70de1a6565f2c5d4f06d89a0368da3bef8edd79a240baea9714036168
 SHA512:
-  metadata.gz: 233bfad156f96b898830edfff409da3a03aad7059fbfa4e665fc306180cdaa04aca0803758bcb120778e96217dfcd4654fb2fcb975e282710b5d7edb8580582e
-  data.tar.gz: 3885c8187f35b67f89fa8c12328f189d7fcd72c834a955de227c518b036b346a5ed7adaea2e817aa1024343e730bdabae230506c1d7221b0853c150f0c1a75a6
+  metadata.gz: 638ddfd2d2194563a061df94d0cca052531286b9f906a8c733c4f25bddb064b9bec7f251998701b0044d5d53635fca6468279c8c58aec5d1898978bebd48ee7e
+  data.tar.gz: 20dbfe4eb823489f03a34121078ecd74810f0d3a45a9cf8cc9d1d8fa7a6af06926562ffa193a15d8516bd27d6c3ae310890a61b887fc977cf63f00c55953d6d7

data/lib/dependabot/nuget/update_checker/version_finder.rb

@@ -75,7 +75,10 @@ module Dependabot
               reject { |v| ignore_req.satisfied_by?(v.fetch(:version)) }
           end
 
-          raise AllVersionsIgnored if @raise_on_ignored && filtered.empty? && possible_versions.any?
+          if @raise_on_ignored && filter_lower_versions(filtered).empty? &&
+             filter_lower_versions(possible_versions).any?
+            raise AllVersionsIgnored
+          end
 
           filtered
         end
@@ -210,14 +213,8 @@ module Dependabot
           @v2_nuget_listings ||=
             dependency_urls.
             select { |details| details.fetch(:repository_type) == "v2" }.
-            map do |url_details|
-              response = Excon.get(
-                url_details[:versions_url],
-                idempotent: true,
-                **SharedHelpers.excon_defaults(
-                  excon_options.merge(headers: url_details[:auth_header])
-                )
-              )
+            flat_map { |url_details| fetch_paginated_v2_nuget_listings(url_details) }.
+            map do |url_details, response|
               next unless response.status == 200
 
               {
@@ -227,6 +224,39 @@ module Dependabot
             end.compact
         end
 
+        def fetch_paginated_v2_nuget_listings(url_details, results = {})
+          response = Excon.get(
+            url_details[:versions_url],
+            idempotent: true,
+            **SharedHelpers.excon_defaults(excon_options.merge(headers: url_details[:auth_header]))
+          )
+
+          # NOTE: Short circuit if we get a circular next link
+          return results.to_a if results.key?(url_details)
+
+          results[url_details] = response
+
+          if (link_href = fetch_v2_next_link_href(response.body))
+            url_details = url_details.dup
+            url_details[:versions_url] = link_href
+            fetch_paginated_v2_nuget_listings(url_details, results)
+          end
+
+          results.to_a
+        end
+
+        def fetch_v2_next_link_href(xml_body)
+          doc = Nokogiri::XML(xml_body)
+          doc.remove_namespaces!
+          link_node = doc.xpath("/feed/link").find do |node|
+            rel = node.attribute("rel").value.strip
+            rel == "next"
+          end
+          link_node.attribute("href").value.strip if link_node
+        rescue Nokogiri::XML::XPath::SyntaxError
+          nil
+        end
+
         def versions_for_v3_repository(repository_details)
           # If we have a search URL that returns results we use it
           # (since it will exclude unlisted versions)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dependabot-nuget
 version: !ruby/object:Gem::Version
-  version: 0.145.0
+  version: 0.146.0
 platform: ruby
 authors:
 - Dependabot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-05-05 00:00:00.000000000 Z
+date: 2021-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dependabot-common
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.145.0
+        version: 0.146.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.145.0
+        version: 0.146.0
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.13.0
+        version: 1.14.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.13.0
+        version: 1.14.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement