dependabot-gradle 0.352.0 → 0.354.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9167450605c90c479bfbd32b2f4a0e68458e25a411cc58cee54a380870c3d073
-  data.tar.gz: 6162f15731d05b8d9f041d3101d39b47071caaac5e9b78e3b4ae1393d1fb0dfb
+  metadata.gz: 7db2a419f742bd2979d5a1725f23be6bc2a10462405c3f6d1c43062e1634d5d8
+  data.tar.gz: e3146c6d0f3940b32a7d051d537d85f2c9d6053c1bf02d968d5ded8c6d1fa851
 SHA512:
-  metadata.gz: 772120fb47bab993074d800657abff25723b064f4b4b15b776ed26acc41bb87292fbc8bf092d1793527d07295f80e9418fc4defa20ee9e21a356f8b4a2d949a2
-  data.tar.gz: 643749b490126dac40f3602a6d7bb428e9072897c0945b6985ddd9163a17460685dd1830ef69fb392343cea06d1e51dcfd15ed225a81b6e26b048e7e4e1f1f1c
+  metadata.gz: 6be8055ca12fb8c042f8e773b41de99c9b84109dbe4ca9cb366d740b28f88c1758435feba240acc711230bcf4507355697c39ca15924830b2f476706a6c98a86
+  data.tar.gz: 19f0de7c5b7638b4dbee8703ecffe083a1abae88b0981e2bc59f0999b6942339477d1f9b7e48dff91cbb4ccd9c713657ea5260e6a0b3b28164a7b3d0a5578011

data/lib/dependabot/gradle/file_fetcher.rb

@@ -192,6 +192,7 @@ module Dependabot
             file.content = Base64.encode64(T.must(file.content)) if file.content
             file.content_encoding = DependencyFile::ContentEncoding::BASE64
           end
+          file.mode = DependencyFile::Mode::EXECUTABLE if file.name.end_with?("gradlew", "gradlew.bat")
           file
         rescue Dependabot::DependencyFileNotFound
           # Gradle itself doesn't worry about missing subprojects, so we don't

data/lib/dependabot/gradle/package/package_details_fetcher.rb

@@ -12,6 +12,7 @@ require "dependabot/gradle/distributions"
 require "dependabot/maven/utils/auth_headers_finder"
 require "sorbet-runtime"
 require "dependabot/gradle/metadata_finder"
+require "dependabot/gradle/package/release_date_extractor"
 
 module Dependabot
   module Gradle
@@ -101,37 +102,16 @@ module Dependabot
 
         sig { returns(T::Hash[String, T::Hash[Symbol, T.untyped]]) }
         def release_details
-          release_date_info = T.let({}, T::Hash[String, T::Hash[Symbol, T.untyped]])
-
-          begin
-            repositories.map do |repository_details|
-              url = repository_details.fetch("url")
-              next unless url == Gradle::FileParser::RepositoriesFinder::CENTRAL_REPO_URL
-
-              release_info_metadata(repository_details).css("a[title]").each do |link|
-                version_string = link["title"]
-                version = version_string.gsub(%r{/$}, "")
-                raw_date_text = link.next.text.strip.split("\n").last.strip
-
-                release_date = begin
-                  Time.parse(raw_date_text)
-                rescue StandardError
-                  nil
-                end
-
-                next unless version && version_class.correct?(version)
-
-                release_date_info[version] = {
-                  release_date: release_date
-                }
-              end
-            end
+          extractor = ReleaseDateExtractor.new(
+            dependency_name: dependency.name,
+            version_class: version_class
+          )
 
-            release_date_info
-          rescue StandardError
-            Dependabot.logger.error("Failed to get release date")
-            {}
-          end
+          extractor.extract(
+            repositories: repositories,
+            dependency_metadata_fetcher: ->(repo) { dependency_metadata(repo) },
+            release_info_metadata_fetcher: ->(repo) { release_info_metadata(repo) }
+          )
         end
 
         sig { returns(T::Array[T::Hash[String, T.untyped]]) }
@@ -226,6 +206,8 @@ module Dependabot
             end
         end
 
+        # Fetches HTML directory listing from Maven-compatible repositories.
+        # Uses CSS selector "a[title]" to extract versions and dates. Caches results per repository.
         sig { params(repository_details: T::Hash[T.untyped, T.untyped]).returns(T.untyped) }
         def release_info_metadata(repository_details)
           @release_info_metadata ||= T.let({}, T.nilable(T::Hash[Integer, T.untyped]))
@@ -237,14 +219,14 @@ module Dependabot
               )
 
               check_response(response, repository_details.fetch("url"))
-              Nokogiri::XML(response.body)
+              Nokogiri::HTML(response.body)
             rescue URI::InvalidURIError
-              Nokogiri::XML("")
+              Nokogiri::HTML("")
             rescue Excon::Error::Socket, Excon::Error::Timeout,
                    Excon::Error::TooManyRedirects
               raise if central_repo_urls.include?(repository_details["url"])
 
-              Nokogiri::XML("")
+              Nokogiri::HTML("")
             end
         end
 

data/lib/dependabot/gradle/package/release_date_extractor.rb

@@ -0,0 +1,166 @@
+# typed: strict
+# frozen_string_literal: true
+
+require "nokogiri"
+require "time"
+require "sorbet-runtime"
+require "dependabot/logger"
+
+module Dependabot
+  module Gradle
+    module Package
+      # Extracts release dates from repository metadata to support the cooldown feature.
+      # Handles multiple repository formats (Maven Central HTML listings, Gradle Plugin Portal XML).
+      class ReleaseDateExtractor
+        extend T::Sig
+
+        sig do
+          params(
+            dependency_name: String,
+            version_class: T.class_of(Dependabot::Version)
+          ).void
+        end
+        def initialize(dependency_name:, version_class:)
+          @dependency_name = dependency_name
+          @version_class = version_class
+        end
+
+        # Extracts release dates from all repositories.
+        # Attempts both parsing strategies for all repositories:
+        # 1. Gradle Plugin Portal style: maven-metadata.xml with lastUpdated timestamp (latest version only)
+        # 2. Maven repository style: HTML directory listings with per-version dates
+        # This supports mirrors/proxies of both Maven Central and Gradle Plugin Portal.
+        sig do
+          params(
+            repositories: T::Array[T::Hash[String, T.untyped]],
+            dependency_metadata_fetcher: T.proc.params(
+              repo: T::Hash[String, T.untyped]
+            ).returns(Nokogiri::XML::Document),
+            release_info_metadata_fetcher: T.proc.params(
+              repo: T::Hash[String, T.untyped]
+            ).returns(Nokogiri::HTML::Document)
+          ).returns(T::Hash[String, T::Hash[Symbol, T.untyped]])
+        end
+        def extract(repositories:, dependency_metadata_fetcher:, release_info_metadata_fetcher:)
+          release_date_info = T.let({}, T::Hash[String, T::Hash[Symbol, T.untyped]])
+
+          begin
+            repositories.each do |repository_details|
+              parse_gradle_plugin_portal_release(
+                repository_details,
+                release_date_info,
+                dependency_metadata_fetcher
+              )
+
+              parse_maven_central_releases(
+                repository_details,
+                release_date_info,
+                release_info_metadata_fetcher
+              )
+            end
+
+            release_date_info
+          rescue StandardError => e
+            Dependabot.logger.error(
+              "Failed to get release date for #{@dependency_name}: #{e.class} - #{e.message}"
+            )
+            Dependabot.logger.error(e.backtrace&.join("\n") || "No backtrace available")
+            {}
+          end
+        end
+
+        private
+
+        sig { returns(String) }
+        attr_reader :dependency_name
+
+        sig { returns(T.class_of(Dependabot::Version)) }
+        attr_reader :version_class
+
+        # Parses Maven-style HTML directory listings to extract release dates.
+        sig do
+          params(
+            repository_details: T::Hash[String, T.untyped],
+            release_date_info: T::Hash[String, T::Hash[Symbol, T.untyped]],
+            metadata_fetcher: T.proc.params(
+              repo: T::Hash[String, T.untyped]
+            ).returns(Nokogiri::HTML::Document)
+          ).void
+        end
+        def parse_maven_central_releases(repository_details, release_date_info, metadata_fetcher)
+          metadata_fetcher.call(repository_details).css("a[title]").each do |link|
+            title = link["title"]
+            next unless title
+
+            version = title.gsub(%r{/$}, "")
+            next unless version_class.correct?(version)
+            next if release_date_info.key?(version)
+
+            release_date = extract_release_date_from_link(link, version)
+            release_date_info[version] = { release_date: release_date }
+          end
+        rescue StandardError => e
+          Dependabot.logger.debug(
+            "Could not parse Maven-style release dates from #{repository_details.fetch('url')} " \
+            "for #{dependency_name}: #{e.message}"
+          )
+        end
+
+        # Parses Gradle Plugin Portal maven-metadata.xml for release dates.
+        sig do
+          params(
+            repository_details: T::Hash[String, T.untyped],
+            release_date_info: T::Hash[String, T::Hash[Symbol, T.untyped]],
+            metadata_fetcher: T.proc.params(
+              repo: T::Hash[String, T.untyped]
+            ).returns(Nokogiri::XML::Document)
+          ).void
+        end
+        def parse_gradle_plugin_portal_release(repository_details, release_date_info, metadata_fetcher)
+          metadata_xml = metadata_fetcher.call(repository_details)
+          last_updated = metadata_xml.at_xpath("//metadata/versioning/lastUpdated")&.text&.strip
+          latest_version = metadata_xml.at_xpath("//metadata/versioning/latest")&.text&.strip
+
+          return unless latest_version && version_class.correct?(latest_version)
+          return if release_date_info.key?(latest_version)
+
+          release_date = parse_gradle_timestamp(last_updated)
+          Dependabot.logger.info(
+            "Parsed Gradle Plugin Portal release for #{dependency_name}: #{latest_version} at #{release_date}"
+          )
+          release_date_info[latest_version] = { release_date: release_date }
+        rescue StandardError => e
+          Dependabot.logger.debug(
+            "Could not parse Gradle Plugin Portal metadata from #{repository_details.fetch('url')} " \
+            "for #{dependency_name}: #{e.message}"
+          )
+        end
+
+        # Extracts release date from HTML link element's adjacent text.
+        sig { params(link: Nokogiri::XML::Element, version: String).returns(T.nilable(Time)) }
+        def extract_release_date_from_link(link, version)
+          raw_date_text = link.next.text.strip.split("\n").last.strip
+          Time.parse(raw_date_text)
+        rescue StandardError => e
+          Dependabot.logger.debug(
+            "Failed to parse release date for #{dependency_name} version #{version}: #{e.message}"
+          )
+          nil
+        end
+
+        # Parses Gradle Plugin Portal timestamp format (YYYYMMDDHHmmss).
+        sig { params(timestamp: T.nilable(String)).returns(T.nilable(Time)) }
+        def parse_gradle_timestamp(timestamp)
+          return nil if timestamp.nil? || timestamp.empty?
+
+          Time.strptime(timestamp, "%Y%m%d%H%M%S")
+        rescue ArgumentError => e
+          Dependabot.logger.warn(
+            "Failed to parse Gradle timestamp for #{dependency_name}: '#{timestamp}' - #{e.message}"
+          )
+          nil
+        end
+      end
+    end
+  end
+end

data/lib/dependabot/gradle/update_checker/version_finder.rb

@@ -253,8 +253,13 @@ module Dependabot
         sig { params(release: Dependabot::Package::PackageRelease).returns(T::Boolean) }
         def in_cooldown_period?(release)
           unless release.released_at
-            Dependabot.logger.info("Release date not available for version #{release.version}")
-            return false
+            if cooldown_options
+              Dependabot.logger.info("Release date not available for version #{release.version} - filtering out")
+              return true
+            else
+              Dependabot.logger.info("Release date not available for version #{release.version}")
+              return false
+            end
           end
 
           current_version = version_class.correct?(dependency.version) ? version_class.new(dependency.version) : nil

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dependabot-gradle
 version: !ruby/object:Gem::Version
-  version: 0.352.0
+  version: 0.354.0
 platform: ruby
 authors:
 - Dependabot
@@ -15,28 +15,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.352.0
+        version: 0.354.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.352.0
+        version: 0.354.0
 - !ruby/object:Gem::Dependency
   name: dependabot-maven
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.352.0
+        version: 0.354.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.352.0
+        version: 0.354.0
 - !ruby/object:Gem::Dependency
   name: debug
   requirement: !ruby/object:Gem::Requirement
@@ -272,6 +272,7 @@ files:
 - lib/dependabot/gradle/metadata_finder.rb
 - lib/dependabot/gradle/package/distributions_fetcher.rb
 - lib/dependabot/gradle/package/package_details_fetcher.rb
+- lib/dependabot/gradle/package/release_date_extractor.rb
 - lib/dependabot/gradle/package_manager.rb
 - lib/dependabot/gradle/requirement.rb
 - lib/dependabot/gradle/update_checker.rb
@@ -284,7 +285,7 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/dependabot/dependabot-core/issues
-  changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.352.0
+  changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.354.0
 rdoc_options: []
 require_paths:
 - lib