dependabot-gradle 0.129.2 → 0.130.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d1dc00bb8b435b360676de16bc2f18ecade53a97e5957d6bb29e0342033631f0
-  data.tar.gz: 616c8a64b3bc6f64ad5219903a90ec095a82b5222961f2bcb8b9a9bd0d58cc1b
+  metadata.gz: 3e876a71ffd580a223b7ae2330d5f52086649df029d84b1cfed5e0e7b668f0fa
+  data.tar.gz: a282e48a59b73806501b2b3e2c1eeebb4ce9779caca3e9e3756f691c3148b2f4
 SHA512:
-  metadata.gz: 10c0cda388a93d7db1403ad10cedcf9c342120549daede60224a0d700c1c9e329eb6febe58bfa5dbdb008fc0445c5d850277e25d5d6b8529c1f822fa24df6f0a
-  data.tar.gz: a14d84a747f50956c1e1eec206f4163345a9a18e7e6e30f8383a8854b86a5864bf322c83940b7f62158e113022f16769ee033376082fad7883c448f707580e81
+  metadata.gz: 8bb5c73e453b21ea93fae8209fc9fefdf430683b2e958a9ad3a3c1883a24f9f6586659ab9e8dbdba14a5582ec63cd0b3c38a441c0248e45de24436c634fc410f
+  data.tar.gz: 48b598eaa21bf1285d136a0fa09d40eeb9e56692d9b724f2186920ce4009a83adf57f25db9dc1c7e65c9895b40f926af5b3c35c55d02fdf02ac50f40bcdb0bc4

data/lib/dependabot/gradle/file_fetcher.rb

@@ -31,6 +31,7 @@ module Dependabot
         fetched_files << buildfile
         fetched_files += subproject_buildfiles
         fetched_files += dependency_script_plugins
+        check_required_files_present
         fetched_files
       end
 
@@ -38,7 +39,7 @@ module Dependabot
         @buildfile ||= begin
           file = supported_build_file
           @buildfile_name ||= file.name if file
-          fetch_file_from_host(file.name) if file
+          file
         end
       end
 
@@ -58,7 +59,10 @@ module Dependabot
         end.compact
       end
 
+      # rubocop:disable Metrics/PerceivedComplexity
       def dependency_script_plugins
+        return [] unless buildfile
+
         dependency_plugin_paths =
           buildfile.content.
           scan(/apply from:\s+['"]([^'"]+)['"]/).flatten.
@@ -77,6 +81,15 @@ module Dependabot
           raise
         end.compact
       end
+      # rubocop:enable Metrics/PerceivedComplexity
+
+      def check_required_files_present
+        return if buildfile
+
+        path = Pathname.new(File.join(directory, "build.gradle")).cleanpath.to_path
+        path += "(.kts)?"
+        raise Dependabot::DependencyFileNotFound, path
+      end
 
       def file_exists_in_submodule?(path)
         fetch_file_from_host(path, fetch_submodules: true)
@@ -86,12 +99,7 @@ module Dependabot
       end
 
       def settings_file
-        @settings_file ||= begin
-          file = supported_settings_file
-          fetch_file_from_host(file.name) if file
-        rescue Dependabot::DependencyFileNotFound
-          nil
-        end
+        @settings_file ||= supported_settings_file
       end
 
       def supported_build_file

data/lib/dependabot/gradle/file_parser.rb

@@ -36,8 +36,6 @@ module Dependabot
         /(?:^|\s)dependencySet\((?<arguments>[^\)]+)\)\s*\{/.freeze
       DEPENDENCY_SET_ENTRY_REGEX = /entry\s+['"](?<name>#{PART})['"]/.freeze
       PLUGIN_BLOCK_DECLARATION_REGEX = /(?:^|\s)plugins\s*\{/.freeze
-      PLUGIN_BLOCK_ENTRY_REGEX =
-        /id\s+"(?<id>#{PART})"\s+version\s+"(?<version>#{VSN_PART})"/.freeze
       PLUGIN_ID_REGEX = /['"](?<id>#{PART})['"]/.freeze
 
       def parse
@@ -149,14 +147,14 @@ module Dependabot
 
         plugin_blocks.each do |blk|
           blk.lines.each do |line|
-            name_regex = /id(\s+#{PLUGIN_ID_REGEX}|\(#{PLUGIN_ID_REGEX}\))/
+            name_regex = /(id|kotlin)(\s+#{PLUGIN_ID_REGEX}|\(#{PLUGIN_ID_REGEX}\))/
             name = line.match(name_regex)&.named_captures&.fetch("id")
             version_regex = /version\s+['"](?<version>#{VSN_PART})['"]/
             version = line.match(version_regex)&.named_captures&.
                 fetch("version")
             next unless name && version
 
-            details = { name: name, group: "plugins", version: version }
+            details = { name: name, group: "plugins", extra_groups: extra_groups(line), version: version }
             dep = dependency_from(details_hash: details, buildfile: buildfile)
             dependency_set << dep if dep
           end
@@ -165,6 +163,10 @@ module Dependabot
         dependency_set
       end
 
+      def extra_groups(line)
+        line.match(/kotlin(\s+#{PLUGIN_ID_REGEX}|\(#{PLUGIN_ID_REGEX}\))/) ? ["kotlin"] : []
+      end
+
       def argument_from_string(string, arg_name)
         string.
           match(map_value_regex(arg_name))&.
@@ -176,13 +178,14 @@ module Dependabot
         group   = evaluated_value(details_hash[:group], buildfile)
         name    = evaluated_value(details_hash[:name], buildfile)
         version = evaluated_value(details_hash[:version], buildfile)
+        extra_groups = details_hash[:extra_groups] || []
 
         dependency_name =
           if group == "plugins" then name
           else "#{group}:#{name}"
           end
         groups =
-          if group == "plugins" then ["plugins"]
+          if group == "plugins" then ["plugins"] + extra_groups
           else []
           end
         source =

data/lib/dependabot/gradle/file_updater.rb

@@ -140,7 +140,7 @@ module Dependabot
             next false unless line.include?(dependency.name.split(":").last)
           else
             name_regex_value = /['"]#{Regexp.quote(dependency.name)}['"]/
-            name_regex = /id(\s+#{name_regex_value}|\(#{name_regex_value}\))/
+            name_regex = /(id|kotlin)(\s+#{name_regex_value}|\(#{name_regex_value}\))/
             next false unless line.match?(name_regex)
           end
 

data/lib/dependabot/gradle/metadata_finder.rb

@@ -11,6 +11,7 @@ module Dependabot
     class MetadataFinder < Dependabot::MetadataFinders::Base
       DOT_SEPARATOR_REGEX = %r{\.(?!\d+([.\/_\-]|$)+)}.freeze
       PROPERTY_REGEX      = /\$\{(?<property>.*?)\}/.freeze
+      KOTLIN_PLUGIN_REPO_PREFIX = "org.jetbrains.kotlin"
 
       private
 
@@ -101,7 +102,8 @@ module Dependabot
         return @dependency_pom_file unless @dependency_pom_file.nil?
 
         artifact_id =
-          if plugin? then "#{dependency.name}.gradle.plugin"
+          if kotlin_plugin? then "#{KOTLIN_PLUGIN_REPO_PREFIX}.#{dependency.name}.gradle.plugin"
+          elsif plugin? then "#{dependency.name}.gradle.plugin"
           else dependency.name.split(":").last
           end
 
@@ -150,7 +152,10 @@ module Dependabot
 
       def maven_repo_dependency_url
         group_id, artifact_id =
-          if plugin? then [dependency.name, "#{dependency.name}.gradle.plugin"]
+          if kotlin_plugin?
+            ["#{KOTLIN_PLUGIN_REPO_PREFIX}.#{dependency.name}",
+             "#{KOTLIN_PLUGIN_REPO_PREFIX}.#{dependency.name}.gradle.plugin"]
+          elsif plugin? then [dependency.name, "#{dependency.name}.gradle.plugin"]
           else dependency.name.split(":")
           end
 
@@ -158,7 +163,11 @@ module Dependabot
       end
 
       def plugin?
-        dependency.requirements.any? { |r| r.fetch(:groups) == ["plugins"] }
+        dependency.requirements.any? { |r| r.fetch(:groups).include? "plugins" }
+      end
+
+      def kotlin_plugin?
+        plugin? && dependency.requirements.any? { |r| r.fetch(:groups).include? "kotlin" }
       end
 
       def auth_details

data/lib/dependabot/gradle/update_checker/version_finder.rb

@@ -13,6 +13,7 @@ module Dependabot
       class VersionFinder
         GOOGLE_MAVEN_REPO = "https://maven.google.com"
         GRADLE_PLUGINS_REPO = "https://plugins.gradle.org/m2"
+        KOTLIN_PLUGIN_REPO_PREFIX = "org.jetbrains.kotlin"
         TYPE_SUFFICES = %w(jre android java).freeze
 
         GRADLE_RANGE_REGEX = /[\(\[].*,.*[\)\]]/.freeze
@@ -295,6 +296,7 @@ module Dependabot
 
         def dependency_metadata_url(repository_url)
           group_id, artifact_id = group_and_artifact_ids
+          group_id = "#{KOTLIN_PLUGIN_REPO_PREFIX}.#{group_id}" if kotlin_plugin?
 
           "#{repository_url}/"\
           "#{group_id.tr('.', '/')}/"\
@@ -303,7 +305,9 @@ module Dependabot
         end
 
         def group_and_artifact_ids
-          if plugin?
+          if kotlin_plugin?
+            [dependency.name, "#{KOTLIN_PLUGIN_REPO_PREFIX}.#{dependency.name}.gradle.plugin"]
+          elsif plugin?
             [dependency.name, "#{dependency.name}.gradle.plugin"]
           else
             dependency.name.split(":")
@@ -311,7 +315,11 @@ module Dependabot
         end
 
         def plugin?
-          dependency.requirements.any? { |r| r.fetch(:groups) == ["plugins"] }
+          dependency.requirements.any? { |r| r.fetch(:groups).include? "plugins" }
+        end
+
+        def kotlin_plugin?
+          plugin? && dependency.requirements.any? { |r| r.fetch(:groups).include? "kotlin" }
         end
 
         def central_repo_urls

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dependabot-gradle
 version: !ruby/object:Gem::Version
-  version: 0.129.2
+  version: 0.130.1
 platform: ruby
 authors:
 - Dependabot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-04 00:00:00.000000000 Z
+date: 2021-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dependabot-common
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.129.2
+        version: 0.130.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.129.2
+        version: 0.130.1
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.7.0
+        version: 1.8.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.7.0
+        version: 1.8.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -206,7 +206,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 2.5.0
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.3
 signing_key: 
 specification_version: 4
 summary: Gradle support for dependabot