dependabot-common 0.243.0 → 0.245.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4c66b8233da2a6599d23a5c9a0db612e4225e7a1ef54aad500fd8861e9a98273
-  data.tar.gz: 682b44c5d4ec337dd4a29a80f029e1e84869b9434aea2619969b5079aecac51c
+  metadata.gz: fbc9b9fbba7549f6bdbb7dafec2f3d3111bd2e8263e966b3eaf1bfce19be3a01
+  data.tar.gz: 2e396338454b56410104329634792a20076533cadf2418f15e74d591612969eb
 SHA512:
-  metadata.gz: 9e5c58e16b97382100d7b9b72dcc85ed38d48b8df82a9a1135d72ecda5deab0182a333a4e4ddbb1840b3d2b73c8cf36d3555c5a89af4bf780b76998fabc36404
-  data.tar.gz: 65b24a2eb7ab108af968ccfde8934e74e5a1bf584af8b517df75a369b48a515a3011c2c2e4392ffb57f6848b800d83c2eea82dac6d9820fa1bd45ec4b56af166
+  metadata.gz: 2cc3166e278f88f679a7d177b74d77ba9d8cd48ac22694db65a61a36bf5386efb7fd459e430f971cad2e21f33253e67f1e264137fcfc48b57d3d41480c71f9f9
+  data.tar.gz: fc85175d8dfe6020bc3737fec46342fe529371e984d0f1d806195c697124ff6c63418edc7a1135a30c1c2ceff6caf28be2a715463c466c6bfa3267b5b0249b8a

data/lib/dependabot/clients/bitbucket_with_retries.rb

@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 require_relative "bitbucket"
@@ -6,15 +6,18 @@ require_relative "bitbucket"
 module Dependabot
   module Clients
     class BitbucketWithRetries
-      RETRYABLE_ERRORS = [
-        Excon::Error::Timeout,
-        Excon::Error::Socket
-      ].freeze
+      extend T::Sig
+
+      RETRYABLE_ERRORS = T.let(
+        [Excon::Error::Timeout, Excon::Error::Socket].freeze,
+        T::Array[T.class_of(Excon::Error)]
+      )
 
       #######################
       # Constructor methods #
       #######################
 
+      sig { params(credentials: T::Array[Dependabot::Credential]).returns(BitbucketWithRetries) }
       def self.for_bitbucket_dot_org(credentials:)
         credential =
           credentials
@@ -28,27 +31,48 @@ module Dependabot
       # Proxying #
       ############
 
-      def initialize(max_retries: 3, **args)
-        @max_retries = max_retries || 3
-        @client = Bitbucket.new(**T.unsafe(args))
+      sig { params(credentials: T.nilable(Dependabot::Credential), max_retries: T.nilable(Integer)).void }
+      def initialize(credentials:, max_retries: 3)
+        @max_retries = T.let(max_retries || 3, Integer)
+        @client = T.let(Bitbucket.new(credentials: credentials), Dependabot::Clients::Bitbucket)
       end
 
+      sig do
+        params(
+          method_name: T.any(Symbol, String),
+          args: T.untyped,
+          block: T.nilable(T.proc.returns(T.untyped))
+        )
+          .returns(T.untyped)
+      end
       def method_missing(method_name, *args, &block)
         retry_connection_failures do
           if @client.respond_to?(method_name)
             mutatable_args = args.map(&:dup)
-            @client.public_send(method_name, *mutatable_args, &block)
+            T.unsafe(@client).public_send(method_name, *mutatable_args, &block)
           else
             super
           end
         end
       end
 
+      sig do
+        params(
+          method_name: Symbol,
+          include_private: T::Boolean
+        )
+          .returns(T::Boolean)
+      end
       def respond_to_missing?(method_name, include_private = false)
         @client.respond_to?(method_name) || super
       end
 
-      def retry_connection_failures
+      sig do
+        type_parameters(:T)
+          .params(_blk: T.proc.returns(T.type_parameter(:T)))
+          .returns(T.type_parameter(:T))
+      end
+      def retry_connection_failures(&_blk)
         retry_attempt = 0
 
         begin

data/lib/dependabot/credential.rb

@@ -2,6 +2,7 @@
 # frozen_string_literal: true
 
 require "sorbet-runtime"
+require "forwardable"
 
 module Dependabot
   class Credential

data/lib/dependabot/git_commit_checker.rb

@@ -393,7 +393,7 @@ module Dependabot
       client = Clients::BitbucketWithRetries
                .for_bitbucket_dot_org(credentials: credentials)
 
-      response = client.get(url)
+      response = T.unsafe(client).get(url)
 
       # Conservatively assume that ref2 is ahead in the equality case, of
       # if we get an unexpected format (e.g., due to a 404)

data/lib/dependabot/shared_helpers.rb

@@ -405,7 +405,6 @@ module Dependabot
                                stderr_to_stdout: true)
       start = Time.now
       cmd = allow_unsafe_shell_command ? command : escape_command(command)
-
       if stderr_to_stdout
         stdout, process = Open3.capture2e(env || {}, cmd)
       else
@@ -425,12 +424,31 @@ module Dependabot
         process_exit_value: process.to_s
       }
 
+      check_out_of_disk_memory_error(stderr, error_context)
+
       raise SharedHelpers::HelperSubprocessFailed.new(
         message: stderr_to_stdout ? stdout : "#{stderr}\n#{stdout}",
         error_context: error_context
       )
     end
 
+    sig { params(stderr: T.nilable(String), error_context: T::Hash[Symbol, String]).void }
+    def self.check_out_of_disk_memory_error(stderr, error_context)
+      if stderr&.include?("No space left on device") || stderr&.include?("Out of diskspace")
+        raise HelperSubprocessFailed.new(
+          message: "No space left on device",
+          error_class: "Dependabot::OutOfDisk",
+          error_context: error_context
+        )
+      elsif stderr&.include?("MemoryError")
+        raise HelperSubprocessFailed.new(
+          message: "MemoryError",
+          error_class: "Dependabot::OutOfMemory",
+          error_context: error_context
+        )
+      end
+    end
+
     sig { params(command: String, stdin_data: String, env: T.nilable(T::Hash[String, String])).returns(String) }
     def self.helper_subprocess_bash_command(command:, stdin_data:, env:)
       escaped_stdin_data = stdin_data.gsub("\"", "\\\"")

data/lib/dependabot/workspace/git.rb

@@ -26,7 +26,7 @@ module Dependabot
 
       sig { returns(T::Boolean) }
       def changed?
-        changes.any? || !changed_files.empty?
+        changes.any? || !changed_files(ignored_mode: "no").empty?
       end
 
       sig { override.returns(String) }
@@ -53,7 +53,7 @@ module Dependabot
           .returns(T.nilable(T::Array[Dependabot::Workspace::ChangeAttempt]))
       end
       def store_change(memo = nil)
-        return nil if changed_files.empty?
+        return nil if changed_files(ignored_mode: "no").empty?
 
         debug("store_change - before: #{current_commit}")
         sha, diff = commit(memo)

data/lib/dependabot.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module Dependabot
-  VERSION = "0.243.0"
+  VERSION = "0.245.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dependabot-common
 version: !ruby/object:Gem::Version
-  version: 0.243.0
+  version: 0.245.0
 platform: ruby
 authors:
 - Dependabot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-02-13 00:00:00.000000000 Z
+date: 2024-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-codecommit
@@ -567,7 +567,7 @@ licenses:
 - Nonstandard
 metadata:
   bug_tracker_uri: https://github.com/dependabot/dependabot-core/issues
-  changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.243.0
+  changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.245.0
 post_install_message: 
 rdoc_options: []
 require_paths: