dependabot-common 0.117.1 → 0.117.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: da31cdf9fa8f40313defdb4b84d5806562865aa98df2eb6c44b5fbd06543defa
-  data.tar.gz: 68452781baab5abaf742e37c033088d1aabba5b5edbd53088ad3d8bb3c666ff8
+  metadata.gz: 14cdb8046ea54f46ad93439ad3f67cd803f00b6905ecce3d8edf26fa0857c686
+  data.tar.gz: 5b9174ab20e524e54eddb09bc48151ea1a8fea0912bf0b5c47e3a7b50c25762b
 SHA512:
-  metadata.gz: cb01ed587b5f7732ab9dc581069ccb26145c3375bc599cd6eb4df6710951f27c94f69de1ddb483da6f03024de0180a575fa0bd43bb68d2cb5009109a9c4d6958
-  data.tar.gz: 7c78d34e24431ff63ccab09957a91c61db07faaeb647809a26171df065e1349780e2449908b2d40bf70f4a3b13c3b77ea969b6e653eff4368edb73d91d2a0a0f
+  metadata.gz: 0312a8c36d969f3936ec0bd938b310aaa736ee59bb8be3c3200c59f6bf4ec2a9fbf1da60f468143d46ef682ae1a2d7092b4523f26d51e4ba786db7196c6ac1a9
+  data.tar.gz: c303d8bc132a106dacbce6a77e9b473c0e3a08cb2f1cdd3b0c967ffa62720f404aa1e54e1e49e627c43e592f3c4971b729dc3c166a989e4cc7beb2f77c9fb932

data/lib/dependabot/pull_request_creator/message_builder.rb

@@ -303,6 +303,8 @@ module Dependabot
       end
 
       def metadata_cascades_for_dep(dep)
+        break_tag = source_provider_supports_html? ? "\n<br />" : "\n\n"
+
         msg = ""
         msg += vulnerabilities_cascade(dep)
         msg += release_cascade(dep)
@@ -310,7 +312,7 @@ module Dependabot
         msg += upgrade_guide_cascade(dep)
         msg += commits_cascade(dep)
         msg += maintainer_changes_cascade(dep)
-        msg += "\n<br />" unless msg == ""
+        msg += break_tag unless msg == ""
         "\n" + sanitize_links_and_mentions(msg)
       end
 
@@ -432,15 +434,19 @@ module Dependabot
       def build_details_tag(summary:, body:)
         # Azure DevOps does not support <details> tag (https://developercommunity.visualstudio.com/content/problem/608769/add-support-for-in-markdown.html)
         # CodeCommit does not support the <details> tag (no url available)
-        if source.provider == ("azure" || "codecommit")
-          "\n\##{summary}\n\n#{body}"
-        else
+        if source_provider_supports_html?
           msg = "<details>\n<summary>#{summary}</summary>\n\n"
           msg += body
           msg + "</details>\n"
+        else
+          "\n\##{summary}\n\n#{body}"
         end
       end
 
+      def source_provider_supports_html?
+        !%w(azure codecommit).include?(source.provider)
+      end
+
       def serialized_vulnerability_details(details)
         msg = vulnerability_source_line(details)
 
@@ -659,6 +665,8 @@ module Dependabot
       end
 
       def sanitize_links_and_mentions(text)
+        return text unless source.provider == "github"
+
         LinkAndMentionSanitizer.
           new(github_redirection_service: github_redirection_service).
           sanitize_links_and_mentions(text: text)

data/lib/dependabot/update_checkers/base.rb

@@ -243,12 +243,22 @@ module Dependabot
       end
 
       def requirements_up_to_date?
-        return true if (updated_requirements - dependency.requirements).none?
-        return false unless latest_version
-        return false unless version_class.correct?(latest_version.to_s)
-        return false unless version_from_requirements
+        if can_compare_requirements?
+          return (version_from_requirements >=
+                  version_class.new(latest_version.to_s))
+        end
+
+        changed_requirements.none?
+      end
 
-        version_from_requirements >= version_class.new(latest_version.to_s)
+      def can_compare_requirements?
+        version_from_requirements &&
+          latest_version &&
+          version_class.correct?(latest_version.to_s)
+      end
+
+      def changed_requirements
+        (updated_requirements - dependency.requirements)
       end
 
       def version_from_requirements
@@ -262,11 +272,9 @@ module Dependabot
       end
 
       def requirements_can_update?
-        changed_reqs = updated_requirements - dependency.requirements
-
-        return false if changed_reqs.none?
+        return false if changed_requirements.none?
 
-        changed_reqs.none? { |r| r[:requirement] == :unfixable }
+        changed_requirements.none? { |r| r[:requirement] == :unfixable }
       end
 
       def ignore_reqs

data/lib/dependabot/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Dependabot
-  VERSION = "0.117.1"
+  VERSION = "0.117.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dependabot-common
 version: !ruby/object:Gem::Version
-  version: 0.117.1
+  version: 0.117.2
 platform: ruby
 authors:
 - Dependabot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-05 00:00:00.000000000 Z
+date: 2020-03-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-codecommit