dependabot-cargo 0.325.0 → 0.326.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 891a036259a08eb4d96b67e02af17989938a0a3c02ce13d85b1edbcf5e0dab39
-  data.tar.gz: cbe0877963a964dd7799635533fcd310792b8ef1fef882b92aee02564a84b653
+  metadata.gz: 65f2f1c55ac562ad6abef01b525db3cbb33619731e81c0a076e3b568534fc113
+  data.tar.gz: b4b855731c6b90017d6a5a8edc77adaded62251983b94ccd0c772733bd5e57dd
 SHA512:
-  metadata.gz: eb660de7847ce36db33053fbd2e03288e14d7f9f63f3ec9e94f215d9f6d2a901f5ff3b605ee81658260c6d1cf2276b81d767141e49a5cfc3b5909ded9453f95c
-  data.tar.gz: 0cc86b9dec23ac4c5fc1fae9237c9aa55d611402f77ddf9e996aca436c823a238362ea6dab631060f47be18f97e234b215e43cb90df97047be4c838a6b2681ce
+  metadata.gz: 98f0de7da1e05b555a23953c5e3e23253fe62c0a6e9f17e0cc87a0a9c8028cf5d787189bf1436e908922fddb4cf04383fb113c0fae95f487ed40995c6f79a31e
+  data.tar.gz: bf20aa8c3ce3317ebb2588f320400abb6857db6b40dbb61a8e7897722bda77f11a44adb76bdd6319ffb1fcca7b8405c0584111bb7c03d7caa9e52d95c45912b2

data/lib/dependabot/cargo/file_parser.rb

@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 require "toml-rb"
@@ -25,6 +25,7 @@ module Dependabot
       DEPENDENCY_TYPES =
         %w(dependencies dev-dependencies build-dependencies).freeze
 
+      sig { override.returns(T::Array[Dependabot::Dependency]) }
       def parse
         check_rust_workspace_root
 
@@ -88,10 +89,14 @@ module Dependabot
         end, T.nilable(String))
       end
 
+      sig { void }
       def check_rust_workspace_root
         cargo_toml = dependency_files.find { |f| f.name == "Cargo.toml" }
-        workspace_root = parsed_file(cargo_toml).dig("package", "workspace")
-        return unless workspace_root
+        workspace_root = parsed_file(T.must(cargo_toml))
+        return unless workspace_root.is_a?(Hash)
+
+        workspace_config = workspace_root.dig("package", "workspace")
+        return unless workspace_config
 
         msg = "This project is part of a Rust workspace but is not the " \
               "workspace root." \
@@ -106,19 +111,23 @@ module Dependabot
       # rubocop:disable Metrics/AbcSize
       # rubocop:disable Metrics/CyclomaticComplexity
       # rubocop:disable Metrics/PerceivedComplexity
+      sig { returns(DependencySet) }
       def manifest_dependencies
         dependency_set = DependencySet.new
 
         manifest_files.each do |file|
+          parsed_content = parsed_file(file)
+          next unless parsed_content.is_a?(Hash)
+
           DEPENDENCY_TYPES.each do |type|
-            parsed_file(file).fetch(type, {}).each do |name, requirement|
+            parsed_content.fetch(type, {}).each do |name, requirement|
               next unless name == name_from_declaration(name, requirement)
               next if lockfile && !version_from_lockfile(name, requirement)
 
               dependency_set << build_dependency(name, requirement, type, file)
             end
 
-            parsed_file(file).fetch("target", {}).each do |_, t_details|
+            parsed_content.fetch("target", {}).each do |_, t_details|
               t_details.fetch(type, {}).each do |name, requirement|
                 next unless name == name_from_declaration(name, requirement)
                 next if lockfile && !version_from_lockfile(name, requirement)
@@ -129,7 +138,7 @@ module Dependabot
             end
           end
 
-          workspace = parsed_file(file).fetch("workspace", {})
+          workspace = parsed_content.fetch("workspace", {})
           workspace.fetch("dependencies", {}).each do |name, requirement|
             next unless name == name_from_declaration(name, requirement)
             next if lockfile && !version_from_lockfile(name, requirement)
@@ -145,6 +154,10 @@ module Dependabot
       # rubocop:enable Metrics/CyclomaticComplexity
       # rubocop:enable Metrics/PerceivedComplexity
 
+      sig do
+        params(name: String, requirement: T.any(String, T::Hash[String, String]), type: String,
+               file: Dependabot::DependencyFile).returns(Dependency)
+      end
       def build_dependency(name, requirement, type, file)
         Dependency.new(
           name: name,
@@ -159,11 +172,15 @@ module Dependabot
         )
       end
 
+      sig { returns(DependencySet) }
       def lockfile_dependencies
         dependency_set = DependencySet.new
         return dependency_set unless lockfile
 
-        parsed_file(lockfile).fetch("package", []).each do |package_details|
+        lockfile_content = parsed_file(T.must(lockfile))
+        return dependency_set unless lockfile_content.is_a?(Hash)
+
+        lockfile_content.fetch("package", []).each do |package_details|
           next unless package_details["source"]
 
           # TODO: This isn't quite right, as it will only give us one
@@ -179,40 +196,49 @@ module Dependabot
         dependency_set
       end
 
+      sig { returns(T::Array[String]) }
       def patched_dependencies
         root_manifest = manifest_files.find { |f| f.name == "Cargo.toml" }
-        return [] unless parsed_file(root_manifest)["patch"]
+        parsed_content = parsed_file(T.must(root_manifest))
+        return [] unless parsed_content.is_a?(Hash)
+        return [] unless parsed_content["patch"]
 
-        parsed_file(root_manifest)["patch"].values.flat_map(&:keys)
+        parsed_content["patch"].values.flat_map(&:keys)
       end
 
+      sig { params(declaration: T.any(String, T::Hash[String, String])).returns(T.nilable(String)) }
       def requirement_from_declaration(declaration)
         if declaration.is_a?(String)
-          return declaration == "" ? nil : declaration
-        end
-        raise "Unexpected dependency declaration: #{declaration}" unless declaration.is_a?(Hash)
-        return declaration["version"] if declaration["version"].is_a?(String) && declaration["version"] != ""
+          declaration == "" ? nil : declaration
+        else
+          return declaration["version"] if declaration["version"].is_a?(String) && declaration["version"] != ""
 
-        nil
+          nil
+        end
       end
 
+      sig { params(name: String, declaration: T.any(String, T::Hash[String, String])).returns(String) }
       def name_from_declaration(name, declaration)
-        return name if declaration.is_a?(String)
-        raise "Unexpected dependency declaration: #{declaration}" unless declaration.is_a?(Hash)
-
-        declaration.fetch("package", name)
+        if declaration.is_a?(String)
+          name
+        else
+          declaration.fetch("package", name)
+        end
       end
 
+      sig { params(declaration: T.any(String, T::Hash[String, String])).returns(T.nilable(T::Hash[Symbol, String])) }
       def source_from_declaration(declaration)
-        return if declaration.is_a?(String)
-        raise "Unexpected dependency declaration: #{declaration}" unless declaration.is_a?(Hash)
-
-        return git_source_details(declaration) if declaration["git"]
-        return { type: "path" } if declaration["path"]
+        if declaration.is_a?(String)
+          nil
+        else
+          return git_source_details(declaration) if declaration["git"]
+          return { type: "path" } if declaration["path"]
 
-        registry_source_details(declaration)
+          registry_source_details(declaration)
+        end
       end
 
+      sig { params(declaration: T.any(String, T::Hash[String, String])).returns(T.nilable(T::Hash[Symbol, String])) }
       def registry_source_details(declaration)
         registry_name = declaration["registry"]
         return if registry_name.nil?
@@ -242,6 +268,7 @@ module Dependabot
         end
       end
 
+      sig { params(registry_name: String, index_url: String).returns(T::Hash[Symbol, String]) }
       def sparse_registry_source_details(registry_name, index_url)
         token = credentials.find do |cred|
           cred["type"] == "cargo_registry" && cred["registry"] == registry_name
@@ -268,25 +295,35 @@ module Dependabot
 
       # Looks up dotted key name in cargo config
       # e.g. "registries.my_registry.index"
+      sig { params(key_name: String).returns(T.nilable(String)) }
       def cargo_config_field(key_name)
         cargo_config_from_env(key_name) || cargo_config_from_file(key_name)
       end
 
+      sig { params(key_name: String).returns(T.nilable(String)) }
       def cargo_config_from_env(key_name)
         env_var = "CARGO_#{key_name.upcase.tr('-.', '_')}"
         ENV.fetch(env_var, nil)
       end
 
+      sig { params(key_name: String).returns(T.nilable(String)) }
       def cargo_config_from_file(key_name)
-        parsed_file(cargo_config).dig(*key_name.split("."))
+        config_file = cargo_config
+        return nil unless config_file
+
+        parsed_file(config_file).dig(*key_name.split("."))
       end
 
+      sig { params(name: String, declaration: T.any(String, T::Hash[String, String])).returns(T.nilable(String)) }
       def version_from_lockfile(name, declaration)
         return unless lockfile
 
+        lockfile_content = parsed_file(T.must(lockfile))
+        return unless lockfile_content.is_a?(Hash)
+
         candidate_packages =
-          parsed_file(lockfile).fetch("package", [])
-                               .select { |p| p["name"] == name }
+          lockfile_content.fetch("package", [])
+                          .select { |p| p["name"] == name }
 
         if (req = requirement_from_declaration(declaration))
           req = Cargo::Requirement.new(req)
@@ -311,10 +348,12 @@ module Dependabot
         version_from_lockfile_details(package)
       end
 
+      sig { params(declaration: T.any(String, T::Hash[String, String])).returns(T::Boolean) }
       def git_req?(declaration)
         source_from_declaration(declaration)&.fetch(:type, nil) == "git"
       end
 
+      sig { params(declaration: T.any(String, T::Hash[String, String])).returns(T::Hash[Symbol, String]) }
       def git_source_details(declaration)
         {
           type: "git",
@@ -324,38 +363,47 @@ module Dependabot
         }
       end
 
+      sig { params(package_details: T::Hash[String, String]).returns(String) }
       def version_from_lockfile_details(package_details)
-        return package_details["version"] unless package_details["source"]&.start_with?("git+")
+        return T.must(package_details["version"]) unless package_details["source"]&.start_with?("git+")
 
-        package_details["source"].split("#").last
+        T.must(T.must(package_details["source"]).split("#").last)
       end
 
+      sig { override.void }
       def check_required_files
         raise "No Cargo.toml!" unless get_original_file("Cargo.toml")
       end
 
+      sig { params(file: DependencyFile).returns(T.untyped) }
       def parsed_file(file)
-        @parsed_file ||= {}
+        @parsed_file ||= T.let({}, T.untyped)
         @parsed_file[file.name] ||= TomlRB.parse(file.content)
       rescue TomlRB::ParseError, TomlRB::ValueOverwriteError
         raise Dependabot::DependencyFileNotParseable, file.path
       end
 
+      sig { returns(T::Array[Dependabot::DependencyFile]) }
       def manifest_files
-        @manifest_files ||=
+        @manifest_files ||= T.let(
           dependency_files
-          .select { |f| f.name.end_with?("Cargo.toml") }
-          .reject(&:support_file?)
+                  .select { |f| f.name.end_with?("Cargo.toml") }
+                  .reject(&:support_file?),
+          T.nilable(T::Array[Dependabot::DependencyFile])
+        )
       end
 
+      sig { returns(T.nilable(Dependabot::DependencyFile)) }
       def lockfile
-        @lockfile ||= get_original_file("Cargo.lock")
+        @lockfile ||= T.let(get_original_file("Cargo.lock"), T.nilable(Dependabot::DependencyFile))
       end
 
+      sig { returns(T.nilable(Dependabot::DependencyFile)) }
       def cargo_config
-        @cargo_config ||= get_original_file(".cargo/config.toml")
+        @cargo_config ||= T.let(get_original_file(".cargo/config.toml"), T.nilable(Dependabot::DependencyFile))
       end
 
+      sig { returns(T.class_of(Dependabot::Version)) }
       def version_class
         Cargo::Version
       end

data/lib/dependabot/cargo/update_checker/version_resolver.rb

@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 require "toml-rb"
@@ -12,7 +12,8 @@ require "dependabot/errors"
 module Dependabot
   module Cargo
     class UpdateChecker
-      class VersionResolver
+      class VersionResolver # rubocop:disable Metrics/ClassLength
+        extend T::Sig
         UNABLE_TO_UPDATE = /Unable to update (?<url>.*?)$/
         BRANCH_NOT_FOUND_REGEX = /#{UNABLE_TO_UPDATE}.*to find branch `(?<branch>[^`]+)`/m
         REVSPEC_PATTERN = /revspec '.*' not found/
@@ -26,31 +27,52 @@ module Dependabot
         NOT_OUR_REF = /fatal: remote error: upload-pack: not our ref/
         NOT_OUR_REF_REGEX = /#{NOT_OUR_REF}.*#{UNABLE_TO_UPDATE}/m
 
+        sig do
+          params(
+            dependency: Dependabot::Dependency,
+            credentials: T::Array[Dependabot::Credential],
+            original_dependency_files: T::Array[Dependabot::DependencyFile],
+            prepared_dependency_files: T::Array[Dependabot::DependencyFile]
+          ).void
+        end
         def initialize(dependency:, credentials:,
                        original_dependency_files:, prepared_dependency_files:)
           @dependency = dependency
           @prepared_dependency_files = prepared_dependency_files
           @original_dependency_files = original_dependency_files
           @credentials = credentials
+
+          # Initialize instance variables with proper T.let declarations
+          @prepared_manifest_files = T.let(nil, T.nilable(T::Array[DependencyFile]))
+          @original_manifest_files = T.let(nil, T.nilable(T::Array[DependencyFile]))
         end
 
+        sig { returns(T.nilable(T.any(String, Gem::Version))) }
         def latest_resolvable_version
           return @latest_resolvable_version if defined?(@latest_resolvable_version)
 
-          @latest_resolvable_version = fetch_latest_resolvable_version
-          rescue Dependabot::SharedHelpers::HelperSubprocessFailed => e
-            raise Dependabot::DependencyFileNotResolvable, e.message
+          @latest_resolvable_version = T.let(fetch_latest_resolvable_version, T.nilable(T.any(String, Gem::Version)))
+        rescue Dependabot::SharedHelpers::HelperSubprocessFailed => e
+          raise Dependabot::DependencyFileNotResolvable, e.message
         end
 
         private
 
+        sig { returns(Dependency) }
         attr_reader :dependency
+
+        sig { returns(T::Array[Credential]) }
         attr_reader :credentials
+
+        sig { returns(T::Array[DependencyFile]) }
         attr_reader :prepared_dependency_files
+
+        sig { returns(T::Array[DependencyFile]) }
         attr_reader :original_dependency_files
 
+        sig { returns(T.nilable(T.any(String, Gem::Version))) }
         def fetch_latest_resolvable_version
-          base_directory = prepared_dependency_files.first.directory
+          base_directory = T.must(prepared_dependency_files.first).directory
           SharedHelpers.in_a_temporary_directory(base_directory) do
             write_temporary_dependency_files
 
@@ -68,8 +90,10 @@ module Dependabot
         rescue SharedHelpers::HelperSubprocessFailed => e
           retry if better_specification_needed?(e)
           handle_cargo_errors(e)
+          nil
         end
 
+        sig { returns(T.nilable(T.any(String, Gem::Version))) }
         def fetch_version_from_new_lockfile
           check_rust_workspace_root unless File.exist?("Cargo.lock")
           lockfile_content = File.read("Cargo.lock")
@@ -95,6 +119,7 @@ module Dependabot
         # rubocop:disable Metrics/PerceivedComplexity
         # rubocop:disable Metrics/CyclomaticComplexity
         # rubocop:disable Metrics/AbcSize
+        sig { params(error: StandardError).returns(T::Boolean) }
         def better_specification_needed?(error)
           return false if @custom_specification
           return false unless error.message.match?(/specification .* is ambigu/)
@@ -108,25 +133,26 @@ module Dependabot
                   dependency.version
                 end
 
-          if spec_options.count { |s| s.end_with?(ver) } == 1
-            @custom_specification = spec_options.find { |s| s.end_with?(ver) }
+          if spec_options.count { |s| s.end_with?(T.must(ver)) } == 1
+            @custom_specification = spec_options.find { |s| s.end_with?(T.must(ver)) }
             return true
-          elsif spec_options.count { |s| s.end_with?(ver) } > 1
-            spec_options.select! { |s| s.end_with?(ver) }
+          elsif spec_options.count { |s| s.end_with?(T.must(ver)) } > 1
+            spec_options.select! { |s| s.end_with?(T.must(ver)) }
           end
 
           if git_dependency? && git_source_url &&
-             spec_options.count { |s| s.include?(git_source_url) } >= 1
-            spec_options.select! { |s| s.include?(git_source_url) }
+             spec_options.count { |s| s.include?(T.must(git_source_url)) } >= 1
+            spec_options.select! { |s| s.include?(T.must(git_source_url)) }
           end
 
-          @custom_specification = spec_options.first
+          @custom_specification = T.let(spec_options.first, T.nilable(String))
           true
         end
         # rubocop:enable Metrics/AbcSize
         # rubocop:enable Metrics/CyclomaticComplexity
         # rubocop:enable Metrics/PerceivedComplexity
 
+        sig { returns(String) }
         def dependency_spec
           return @custom_specification if @custom_specification
 
@@ -143,6 +169,7 @@ module Dependabot
 
         # Shell out to Cargo, which handles everything for us, and does
         # so without doing an install (so it's fast).
+        sig { void }
         def run_cargo_update_command
           run_cargo_command(
             "cargo update -p #{dependency_spec} -vv",
@@ -150,6 +177,7 @@ module Dependabot
           )
         end
 
+        sig { params(command: String, fingerprint: T.nilable(String)).void }
         def run_cargo_command(command, fingerprint: nil)
           start = Time.now
           command = SharedHelpers.escape_command(command)
@@ -176,40 +204,43 @@ module Dependabot
           )
         end
 
+        sig { params(prepared: T::Boolean).returns(T.nilable(Integer)) }
         def write_temporary_dependency_files(prepared: true)
           write_manifest_files(prepared: prepared)
 
-          File.write(lockfile.name, lockfile.content) if lockfile
-          File.write(toolchain.name, toolchain.content) if toolchain
+          File.write(T.must(lockfile).name, T.must(lockfile).content) if lockfile
+          File.write(T.must(toolchain).name, T.must(toolchain).content) if toolchain
           return unless config
 
-          FileUtils.mkdir_p(File.dirname(config.name))
-          File.write(config.name, config.content)
+          FileUtils.mkdir_p(File.dirname(T.must(config).name))
+          File.write(T.must(config).name, T.must(config).content)
         end
 
+        sig { void }
         def check_rust_workspace_root
           cargo_toml = original_dependency_files
                        .select { |f| f.name.end_with?("../Cargo.toml") }
                        .max_by { |f| f.name.length }
-          return unless TomlRB.parse(cargo_toml.content)["workspace"]
+          return unless TomlRB.parse(T.must(cargo_toml).content)["workspace"]
 
           msg = "This project is part of a Rust workspace but is not the " \
                 "workspace root." \
 
-          if cargo_toml.directory != "/"
+          if T.must(cargo_toml).directory != "/"
             msg += "Please update your settings so Dependabot points at the " \
-                   "workspace root instead of #{cargo_toml.directory}."
+                   "workspace root instead of #{T.must(cargo_toml).directory}."
           end
           raise Dependabot::DependencyFileNotResolvable, msg
         end
 
         # rubocop:disable Metrics/AbcSize
         # rubocop:disable Metrics/PerceivedComplexity
+        sig { params(error: StandardError).void }
         def handle_cargo_errors(error)
           if error.message.include?("does not have these features")
             # TODO: Ideally we should update the declaration not to ask
             # for the specified features
-            return nil
+            return
           end
 
           if error.message.include?("authenticate when downloading repo") ||
@@ -218,22 +249,24 @@ module Dependabot
             # consistent error)
             urls = unreachable_git_urls
 
-            if urls.none?
-              url = error.message.match(UNABLE_TO_UPDATE)
-                         .named_captures.fetch("url").split(/[#?]/).first
-              raise if reachable_git_urls.include?(url)
+            if T.must(urls).none?
+              url = T.must(T.must(error.message.match(UNABLE_TO_UPDATE))
+                            .named_captures.fetch("url")).split(/[#?]/).first
+              raise if T.must(reachable_git_urls).include?(url)
 
-              urls << url
+              # Fix: Wrap url in T.must since split().first can return nil
+              T.must(urls) << T.must(url)
             end
 
-            raise Dependabot::GitDependenciesNotReachable, urls
+            raise Dependabot::GitDependenciesNotReachable, T.must(urls)
           end
 
           [BRANCH_NOT_FOUND_REGEX, REF_NOT_FOUND_REGEX, GIT_REF_NOT_FOUND_REGEX, NOT_OUR_REF_REGEX].each do |regex|
             next unless error.message.match?(regex)
 
-            dependency_url = error.message.match(regex).named_captures.fetch("url").split(/[#?]/).first
-            raise Dependabot::GitDependencyReferenceNotFound, dependency_url
+            dependency_url = T.must(T.must(error.message.match(regex)).named_captures.fetch("url")).split(/[#?]/).first
+            # Fix: Wrap dependency_url in T.must since split().first can return nil
+            raise Dependabot::GitDependencyReferenceNotFound, T.must(dependency_url)
           end
 
           if workspace_native_library_update_error?(error.message)
@@ -268,8 +301,9 @@ module Dependabot
         # rubocop:enable Metrics/AbcSize
         # rubocop:enable Metrics/PerceivedComplexity
 
+        sig { params(message: T.nilable(String)).returns(T.any(Dependabot::Version, T::Boolean)) }
         def using_old_toolchain?(message)
-          return true if message.include?("usage of sparse registries requires `-Z sparse-registry`")
+          return true if T.must(message).include?("usage of sparse registries requires `-Z sparse-registry`")
 
           version_log = /rust version (?<version>\d.\d+)/.match(message)
           return false unless version_log
@@ -277,11 +311,12 @@ module Dependabot
           version_class.new(version_log[:version]) < version_class.new("1.68")
         end
 
+        sig { returns(T.nilable(T::Array[String])) }
         def unreachable_git_urls
           return @unreachable_git_urls if defined?(@unreachable_git_urls)
 
-          @unreachable_git_urls = []
-          @reachable_git_urls = []
+          @unreachable_git_urls = T.let([], T.nilable(T::Array[String]))
+          @reachable_git_urls = T.let([], T.nilable(T::Array[String]))
 
           dependencies = FileParser.new(
             dependency_files: original_dependency_files,
@@ -295,19 +330,20 @@ module Dependabot
             )
             next unless checker.git_dependency?
 
-            url = dep.requirements.find { |r| r.dig(:source, :type) == "git" }
-                     .fetch(:source).fetch(:url)
+            url = T.must(dep.requirements.find { |r| r.dig(:source, :type) == "git" })
+                   .fetch(:source).fetch(:url)
 
             if checker.git_repo_reachable?
-              @reachable_git_urls << url
+              T.must(@reachable_git_urls) << url
             else
-              @unreachable_git_urls << url
+              T.must(@unreachable_git_urls) << url
             end
           end
 
           @unreachable_git_urls
         end
 
+        sig { returns(T.nilable(T::Array[String])) }
         def reachable_git_urls
           return @reachable_git_urls if defined?(@reachable_git_urls)
 
@@ -315,6 +351,7 @@ module Dependabot
           @reachable_git_urls
         end
 
+        sig { params(message: String).returns(T::Boolean) }
         def resolvability_error?(message)
           return true if message.include?("failed to parse lock")
           return true if message.include?("believes it's in a workspace")
@@ -330,8 +367,9 @@ module Dependabot
           !original_requirements_resolvable
         end
 
+        sig { returns(T.any(TrueClass, FalseClass, Symbol)) }
         def original_requirements_resolvable?
-          base_directory = original_dependency_files.first.directory
+          base_directory = T.must(original_dependency_files.first).directory
           SharedHelpers.in_a_temporary_directory(base_directory) do
             write_temporary_dependency_files(prepared: false)
 
@@ -353,10 +391,11 @@ module Dependabot
           end
         end
 
+        sig { params(message: String).returns(T::Boolean) }
         def workspace_native_library_update_error?(message)
           return false unless message.include?("native library")
 
-          library_count = prepared_manifest_files.count do |file|
+          library_count = T.must(prepared_manifest_files).count do |file|
             package_name = TomlRB.parse(file.content).dig("package", "name")
             next false unless package_name
 
@@ -366,17 +405,18 @@ module Dependabot
           library_count >= 2
         end
 
+        sig { params(prepared: T::Boolean).returns(T.nilable(T::Array[Dependabot::DependencyFile])) }
         def write_manifest_files(prepared: true)
           manifest_files = if prepared then prepared_manifest_files
                            else
                              original_manifest_files
                            end
 
-          manifest_files.each do |file|
+          T.must(manifest_files).each do |file|
             path = file.name
             dir = Pathname.new(path).dirname
             FileUtils.mkdir_p(dir)
-            File.write(file.name, sanitized_manifest_content(file.content))
+            File.write(file.name, sanitized_manifest_content(T.must(file.content)))
 
             next if virtual_manifest?(file)
 
@@ -388,26 +428,30 @@ module Dependabot
           end
         end
 
+        sig { returns(T.nilable(String)) }
         def git_dependency_version
           return unless lockfile
 
-          TomlRB.parse(lockfile.content)
+          TomlRB.parse(T.must(lockfile).content)
                 .fetch("package", [])
                 .select { |p| p["name"] == dependency.name }
                 .find { |p| p["source"].end_with?(dependency.version) }
                 .fetch("version")
         end
 
+        sig { returns(T.nilable(String)) }
         def git_source_url
           dependency.requirements
                     .find { |r| r.dig(:source, :type) == "git" }
                     &.dig(:source, :url)
         end
 
+        sig { returns(String) }
         def dummy_app_content
           %{fn main() {\nprintln!("Hello, world!");\n}}
         end
 
+        sig { params(content: String).returns(String) }
         def sanitized_manifest_content(content)
           object = TomlRB.parse(content)
 
@@ -424,32 +468,40 @@ module Dependabot
           TomlRB.dump(object)
         end
 
+        sig { returns(T.nilable(T::Array[DependencyFile])) }
         def prepared_manifest_files
           @prepared_manifest_files ||=
             prepared_dependency_files
             .select { |f| f.name.end_with?("Cargo.toml") }
         end
 
+        sig { returns(T.nilable(T::Array[DependencyFile])) }
         def original_manifest_files
           @original_manifest_files ||=
             original_dependency_files
             .select { |f| f.name.end_with?("Cargo.toml") }
         end
 
+        sig { returns(T.nilable(DependencyFile)) }
         def lockfile
-          @lockfile ||= prepared_dependency_files
-                        .find { |f| f.name == "Cargo.lock" }
+          @lockfile ||= T.let(prepared_dependency_files
+                                .find { |f| f.name == "Cargo.lock" }, T.nilable(Dependabot::DependencyFile))
         end
 
+        sig { returns(T.nilable(DependencyFile)) }
         def toolchain
-          @toolchain ||= original_dependency_files
-                         .find { |f| f.name == "rust-toolchain" }
+          @toolchain ||= T.let(original_dependency_files
+                                 .find { |f| f.name == "rust-toolchain" }, T.nilable(Dependabot::DependencyFile))
         end
 
+        sig { returns(T.nilable(DependencyFile)) }
         def config
-          @config ||= original_dependency_files.find { |f| f.name == ".cargo/config.toml" }
+          @config ||= T.let(original_dependency_files.find do |f|
+            f.name == ".cargo/config.toml"
+          end, T.nilable(Dependabot::DependencyFile))
         end
 
+        sig { returns(T::Boolean) }
         def git_dependency?
           GitCommitChecker.new(
             dependency: dependency,
@@ -460,10 +512,12 @@ module Dependabot
         # When the package table is not present in a workspace manifest, it is
         # called a virtual manifest: https://doc.rust-lang.org/cargo/reference/
         # manifest.html#virtual-manifest
+        sig { params(file: DependencyFile).returns(T::Boolean) }
         def virtual_manifest?(file)
-          !file.content.include?("[package]")
+          !T.must(file.content).include?("[package]")
         end
 
+        sig { returns(T.class_of(Dependabot::Version)) }
         def version_class
           dependency.version_class
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dependabot-cargo
 version: !ruby/object:Gem::Version
-  version: 0.325.0
+  version: 0.326.0
 platform: ruby
 authors:
 - Dependabot
@@ -15,14 +15,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.325.0
+        version: 0.326.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.325.0
+        version: 0.326.0
 - !ruby/object:Gem::Dependency
   name: debug
   requirement: !ruby/object:Gem::Requirement
@@ -265,7 +265,7 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/dependabot/dependabot-core/issues
-  changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.325.0
+  changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.326.0
 rdoc_options: []
 require_paths:
 - lib