departure 4.0.0 → 4.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6212b46cc9534ddacaefd8341432e124ccce6247
-  data.tar.gz: 4f99581bf9f9657ff07adf9684dc93d40b9dfa8c
+  metadata.gz: 89a3f4d1cb84878f4a556da1439057a2dc8a402e
+  data.tar.gz: c6b8f26150c220f793ef021b7dc1d7ceb0a7ebe7
 SHA512:
-  metadata.gz: 85c386d3d73919fe7e61d805835d5ddd8478fc8f204be09bd563151d67f1469424c7a89e40bdee579da483687f9602d071f80dd3bf9cdd547c78d2e80a91e325
-  data.tar.gz: aeef6570099eee655fc5eb7cd4b9dda7c0f7f4c482d575b83700ad8cbdbe63a1a914e173de1dc68467aa2b84fd2d3ba61d7608ed8a6ea03d422451a798e297c7
+  metadata.gz: 66727be4d155815b20da61075f06ddf5e94665e165a3cc9f5ebada94f96e63ac8940efc555a812a127fa013533feb2f3bc0e9342aa5ca0ca699ff8044f000efb
+  data.tar.gz: 89ae513dd2268fddea60c3e11325fcdc309ae02283b74d07a719b77ecf8df968d041d7d92af8d6a35f36d8b341e826a2ce6c42ac9154dec5606cf0da18462daa

data/CHANGELOG.md

@@ -12,6 +12,18 @@ Please follow the format in [Keep a Changelog](http://keepachangelog.com/)
 ### Removed
 ### Fixed
 
+## [4.0.1] - 2017-08-01
+
+### Added
+
+- Support for all pt-osc command-line options, including short forms and array
+    arguments
+
+### Changed
+### Deprecated
+### Removed
+### Fixed
+
 ## [4.0.0] - 2017-06-12
 
 ### Added

data/RELEASING.md

@@ -7,7 +7,7 @@ In order to give support to a new major Rails version, we'll branch off of
 master, name it following the Rails repo convention, such as `v4.2`, and
 we'll keep it open for bug fixes.
 
-1. Update `lib/percona_migrator/version.rb` accordingly
+1. Update `lib/departure/version.rb` accordingly
 2. Review the `CHANGELOG.md` and add a new section following the format
    `[version] - YYYY-MM-DD`. We conform to the guidelines of
    http://keepachangelog.com/

data/lib/departure/option.rb

@@ -3,15 +3,11 @@ module Departure
     attr_reader :name, :value
 
     # Builds an instance by parsing its name and value out of the given string.
-    # Note the string must conform to "--<arg>=<value>" format.
     #
     # @param string [String]
     # @return [Option]
     def self.from_string(string)
-      pair = string.split('=')
-      name = pair[0][2..-1]
-      value = pair[1]
-
+      name, value = string.split(/\s|=/, 2)
       new(name, value)
     end
 
@@ -20,7 +16,7 @@ module Departure
     # @param name [String]
     # @param optional value [String]
     def initialize(name, value = nil)
-      @name = name
+      @name = normalize_option(name)
       @value = value
     end
 
@@ -40,21 +36,37 @@ module Departure
       name.hash
     end
 
-    # Returns the option as string following the "--<name>=<value>" format
+    # Returns the option as string following the "--<name>=<value>" format or
+    # the short "-n=value" format
     #
     # @return [String]
     def to_s
-      "--#{name}#{value_as_string}"
+      "#{name}#{value_as_string}"
     end
 
     private
 
+    # Returns the option name in "long" format, e.g., "--name"
+    #
+    # @return [String]
+    def normalize_option(name)
+      if name.start_with?('-')
+        name
+      elsif name.length == 1
+        "-#{name}"
+      else
+        "--#{name}"
+      end
+    end
+
     # Returns the value fragment of the option string if any value is specified
     #
     # @return [String]
     def value_as_string
       if value.nil?
         ''
+      elsif value.include?("=")
+        " #{value}"
       else
         "=#{value}"
       end

data/lib/departure/user_options.rb

@@ -36,7 +36,7 @@ module Departure
     #
     # @return [Array<Option>]
     def build_options
-      arguments.split(' ').map do |argument|
+      arguments.split(/\s(?=-)/).map do |argument|
         Option.from_string(argument)
       end
     end

data/lib/departure/version.rb

@@ -1,3 +1,3 @@
 module Departure
-  VERSION = '4.0.0'.freeze
+  VERSION = '4.0.1'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: departure
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.0.1
 platform: ruby
 authors:
 - Ilya Zayats
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-12 00:00:00.000000000 Z
+date: 2017-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -211,7 +211,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.10
+rubygems_version: 2.4.5.2
 signing_key: 
 specification_version: 4
 summary: pt-online-schema-change runner for ActiveRecord migrations