denormalizer 0.0.2 → 0.0.3

data/CHANGELOG

@@ -1,5 +1,10 @@
 == unreleased changes
 
+== 0.0.3
+
+* Updated the generated scopes so that they are chainable with each other.  Rails
+has issues when you try to join to the same table twice.
+
 == 0.0.2
 
 * Added basic testing for the mixins

data/VERSION

@@ -1 +1 @@
-0.0.2
+0.0.3

data/denormalizer.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "denormalizer"
-  s.version = "0.0.2"
+  s.version = "0.0.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Jeremiah Hemphill"]
-  s.date = "2012-07-13"
+  s.date = "2012-12-03"
   s.description = "Cache method outputs and automatically create chainable scopes based on their outputs"
   s.email = "jeremiah@cloudspace.com"
   s.extra_rdoc_files = [

data/lib/denormalizer/denormalize.rb

@@ -29,22 +29,27 @@ module Denormalizer
         # create scopes
         # note that at some point, we probably need to identify these as denormalized scopes (JH 7-5-2012)
         # dn_method_name maybe
+        #
+        # Table aliases have been added so that denormalized scopes can be chained (JH 12-3-2012)
+        # Note that you can chain a method with it's false version
         args.each do |method_name|
+          table_alias = "dnmos_#{table_name}_#{self.denormalized_methods.size - 1}"
           # setup true scope
           true_attributes = { 
-            "denormalizer_method_outputs.denormalized_object_method" => method_name.to_s,
-            "denormalizer_method_outputs.method_output" => Denormalizer::MethodOutput::TrueOutput
+            "#{table_alias}.denormalized_object_method" => method_name.to_s,
+            "#{table_alias}.method_output" => Denormalizer::MethodOutput::TrueOutput
           }
           true_scope_name = "denormalized_#{method_name.to_s.gsub('?', '')}".pluralize.to_sym
-          scope true_scope_name, lambda { joins(:denormalized_method_outputs).where(true_attributes)}
+          scope true_scope_name, lambda { joins("INNER JOIN denormalizer_method_outputs AS #{table_alias} on #{table_alias}.denormalized_object_type='#{to_s}' AND #{table_alias}.denormalized_object_id=#{table_name}.id").where(true_attributes)}
 
           # setup false scope
+          # the false query uses the same table alias
           false_attributes = {
-            "denormalizer_method_outputs.denormalized_object_method" => method_name.to_s,
-            "denormalizer_method_outputs.method_output" => Denormalizer::MethodOutput::FalseOutput
+            "#{table_alias}.denormalized_object_method" => method_name.to_s,
+            "#{table_alias}.method_output" => Denormalizer::MethodOutput::FalseOutput
           }
           false_scope_name = "denormalized_not_#{method_name.to_s.gsub('?', '')}".pluralize.to_sym
-          scope false_scope_name, lambda { joins(:denormalized_method_outputs).where(false_attributes)}
+          scope false_scope_name, lambda { joins("INNER JOIN denormalizer_method_outputs AS #{table_alias} on #{table_alias}.denormalized_object_type='#{to_s}' AND #{table_alias}.denormalized_object_id=#{table_name}.id").where(false_attributes)}
 
           instance_method_name = "denormalized_#{method_name.to_s}"
           define_method instance_method_name do

data/spec/method_denormalization_spec.rb

@@ -32,16 +32,16 @@ describe "method denormalization" do
     describe "denormalized_short_names" do
       it "should match this sql" do
         sql = Book.denormalized_short_names.to_sql 
-        sql.should match "INNER JOIN \"denormalizer_method_outputs\" ON \"denormalizer_method_outputs\".\"denormalized_object_id\" = \"books\".\"id\" AND \"denormalizer_method_outputs\".\"denormalized_object_type\" = 'Book'"
-        sql.should match "WHERE \"denormalizer_method_outputs\".\"denormalized_object_method\" = 'short_name.' AND \"denormalizer_method_outputs\".\"method_output\" = 1"
+        sql.should match "INNER JOIN denormalizer_method_outputs AS dnmos_books_0 on dnmos_books_0.denormalized_object_type='Book' AND dnmos_books_0.denormalized_object_id=books.id"
+        sql.should match "WHERE \"dnmos_books_0\".\"denormalized_object_method\" = 'short_name.' AND \"dnmos_books_0\".\"method_output\" = 1"
       end
     end
 
     describe "denormalized_not_short_names" do
       it "should match this sql" do
         sql = Book.denormalized_not_short_names.to_sql 
-        sql.should match "INNER JOIN \"denormalizer_method_outputs\" ON \"denormalizer_method_outputs\".\"denormalized_object_id\" = \"books\".\"id\" AND \"denormalizer_method_outputs\".\"denormalized_object_type\" = 'Book'"
-        sql.should match "WHERE \"denormalizer_method_outputs\".\"denormalized_object_method\" = 'short_name.' AND \"denormalizer_method_outputs\".\"method_output\" = 0"
+        sql.should match "INNER JOIN denormalizer_method_outputs AS dnmos_books_0 on dnmos_books_0.denormalized_object_type='Book' AND dnmos_books_0.denormalized_object_id=books.id"
+        sql.should match "WHERE \"dnmos_books_0\".\"denormalized_object_method\" = 'short_name.' AND \"dnmos_books_0\".\"method_output\" = 0"
       end
     end
   end

metadata

@@ -2,7 +2,7 @@
 name: denormalizer
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors: 
 - Jeremiah Hemphill
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-07-13 00:00:00 Z
+date: 2012-12-03 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rails
@@ -207,7 +207,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3695816084296706715
+      hash: -921716589672485106
       segments: 
       - 0
       version: "0"