denormalize_fields 1.1.1 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7bf731da26d483667dbb6a1942755bdf5c6cf5161aaf1b2d9fb1b2dc84366d96
-  data.tar.gz: a8e09ec6ced26720d404ca8e693f1e9c036a92b01b9f7d607b8cb6a51587112f
+  metadata.gz: b9b1cb8a3c118b8e410665f182f78fd63ec1dfa571af98f2d93f5deca9e0600a
+  data.tar.gz: 73785e5dc16509d33978fcc22571e9dc961d9c5dd02e712b640d4a57d8bb8a2f
 SHA512:
-  metadata.gz: d3cb5a23f3896d6074020c48e53b954f0e4266a779da1b7c106d8bc5d0df6f22597bcab869ef9872d14aa23de163aa5b6d2df1e7904ac66a190d9546b462d462
-  data.tar.gz: 75c819d17a023f5fbbade955cb90ee54417e4a22807ab78fb924aff011611bf4d858fbf7cfad1eb63bbf9fe2807f0897c6d89a0be87cde2902757bf08266fbdb
+  metadata.gz: 5836ceeb70a8d592d5f9406c6b6c79bd6d0ffe51f5a80b4e3ab202983aba5ec0526ec30fe7a561b02e78da97578a10a8509be898c9a208e9dc3e043417c2387c
+  data.tar.gz: 8f87ae5f9efae07bd63eab9e5394d5b78cd6162569583327cac0c086dc244899d718c69ce2c50aa4039d4b35ea21d268641ce83892bdb44df0a899b0e50575e7

data/lib/denormalize_fields/association_extension.rb

@@ -12,10 +12,9 @@ module DenormalizeFields
       return unless options = association.options[OPTION]
 
       DenormalizeFields.denormalize(
-        fields: options[:fields],
-        from:   association.active_record,
-        onto:   association.name,
-        prefix: options[:prefix],
+        from: association.active_record,
+        onto: association.name,
+        **options,
       )
     end
   end

data/lib/denormalize_fields/version.rb

@@ -1,3 +1,3 @@
 module DenormalizeFields
-  VERSION = '1.1.1'
+  VERSION = '1.3.0'
 end

data/lib/denormalize_fields.rb

@@ -4,14 +4,48 @@ require 'denormalize_fields/version'
 module DenormalizeFields
   module_function
 
-  def denormalize(fields:, from:, onto:, prefix: nil)
+  class ArgumentError < ::ArgumentError; end
+
+  class RelatedRecordInvalid < ::ActiveRecord::RecordInvalid
+    attr_accessor :owner, :mapping
+
+    def initialize(record:, owner:, mapping:)
+      super(record)
+      self.owner = owner
+      self.mapping = mapping
+    end
+  end
+
+  def denormalize(fields:, from:, onto:, prefix: nil, **options)
     mapping = cast_to_mapping(fields, prefix: prefix)
+    validate_options(**options)
 
     from.after_save do
-      DenormalizeFields.call(record: self, relation_name: onto, mapping: mapping)
+      DenormalizeFields.call(
+        record:        self,
+        relation_name: onto,
+        mapping:       mapping,
+        **options,
+      )
     end
   end
 
+  def validate_options(**options)
+    validate_conditional(options[:if])
+    validate_conditional(options[:unless])
+    unsupported = (options.keys - %i[if unless]).empty? ||
+      raise(ArgumentError, "unsupported denormalize options: #{unsupported}")
+  end
+
+  CONDITIONAL_CLASSES = [NilClass, TrueClass, FalseClass, Symbol, Proc]
+
+  def validate_conditional(arg)
+    CONDITIONAL_CLASSES.include?(arg.class) || raise(
+      ArgumentError,
+      "`if:` option must be a #{CONDITIONAL_CLASSES.join('/')}, got: #{arg.class}"
+    )
+  end
+
   def cast_to_mapping(fields, prefix: nil)
     if fields.is_a?(Hash)
       prefix && raise(ArgumentError, 'pass EITHER a fields Hash OR a prefix')
@@ -21,7 +55,10 @@ module DenormalizeFields
     end
   end
 
-  def call(record:, relation_name:, mapping:)
+  def call(record:, relation_name:, mapping:, **options)
+    return unless conditional_passes?(options[:if],     record, false)
+    return unless conditional_passes?(options[:unless], record, true)
+
     changeset = DenormalizeFields.changeset(record: record, mapping: mapping)
     return if changeset.empty?
 
@@ -32,6 +69,21 @@ module DenormalizeFields
     end
   end
 
+  def conditional_passes?(conditional, record, inverted)
+    return true if conditional.nil?
+
+    result =
+      if conditional.respond_to?(:call)
+        record.instance_exec(&conditional)
+      elsif conditional.class == Symbol
+        record.send(conditional)
+      else # true, false
+        conditional
+      end
+
+    inverted ? !result : !!result
+  end
+
   def changeset(record:, mapping:)
     mapping.each.with_object({}) do |(source, dest), hash|
       if source.is_a?(Array)
@@ -54,15 +106,16 @@ module DenormalizeFields
     return if to.new_record? ? to.valid? : to.save
 
     DenormalizeFields.copy_errors(to.errors, to_record: owner, mapping: mapping)
-    raise(ActiveRecord::RecordInvalid, to)
+    raise RelatedRecordInvalid.new(record: to, owner: owner, mapping: mapping)
   end
 
   # TODO: use Errors#import when it becomes available in rails 6.1 or 6.2
   def copy_errors(errors, to_record:, mapping:)
     errors.details.each do |key, array|
-      field = mapping.rassoc(key.to_sym).first
-      array.each do |details|
-        to_record.errors.add(field, details[:error], details.except(:error))
+      Array(mapping.rassoc(key.to_sym)).compact.each do |field|
+        array.each do |details|
+          to_record.errors.add(field, details[:error], **details.except(:error))
+        end
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: denormalize_fields
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.3.0
 platform: ruby
 authors:
 - Janosch Müller
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-03-26 00:00:00.000000000 Z
+date: 2021-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -19,7 +19,7 @@ dependencies:
         version: 4.1.14
     - - "<"
       - !ruby/object:Gem::Version
-        version: 7.0.0
+        version: 8.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,27 +29,21 @@ dependencies:
         version: 4.1.14
     - - "<"
       - !ruby/object:Gem::Version
-        version: 7.0.0
+        version: 8.0.0
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.1.14
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.0.0
+        version: '7.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.1.14
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.0.0
+        version: '7.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -121,7 +115,7 @@ homepage: https://www.github.com/jaynetics/denormalize_fields
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -136,8 +130,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.2.32
+signing_key:
 specification_version: 4
 summary: Simplify denormalizing fields from one record to another.
 test_files: []