denormalize-field 0.1.0 → 0.1.1

data/Gemfile

@@ -7,4 +7,5 @@ group :development do
   gem "rspec",        "~> 2.8.0"
   gem "rdoc",         "~> 3.12"
   gem "jeweler",      "~> 1.8.4"
+  gem "mocha"
 end

data/Gemfile.lock

@@ -24,7 +24,10 @@ GEM
       rake
       rdoc
     json (1.7.5)
+    metaclass (0.0.1)
     method_source (0.8)
+    mocha (0.10.4)
+      metaclass (~> 0.0.1)
     multi_json (1.3.6)
     pry (0.9.10)
       coderay (~> 1.0.5)
@@ -51,6 +54,7 @@ PLATFORMS
 DEPENDENCIES
   activerecord (~> 3.2.0)
   jeweler (~> 1.8.4)
+  mocha
   pry
   rdoc (~> 3.12)
   rspec (~> 2.8.0)

data/VERSION

@@ -1 +1 @@
-0.1.0
+0.1.1

data/denormalize-field.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "denormalize-field"
-  s.version = "0.1.0"
+  s.version = "0.1.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Len Smith"]
-  s.date = "2012-09-24"
+  s.date = "2012-10-15"
   s.description = "Denormalize ActiveRecord fields for performance reasons"
   s.email = "len@barrison.com"
   s.extra_rdoc_files = [
@@ -47,6 +47,7 @@ Gem::Specification.new do |s|
       s.add_development_dependency(%q<rspec>, ["~> 2.8.0"])
       s.add_development_dependency(%q<rdoc>, ["~> 3.12"])
       s.add_development_dependency(%q<jeweler>, ["~> 1.8.4"])
+      s.add_development_dependency(%q<mocha>, [">= 0"])
     else
       s.add_dependency(%q<activerecord>, ["~> 3.2.0"])
       s.add_dependency(%q<pry>, [">= 0"])
@@ -54,6 +55,7 @@ Gem::Specification.new do |s|
       s.add_dependency(%q<rspec>, ["~> 2.8.0"])
       s.add_dependency(%q<rdoc>, ["~> 3.12"])
       s.add_dependency(%q<jeweler>, ["~> 1.8.4"])
+      s.add_dependency(%q<mocha>, [">= 0"])
     end
   else
     s.add_dependency(%q<activerecord>, ["~> 3.2.0"])
@@ -62,6 +64,7 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<rspec>, ["~> 2.8.0"])
     s.add_dependency(%q<rdoc>, ["~> 3.12"])
     s.add_dependency(%q<jeweler>, ["~> 1.8.4"])
+    s.add_dependency(%q<mocha>, [">= 0"])
   end
 end
 

data/lib/denormalize-field.rb

@@ -9,13 +9,17 @@ module DenormalizeFields
 
       before_save do
         _denormalized_field_name = "#{key}_#{_field_name}"
-        self.send "#{_denormalized_field_name}=", self.send(key).send(_field_name)
+        if self.send(key)
+          self.send "#{_denormalized_field_name}=", self.send(key).send(_field_name)
+        end
         _original_klass = self.class
 
         _klass = key.to_s.camelize.constantize
         _klass.after_save do
-          self.send(_original_klass.name.downcase.pluralize).each do |child|
-            child.update_attribute _denormalized_field_name, self.send(_field_name)
+          if self.send "#{_field_name}_changed?"
+            self.send(_original_klass.name.downcase.pluralize).each do |child|
+              child.update_attribute _denormalized_field_name, self.send(_field_name)
+            end
           end
         end
       end

data/spec/denormalize-field_spec.rb

@@ -27,4 +27,19 @@ describe "DenormalizeField" do
     post.reload
     post.category_name.should == "Sports"
   end
+
+  it "handles nil associations" do
+    post.category = nil
+    expect { post.save! }.to_not raise_error
+  end
+
+  it "doesn't save the association unless the denormalized field has changed" do
+    post.save!
+    updated_at = post.updated_at
+    category = Category.first
+    Post.any_instance.expects(:update_attribute).never
+    category.save!
+    post.reload
+    post.updated_at.should == updated_at
+  end
 end

data/spec/spec_helper.rb

@@ -8,6 +8,7 @@ require 'denormalize-field'
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
 
 RSpec.configure do |config|
+  config.mock_with :mocha
   config.before(:each) do
     Post.delete_all
     Category.delete_all
@@ -21,10 +22,11 @@ ActiveRecord::Base.connection.drop_table(:categories)
 ActiveRecord::Base.connection.drop_table(:posts)
 ActiveRecord::Base.connection.create_table(:categories) do |t|
   t.string :name
+  t.timestamps
 end
+
 ActiveRecord::Base.connection.create_table(:posts) do |t|
   t.string :category_id
   t.string :category_name
+  t.timestamps
 end
-
-

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: denormalize-field
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-24 00:00:00.000000000 Z
+date: 2012-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -107,6 +107,22 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 1.8.4
+- !ruby/object:Gem::Dependency
+  name: mocha
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Denormalize ActiveRecord fields for performance reasons
 email: len@barrison.com
 executables: []
@@ -143,7 +159,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2097104229179456767
+      hash: -2310274832214155233
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: