delta_test 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5124c1d8cd4164ac2b4e697a940dd9c8ac4cee50
-  data.tar.gz: bd5137e61e6143e541ae75c06c5515d9914831f9
+  metadata.gz: a176739129c5821a3db48e783d057a02ac2e7d7f
+  data.tar.gz: 76065c7dd622c9b4077431e5a5662a97fbb27d80
 SHA512:
-  metadata.gz: 428600dc97de76a3993c0fc544c88f1da90006a7e0e9146b8bce40d1ba92c547d3d3a79b9df1a13578b006eae35636612b79bb478ce13b360f12cb787584f1bd
-  data.tar.gz: 055945bec6eac5d010e394880d894719a3b3726cb4023c656d14c9b06defb3e5e2635abd775bea4828c6a69abbe6c354620b62689a08da544932db0308d0ec50
+  metadata.gz: 5b6a2b75604884e8c1d93929e4c4a3d179392c4df79ed581e7206e69e474553186413c49e1435bca207c905a20fe847435ed0ec2391a7bd3c954e9f7e5ba486a
+  data.tar.gz: 7a5df579dfe7ca4a60eebdd863094e7e75cb5584f4dbb5572bd58dd23ac30f3e56246a6a42cc916db6b4b51724b750a488b224e494320f8fddbc259ffeb431b6

data/lib/delta_test/cli/command_base.rb

@@ -1,3 +1,4 @@
+require 'fileutils'
 require 'open3'
 require 'shellwords'
 require 'thread'
@@ -111,6 +112,60 @@ module DeltaTest
         Object.const_defined?(:Bundler) || !!Utils.find_file_upward('Gemfile')
       end
 
+      ###
+      # Wrapper of hook_create_error_file
+      #
+      # @block
+      ###
+      def record_error
+        hook_create_error_file
+        yield if block_given?
+      end
+
+      ###
+      # Hook on exit and record errors
+      ###
+      def hook_create_error_file
+        at_exit do
+          create_error_file unless current_process_status_success?
+        end
+      end
+
+      ###
+      # Check exit status of the current process
+      #
+      # @return {Boolean}
+      ###
+      def current_process_status_success?
+        $!.nil? || $!.is_a?(SystemExit) && $!.success?
+      end
+
+      ###
+      # Check if any error is recorded
+      #
+      # @return {Boolean}
+      ###
+      def error_recorded?
+        File.exists?(error_file)
+      end
+
+      ###
+      # Path for an error file
+      #
+      # @return {Pathname}
+      ###
+      def error_file
+        @error_file ||= DeltaTest.config.tmp_table_file.parent.join('error.txt')
+      end
+
+      ###
+      # Create an error file
+      ###
+      def create_error_file
+        FileUtils.mkdir_p(File.dirname(error_file))
+        File.new(error_file, 'w')
+      end
+
     end
   end
 end

data/lib/delta_test/cli/exec_command.rb

@@ -93,7 +93,9 @@ module DeltaTest
 
         args += @args
 
-        exec_with_data(args.join(' '), @spec_files)
+        record_error do
+          exec_with_data(args.join(' '), @spec_files)
+        end
       end
 
     end

data/lib/delta_test/cli/stats_save_command.rb

@@ -9,12 +9,16 @@ module DeltaTest
     class StatsSaveCommand < CommandBase
 
       def invoke!
+        return if error_recorded?
+
         load_tmp_table_files
         cleanup_tmp_table_files
-        save_table_file
 
-        stage_table_file
-        sync_table_file unless @options['no-sync']
+        if table.any?
+          save_table_file
+          stage_table_file
+          sync_table_file unless @options['no-sync']
+        end
       end
 
       def load_tmp_table_files

data/lib/delta_test/version.rb

@@ -2,7 +2,7 @@ module DeltaTest
 
   MAJOR    = 1
   MINOR    = 0
-  REVISION = 2
+  REVISION = 3
 
   VERSION = [MAJOR, MINOR, REVISION].compact.join('.')
 

data/spec/lib/delta_test/cli/command_base_spec.rb

@@ -161,4 +161,64 @@ describe DeltaTest::CLI::CommandBase do
 
   end
 
+  describe '#error_file' do
+
+    it 'should return a path for an error file' do
+      expect(command_base.error_file).to be_a(Pathname)
+    end
+
+  end
+
+  describe '#create_error_file' do
+
+    it 'should create an error file' do
+      expect(File.exists?(command_base.error_file)).to be(false)
+      command_base.create_error_file
+      expect(File.exists?(command_base.error_file)).to be(true)
+    end
+
+  end
+
+  describe '#error_recorded?' do
+
+    it 'should return false if no error file exists' do
+      expect(File.exists?(command_base.error_file)).to be(false)
+      expect(command_base.error_recorded?).to be(false)
+    end
+
+    it 'should return false if an error file exists' do
+      command_base.create_error_file
+      expect(File.exists?(command_base.error_file)).to be(true)
+      expect(command_base.error_recorded?).to be(true)
+    end
+
+  end
+
+  describe '#record_error' do
+
+    before do
+      allow(command_base).to receive(:hook_create_error_file).and_return(nil)
+    end
+
+    it 'should call hook_create_error_file' do
+      expect(command_base).to receive(:hook_create_error_file)
+      command_base.record_error
+    end
+
+    it 'should yield a given block' do
+      called = false
+      command_base.record_error { called = true }
+      expect(called).to be(true)
+    end
+
+  end
+
+  describe '#hook_create_error_file' do
+
+  end
+
+  describe '#current_process_status_success?' do
+
+  end
+
 end

data/spec/lib/delta_test/cli/exec_command_spec.rb

@@ -27,6 +27,8 @@ describe DeltaTest::CLI::ExecCommand do
 
     allow(command.stats).to receive(:base_commit).and_return(base_commit)
     allow(command.stats).to receive(:table_file_path).and_return(nil)
+
+    allow(command).to receive(:hook_create_error_file).and_return(nil)
   end
 
   describe '#profile_mode?' do

data/spec/lib/delta_test/cli/stats_save_command_spec.rb

@@ -49,6 +49,11 @@ describe DeltaTest::CLI::StatsSaveCommand do
 
   describe '#invoke!' do
 
+    before do
+      allow(command.table).to receive(:any?).and_return(true)
+      allow(command).to receive(:error_recorded?).and_return(false)
+    end
+
     it 'should execute procedures' do
       expect(command).to receive(:load_tmp_table_files).and_return(nil).once.ordered
       expect(command).to receive(:cleanup_tmp_table_files).and_return(nil).once.ordered
@@ -73,6 +78,34 @@ describe DeltaTest::CLI::StatsSaveCommand do
 
     end
 
+    context 'no table data' do
+
+      it 'should not create an empty table file' do
+        allow(command.table).to receive(:any?).and_return(false)
+        expect(command).to receive(:load_tmp_table_files).and_return(nil).once.ordered
+        expect(command).to receive(:cleanup_tmp_table_files).and_return(nil).once.ordered
+        expect(command).not_to receive(:save_table_file)
+        expect(command).not_to receive(:stage_table_file)
+        expect(command).not_to receive(:sync_table_file)
+        command.invoke!
+      end
+
+    end
+
+    context 'error_recorded?' do
+
+      it 'should do nothing' do
+        allow(command).to receive(:error_recorded?).and_return(true)
+        expect(command).not_to receive(:load_tmp_table_files)
+        expect(command).not_to receive(:cleanup_tmp_table_files)
+        expect(command).not_to receive(:save_table_file)
+        expect(command).not_to receive(:stage_table_file)
+        expect(command).not_to receive(:sync_table_file)
+        command.invoke!
+      end
+
+    end
+
   end
 
   describe '#tmp_table_files' do

data/spec/rails/Gemfile.lock

@@ -11,7 +11,7 @@ GIT
 PATH
   remote: ../..
   specs:
-    delta_test (1.0.1)
+    delta_test (1.0.3)
 
 GEM
   remote: https://rubygems.org/

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: delta_test
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Yuki Iwanaga
@@ -121,7 +121,6 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".ruby-version"
-- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md

data/CHANGELOG.md

@@ -1,44 +0,0 @@
-Change logs
-===========
-
-master
-------
-
-N/A
-
-
-1.0.1
------
-
-- [feature] #26 Subversioning to avoid conflicts
-
-
-1.0.0
------
-
-- [feature] #25 Versioning table files. Including many refactorings and bug fixes
-
-
-0.2.0
------
-
-- [dev] #1 Setup CircleCI. and others
-- [dev] #2 Add codeclimate
-- [dev] #3 Fix bundle install command in rails directory. and others
-- [bugfix] #4 Use hook scope names of rspec v2
-- [bugfix] #8 Exit with real status
-- [bugfix] #9 Fail to obtain current spec file path with RSpec 2
-- [improvement] #12 Use original profiler
-- [improvement] #14 Improve profiler
-- [improvement] #15 Fully support parallel_tests
-- [improvement] #19 Auto bundle exec
-- [feature] #20 Run full tests
-- [feature] #21 Add clear command
-
-And many bugfixes and refactorings.
-
-
-0.1.0
------
-
-- The first release