delta_changes 0.0.1 → 2.2.1

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA256:
+  metadata.gz: 5098ae34ad5c3463ae089a94bf3736e15b47ae4f8c9d185a4208841ebec00f69
+  data.tar.gz: 540276c58ac91875d021e4fa86a59d983f542059d5ad1828b2c76e55fdd017f0
+SHA512:
+  metadata.gz: d46bf7b19b2678cd0c44318d234e42a6dd11a0bb16427f645ad60e28127badebcbeb0db3738d80f903c65b03fd0b0bf0dcb5d592337fdd5353ebe6792e1455bb
+  data.tar.gz: 78c00a7637ef11280224edad95d55e3823c4ef5ae591f925dfb0e7ea9e417b479c10dc3b118e1c258f3505e9ec759a612b854b38f945f7e51dd5e22fd9c10864

data/lib/delta_changes.rb

@@ -6,7 +6,8 @@ module DeltaChanges
       base.extend(ClassMethods)
       base.cattr_accessor :delta_changes_options
       base.attribute_method_suffix '_delta_changed?', '_delta_change', '_delta_was', '_delta_will_change!'
-      base.alias_method_chain :write_attribute, :delta_changes
+      base.send(:alias_method, :write_attribute_without_delta_changes, :write_attribute)
+      base.send(:alias_method, :write_attribute, :write_attribute_with_delta_changes)
     end
 
     module ClassMethods
@@ -20,23 +21,23 @@ module DeltaChanges
       #
       def define_virtual_attribute_delta_methods
         delta_changes_options[:attributes].each do |tracked_attribute|
-          class_eval(<<-RUBY, __FILE__, __LINE__ + 1)
-            def #{tracked_attribute}_delta_changed?
-              attribute_delta_changed?('#{tracked_attribute}')
+          class_eval do
+            define_method("#{tracked_attribute}_delta_changed?") do
+              attribute_delta_changed?(tracked_attribute)
             end
 
-            def #{tracked_attribute}_delta_change
-              attribute_delta_change('#{tracked_attribute}')
+            define_method("#{tracked_attribute}_delta_change") do
+              attribute_delta_change(tracked_attribute)
             end
 
-            def #{tracked_attribute}_delta_was
-              attribute_delta_was('#{tracked_attribute}')
+            define_method("#{tracked_attribute}_delta_was") do
+              attribute_delta_was(tracked_attribute)
             end
 
-            def #{tracked_attribute}_delta_will_change!
-              attribute_delta_will_change!('#{tracked_attribute}')
+            define_method("#{tracked_attribute}_delta_will_change!") do
+              attribute_delta_will_change!(tracked_attribute)
             end
-          RUBY
+          end
         end
       end
     end
@@ -83,7 +84,7 @@ module DeltaChanges
         value = send(attr)
         value.duplicable? ? value.clone : value
       else
-        options[:from] || clone_attribute_value(:read_attribute, attr)
+        options[:from] || respond_to?(:clone_attribute_value) ? clone_attribute_value(:read_attribute, attr) : read_attribute(attr).dup
       end
       delta_changed_attributes[attr] = attribute_value
     end
@@ -92,18 +93,32 @@ module DeltaChanges
     def write_attribute_with_delta_changes(attr, value)
       attr = attr.to_s
 
-      if self.class.delta_changes_options[:columns].include?(attr)
-        # The attribute already has an unsaved change.
-        if delta_changed_attributes.include?(attr)
-          old = delta_changed_attributes[attr]
-          delta_changed_attributes.delete(attr) unless field_changed?(attr, old, value)
-        else
-          old = clone_attribute_value(:read_attribute, attr)
-          delta_changed_attributes[attr] = old if field_changed?(attr, old, value)
-        end
+      unless self.class.delta_changes_options[:columns].include?(attr)
+        return write_attribute_without_delta_changes(attr, value)
+      end
+
+      # The attribute already has an unsaved change.
+      if delta_changed_attributes.include?(attr)
+        old = delta_changed_attributes[attr]
+        write_attribute_without_delta_changes(attr, value)
+        delta_changed_attributes.delete(attr) unless delta_changes_field_changed?(attr, old, value)
+      else
+        old = respond_to?(:clone_attribute_value) ? clone_attribute_value(:read_attribute, attr) : read_attribute(attr).dup
+        write_attribute_without_delta_changes(attr, value)
+        delta_changed_attributes[attr] = old if delta_changes_field_changed?(attr, old, value)
       end
+    end
+
+    def delta_changes_field_changed?(attr, old, value)
+      return true if !old.present? && value.present?
 
-      write_attribute_without_delta_changes(attr, value)
+      if ActiveRecord::VERSION::STRING < '4.2.0'
+        _field_changed?(attr, old, value)
+      elsif ActiveRecord::VERSION::MAJOR < 5
+        _field_changed?(attr, old)
+      else
+        self[attr] != old
+      end
     end
   end
 end

data/lib/delta_changes/version.rb

@@ -1,3 +1,3 @@
 module DeltaChanges
-  VERSION = "0.0.1"
+  VERSION = "2.2.1"
 end

metadata

@@ -1,84 +1,148 @@
 --- !ruby/object:Gem::Specification
 name: delta_changes
 version: !ruby/object:Gem::Version
-  version: 0.0.1
-  prerelease: 
+  version: 2.2.1
 platform: ruby
 authors:
 - Michael Grosser
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2012-09-20 00:00:00.000000000 Z
+date: 2021-02-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.2.22
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.2.22
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.2'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.6
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.6
+- !ruby/object:Gem::Dependency
+  name: bump
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: wwtd
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description:
 email: michael@grosser.it
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .travis.yml
-- Appraisals
-- Gemfile
-- Gemfile.lock
-- Rakefile
-- Readme.md
-- delta_changes.gemspec
-- gemfiles/rails2.gemfile
-- gemfiles/rails2.gemfile.lock
-- gemfiles/rails30.gemfile
-- gemfiles/rails30.gemfile.lock
-- gemfiles/rails32.gemfile
-- gemfiles/rails32.gemfile.lock
 - lib/delta_changes.rb
 - lib/delta_changes/version.rb
-- spec/delta_changes_spec.rb
-- spec/spec_helper.rb
-homepage: http://github.com/grosser/delta_changes
+homepage: http://github.com/zendesk/delta_changes
 licenses:
 - MIT
-post_install_message: 
+metadata: {}
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 3940600882562868341
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 3940600882562868341
 requirements: []
-rubyforge_project: 
-rubygems_version: 1.8.24
-signing_key: 
-specification_version: 3
+rubygems_version: 3.0.3
+signing_key:
+specification_version: 4
 summary: Additional real/virtual attribute change tracking independent of ActiveRecords
 test_files: []

data/.travis.yml

@@ -1,4 +0,0 @@
-rvm:
-  - ree
-  - 1.9.2
-  - 1.9.3

data/Appraisals

@@ -1,15 +0,0 @@
-appraise "rails2" do
-  version = "2.3.14"
-  gem 'activerecord', version
-end
-
-appraise "rails30" do
-  version = "3.2.3"
-  gem 'activerecord', version
-end
-
-
-appraise "rails32" do
-  version = "3.2.3"
-  gem 'activerecord', version
-end

data/Gemfile

@@ -1,7 +0,0 @@
-source :rubygems
-gemspec
-
-gem "appraisal"
-gem "rake"
-gem "rspec", "~>2"
-gem "sqlite3"

data/Gemfile.lock

@@ -1,49 +0,0 @@
-PATH
-  remote: .
-  specs:
-    delta_changes (0.0.1)
-      activerecord
-
-GEM
-  remote: http://rubygems.org/
-  specs:
-    activemodel (3.2.8)
-      activesupport (= 3.2.8)
-      builder (~> 3.0.0)
-    activerecord (3.2.8)
-      activemodel (= 3.2.8)
-      activesupport (= 3.2.8)
-      arel (~> 3.0.2)
-      tzinfo (~> 0.3.29)
-    activesupport (3.2.8)
-      i18n (~> 0.6)
-      multi_json (~> 1.0)
-    appraisal (0.4.1)
-      bundler
-      rake
-    arel (3.0.2)
-    builder (3.0.3)
-    diff-lcs (1.1.3)
-    i18n (0.6.1)
-    multi_json (1.3.6)
-    rake (0.9.2)
-    rspec (2.6.0)
-      rspec-core (~> 2.6.0)
-      rspec-expectations (~> 2.6.0)
-      rspec-mocks (~> 2.6.0)
-    rspec-core (2.6.4)
-    rspec-expectations (2.6.0)
-      diff-lcs (~> 1.1.2)
-    rspec-mocks (2.6.0)
-    sqlite3 (1.3.6)
-    tzinfo (0.3.33)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  appraisal
-  delta_changes!
-  rake
-  rspec (~> 2)
-  sqlite3

data/Rakefile

@@ -1,27 +0,0 @@
-require "bundler/gem_tasks"
-require "appraisal"
-
-task :spec do
-  sh "rspec spec/"
-end
-
-task :default do
-  sh "bundle exec rake appraisal:install && bundle exec rake appraisal spec"
-end
-
-# extracted from https://github.com/grosser/project_template
-rule /^version:bump:.*/ do |t|
-  file = "lib/delta_changes/version.rb"
-
-  sh "git status | grep 'nothing to commit'" # ensure we are not dirty
-  index = ["major", "minor", "patch"].index(t.name.split(':').last)
-  version_file = File.read(file)
-  old_version, *version_parts = version_file.match(/(\d+)\.(\d+)\.(\d+)/).to_a
-  version_parts[index] = version_parts[index].to_i + 1
-  version_parts[2] = 0 if index < 2 # remove patch for minor
-  version_parts[1] = 0 if index < 1 # remove minor for major
-  new_version = version_parts * '.'
-
-  File.open(file,"w"){|f| f.write(version_file.sub(old_version, new_version)) }
-  sh "bundle && git add #{file} Gemfile.lock && git commit -m 'bump version to #{new_version}'"
-end

data/Readme.md

@@ -1,34 +0,0 @@
-Additional real/virtual attribute change tracking independent of ActiveRecords
-
-
-Install
-=======
-
-    gem install delta_changes
-
-Usage
-=====
-
-    class User < ActiveRecord::Base
-      include DeltaChanges::Extension
-      delta_changes :columns => [:name], :attributes => [:full_name]
-    end
-
-    user.name = "bar"
-    user.delta_changes # => {"name" => [nil, "bar"]}
-
-    user.full_name_will_change!
-    user.delta_changes # => {"name" => [nil, "bar"], "full_name" => [nil, "Mr. Bar"]}
-
-    user.save!
-    user.delta_changes # => {"name" => [nil, "bar"], "full_name" => [nil, "Mr. Bar"]}
-
-    user.reset_delta_changes!
-    user.delta_changes # => {}
-
-Author
-======
-[Michael Grosser](http://grosser.it)<br/>
-michael@grosser.it<br/>
-License: MIT<br/>
-[![Build Status](https://secure.travis-ci.org/grosser/delta_changes.png)](http://travis-ci.org/grosser/delta_changes)

data/delta_changes.gemspec

@@ -1,13 +0,0 @@
-$LOAD_PATH.unshift File.expand_path("../lib", __FILE__)
-name = "delta_changes"
-require "#{name}/version"
-
-Gem::Specification.new name, DeltaChanges::VERSION do |s|
-  s.summary = "Additional real/virtual attribute change tracking independent of ActiveRecords"
-  s.authors = ["Michael Grosser"]
-  s.email = "michael@grosser.it"
-  s.homepage = "http://github.com/grosser/#{name}"
-  s.files = `git ls-files`.split("\n")
-  s.add_runtime_dependency "activerecord"
-  s.license = "MIT"
-end

data/gemfiles/rails2.gemfile

@@ -1,11 +0,0 @@
-# This file was generated by Appraisal
-
-source :rubygems
-
-gem "appraisal"
-gem "rake"
-gem "rspec", "~>2"
-gem "sqlite3"
-gem "activerecord", "2.3.14"
-
-gemspec :path=>"../"

data/gemfiles/rails2.gemfile.lock

@@ -1,37 +0,0 @@
-PATH
-  remote: /Users/mgrosser/code/tools/delta_changes
-  specs:
-    delta_changes (0.0.0)
-      activerecord
-
-GEM
-  remote: http://rubygems.org/
-  specs:
-    activerecord (2.3.14)
-      activesupport (= 2.3.14)
-    activesupport (2.3.14)
-    appraisal (0.4.1)
-      bundler
-      rake
-    diff-lcs (1.1.3)
-    rake (0.9.2.2)
-    rspec (2.11.0)
-      rspec-core (~> 2.11.0)
-      rspec-expectations (~> 2.11.0)
-      rspec-mocks (~> 2.11.0)
-    rspec-core (2.11.1)
-    rspec-expectations (2.11.3)
-      diff-lcs (~> 1.1.3)
-    rspec-mocks (2.11.2)
-    sqlite3 (1.3.6)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activerecord (= 2.3.14)
-  appraisal
-  delta_changes!
-  rake
-  rspec (~> 2)
-  sqlite3

data/gemfiles/rails30.gemfile

@@ -1,11 +0,0 @@
-# This file was generated by Appraisal
-
-source :rubygems
-
-gem "appraisal"
-gem "rake"
-gem "rspec", "~>2"
-gem "sqlite3"
-gem "activerecord", "3.2.3"
-
-gemspec :path=>"../"

data/gemfiles/rails30.gemfile.lock

@@ -1,50 +0,0 @@
-PATH
-  remote: /Users/mgrosser/code/tools/delta_changes
-  specs:
-    delta_changes (0.0.0)
-      activerecord
-
-GEM
-  remote: http://rubygems.org/
-  specs:
-    activemodel (3.2.3)
-      activesupport (= 3.2.3)
-      builder (~> 3.0.0)
-    activerecord (3.2.3)
-      activemodel (= 3.2.3)
-      activesupport (= 3.2.3)
-      arel (~> 3.0.2)
-      tzinfo (~> 0.3.29)
-    activesupport (3.2.3)
-      i18n (~> 0.6)
-      multi_json (~> 1.0)
-    appraisal (0.4.1)
-      bundler
-      rake
-    arel (3.0.2)
-    builder (3.0.3)
-    diff-lcs (1.1.3)
-    i18n (0.6.1)
-    multi_json (1.3.6)
-    rake (0.9.2.2)
-    rspec (2.11.0)
-      rspec-core (~> 2.11.0)
-      rspec-expectations (~> 2.11.0)
-      rspec-mocks (~> 2.11.0)
-    rspec-core (2.11.1)
-    rspec-expectations (2.11.3)
-      diff-lcs (~> 1.1.3)
-    rspec-mocks (2.11.2)
-    sqlite3 (1.3.6)
-    tzinfo (0.3.33)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activerecord (= 3.2.3)
-  appraisal
-  delta_changes!
-  rake
-  rspec (~> 2)
-  sqlite3

data/gemfiles/rails32.gemfile

@@ -1,11 +0,0 @@
-# This file was generated by Appraisal
-
-source :rubygems
-
-gem "appraisal"
-gem "rake"
-gem "rspec", "~>2"
-gem "sqlite3"
-gem "activerecord", "3.2.3"
-
-gemspec :path=>"../"

data/gemfiles/rails32.gemfile.lock

@@ -1,50 +0,0 @@
-PATH
-  remote: /Users/mgrosser/code/tools/delta_changes
-  specs:
-    delta_changes (0.0.0)
-      activerecord
-
-GEM
-  remote: http://rubygems.org/
-  specs:
-    activemodel (3.2.3)
-      activesupport (= 3.2.3)
-      builder (~> 3.0.0)
-    activerecord (3.2.3)
-      activemodel (= 3.2.3)
-      activesupport (= 3.2.3)
-      arel (~> 3.0.2)
-      tzinfo (~> 0.3.29)
-    activesupport (3.2.3)
-      i18n (~> 0.6)
-      multi_json (~> 1.0)
-    appraisal (0.4.1)
-      bundler
-      rake
-    arel (3.0.2)
-    builder (3.0.3)
-    diff-lcs (1.1.3)
-    i18n (0.6.1)
-    multi_json (1.3.6)
-    rake (0.9.2.2)
-    rspec (2.11.0)
-      rspec-core (~> 2.11.0)
-      rspec-expectations (~> 2.11.0)
-      rspec-mocks (~> 2.11.0)
-    rspec-core (2.11.1)
-    rspec-expectations (2.11.3)
-      diff-lcs (~> 1.1.3)
-    rspec-mocks (2.11.2)
-    sqlite3 (1.3.6)
-    tzinfo (0.3.33)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activerecord (= 3.2.3)
-  appraisal
-  delta_changes!
-  rake
-  rspec (~> 2)
-  sqlite3

data/spec/delta_changes_spec.rb

@@ -1,99 +0,0 @@
-require "spec_helper"
-
-describe DeltaChanges do
-  it "has a VERSION" do
-    DeltaChanges::VERSION.should =~ /^[\.\da-z]+$/
-  end
-
-  it "should not create methods on unspecified attributes" do
-    # TODO broken, but that might be rails 2 ...
-    #expect{
-    #  User.new.email_delta_will_change!
-    #}.to raise_error
-
-    expect{
-      User.new.bar_delta_will_change!
-    }.to raise_error
-
-    expect{
-      User.new.does_not_exist_delta_will_change!
-    }.to raise_error
-  end
-
-  describe "#delta_changes" do
-    it "should be empty on unchanged" do
-      User.new.delta_changes.should == {}
-    end
-
-    it "should be filled by tracked column changes" do
-      User.new(:name => "Peter").delta_changes.should == {"name"=>[nil, "Peter"]}
-    end
-
-    it "should be filled by tracked number column change" do
-      User.new(:score => 5).delta_changes.should == {"score"=>[nil, 5]}
-    end
-
-    it "should be filled by tracked number column change that have the wrong type" do
-      User.new(:score => "5").delta_changes.should == {"score"=>[nil, 5]}
-    end
-
-    it "should not be filled by untracked column changes" do
-      User.new(:email => "Peter").delta_changes.should == {}
-    end
-
-    it "should not be filled implicit tracked attribute changes" do
-      user = User.new(:foo => 1)
-      user.delta_changes.should == {}
-    end
-
-    it "should be filled by explicit tracked attribute changes" do
-      user = User.new(:foo => 1)
-      user.foo_delta_will_change!
-      user.foo = 2
-      user.delta_changes.should == {"foo"=>[1, 2]}
-    end
-
-    it "should not mess with normal changes" do
-      User.new(:email => "EMAIL", :name => "NAME", :foo => "FOO").changes.should ==
-        {"email"=>[nil, "EMAIL"], "name"=>[nil, "NAME"]}
-    end
-
-    it "should not reset columns on save" do
-      user = User.create!(:name => "NAME", :foo => "FOO", :bar => "BAR")
-      user.delta_changes.should == {"name"=>[nil, "NAME"]}
-    end
-
-    it "should not reset columns on update" do
-      user = User.create!(:name => "NAME", :foo => "FOO", :bar => "BAR")
-      user.update_attributes(:name => "NAME-2")
-      user.delta_changes.should == {"name"=>[nil, "NAME-2"]}
-    end
-
-    # that might change, I'd consider this a bug ... but just documenting for now
-    it "should not reset columns on reload" do
-      user = User.create!(:name => "NAME", :foo => "FOO", :bar => "BAR")
-      user.reload
-      user.delta_changes.should == {"name"=>[nil, "NAME"]}
-    end
-
-    it "should have previouse value from db" do
-      user = User.create!(:name => "NAME", :foo => "FOO", :bar => "BAR")
-      user = User.find(user)
-      user.name = "NAME-2"
-      user.delta_changes.should == {"name"=>["NAME", "NAME-2"]}
-    end
-
-    it "should not track non-changes on tracked columns" do
-      user = User.create!(:score => 5).reload
-      user.reset_delta_changes!
-
-      user.delta_changes.should == {}
-
-      user.score = 5
-      user.delta_changes.should == {}
-
-      user.score = "5"
-      user.delta_changes.should == {}
-    end
-  end
-end

data/spec/spec_helper.rb

@@ -1,31 +0,0 @@
-require "bundler/setup"
-require "delta_changes"
-require "active_record"
-
-# connect
-ActiveRecord::Base.establish_connection(
-  :adapter => "sqlite3",
-  :database => ":memory:"
-)
-
-# create tables
-ActiveRecord::Schema.define(:version => 1) do
-  create_table :users do |t|
-    t.string :name
-    t.string :email
-    t.integer :score
-    t.timestamps
-  end
-end
-
-# create models
-class User < ActiveRecord::Base
-  include DeltaChanges::Extension
-  attr_accessor :foo, :bar
-
-  delta_changes :columns => ["name", "score"], :attributes => ["foo"]
-
-  def full_name
-    "Mr. #{name}"
-  end
-end