delta_attributes 0.0.1 → 0.0.2

data/.gitignore

@@ -3,6 +3,7 @@
 .bundle
 .config
 .yardoc
+.idea
 Gemfile.lock
 InstalledFiles
 _yardoc

data/README.md

@@ -2,7 +2,7 @@
 
     This gem makes updating specified number fields by ActiveRecord in unusual way.
 
-    Instead to generate sql script to update value in usual way like this:
+    Instead of generating sql script to update value in usual way like this:
 
       UPDATE users
       SET money = 10
@@ -38,11 +38,23 @@ Or install it yourself as:
   To mark numeric field to be updated by "field = field + d" way you just need to add field
   name to delta_attributes like this:
 
-  class User < ActiveRecord::Base
+    class User < ActiveRecord::Base
 
-    delta_attributes :money
+      delta_attributes :money
 
-  end
+    end
+
+  Now you can:
+
+    u = User.first # money = 3, id = 1
+    u.money = 5
+    u.save
+
+  will generate
+
+    UPDATE users SET money = money + 2 where id = 1
+
+  Tested with rails 3.2.8.
 
 ## Contributing
 

data/delta_attributes.gemspec

@@ -6,12 +6,12 @@ require 'delta_attributes/version'
 Gem::Specification.new do |gem|
   gem.name          = "delta_attributes"
   gem.version       = DeltaAttributes::VERSION
-  gem.authors       = ["izbor"]
+  gem.authors       = ["Oleh Novosad, Yuriy Lavryk, Arya"]
   gem.email         = ["oleh.novosad@gmail.com"]
   gem.description   = %q{
     This gem makes updating specified number fields by ActiveRecord in unusual way.
 
-    Instead to generate sql script to update value in usual way like this:
+    Instead of generating sql script to update value in usual way like this:
 
       UPDATE users
       SET money = 10
@@ -25,7 +25,9 @@ Gem::Specification.new do |gem|
 
     where d is difference between old value and new value of that field.
 
-    This solves problem with simultaneous updating of same field.
+    This solves problem with simultaneous updating of the same field by different threads.
+
+    Source code: https://github.com/izbor/delta_attributes
   }
   gem.summary       = %q{ delta attributes }
   gem.homepage      = ""

data/lib/delta_attributes/mysql.rb

@@ -7,7 +7,7 @@ module Arel
       def visit_Arel_Nodes_UpdateStatement o
         [
             "UPDATE #{visit o.relation}",
-            ("SET #{o.values_changed.map { |value| visit value }.join ', '}" unless o.values.empty?),
+            ("SET #{o.values_changed.map { |value| visit value }.join ', '}" unless o.values_changed.empty?),
             ("WHERE #{o.wheres.map { |x| visit x }.join ' AND '}" unless o.wheres.empty?),
             ("ORDER BY #{o.orders.map { |x| visit x }.join(', ')}" unless o.orders.empty?),
             (visit(o.limit) if o.limit),

data/lib/delta_attributes/to_sql.rb

@@ -16,10 +16,32 @@ module Arel
         "#{visit o.arel_node.left} = #{delta_string}"
       end
 
-      #alias_method_chain :visit_Arel_Nodes_Assignment, :deltas
-
       alias_method :visit_Arel_Nodes_Assignment_without_deltas, :visit_Arel_Nodes_Assignment
       alias_method :visit_Arel_Nodes_Assignment, :visit_Arel_Nodes_Assignment_with_deltas
+
+      def visit_Arel_Nodes_UpdateStatement o
+        if o.orders.empty? && o.limit.nil?
+          wheres = o.wheres
+        else
+          key = o.key
+          unless key
+            warn(<<-eowarn) if $VERBOSE
+(#{caller.first}) Using UpdateManager without setting UpdateManager#key is
+deprecated and support will be removed in ARel 4.0.0.  Please set the primary
+key on UpdateManager using UpdateManager#key=
+            eowarn
+            key = o.relation.primary_key
+          end
+
+          wheres = [Nodes::In.new(key, [build_subselect(key, o)])]
+        end
+
+        [
+          "UPDATE #{visit o.relation}",
+          ("SET #{o.values_changed.map { |value| visit value }.join ', '}" unless o.values_changed.empty?),
+          ("WHERE #{wheres.map { |x| visit x }.join ' AND '}" unless wheres.empty?),
+        ].compact.join ' '
+      end
     end
   end
 end

data/lib/delta_attributes/version.rb

@@ -1,3 +1,3 @@
 module DeltaAttributes
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

metadata

@@ -1,44 +1,49 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: delta_attributes
-version: !ruby/object:Gem::Version
-  version: 0.0.1
+version: !ruby/object:Gem::Version 
+  hash: 27
   prerelease: 
+  segments: 
+  - 0
+  - 0
+  - 2
+  version: 0.0.2
 platform: ruby
-authors:
-- izbor
+authors: 
+- Oleh Novosad, Yuriy Lavryk, Arya
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-18 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
+
+date: 2012-11-20 00:00:00 +02:00
+default_executable: 
+dependencies: 
+- !ruby/object:Gem::Dependency 
   name: rails
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 3.2.8
-  type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
+    requirements: 
     - - ~>
-      - !ruby/object:Gem::Version
+      - !ruby/object:Gem::Version 
+        hash: 31
+        segments: 
+        - 3
+        - 2
+        - 8
         version: 3.2.8
-description: ! "\n    This gem makes updating specified number fields by ActiveRecord
-  in unusual way.\n\n    Instead to generate sql script to update value in usual way
-  like this:\n\n      UPDATE users\n      SET money = 10\n      WHERE id = 1;\n\n
-  \   It replaces it with\n\n      UPDATE users\n      SET money = money + d\n      WHERE
-  id = 1;\n\n    where d is difference between old value and new value of that field.\n\n
-  \   This solves problem with simultaneous updating of same field.\n  "
-email:
+  type: :runtime
+  version_requirements: *id001
+description: "\n    This gem makes updating specified number fields by ActiveRecord in unusual way.\n\n    Instead of generating sql script to update value in usual way like this:\n\n      UPDATE users\n      SET money = 10\n      WHERE id = 1;\n\n    It replaces it with\n\n      UPDATE users\n      SET money = money + d\n      WHERE id = 1;\n\n    where d is difference between old value and new value of that field.\n\n    This solves problem with simultaneous updating of the same field by different threads.\n\n    Source code: https://github.com/izbor/delta_attributes\n  "
+email: 
 - oleh.novosad@gmail.com
 executables: []
+
 extensions: []
+
 extra_rdoc_files: []
-files:
+
+files: 
 - .gitignore
 - Gemfile
 - LICENSE.txt
@@ -55,28 +60,39 @@ files:
 - lib/delta_attributes/update_statement.rb
 - lib/delta_attributes/version.rb
 - lib/delta_attributes/visitor.rb
-homepage: ''
+has_rdoc: true
+homepage: ""
 licenses: []
+
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
+required_ruby_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
 requirements: []
+
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.5.3
 signing_key: 
 specification_version: 3
 summary: delta attributes
 test_files: []
+