delegate_all_for 0.0.2 → 0.0.3

data/delegate_all_for.gemspec

@@ -14,4 +14,8 @@ Gem::Specification.new do |gem|
   gem.name          = "delegate_all_for"
   gem.require_paths = ["lib"]
   gem.version       = DelegateAllFor::VERSION
+  gem.add_dependency 'activerecord', '~> 3.2.3'
+  gem.add_development_dependency 'rake', '~> 0.9.2.2'
+  gem.add_development_dependency 'rspec', '~> 2.9.0'
+  gem.add_development_dependency 'sqlite3', '~> 1.3.6'
 end

data/lib/delegate_all_for.rb

@@ -9,7 +9,7 @@ $LOAD_PATH.shift
 
 module DelegateAllFor
   # For all columns of the specified association to the current object,
-  # the getter, setter, and predicate are delegated.
+  # the reader, writer, and predicate methods are delegated.
   #
   # Supported options:
   # [:except]
@@ -28,6 +28,7 @@ module DelegateAllFor
           class_eval(%{delegate :#{m}, :to => :#{association_name}})
         end
         (reflection.klass.column_names - exclude_columns).each do |column_name|
+          next if column_name =~ /_id$/
           class_eval <<-eoruby, __FILE__, __LINE__ + 1
             delegate :#{column_name}, :to => :#{association_name}
             delegate :#{column_name}=, :to => :#{association_name}
@@ -43,4 +44,4 @@ end
 
 if defined?(ActiveRecord::Base)
   ActiveRecord::Base.extend DelegateAllFor
-end
+end

data/lib/delegate_all_for/version.rb

@@ -1,3 +1,3 @@
 module DelegateAllFor
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/delegate_all_for/delegate_all_for_spec.rb

@@ -1,34 +1,59 @@
 require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../../support/active_record', __FILE__)
 
-# Still need to figure out how to get this to work
-=begin
-class Parent < ActiveRecord::Base
-  def self.column_names; %w(one two) end
+class Child < ActiveRecord::Base
+  belongs_to :parent
+  def two; 'child' end
+  def extra; true end
+end
 
+class Parent < ActiveRecord::Base
   has_one :child
   delegate_all_for :child, except: [:three], also_include: [:extra]
-
-  def initialize; end
   def two; 'parent' end
 end
 
-class Child < ActiveRecord::Base
-  belongs_to :parent
-  def self.column_names; %w(two three four) end
-  def two; 'child' end
-  def extra; true end
-end
 
 describe DelegateAllFor do
   describe 'delegate_all_for' do
-    subject { Parent.new }
-
-    it { should respond_to? :three }
-    it { should respond_to? :three? }
-    it { should respond_to? :three= }
-    it { should respond_to? :extra }
-    it { should_not respond_to? :three }
-    its(:two) { should == 'parent' }
+    subject do
+      Parent.create(one: 1) do |p|
+        p.two = 2
+        p.child = Child.create(two: 'two', three: 'three', four: 'four')
+      end
+    end
+
+    context 'does not respond to three' do
+      it 'reader' do
+        lambda { subject.three }.should raise_error NoMethodError
+      end
+      it 'predicate' do
+        lambda { subject.three? }.should raise_error NoMethodError
+      end
+      it 'writer' do
+        lambda { subject.three = 'THREE' }.should raise_error NoMethodError
+      end
+    end
+
+    context 'delegates to child attributes' do
+      its(:four)  { should == 'four' }
+      its(:extra) { should be_true }
+      its(:two)   { should == 'parent' }
+
+      it 'does not delegate to association attributes' do
+        lambda { subject.parent_id }.should raise_error NoMethodError
+      end
+    end
+
+    context 'guards against user error' do
+      it 'notices when an association is wrong' do
+        lambda do
+          class Parent < ActiveRecord::Base
+            has_one :child
+            delegate_all_for :foo
+          end
+        end.should raise_error ArgumentError
+      end
+    end
   end
 end
-=end

data/spec/support/active_record.rb

@@ -0,0 +1,13 @@
+ActiveRecord::Base.establish_connection adapter: 'sqlite3', database: ':memory:'
+ActiveRecord::Migration.create_table :parents do |t|
+  t.string :one
+  t.string :two
+  t.timestamps
+end
+ActiveRecord::Migration.create_table :children do |t|
+  t.string :two
+  t.string :three
+  t.string :four
+  t.integer :parent_id
+  t.timestamps
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: delegate_all_for
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,8 +9,52 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-02 00:00:00.000000000 Z
-dependencies: []
+date: 2012-05-03 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: &70156840498460 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 3.2.3
+  type: :runtime
+  prerelease: false
+  version_requirements: *70156840498460
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: &70156840495600 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.9.2.2
+  type: :development
+  prerelease: false
+  version_requirements: *70156840495600
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: &70156840494300 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.9.0
+  type: :development
+  prerelease: false
+  version_requirements: *70156840494300
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: &70156840493440 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.3.6
+  type: :development
+  prerelease: false
+  version_requirements: *70156840493440
 description: Easy delegation of all columns of an ActiveRecord association
 email:
 - jason@lessonplanet.com
@@ -29,6 +73,7 @@ files:
 - lib/delegate_all_for/version.rb
 - spec/delegate_all_for/delegate_all_for_spec.rb
 - spec/spec_helper.rb
+- spec/support/active_record.rb
 homepage: https://github.com/LessonPlanet/delegate_all_for
 licenses: []
 post_install_message: 
@@ -56,3 +101,4 @@ summary: Easy delegation of all columns of an ActiveRecord association
 test_files:
 - spec/delegate_all_for/delegate_all_for_spec.rb
 - spec/spec_helper.rb
+- spec/support/active_record.rb