delayed_paperclip 2.8.0 → 2.9.0

data/gemfiles/4.1.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "http://rubygems.org"
+
+gem "rails", "~> 4.1.0"
+gem "delayed_paperclip", :path => "../"
+
+gemspec :path => "../"

data/gemfiles/4.1.gemfile.lock

@@ -0,0 +1,156 @@
+PATH
+  remote: ../
+  specs:
+    delayed_paperclip (2.8.0)
+      paperclip (>= 3.3)
+
+GEM
+  remote: http://rubygems.org/
+  specs:
+    actionmailer (4.1.8)
+      actionpack (= 4.1.8)
+      actionview (= 4.1.8)
+      mail (~> 2.5, >= 2.5.4)
+    actionpack (4.1.8)
+      actionview (= 4.1.8)
+      activesupport (= 4.1.8)
+      rack (~> 1.5.2)
+      rack-test (~> 0.6.2)
+    actionview (4.1.8)
+      activesupport (= 4.1.8)
+      builder (~> 3.1)
+      erubis (~> 2.7.0)
+    activemodel (4.1.8)
+      activesupport (= 4.1.8)
+      builder (~> 3.1)
+    activerecord (4.1.8)
+      activemodel (= 4.1.8)
+      activesupport (= 4.1.8)
+      arel (~> 5.0.0)
+    activesupport (4.1.8)
+      i18n (~> 0.6, >= 0.6.9)
+      json (~> 1.7, >= 1.7.7)
+      minitest (~> 5.1)
+      thread_safe (~> 0.1)
+      tzinfo (~> 1.1)
+    appraisal (1.0.2)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    arel (5.0.1.20140414130214)
+    builder (3.2.2)
+    celluloid (0.15.2)
+      timers (~> 1.1.0)
+    climate_control (0.0.3)
+      activesupport (>= 3.0)
+    cocaine (0.5.5)
+      climate_control (>= 0.0.3, < 1.0)
+    connection_pool (2.1.0)
+    delayed_job (4.0.6)
+      activesupport (>= 3.0, < 5.0)
+    delayed_job_active_record (4.0.3)
+      activerecord (>= 3.0, < 5.0)
+      delayed_job (>= 3.0, < 4.1)
+    diff-lcs (1.2.5)
+    erubis (2.7.0)
+    hike (1.2.3)
+    i18n (0.7.0)
+    json (1.8.1)
+    mail (2.6.3)
+      mime-types (>= 1.16, < 3)
+    metaclass (0.0.4)
+    mime-types (2.4.3)
+    minitest (5.5.0)
+    mocha (1.1.0)
+      metaclass (~> 0.0.1)
+    mono_logger (1.1.0)
+    multi_json (1.10.1)
+    paperclip (4.2.1)
+      activemodel (>= 3.0.0)
+      activesupport (>= 3.0.0)
+      cocaine (~> 0.5.3)
+      mime-types
+    rack (1.5.2)
+    rack-protection (1.5.3)
+      rack
+    rack-test (0.6.2)
+      rack (>= 1.0)
+    rails (4.1.8)
+      actionmailer (= 4.1.8)
+      actionpack (= 4.1.8)
+      actionview (= 4.1.8)
+      activemodel (= 4.1.8)
+      activerecord (= 4.1.8)
+      activesupport (= 4.1.8)
+      bundler (>= 1.3.0, < 2.0)
+      railties (= 4.1.8)
+      sprockets-rails (~> 2.0)
+    railties (4.1.8)
+      actionpack (= 4.1.8)
+      activesupport (= 4.1.8)
+      rake (>= 0.8.7)
+      thor (>= 0.18.1, < 2.0)
+    rake (10.4.2)
+    redis (3.2.0)
+    redis-namespace (1.5.1)
+      redis (~> 3.0, >= 3.0.4)
+    resque (1.25.2)
+      mono_logger (~> 1.0)
+      multi_json (~> 1.0)
+      redis-namespace (~> 1.3)
+      sinatra (>= 0.9.2)
+      vegas (~> 0.1.2)
+    rspec (2.99.0)
+      rspec-core (~> 2.99.0)
+      rspec-expectations (~> 2.99.0)
+      rspec-mocks (~> 2.99.0)
+    rspec-core (2.99.2)
+    rspec-expectations (2.99.2)
+      diff-lcs (>= 1.1.3, < 2.0)
+    rspec-mocks (2.99.2)
+    sidekiq (2.17.8)
+      celluloid (= 0.15.2)
+      connection_pool (~> 2.0)
+      json
+      redis (~> 3.1)
+      redis-namespace (~> 1.3)
+    sinatra (1.4.5)
+      rack (~> 1.4)
+      rack-protection (~> 1.4)
+      tilt (~> 1.3, >= 1.3.4)
+    sprockets (2.12.3)
+      hike (~> 1.2)
+      multi_json (~> 1.0)
+      rack (~> 1.0)
+      tilt (~> 1.1, != 1.3.0)
+    sprockets-rails (2.2.2)
+      actionpack (>= 3.0)
+      activesupport (>= 3.0)
+      sprockets (>= 2.8, < 4.0)
+    sqlite3 (1.3.10)
+    thor (0.19.1)
+    thread_safe (0.3.4)
+    tilt (1.4.1)
+    timers (1.1.0)
+    tzinfo (1.2.2)
+      thread_safe (~> 0.1)
+    vegas (0.1.11)
+      rack (>= 1.0.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  appraisal
+  bundler
+  delayed_job
+  delayed_job_active_record
+  delayed_paperclip!
+  mocha
+  rails (~> 4.1.0)
+  railties
+  rake
+  resque
+  rspec (< 3.0)
+  sidekiq (< 3.0)
+  sqlite3

data/gemfiles/4.2.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "http://rubygems.org"
+
+gem "rails", "~> 4.2.0"
+gem "delayed_paperclip", :path => "../"
+
+gemspec :path => "../"

data/gemfiles/4.2.gemfile.lock

@@ -0,0 +1,181 @@
+PATH
+  remote: ../
+  specs:
+    delayed_paperclip (2.8.0)
+      paperclip (>= 3.3)
+
+GEM
+  remote: http://rubygems.org/
+  specs:
+    actionmailer (4.2.0)
+      actionpack (= 4.2.0)
+      actionview (= 4.2.0)
+      activejob (= 4.2.0)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+    actionpack (4.2.0)
+      actionview (= 4.2.0)
+      activesupport (= 4.2.0)
+      rack (~> 1.6.0)
+      rack-test (~> 0.6.2)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+      rails-html-sanitizer (~> 1.0, >= 1.0.1)
+    actionview (4.2.0)
+      activesupport (= 4.2.0)
+      builder (~> 3.1)
+      erubis (~> 2.7.0)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+      rails-html-sanitizer (~> 1.0, >= 1.0.1)
+    activejob (4.2.0)
+      activesupport (= 4.2.0)
+      globalid (>= 0.3.0)
+    activemodel (4.2.0)
+      activesupport (= 4.2.0)
+      builder (~> 3.1)
+    activerecord (4.2.0)
+      activemodel (= 4.2.0)
+      activesupport (= 4.2.0)
+      arel (~> 6.0)
+    activesupport (4.2.0)
+      i18n (~> 0.7)
+      json (~> 1.7, >= 1.7.7)
+      minitest (~> 5.1)
+      thread_safe (~> 0.3, >= 0.3.4)
+      tzinfo (~> 1.1)
+    appraisal (1.0.2)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    arel (6.0.0)
+    builder (3.2.2)
+    celluloid (0.15.2)
+      timers (~> 1.1.0)
+    climate_control (0.0.3)
+      activesupport (>= 3.0)
+    cocaine (0.5.5)
+      climate_control (>= 0.0.3, < 1.0)
+    connection_pool (2.1.0)
+    delayed_job (4.0.6)
+      activesupport (>= 3.0, < 5.0)
+    delayed_job_active_record (4.0.3)
+      activerecord (>= 3.0, < 5.0)
+      delayed_job (>= 3.0, < 4.1)
+    diff-lcs (1.2.5)
+    erubis (2.7.0)
+    globalid (0.3.0)
+      activesupport (>= 4.1.0)
+    hike (1.2.3)
+    i18n (0.7.0)
+    json (1.8.1)
+    loofah (2.0.1)
+      nokogiri (>= 1.5.9)
+    mail (2.6.3)
+      mime-types (>= 1.16, < 3)
+    metaclass (0.0.4)
+    mime-types (2.4.3)
+    mini_portile (0.6.1)
+    minitest (5.5.0)
+    mocha (1.1.0)
+      metaclass (~> 0.0.1)
+    mono_logger (1.1.0)
+    multi_json (1.10.1)
+    nokogiri (1.6.5)
+      mini_portile (~> 0.6.0)
+    paperclip (4.2.1)
+      activemodel (>= 3.0.0)
+      activesupport (>= 3.0.0)
+      cocaine (~> 0.5.3)
+      mime-types
+    rack (1.6.0)
+    rack-protection (1.5.3)
+      rack
+    rack-test (0.6.2)
+      rack (>= 1.0)
+    rails (4.2.0)
+      actionmailer (= 4.2.0)
+      actionpack (= 4.2.0)
+      actionview (= 4.2.0)
+      activejob (= 4.2.0)
+      activemodel (= 4.2.0)
+      activerecord (= 4.2.0)
+      activesupport (= 4.2.0)
+      bundler (>= 1.3.0, < 2.0)
+      railties (= 4.2.0)
+      sprockets-rails
+    rails-deprecated_sanitizer (1.0.3)
+      activesupport (>= 4.2.0.alpha)
+    rails-dom-testing (1.0.5)
+      activesupport (>= 4.2.0.beta, < 5.0)
+      nokogiri (~> 1.6.0)
+      rails-deprecated_sanitizer (>= 1.0.1)
+    rails-html-sanitizer (1.0.1)
+      loofah (~> 2.0)
+    railties (4.2.0)
+      actionpack (= 4.2.0)
+      activesupport (= 4.2.0)
+      rake (>= 0.8.7)
+      thor (>= 0.18.1, < 2.0)
+    rake (10.4.2)
+    redis (3.2.0)
+    redis-namespace (1.5.1)
+      redis (~> 3.0, >= 3.0.4)
+    resque (1.25.2)
+      mono_logger (~> 1.0)
+      multi_json (~> 1.0)
+      redis-namespace (~> 1.3)
+      sinatra (>= 0.9.2)
+      vegas (~> 0.1.2)
+    rspec (2.99.0)
+      rspec-core (~> 2.99.0)
+      rspec-expectations (~> 2.99.0)
+      rspec-mocks (~> 2.99.0)
+    rspec-core (2.99.2)
+    rspec-expectations (2.99.2)
+      diff-lcs (>= 1.1.3, < 2.0)
+    rspec-mocks (2.99.2)
+    sidekiq (2.17.8)
+      celluloid (= 0.15.2)
+      connection_pool (~> 2.0)
+      json
+      redis (~> 3.1)
+      redis-namespace (~> 1.3)
+    sinatra (1.4.5)
+      rack (~> 1.4)
+      rack-protection (~> 1.4)
+      tilt (~> 1.3, >= 1.3.4)
+    sprockets (2.12.3)
+      hike (~> 1.2)
+      multi_json (~> 1.0)
+      rack (~> 1.0)
+      tilt (~> 1.1, != 1.3.0)
+    sprockets-rails (2.2.2)
+      actionpack (>= 3.0)
+      activesupport (>= 3.0)
+      sprockets (>= 2.8, < 4.0)
+    sqlite3 (1.3.10)
+    thor (0.19.1)
+    thread_safe (0.3.4)
+    tilt (1.4.1)
+    timers (1.1.0)
+    tzinfo (1.2.2)
+      thread_safe (~> 0.1)
+    vegas (0.1.11)
+      rack (>= 1.0.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  appraisal
+  bundler
+  delayed_job
+  delayed_job_active_record
+  delayed_paperclip!
+  mocha
+  rails (~> 4.2.0)
+  railties
+  rake
+  resque
+  rspec (< 3.0)
+  sidekiq (< 3.0)
+  sqlite3

data/lib/delayed_paperclip/jobs/active_job.rb

@@ -0,0 +1,16 @@
+module DelayedPaperclip
+  module Jobs
+    class ActiveJob < ActiveJob::Base
+      queue_as :paperclip
+
+      def self.enqueue_delayed_paperclip(instance_klass, instance_id, attachment_name)
+        # ActiveJob currently does not support symbol arguments
+        self.perform_later(instance_klass, instance_id, attachment_name.to_s)
+      end
+
+      def perform(instance_klass, instance_id, attachment_name)
+        DelayedPaperclip.process_job(instance_klass, instance_id, attachment_name.to_sym)
+      end
+    end
+  end
+end

data/lib/delayed_paperclip/jobs.rb

@@ -1,5 +1,6 @@
 module DelayedPaperclip
   module Jobs
+    autoload :ActiveJob,  'delayed_paperclip/jobs/active_job'
     autoload :DelayedJob, 'delayed_paperclip/jobs/delayed_job'
     autoload :Resque,     'delayed_paperclip/jobs/resque'
     autoload :Sidekiq,    'delayed_paperclip/jobs/sidekiq'

data/lib/delayed_paperclip/url_generator.rb

@@ -9,7 +9,7 @@ module DelayedPaperclip
     end
 
     def for_with_processed(style_name, options)
-      most_appropriate_url = most_appropriate_url(style_name)
+      most_appropriate_url = @attachment.processing_style?(style_name) ? most_appropriate_url(style_name) : most_appropriate_url_without_processed
 
       escape_url_as_needed(
         timestamp_as_needed(

data/lib/delayed_paperclip/version.rb

@@ -1,3 +1,3 @@
 module DelayedPaperclip
-  VERSION = "2.8.0"
+  VERSION = "2.9.0"
 end

data/lib/delayed_paperclip.rb

@@ -16,6 +16,7 @@ module DelayedPaperclip
     end
 
     def detect_background_task
+      return DelayedPaperclip::Jobs::ActiveJob  if defined? ::ActiveJob::Base
       return DelayedPaperclip::Jobs::DelayedJob if defined? ::Delayed::Job
       return DelayedPaperclip::Jobs::Resque     if defined? ::Resque
       return DelayedPaperclip::Jobs::Sidekiq    if defined? ::Sidekiq

data/spec/delayed_paperclip/url_generator_spec.rb

@@ -11,7 +11,11 @@ describe DelayedPaperclip::UrlGenerator do
   let(:dummy_options) { {} }
 
   describe "for_with_processed" do
-    context "with split pcoessing" do
+    before do
+      attachment.stubs(:original_filename).returns "12k.png"
+    end
+
+    context "with split processing" do
       # everything in this hash is passed to delayed_paperclip, expect for the
       # paperclip stuff
       let(:dummy_options) { {
@@ -26,8 +30,32 @@ describe DelayedPaperclip::UrlGenerator do
         only_process: [:background]
       }}
 
-      it "returns the default_url when the style is still being processed" do
-        expect(attachment.url(:background)).to eql "/images/background/missing.png"
+      context "processing" do
+        before do
+          attachment.stubs(:processing?).returns true
+        end
+
+        it "returns the default_url when the style is still being processed" do
+          expect(attachment.url(:background)).to eql "/images/background/missing.png"
+        end
+
+        it "returns the attachment url when the style is not set for background processing" do
+          expect(attachment.url(:online)).to eql "/system/dummies/images/000/000/001/online/12k.png"
+        end
+      end
+
+      context "not processing" do
+        before do
+          attachment.stubs(:processing?).returns false
+        end
+
+        it "returns the attachment url even when the style is set for background processing" do
+          expect(attachment.url(:background)).to eql "/system/dummies/images/000/000/001/background/12k.png"
+        end
+
+        it "returns the generated url when the style is not set for background processing" do
+          expect(attachment.url(:online)).to eql "/system/dummies/images/000/000/001/online/12k.png"
+        end
       end
     end
   end

data/spec/integration/active_job_inline_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+describe "ActiveJob inline" do
+
+  if defined? ActiveJob
+    before :all do
+      DelayedPaperclip.options[:background_job_class] = DelayedPaperclip::Jobs::ActiveJob
+      ActiveJob::Base.logger = nil
+    end
+
+    let(:dummy) { Dummy.new(:image => File.open("#{ROOT}/spec/fixtures/12k.png")) }
+
+    describe "perform job" do
+      before :each do
+        DelayedPaperclip.options[:url_with_processing] = true
+        reset_dummy
+      end
+
+      it "performs a job" do
+        dummy.image = File.open("#{ROOT}/spec/fixtures/12k.png")
+        Paperclip::Attachment.any_instance.expects(:reprocess!)
+        dummy.save!
+      end
+    end
+  end
+end

data/spec/integration/active_job_resque_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+require 'resque'
+
+if defined? ActiveJob
+  describe "Active Job with Resque backend" do
+
+    before :all do
+      DelayedPaperclip.options[:background_job_class] = DelayedPaperclip::Jobs::ActiveJob
+      ActiveJob::Base.logger = nil
+      ActiveJob::Base.queue_adapter = :resque
+      Resque.remove_queue(:paperclip)
+    end
+
+    let(:dummy) { Dummy.new(:image => File.open("#{ROOT}/spec/fixtures/12k.png")) }
+
+    describe "integration tests" do
+      include_examples "base usage"
+    end
+
+    def process_jobs
+      worker = Resque::Worker.new(:paperclip)
+      worker.process
+    end
+
+    def jobs_count
+
+      Resque.size(:paperclip)
+    end
+
+  end
+end

data/spec/integration/active_job_sidekiq_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+require 'sidekiq/api'
+
+describe "ActiveJob with Sidekiq backend" do
+
+if defined? ActiveJob
+  before :all do
+    DelayedPaperclip.options[:background_job_class] = DelayedPaperclip::Jobs::ActiveJob
+    ActiveJob::Base.logger = nil
+    ActiveJob::Base.queue_adapter = :sidekiq
+  end
+
+  let(:dummy) { Dummy.new(:image => File.open("#{ROOT}/spec/fixtures/12k.png")) }
+
+  describe "integration tests" do
+    include_examples "base usage"
+  end
+end
+
+  def process_jobs
+    Sidekiq::Queue.new(:paperclip).each do |job|
+      worker = job.klass.constantize.new
+      args   = job.args
+      begin
+        worker.perform(*args)
+      rescue # Assume sidekiq handle exception properly
+      end
+      job.delete
+    end
+  end
+
+  def jobs_count
+    Sidekiq::Queue.new(:paperclip).size
+  end
+end

data/spec/integration/delayed_job_spec.rb

@@ -49,7 +49,7 @@ describe "Delayed Job" do
       table.datetime :failed_at                    # Set when all retries have failed (actually, by default, the record is deleted instead)
       table.string   :locked_by                    # Who is working on this object (if locked)
       table.string   :queue
-      table.timestamps
+      table.timestamps null: true
     end
   end
 end

data/spec/spec_helper.rb

@@ -7,6 +7,10 @@ require 'active_support'
 require 'active_support/core_ext'
 require 'rspec'
 require 'mocha/api'
+begin
+  require 'active_job'
+rescue LoadError
+end
 
 begin
   require 'pry'
@@ -20,6 +24,11 @@ Paperclip::Railtie.insert
 require 'delayed_paperclip/railtie'
 DelayedPaperclip::Railtie.insert
 
+# silence deprecation warnings in rails 4.2
+if ActiveRecord::Base.respond_to?(:raise_in_transactional_callbacks=)
+  ActiveRecord::Base.raise_in_transactional_callbacks = true
+end
+
 # Connect to sqlite
 ActiveRecord::Base.establish_connection(
   "adapter" => "sqlite3",

data/test/base_delayed_paperclip_test.rb

@@ -1,3 +1,7 @@
+###
+#  DEPRECATED, Don't Use
+###
+
 module BaseDelayedPaperclipTest
   def setup
     super

data/test/test_helper.rb

@@ -1,5 +1,18 @@
+###
+#  DEPRECATED, Don't Use
+###
+
 require 'rubygems'
-require 'test/unit'
+
+begin
+  require 'test/unit'
+rescue
+  # we are probably Rails 4.2, so no Test::Unit here
+  # move along...
+  puts "No Test::Unit available. Skipping..."
+  exit(0)
+end
+
 require 'mocha/setup'
 require 'active_record'
 require 'active_record/version'